From: Archit Taneja <architt-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> To: Sean Paul <seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>, freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Cc: jsanka-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, robdclark-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, hoegsberg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, abhinavk-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Subject: Re: [PATCH v2 3/6] drm/msm: Mark the crtc->state->event consumed Date: Mon, 2 Apr 2018 10:52:44 +0530 [thread overview] Message-ID: <9fdb112c-7e2e-0f2d-646a-c9ffb3c4c5f8@codeaurora.org> (raw) In-Reply-To: <20180328190657.218661-4-seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> On Thursday 29 March 2018 12:36 AM, Sean Paul wrote: > Don't leave the event != NULL once it's consumed, this is used a signal s/used a/used as a ? > to the atomic helpers that the event will be handled by the driver. > Reviewed-by: Archit Taneja <architt@codeaurora.org> > Changes in v2: > - None > > Cc: Jeykumar Sankaran <jsanka@codeaurora.org> > Signed-off-by: Sean Paul <seanpaul@chromium.org> > --- > drivers/gpu/drm/msm/disp/mdp4/mdp4_crtc.c | 1 + > drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/msm/disp/mdp4/mdp4_crtc.c b/drivers/gpu/drm/msm/disp/mdp4/mdp4_crtc.c > index 6e5e1aa54ce1..b001699297c4 100644 > --- a/drivers/gpu/drm/msm/disp/mdp4/mdp4_crtc.c > +++ b/drivers/gpu/drm/msm/disp/mdp4/mdp4_crtc.c > @@ -351,6 +351,7 @@ static void mdp4_crtc_atomic_flush(struct drm_crtc *crtc, > > spin_lock_irqsave(&dev->event_lock, flags); > mdp4_crtc->event = crtc->state->event; > + crtc->state->event = NULL; > spin_unlock_irqrestore(&dev->event_lock, flags); > > blend_setup(crtc); > diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c b/drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c > index 9893e43ba6c5..76b96081916f 100644 > --- a/drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c > +++ b/drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c > @@ -708,6 +708,7 @@ static void mdp5_crtc_atomic_flush(struct drm_crtc *crtc, > > spin_lock_irqsave(&dev->event_lock, flags); > mdp5_crtc->event = crtc->state->event; > + crtc->state->event = NULL; > spin_unlock_irqrestore(&dev->event_lock, flags); > > /* > _______________________________________________ Freedreno mailing list Freedreno@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/freedreno
WARNING: multiple messages have this Message-ID (diff)
From: Archit Taneja <architt@codeaurora.org> To: Sean Paul <seanpaul@chromium.org>, freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org Cc: robdclark@gmail.com, hoegsberg@chromium.org, jsanka@codeaurora.org, abhinavk@codeaurora.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/6] drm/msm: Mark the crtc->state->event consumed Date: Mon, 2 Apr 2018 10:52:44 +0530 [thread overview] Message-ID: <9fdb112c-7e2e-0f2d-646a-c9ffb3c4c5f8@codeaurora.org> (raw) In-Reply-To: <20180328190657.218661-4-seanpaul@chromium.org> On Thursday 29 March 2018 12:36 AM, Sean Paul wrote: > Don't leave the event != NULL once it's consumed, this is used a signal s/used a/used as a ? > to the atomic helpers that the event will be handled by the driver. > Reviewed-by: Archit Taneja <architt@codeaurora.org> > Changes in v2: > - None > > Cc: Jeykumar Sankaran <jsanka@codeaurora.org> > Signed-off-by: Sean Paul <seanpaul@chromium.org> > --- > drivers/gpu/drm/msm/disp/mdp4/mdp4_crtc.c | 1 + > drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/msm/disp/mdp4/mdp4_crtc.c b/drivers/gpu/drm/msm/disp/mdp4/mdp4_crtc.c > index 6e5e1aa54ce1..b001699297c4 100644 > --- a/drivers/gpu/drm/msm/disp/mdp4/mdp4_crtc.c > +++ b/drivers/gpu/drm/msm/disp/mdp4/mdp4_crtc.c > @@ -351,6 +351,7 @@ static void mdp4_crtc_atomic_flush(struct drm_crtc *crtc, > > spin_lock_irqsave(&dev->event_lock, flags); > mdp4_crtc->event = crtc->state->event; > + crtc->state->event = NULL; > spin_unlock_irqrestore(&dev->event_lock, flags); > > blend_setup(crtc); > diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c b/drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c > index 9893e43ba6c5..76b96081916f 100644 > --- a/drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c > +++ b/drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c > @@ -708,6 +708,7 @@ static void mdp5_crtc_atomic_flush(struct drm_crtc *crtc, > > spin_lock_irqsave(&dev->event_lock, flags); > mdp5_crtc->event = crtc->state->event; > + crtc->state->event = NULL; > spin_unlock_irqrestore(&dev->event_lock, flags); > > /* >
next prev parent reply other threads:[~2018-04-02 5:22 UTC|newest] Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-03-28 19:06 [PATCH v2 0/6] drm/msm: Switch to atomic helpers Sean Paul 2018-03-28 19:06 ` [PATCH v2 1/6] drm/msm: Use drm_private_obj/state instead of subclassing Sean Paul 2018-03-28 19:06 ` Sean Paul [not found] ` <20180328190657.218661-2-seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> 2018-04-02 5:01 ` Archit Taneja 2018-04-02 5:01 ` Archit Taneja [not found] ` <20180328190657.218661-1-seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> 2018-03-28 19:06 ` [PATCH v2 2/6] drm/msm: Refactor complete_commit() to look more the helpers Sean Paul 2018-03-28 19:06 ` Sean Paul [not found] ` <20180328190657.218661-3-seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> 2018-04-02 5:22 ` Archit Taneja 2018-04-02 5:22 ` Archit Taneja 2018-03-28 19:06 ` [PATCH v2 3/6] drm/msm: Mark the crtc->state->event consumed Sean Paul 2018-03-28 19:06 ` Sean Paul [not found] ` <20180328190657.218661-4-seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> 2018-04-02 5:22 ` Archit Taneja [this message] 2018-04-02 5:22 ` Archit Taneja 2018-03-28 19:06 ` [PATCH v2 4/6] drm/msm: Issue queued events when disabling crtc Sean Paul 2018-03-28 19:06 ` Sean Paul [not found] ` <20180328190657.218661-5-seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> 2018-04-02 5:23 ` Archit Taneja 2018-04-02 5:23 ` Archit Taneja 2018-03-28 19:06 ` [PATCH v2 5/6] drm/msm: Remove msm_commit/worker, use atomic helper commit Sean Paul 2018-03-28 19:06 ` Sean Paul 2018-03-28 19:06 ` [PATCH v2 6/6] drm/msm: Switch to atomic_helper_commit() Sean Paul 2018-03-28 19:06 ` Sean Paul
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=9fdb112c-7e2e-0f2d-646a-c9ffb3c4c5f8@codeaurora.org \ --to=architt-sgv2jx0feol9jmxxk+q4oq@public.gmane.org \ --cc=abhinavk-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \ --cc=dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \ --cc=freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \ --cc=hoegsberg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \ --cc=jsanka-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \ --cc=linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=robdclark-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \ --cc=seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.