Re: [PATCH iproute2-next v2 07/19] bridge: vlan: add global mcast_snooping option

From: Nikolay Aleksandrov <nikolay@nvidia.com>
To: David Ahern <dsahern@gmail.com>,
	Nikolay Aleksandrov <razor@blackwall.org>,
	netdev@vger.kernel.org
Cc: roopa@nvidia.com, stephen@networkplumber.org,
	Joachim Wiberg <troglobit@gmail.com>
Subject: Re: [PATCH iproute2-next v2 07/19] bridge: vlan: add global mcast_snooping option
Date: Wed, 1 Sep 2021 11:07:17 +0300	[thread overview]
Message-ID: <9fe01b5a-0f22-348c-c1d5-16f96b9605ef@nvidia.com> (raw)
In-Reply-To: <52857ec7-48fc-b22c-de20-e751d51e612e@gmail.com>

On 01/09/2021 06:36, David Ahern wrote:
> On 8/28/21 4:07 AM, Nikolay Aleksandrov wrote:
>> @@ -397,6 +400,12 @@ static int vlan_global_option_set(int argc, char **argv)
>>  			if (vid_end != -1)
>>  				addattr16(&req.n, sizeof(req),
>>  					  BRIDGE_VLANDB_GOPTS_RANGE, vid_end);
>> +		} else if (strcmp(*argv, "mcast_snooping") == 0) {
>> +			NEXT_ARG();
>> +			if (get_u8(&val8, *argv, 0))
>> +				invarg("invalid mcast_snooping", *argv);
>> +			addattr8(&req.n, 1024,
>> +				 BRIDGE_VLANDB_GOPTS_MCAST_SNOOPING, val8);
>>  		} else {
>>  			if (matches(*argv, "help") == 0)
>>  				NEXT_ARG();
> 
> How did you redo this patch set where 06 uses strcmp for the help line
> and yet patches 7-17 all have matches?
> 
> Fixed those up given where we are with 5.14 cycle and applied to
> iproute2-next.
> 

Oh wtf, looks like rebasing gone wrong, I'll have to fix up my scripts.
Apologies about that and thanks for taking care of the matches -> strcmp.