From: "Wu, Songjun" <songjun.wu@linux.intel.com>
To: Rob Herring <robh@kernel.org>
Cc: hua.ma@linux.intel.com, yixin.zhu@linux.intel.com,
chuanhua.lei@linux.intel.com, linux-mips@linux-mips.org,
qi-ming.wu@intel.com, linux-clk@vger.kernel.org,
linux-serial@vger.kernel.org, devicetree@vger.kernel.org,
James Hogan <jhogan@kernel.org>,
linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Philippe Ombredanne <pombredanne@nexb.com>,
Kate Stewart <kstewart@linuxfoundation.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Mark Rutland <mark.rutland@arm.com>,
Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [PATCH 1/7] MIPS: dts: Add aliases node for lantiq danube serial
Date: Thu, 14 Jun 2018 14:19:35 +0800 [thread overview]
Message-ID: <9fee8672-f518-eae5-e012-bb718106217b@linux.intel.com> (raw)
In-Reply-To: <20180612222424.GA2197@rob-hp-laptop>
[-- Attachment #1: Type: text/plain, Size: 1449 bytes --]
On 6/13/2018 6:24 AM, Rob Herring wrote:
> On Tue, Jun 12, 2018 at 01:40:28PM +0800, Songjun Wu wrote:
>> Previous implementation uses a hard-coded register value to check if
>> the current serial entity is the console entity.
>> Now the lantiq serial driver uses the aliases for the index of the
>> serial port.
>> The lantiq danube serial dts are updated with aliases to support this.
>>
>> Signed-off-by: Songjun Wu <songjun.wu@linux.intel.com>
>> ---
>>
>> arch/mips/boot/dts/lantiq/danube.dtsi | 6 +++++-
>> 1 file changed, 5 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/mips/boot/dts/lantiq/danube.dtsi b/arch/mips/boot/dts/lantiq/danube.dtsi
>> index 2dd950181f8a..7a9e15da6bd0 100644
>> --- a/arch/mips/boot/dts/lantiq/danube.dtsi
>> +++ b/arch/mips/boot/dts/lantiq/danube.dtsi
>> @@ -4,6 +4,10 @@
>> #size-cells = <1>;
>> compatible = "lantiq,xway", "lantiq,danube";
>>
>> + aliases {
>> + serial0 = &asc1;
>> + };
>> +
>> cpus {
>> cpu@0 {
>> compatible = "mips,mips24Kc";
>> @@ -74,7 +78,7 @@
>> reg = <0xE100A00 0x100>;
>> };
>>
>> - serial@E100C00 {
>> + asc1: serial@E100C00 {
> Fix this to be lower case hex while you are at it.
Thanks.
All the upper case in unit-address and hex constants will be changed to
lower case according to the Linux conventions.
>
>> compatible = "lantiq,asc";
>> reg = <0xE100C00 0x400>;
>> interrupt-parent = <&icu0>;
>> --
>> 2.11.0
>>
[-- Attachment #2: Type: text/html, Size: 2545 bytes --]
next prev parent reply other threads:[~2018-06-14 6:19 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-12 5:40 [PATCH 0/7] MIPS: intel: add initial support for Intel MIPS SoCs Songjun Wu
2018-06-12 5:40 ` [PATCH 1/7] MIPS: dts: Add aliases node for lantiq danube serial Songjun Wu
2018-06-12 22:24 ` Rob Herring
2018-06-14 6:19 ` Wu, Songjun [this message]
2018-06-14 10:03 ` Arnd Bergmann
2018-06-18 9:42 ` Wu, Songjun
2018-06-18 10:59 ` Arnd Bergmann
2018-06-19 6:46 ` Wu, Songjun
2018-06-12 5:40 ` [PATCH 2/7] clk: intel: Add clock driver for GRX500 SoC Songjun Wu
2018-06-12 22:37 ` Rob Herring
2018-06-14 8:40 ` yixin zhu
2018-06-14 14:09 ` Rob Herring
2018-06-18 10:05 ` yixin zhu
2018-06-12 5:40 ` [PATCH 3/7] MIPS: intel: Add initial support for Intel MIPS SoCs Songjun Wu
2018-06-12 11:23 ` James Hogan
2018-06-14 9:24 ` yixin zhu
2018-06-12 22:31 ` Rob Herring
2018-06-14 8:01 ` Hua Ma
2018-06-12 5:40 ` [PATCH 4/7] tty: serial: lantiq: Always use readl()/writel() Songjun Wu
2018-06-12 8:13 ` Andy Shevchenko
2018-06-14 7:05 ` Wu, Songjun
2018-06-14 10:07 ` Arnd Bergmann
2018-06-18 9:39 ` Wu, Songjun
2018-06-18 11:52 ` Arnd Bergmann
2018-06-12 5:40 ` [PATCH 5/7] tty: serial: lantiq: Convert global lock to per device lock Songjun Wu
2018-06-12 5:40 ` [PATCH 6/7] tty: serial: lantiq: Remove unneeded header includes and macros Songjun Wu
2018-06-12 5:40 ` [PATCH 7/7] tty: serial: lantiq: Add CCF support Songjun Wu
2018-06-12 8:07 ` kbuild test robot
2018-06-12 8:07 ` kbuild test robot
2018-06-12 8:07 ` kbuild test robot
2018-06-12 22:39 ` Rob Herring
2018-06-14 6:38 ` Wu, Songjun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9fee8672-f518-eae5-e012-bb718106217b@linux.intel.com \
--to=songjun.wu@linux.intel.com \
--cc=chuanhua.lei@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hua.ma@linux.intel.com \
--cc=jhogan@kernel.org \
--cc=kstewart@linuxfoundation.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-serial@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pombredanne@nexb.com \
--cc=qi-ming.wu@intel.com \
--cc=ralf@linux-mips.org \
--cc=robh@kernel.org \
--cc=tglx@linutronix.de \
--cc=yixin.zhu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.