* [PATCH] media: mediatek: vcodec: fix minmax.cocci warning
@ 2022-06-14 7:25 ` Guo Zhengkui
0 siblings, 0 replies; 6+ messages in thread
From: Guo Zhengkui @ 2022-06-14 7:25 UTC (permalink / raw)
To: Tiffany Lin, Andrew-CT Chen, Mauro Carvalho Chehab,
Matthias Brugger, Hans Verkuil, Yunfei Dong, Haowen Bai,
George Sun, Guo Zhengkui,
open list:MEDIA INPUT INFRASTRUCTURE (V4L/DVB),
open list, moderated list:ARM/Mediatek SoC support,
moderated list:ARM/Mediatek SoC support
Cc: zhengkui_guo
Fix the following coccicheck warning:
drivers/media/platform/mediatek/vcodec/vdec/vdec_vp9_req_lat_if.c:
694:15-16: WARNING opportunity for min().
Signed-off-by: Guo Zhengkui <guozhengkui@vivo.com>
---
.../media/platform/mediatek/vcodec/vdec/vdec_vp9_req_lat_if.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/mediatek/vcodec/vdec/vdec_vp9_req_lat_if.c b/drivers/media/platform/mediatek/vcodec/vdec/vdec_vp9_req_lat_if.c
index f464af190d8c..81de876d5126 100644
--- a/drivers/media/platform/mediatek/vcodec/vdec/vdec_vp9_req_lat_if.c
+++ b/drivers/media/platform/mediatek/vcodec/vdec/vdec_vp9_req_lat_if.c
@@ -691,7 +691,7 @@ static int vdec_vp9_slice_tile_offset(int idx, int mi_num, int tile_log2)
int sbs = (mi_num + 7) >> 3;
int offset = ((idx * sbs) >> tile_log2) << 3;
- return offset < mi_num ? offset : mi_num;
+ return min(offset, mi_num);
}
static
--
2.20.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] media: mediatek: vcodec: fix minmax.cocci warning
@ 2022-06-14 7:25 ` Guo Zhengkui
0 siblings, 0 replies; 6+ messages in thread
From: Guo Zhengkui @ 2022-06-14 7:25 UTC (permalink / raw)
To: Tiffany Lin, Andrew-CT Chen, Mauro Carvalho Chehab,
Matthias Brugger, Hans Verkuil, Yunfei Dong, Haowen Bai,
George Sun, Guo Zhengkui,
open list:MEDIA INPUT INFRASTRUCTURE (V4L/DVB),
open list, moderated list:ARM/Mediatek SoC support,
moderated list:ARM/Mediatek SoC support
Cc: zhengkui_guo
Fix the following coccicheck warning:
drivers/media/platform/mediatek/vcodec/vdec/vdec_vp9_req_lat_if.c:
694:15-16: WARNING opportunity for min().
Signed-off-by: Guo Zhengkui <guozhengkui@vivo.com>
---
.../media/platform/mediatek/vcodec/vdec/vdec_vp9_req_lat_if.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/mediatek/vcodec/vdec/vdec_vp9_req_lat_if.c b/drivers/media/platform/mediatek/vcodec/vdec/vdec_vp9_req_lat_if.c
index f464af190d8c..81de876d5126 100644
--- a/drivers/media/platform/mediatek/vcodec/vdec/vdec_vp9_req_lat_if.c
+++ b/drivers/media/platform/mediatek/vcodec/vdec/vdec_vp9_req_lat_if.c
@@ -691,7 +691,7 @@ static int vdec_vp9_slice_tile_offset(int idx, int mi_num, int tile_log2)
int sbs = (mi_num + 7) >> 3;
int offset = ((idx * sbs) >> tile_log2) << 3;
- return offset < mi_num ? offset : mi_num;
+ return min(offset, mi_num);
}
static
--
2.20.1
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] media: mediatek: vcodec: fix minmax.cocci warning
@ 2022-06-14 7:25 ` Guo Zhengkui
0 siblings, 0 replies; 6+ messages in thread
From: Guo Zhengkui @ 2022-06-14 7:25 UTC (permalink / raw)
To: Tiffany Lin, Andrew-CT Chen, Mauro Carvalho Chehab,
Matthias Brugger, Hans Verkuil, Yunfei Dong, Haowen Bai,
George Sun, Guo Zhengkui,
open list:MEDIA INPUT INFRASTRUCTURE (V4L/DVB),
open list, moderated list:ARM/Mediatek SoC support,
moderated list:ARM/Mediatek SoC support
Cc: zhengkui_guo
Fix the following coccicheck warning:
drivers/media/platform/mediatek/vcodec/vdec/vdec_vp9_req_lat_if.c:
694:15-16: WARNING opportunity for min().
Signed-off-by: Guo Zhengkui <guozhengkui@vivo.com>
---
.../media/platform/mediatek/vcodec/vdec/vdec_vp9_req_lat_if.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/mediatek/vcodec/vdec/vdec_vp9_req_lat_if.c b/drivers/media/platform/mediatek/vcodec/vdec/vdec_vp9_req_lat_if.c
index f464af190d8c..81de876d5126 100644
--- a/drivers/media/platform/mediatek/vcodec/vdec/vdec_vp9_req_lat_if.c
+++ b/drivers/media/platform/mediatek/vcodec/vdec/vdec_vp9_req_lat_if.c
@@ -691,7 +691,7 @@ static int vdec_vp9_slice_tile_offset(int idx, int mi_num, int tile_log2)
int sbs = (mi_num + 7) >> 3;
int offset = ((idx * sbs) >> tile_log2) << 3;
- return offset < mi_num ? offset : mi_num;
+ return min(offset, mi_num);
}
static
--
2.20.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] media: mediatek: vcodec: fix minmax.cocci warning
2022-06-14 7:25 ` Guo Zhengkui
(?)
@ 2022-06-14 18:16 ` Nicolas Dufresne
-1 siblings, 0 replies; 6+ messages in thread
From: Nicolas Dufresne @ 2022-06-14 18:16 UTC (permalink / raw)
To: Guo Zhengkui, Tiffany Lin, Andrew-CT Chen, Mauro Carvalho Chehab,
Matthias Brugger, Hans Verkuil, Yunfei Dong, Haowen Bai,
George Sun, open list:MEDIA INPUT INFRASTRUCTURE (V4L/DVB),
open list, moderated list:ARM/Mediatek SoC support,
moderated list:ARM/Mediatek SoC support
Cc: zhengkui_guo
Le mardi 14 juin 2022 à 15:25 +0800, Guo Zhengkui a écrit :
> Fix the following coccicheck warning:
>
> drivers/media/platform/mediatek/vcodec/vdec/vdec_vp9_req_lat_if.c:
> 694:15-16: WARNING opportunity for min().
>
> Signed-off-by: Guo Zhengkui <guozhengkui@vivo.com>
Reviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>
> ---
> .../media/platform/mediatek/vcodec/vdec/vdec_vp9_req_lat_if.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/mediatek/vcodec/vdec/vdec_vp9_req_lat_if.c b/drivers/media/platform/mediatek/vcodec/vdec/vdec_vp9_req_lat_if.c
> index f464af190d8c..81de876d5126 100644
> --- a/drivers/media/platform/mediatek/vcodec/vdec/vdec_vp9_req_lat_if.c
> +++ b/drivers/media/platform/mediatek/vcodec/vdec/vdec_vp9_req_lat_if.c
> @@ -691,7 +691,7 @@ static int vdec_vp9_slice_tile_offset(int idx, int mi_num, int tile_log2)
> int sbs = (mi_num + 7) >> 3;
> int offset = ((idx * sbs) >> tile_log2) << 3;
>
> - return offset < mi_num ? offset : mi_num;
> + return min(offset, mi_num);
> }
>
> static
regards,
Nicolas
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] media: mediatek: vcodec: fix minmax.cocci warning
@ 2022-06-14 18:16 ` Nicolas Dufresne
0 siblings, 0 replies; 6+ messages in thread
From: Nicolas Dufresne @ 2022-06-14 18:16 UTC (permalink / raw)
To: Guo Zhengkui, Tiffany Lin, Andrew-CT Chen, Mauro Carvalho Chehab,
Matthias Brugger, Hans Verkuil, Yunfei Dong, Haowen Bai,
George Sun, open list:MEDIA INPUT INFRASTRUCTURE (V4L/DVB),
open list, moderated list:ARM/Mediatek SoC support,
moderated list:ARM/Mediatek SoC support
Cc: zhengkui_guo
Le mardi 14 juin 2022 à 15:25 +0800, Guo Zhengkui a écrit :
> Fix the following coccicheck warning:
>
> drivers/media/platform/mediatek/vcodec/vdec/vdec_vp9_req_lat_if.c:
> 694:15-16: WARNING opportunity for min().
>
> Signed-off-by: Guo Zhengkui <guozhengkui@vivo.com>
Reviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>
> ---
> .../media/platform/mediatek/vcodec/vdec/vdec_vp9_req_lat_if.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/mediatek/vcodec/vdec/vdec_vp9_req_lat_if.c b/drivers/media/platform/mediatek/vcodec/vdec/vdec_vp9_req_lat_if.c
> index f464af190d8c..81de876d5126 100644
> --- a/drivers/media/platform/mediatek/vcodec/vdec/vdec_vp9_req_lat_if.c
> +++ b/drivers/media/platform/mediatek/vcodec/vdec/vdec_vp9_req_lat_if.c
> @@ -691,7 +691,7 @@ static int vdec_vp9_slice_tile_offset(int idx, int mi_num, int tile_log2)
> int sbs = (mi_num + 7) >> 3;
> int offset = ((idx * sbs) >> tile_log2) << 3;
>
> - return offset < mi_num ? offset : mi_num;
> + return min(offset, mi_num);
> }
>
> static
regards,
Nicolas
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] media: mediatek: vcodec: fix minmax.cocci warning
@ 2022-06-14 18:16 ` Nicolas Dufresne
0 siblings, 0 replies; 6+ messages in thread
From: Nicolas Dufresne @ 2022-06-14 18:16 UTC (permalink / raw)
To: Guo Zhengkui, Tiffany Lin, Andrew-CT Chen, Mauro Carvalho Chehab,
Matthias Brugger, Hans Verkuil, Yunfei Dong, Haowen Bai,
George Sun, open list:MEDIA INPUT INFRASTRUCTURE (V4L/DVB),
open list, moderated list:ARM/Mediatek SoC support,
moderated list:ARM/Mediatek SoC support
Cc: zhengkui_guo
Le mardi 14 juin 2022 à 15:25 +0800, Guo Zhengkui a écrit :
> Fix the following coccicheck warning:
>
> drivers/media/platform/mediatek/vcodec/vdec/vdec_vp9_req_lat_if.c:
> 694:15-16: WARNING opportunity for min().
>
> Signed-off-by: Guo Zhengkui <guozhengkui@vivo.com>
Reviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>
> ---
> .../media/platform/mediatek/vcodec/vdec/vdec_vp9_req_lat_if.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/mediatek/vcodec/vdec/vdec_vp9_req_lat_if.c b/drivers/media/platform/mediatek/vcodec/vdec/vdec_vp9_req_lat_if.c
> index f464af190d8c..81de876d5126 100644
> --- a/drivers/media/platform/mediatek/vcodec/vdec/vdec_vp9_req_lat_if.c
> +++ b/drivers/media/platform/mediatek/vcodec/vdec/vdec_vp9_req_lat_if.c
> @@ -691,7 +691,7 @@ static int vdec_vp9_slice_tile_offset(int idx, int mi_num, int tile_log2)
> int sbs = (mi_num + 7) >> 3;
> int offset = ((idx * sbs) >> tile_log2) << 3;
>
> - return offset < mi_num ? offset : mi_num;
> + return min(offset, mi_num);
> }
>
> static
regards,
Nicolas
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-06-14 18:17 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-14 7:25 [PATCH] media: mediatek: vcodec: fix minmax.cocci warning Guo Zhengkui
2022-06-14 7:25 ` Guo Zhengkui
2022-06-14 7:25 ` Guo Zhengkui
2022-06-14 18:16 ` Nicolas Dufresne
2022-06-14 18:16 ` Nicolas Dufresne
2022-06-14 18:16 ` Nicolas Dufresne
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.