Re: [Outreachy kernel] [PATCH] staging: iio: accel: adis16201: remove local variable addr

[Jonathan Cameron <jic23@jic23.retrosnub.co.uk>]

On 23 March 2017 14:48:10 GMT+00:00, Julia Lawall <julia=2Elawall@lip6=2Ef=
r> wrote:
>
>
>On Thu, 23 Mar 2017, Aishwarya Pant wrote:
>
>> Remove local variable addr from adis_read_reg_16() and
>adis_write_reg_16()
>> as it is used only once=2E
>>
>> Signed-off-by: Aishwarya Pant <aishpant@gmail=2Ecom>
>> ---
>>  drivers/staging/iio/accel/adis16201=2Ec | 12 ++++++------
>>  1 file changed, 6 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/staging/iio/accel/adis16201=2Ec
>b/drivers/staging/iio/accel/adis16201=2Ec
>> index fbc2406=2E=2Eb03c4f3 100644
>> --- a/drivers/staging/iio/accel/adis16201=2Ec
>> +++ b/drivers/staging/iio/accel/adis16201=2Ec
>> @@ -175,7 +175,6 @@ static int adis16201_read_raw(struct iio_dev
>*indio_dev,
>>  	struct adis *st =3D iio_priv(indio_dev);
>>  	int ret;
>>  	int bits;
>> -	u8 addr;
>>  	s16 val16;
>>
>>  	switch (mask) {
>> @@ -223,8 +222,9 @@ static int adis16201_read_raw(struct iio_dev
>*indio_dev,
>>  		default:
>>  			return -EINVAL;
>>  		}
>> -		addr =3D adis16201_addresses[chan->scan_index];
>> -		ret =3D adis_read_reg_16(st, addr, &val16);
>> +		ret =3D adis_read_reg_16(st,
>> +				       adis16201_addresses[chan->scan_index],
>> +				       &val16);
>
>The original code was probably nicer=2E  One line shorter in the part
>that
>actually does computation=2E
That did indeed fall out worse than i expected=2E

Sorry Aishwarya, I led you up a blind alley here!

Jonathan
>
>julia
>
>>  		if (ret)
>>  			return ret;
>>  		val16 &=3D (1 << bits) - 1;
>> @@ -244,7 +244,6 @@ static int adis16201_write_raw(struct iio_dev
>*indio_dev,
>>  	struct adis *st =3D iio_priv(indio_dev);
>>  	int bits;
>>  	s16 val16;
>> -	u8 addr;
>>
>>  	switch (mask) {
>>  	case IIO_CHAN_INFO_CALIBBIAS:
>> @@ -259,8 +258,9 @@ static int adis16201_write_raw(struct iio_dev
>*indio_dev,
>>  			return -EINVAL;
>>  		}
>>  		val16 =3D val & ((1 << bits) - 1);
>> -		addr =3D adis16201_addresses[chan->scan_index];
>> -		return adis_write_reg_16(st, addr, val16);
>> +		return adis_write_reg_16(st,
>> +					 adis16201_addresses[chan->scan_index],
>> +					 val16);
>>  	}
>>  	return -EINVAL;
>>  }
>> --
>> 2=2E7=2E4
>>
>> --
>> You received this message because you are subscribed to the Google
>Groups "outreachy-kernel" group=2E
>> To unsubscribe from this group and stop receiving emails from it,
>send an email to outreachy-kernel+unsubscribe@googlegroups=2Ecom=2E
>> To post to this group, send email to
>outreachy-kernel@googlegroups=2Ecom=2E
>> To view this discussion on the web visit
>https://groups=2Egoogle=2Ecom/d/msgid/outreachy-kernel/20170323144453=2EG=
A7093%40aishwarya=2E
>> For more options, visit https://groups=2Egoogle=2Ecom/d/optout=2E
>>
>--
>To unsubscribe from this list: send the line "unsubscribe linux-iio" in
>the body of a message to majordomo@vger=2Ekernel=2Eorg
>More majordomo info at  http://vger=2Ekernel=2Eorg/majordomo-info=2Ehtml

--=20
Sent from my Android device with K-9 Mail=2E Please excuse my brevity=2E