From: "Liu, Yi L" <yi.l.liu@intel.com> To: Peter Xu <peterx@redhat.com> Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, "david@gibson.dropbear.id.au" <david@gibson.dropbear.id.au>, "pbonzini@redhat.com" <pbonzini@redhat.com>, "alex.williamson@redhat.com" <alex.williamson@redhat.com>, "mst@redhat.com" <mst@redhat.com>, "eric.auger@redhat.com" <eric.auger@redhat.com>, "Tian, Kevin" <kevin.tian@intel.com>, "Tian, Jun J" <jun.j.tian@intel.com>, "Sun, Yi Y" <yi.y.sun@intel.com>, "kvm@vger.kernel.org" <kvm@vger.kernel.org>, "Wu, Hao" <hao.wu@intel.com>, Jacob Pan <jacob.jun.pan@linux.intel.com>, Yi Sun <yi.y.sun@linux.intel.com>, Richard Henderson <rth@twiddle.net>, "Eduardo Habkost" <ehabkost@redhat.com> Subject: RE: [RFC v3 13/25] intel_iommu: modify x-scalable-mode to be string option Date: Wed, 12 Feb 2020 07:28:24 +0000 [thread overview] Message-ID: <A2975661238FB949B60364EF0F2C25743A1BA573@SHSMSX104.ccr.corp.intel.com> (raw) In-Reply-To: <20200211194331.GK984290@xz-x1> > From: Peter Xu <peterx@redhat.com> > Sent: Wednesday, February 12, 2020 3:44 AM > To: Liu, Yi L <yi.l.liu@intel.com> > Subject: Re: [RFC v3 13/25] intel_iommu: modify x-scalable-mode to be string > option > > On Wed, Jan 29, 2020 at 04:16:44AM -0800, Liu, Yi L wrote: > > From: Liu Yi L <yi.l.liu@intel.com> > > > > Intel VT-d 3.0 introduces scalable mode, and it has a bunch of > > capabilities related to scalable mode translation, thus there are multiple > combinations. > > While this vIOMMU implementation wants simplify it for user by > > providing typical combinations. User could config it by > > "x-scalable-mode" option. The usage is as below: > > > > "-device intel-iommu,x-scalable-mode=["legacy"|"modern"]" > > Maybe also "off" when someone wants to explicitly disable it? emmm, I think x-scalable-mode should be disabled by default. It is enabled only when "legacy" or "modern" is configured. I'm fine to add "off" as an explicit way to turn it off if you think it is necessary. :-) > > > > - "legacy": gives support for SL page table > > - "modern": gives support for FL page table, pasid, virtual command > > - if not configured, means no scalable mode support, if not proper > > configured, will throw error > > > > Cc: Kevin Tian <kevin.tian@intel.com> > > Cc: Jacob Pan <jacob.jun.pan@linux.intel.com> > > Cc: Peter Xu <peterx@redhat.com> > > Cc: Yi Sun <yi.y.sun@linux.intel.com> > > Cc: Paolo Bonzini <pbonzini@redhat.com> > > Cc: Richard Henderson <rth@twiddle.net> > > Cc: Eduardo Habkost <ehabkost@redhat.com> > > Signed-off-by: Liu Yi L <yi.l.liu@intel.com> > > Signed-off-by: Yi Sun <yi.y.sun@linux.intel.com> > > --- > > hw/i386/intel_iommu.c | 27 +++++++++++++++++++++++++-- > > hw/i386/intel_iommu_internal.h | 3 +++ > > include/hw/i386/intel_iommu.h | 2 ++ > > 3 files changed, 30 insertions(+), 2 deletions(-) > > > > diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c index > > 1c1eb7f..33be40c 100644 > > --- a/hw/i386/intel_iommu.c > > +++ b/hw/i386/intel_iommu.c > > @@ -3078,7 +3078,7 @@ static Property vtd_properties[] = { > > DEFINE_PROP_UINT8("aw-bits", IntelIOMMUState, aw_bits, > > VTD_HOST_ADDRESS_WIDTH), > > DEFINE_PROP_BOOL("caching-mode", IntelIOMMUState, caching_mode, > FALSE), > > - DEFINE_PROP_BOOL("x-scalable-mode", IntelIOMMUState, scalable_mode, > FALSE), > > + DEFINE_PROP_STRING("x-scalable-mode", IntelIOMMUState, > > + scalable_mode_str), > > DEFINE_PROP_BOOL("dma-drain", IntelIOMMUState, dma_drain, true), > > DEFINE_PROP_END_OF_LIST(), > > }; > > @@ -3708,8 +3708,11 @@ static void vtd_init(IntelIOMMUState *s) > > } > > > > /* TODO: read cap/ecap from host to decide which cap to be exposed. */ > > - if (s->scalable_mode) { > > + if (s->scalable_mode && !s->scalable_modern) { > > s->ecap |= VTD_ECAP_SMTS | VTD_ECAP_SRS | VTD_ECAP_SLTS; > > + } else if (s->scalable_mode && s->scalable_modern) { > > + s->ecap |= VTD_ECAP_SMTS | VTD_ECAP_SRS | VTD_ECAP_PASID > > + | VTD_ECAP_FLTS | VTD_ECAP_PSS; > > This patch might be good to be the last one after all the impls are ready. Oh, yes. Let me reorder it in next version. > > } > > > > vtd_reset_caches(s); > > @@ -3845,6 +3848,26 @@ static bool vtd_decide_config(IntelIOMMUState *s, > Error **errp) > > return false; > > } > > > > + if (s->scalable_mode_str && > > + (strcmp(s->scalable_mode_str, "modern") && > > + strcmp(s->scalable_mode_str, "legacy"))) { > > + error_setg(errp, "Invalid x-scalable-mode config"); > > Maybe "..., Please use 'modern', 'legacy', or 'off'." to show options. Got it. Thanks, Yi Liu
WARNING: multiple messages have this Message-ID (diff)
From: "Liu, Yi L" <yi.l.liu@intel.com> To: Peter Xu <peterx@redhat.com> Cc: "Tian, Kevin" <kevin.tian@intel.com>, Jacob Pan <jacob.jun.pan@linux.intel.com>, Yi Sun <yi.y.sun@linux.intel.com>, Eduardo Habkost <ehabkost@redhat.com>, "kvm@vger.kernel.org" <kvm@vger.kernel.org>, "mst@redhat.com" <mst@redhat.com>, "Tian, Jun J" <jun.j.tian@intel.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, "eric.auger@redhat.com" <eric.auger@redhat.com>, "alex.williamson@redhat.com" <alex.williamson@redhat.com>, "pbonzini@redhat.com" <pbonzini@redhat.com>, "Wu, Hao" <hao.wu@intel.com>, "Sun, Yi Y" <yi.y.sun@intel.com>, Richard Henderson <rth@twiddle.net>, "david@gibson.dropbear.id.au" <david@gibson.dropbear.id.au> Subject: RE: [RFC v3 13/25] intel_iommu: modify x-scalable-mode to be string option Date: Wed, 12 Feb 2020 07:28:24 +0000 [thread overview] Message-ID: <A2975661238FB949B60364EF0F2C25743A1BA573@SHSMSX104.ccr.corp.intel.com> (raw) In-Reply-To: <20200211194331.GK984290@xz-x1> > From: Peter Xu <peterx@redhat.com> > Sent: Wednesday, February 12, 2020 3:44 AM > To: Liu, Yi L <yi.l.liu@intel.com> > Subject: Re: [RFC v3 13/25] intel_iommu: modify x-scalable-mode to be string > option > > On Wed, Jan 29, 2020 at 04:16:44AM -0800, Liu, Yi L wrote: > > From: Liu Yi L <yi.l.liu@intel.com> > > > > Intel VT-d 3.0 introduces scalable mode, and it has a bunch of > > capabilities related to scalable mode translation, thus there are multiple > combinations. > > While this vIOMMU implementation wants simplify it for user by > > providing typical combinations. User could config it by > > "x-scalable-mode" option. The usage is as below: > > > > "-device intel-iommu,x-scalable-mode=["legacy"|"modern"]" > > Maybe also "off" when someone wants to explicitly disable it? emmm, I think x-scalable-mode should be disabled by default. It is enabled only when "legacy" or "modern" is configured. I'm fine to add "off" as an explicit way to turn it off if you think it is necessary. :-) > > > > - "legacy": gives support for SL page table > > - "modern": gives support for FL page table, pasid, virtual command > > - if not configured, means no scalable mode support, if not proper > > configured, will throw error > > > > Cc: Kevin Tian <kevin.tian@intel.com> > > Cc: Jacob Pan <jacob.jun.pan@linux.intel.com> > > Cc: Peter Xu <peterx@redhat.com> > > Cc: Yi Sun <yi.y.sun@linux.intel.com> > > Cc: Paolo Bonzini <pbonzini@redhat.com> > > Cc: Richard Henderson <rth@twiddle.net> > > Cc: Eduardo Habkost <ehabkost@redhat.com> > > Signed-off-by: Liu Yi L <yi.l.liu@intel.com> > > Signed-off-by: Yi Sun <yi.y.sun@linux.intel.com> > > --- > > hw/i386/intel_iommu.c | 27 +++++++++++++++++++++++++-- > > hw/i386/intel_iommu_internal.h | 3 +++ > > include/hw/i386/intel_iommu.h | 2 ++ > > 3 files changed, 30 insertions(+), 2 deletions(-) > > > > diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c index > > 1c1eb7f..33be40c 100644 > > --- a/hw/i386/intel_iommu.c > > +++ b/hw/i386/intel_iommu.c > > @@ -3078,7 +3078,7 @@ static Property vtd_properties[] = { > > DEFINE_PROP_UINT8("aw-bits", IntelIOMMUState, aw_bits, > > VTD_HOST_ADDRESS_WIDTH), > > DEFINE_PROP_BOOL("caching-mode", IntelIOMMUState, caching_mode, > FALSE), > > - DEFINE_PROP_BOOL("x-scalable-mode", IntelIOMMUState, scalable_mode, > FALSE), > > + DEFINE_PROP_STRING("x-scalable-mode", IntelIOMMUState, > > + scalable_mode_str), > > DEFINE_PROP_BOOL("dma-drain", IntelIOMMUState, dma_drain, true), > > DEFINE_PROP_END_OF_LIST(), > > }; > > @@ -3708,8 +3708,11 @@ static void vtd_init(IntelIOMMUState *s) > > } > > > > /* TODO: read cap/ecap from host to decide which cap to be exposed. */ > > - if (s->scalable_mode) { > > + if (s->scalable_mode && !s->scalable_modern) { > > s->ecap |= VTD_ECAP_SMTS | VTD_ECAP_SRS | VTD_ECAP_SLTS; > > + } else if (s->scalable_mode && s->scalable_modern) { > > + s->ecap |= VTD_ECAP_SMTS | VTD_ECAP_SRS | VTD_ECAP_PASID > > + | VTD_ECAP_FLTS | VTD_ECAP_PSS; > > This patch might be good to be the last one after all the impls are ready. Oh, yes. Let me reorder it in next version. > > } > > > > vtd_reset_caches(s); > > @@ -3845,6 +3848,26 @@ static bool vtd_decide_config(IntelIOMMUState *s, > Error **errp) > > return false; > > } > > > > + if (s->scalable_mode_str && > > + (strcmp(s->scalable_mode_str, "modern") && > > + strcmp(s->scalable_mode_str, "legacy"))) { > > + error_setg(errp, "Invalid x-scalable-mode config"); > > Maybe "..., Please use 'modern', 'legacy', or 'off'." to show options. Got it. Thanks, Yi Liu
next prev parent reply other threads:[~2020-02-12 7:28 UTC|newest] Thread overview: 136+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-01-29 12:16 [RFC v3 00/25] intel_iommu: expose Shared Virtual Addressing to VMs Liu, Yi L 2020-01-29 12:16 ` Liu, Yi L 2020-01-29 12:16 ` [RFC v3 01/25] hw/pci: modify pci_setup_iommu() to set PCIIOMMUOps Liu, Yi L 2020-01-29 12:16 ` Liu, Yi L 2020-01-29 12:16 ` [RFC v3 02/25] hw/iommu: introduce DualStageIOMMUObject Liu, Yi L 2020-01-29 12:16 ` Liu, Yi L 2020-01-31 3:59 ` David Gibson 2020-01-31 3:59 ` David Gibson 2020-01-31 11:42 ` Liu, Yi L 2020-01-31 11:42 ` Liu, Yi L 2020-02-12 6:32 ` David Gibson 2020-02-12 6:32 ` David Gibson 2020-01-29 12:16 ` [RFC v3 03/25] hw/iommu: introduce IOMMUContext Liu, Yi L 2020-01-29 12:16 ` Liu, Yi L 2020-01-31 4:06 ` David Gibson 2020-01-31 4:06 ` David Gibson 2020-01-31 11:42 ` Liu, Yi L 2020-01-31 11:42 ` Liu, Yi L 2020-02-11 16:58 ` Peter Xu 2020-02-11 16:58 ` Peter Xu 2020-02-12 7:15 ` Liu, Yi L 2020-02-12 7:15 ` Liu, Yi L 2020-02-12 15:59 ` Peter Xu 2020-02-12 15:59 ` Peter Xu 2020-02-13 2:46 ` Liu, Yi L 2020-02-13 2:46 ` Liu, Yi L 2020-02-14 5:36 ` David Gibson 2020-02-14 5:36 ` David Gibson 2020-02-15 6:25 ` Liu, Yi L 2020-02-15 6:25 ` Liu, Yi L 2020-01-29 12:16 ` [RFC v3 04/25] hw/pci: introduce pci_device_iommu_context() Liu, Yi L 2020-01-29 12:16 ` Liu, Yi L 2020-01-29 12:16 ` [RFC v3 05/25] intel_iommu: provide get_iommu_context() callback Liu, Yi L 2020-01-29 12:16 ` Liu, Yi L 2020-01-29 12:16 ` [RFC v3 06/25] scripts/update-linux-headers: Import iommu.h Liu, Yi L 2020-01-29 12:16 ` Liu, Yi L 2020-01-29 12:25 ` Cornelia Huck 2020-01-29 12:25 ` Cornelia Huck 2020-01-31 11:40 ` Liu, Yi L 2020-01-31 11:40 ` Liu, Yi L 2020-01-29 12:16 ` [RFC v3 07/25] header file update VFIO/IOMMU vSVA APIs Liu, Yi L 2020-01-29 12:16 ` Liu, Yi L 2020-01-29 12:28 ` Cornelia Huck 2020-01-29 12:28 ` Cornelia Huck 2020-01-31 11:41 ` Liu, Yi L 2020-01-31 11:41 ` Liu, Yi L 2020-01-29 12:16 ` [RFC v3 08/25] vfio: pass IOMMUContext into vfio_get_group() Liu, Yi L 2020-01-29 12:16 ` Liu, Yi L 2020-01-29 12:16 ` [RFC v3 09/25] vfio: check VFIO_TYPE1_NESTING_IOMMU support Liu, Yi L 2020-01-29 12:16 ` Liu, Yi L 2020-02-11 19:08 ` Peter Xu 2020-02-11 19:08 ` Peter Xu 2020-02-12 7:16 ` Liu, Yi L 2020-02-12 7:16 ` Liu, Yi L 2020-01-29 12:16 ` [RFC v3 10/25] vfio: register DualStageIOMMUObject to vIOMMU Liu, Yi L 2020-01-29 12:16 ` Liu, Yi L 2020-01-29 12:16 ` [RFC v3 11/25] vfio: get stage-1 pasid formats from Kernel Liu, Yi L 2020-01-29 12:16 ` Liu, Yi L 2020-02-11 19:30 ` Peter Xu 2020-02-11 19:30 ` Peter Xu 2020-02-12 7:19 ` Liu, Yi L 2020-02-12 7:19 ` Liu, Yi L 2020-01-29 12:16 ` [RFC v3 12/25] vfio/common: add pasid_alloc/free support Liu, Yi L 2020-01-29 12:16 ` Liu, Yi L 2020-02-11 19:31 ` Peter Xu 2020-02-11 19:31 ` Peter Xu 2020-02-12 7:20 ` Liu, Yi L 2020-02-12 7:20 ` Liu, Yi L 2020-01-29 12:16 ` [RFC v3 13/25] intel_iommu: modify x-scalable-mode to be string option Liu, Yi L 2020-01-29 12:16 ` Liu, Yi L 2020-02-11 19:43 ` Peter Xu 2020-02-11 19:43 ` Peter Xu 2020-02-12 7:28 ` Liu, Yi L [this message] 2020-02-12 7:28 ` Liu, Yi L 2020-02-12 16:05 ` Peter Xu 2020-02-12 16:05 ` Peter Xu 2020-02-13 2:44 ` Liu, Yi L 2020-02-13 2:44 ` Liu, Yi L 2020-01-29 12:16 ` [RFC v3 14/25] intel_iommu: add virtual command capability support Liu, Yi L 2020-01-29 12:16 ` Liu, Yi L 2020-02-11 20:16 ` Peter Xu 2020-02-11 20:16 ` Peter Xu 2020-02-12 7:32 ` Liu, Yi L 2020-02-12 7:32 ` Liu, Yi L 2020-02-11 21:56 ` Peter Xu 2020-02-11 21:56 ` Peter Xu 2020-02-13 2:40 ` Liu, Yi L 2020-02-13 2:40 ` Liu, Yi L 2020-02-13 14:31 ` Peter Xu 2020-02-13 14:31 ` Peter Xu 2020-02-13 15:08 ` Peter Xu 2020-02-13 15:08 ` Peter Xu 2020-02-15 8:49 ` Liu, Yi L 2020-02-15 8:49 ` Liu, Yi L 2020-01-29 12:16 ` [RFC v3 15/25] intel_iommu: process pasid cache invalidation Liu, Yi L 2020-01-29 12:16 ` Liu, Yi L 2020-02-11 20:17 ` Peter Xu 2020-02-11 20:17 ` Peter Xu 2020-02-12 7:33 ` Liu, Yi L 2020-02-12 7:33 ` Liu, Yi L 2020-01-29 12:16 ` [RFC v3 16/25] intel_iommu: add PASID cache management infrastructure Liu, Yi L 2020-01-29 12:16 ` Liu, Yi L 2020-02-11 23:35 ` Peter Xu 2020-02-11 23:35 ` Peter Xu 2020-02-12 8:37 ` Liu, Yi L 2020-02-12 8:37 ` Liu, Yi L 2020-02-12 15:26 ` Peter Xu 2020-02-12 15:26 ` Peter Xu 2020-02-13 2:59 ` Liu, Yi L 2020-02-13 2:59 ` Liu, Yi L 2020-02-13 15:14 ` Peter Xu 2020-02-13 15:14 ` Peter Xu 2020-02-15 8:50 ` Liu, Yi L 2020-02-15 8:50 ` Liu, Yi L 2020-01-29 12:16 ` [RFC v3 17/25] vfio: add bind stage-1 page table support Liu, Yi L 2020-01-29 12:16 ` Liu, Yi L 2020-01-29 12:16 ` [RFC v3 18/25] intel_iommu: bind/unbind guest page table to host Liu, Yi L 2020-01-29 12:16 ` Liu, Yi L 2020-01-29 12:16 ` [RFC v3 19/25] intel_iommu: replay guest pasid bindings " Liu, Yi L 2020-01-29 12:16 ` Liu, Yi L 2020-01-29 12:16 ` [RFC v3 20/25] intel_iommu: replay pasid binds after context cache invalidation Liu, Yi L 2020-01-29 12:16 ` Liu, Yi L 2020-01-29 12:16 ` [RFC v3 21/25] intel_iommu: do not pass down pasid bind for PASID #0 Liu, Yi L 2020-01-29 12:16 ` Liu, Yi L 2020-01-29 12:16 ` [RFC v3 22/25] vfio: add support for flush iommu stage-1 cache Liu, Yi L 2020-01-29 12:16 ` Liu, Yi L 2020-01-29 12:16 ` [RFC v3 23/25] intel_iommu: process PASID-based iotlb invalidation Liu, Yi L 2020-01-29 12:16 ` Liu, Yi L 2020-01-29 12:16 ` [RFC v3 24/25] intel_iommu: propagate PASID-based iotlb invalidation to host Liu, Yi L 2020-01-29 12:16 ` Liu, Yi L 2020-01-29 12:16 ` [RFC v3 25/25] intel_iommu: process PASID-based Device-TLB invalidation Liu, Yi L 2020-01-29 12:16 ` Liu, Yi L 2020-01-29 13:44 ` [RFC v3 00/25] intel_iommu: expose Shared Virtual Addressing to VMs no-reply 2020-01-29 13:44 ` no-reply 2020-01-29 13:48 ` no-reply 2020-01-29 13:48 ` no-reply
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=A2975661238FB949B60364EF0F2C25743A1BA573@SHSMSX104.ccr.corp.intel.com \ --to=yi.l.liu@intel.com \ --cc=alex.williamson@redhat.com \ --cc=david@gibson.dropbear.id.au \ --cc=ehabkost@redhat.com \ --cc=eric.auger@redhat.com \ --cc=hao.wu@intel.com \ --cc=jacob.jun.pan@linux.intel.com \ --cc=jun.j.tian@intel.com \ --cc=kevin.tian@intel.com \ --cc=kvm@vger.kernel.org \ --cc=mst@redhat.com \ --cc=pbonzini@redhat.com \ --cc=peterx@redhat.com \ --cc=qemu-devel@nongnu.org \ --cc=rth@twiddle.net \ --cc=yi.y.sun@intel.com \ --cc=yi.y.sun@linux.intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.