* [PATCH 1/1] ntfs: kernel-doc warning fixes
@ 2014-07-04 19:53 Fabian Frederick
2014-07-04 20:21 ` Anton Altaparmakov
0 siblings, 1 reply; 2+ messages in thread
From: Fabian Frederick @ 2014-07-04 19:53 UTC (permalink / raw)
To: linux-kernel
Cc: Fabian Frederick, Anton Altaparmakov, Andrew Morton, linux-ntfs-dev
cached_page and lru_pvec were removed from
ntfs_attr_extend_initialized in commit 2ec93b0bf35f
("ntfs: clean up ntfs_attr_extend_initialized")
lru_pvec has been removed from __ntfs_grab_cache_pages in commit 4c99000ac47c
("ntfs: use add_to_page_cache_lru()")
Cc: Anton Altaparmakov <anton@tuxera.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-ntfs-dev@lists.sourceforge.net
Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
fs/ntfs/file.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/fs/ntfs/file.c b/fs/ntfs/file.c
index 5c9e2c8..f5ec1ce 100644
--- a/fs/ntfs/file.c
+++ b/fs/ntfs/file.c
@@ -74,8 +74,6 @@ static int ntfs_file_open(struct inode *vi, struct file *filp)
* ntfs_attr_extend_initialized - extend the initialized size of an attribute
* @ni: ntfs inode of the attribute to extend
* @new_init_size: requested new initialized size in bytes
- * @cached_page: store any allocated but unused page here
- * @lru_pvec: lru-buffering pagevec of the caller
*
* Extend the initialized size of an attribute described by the ntfs inode @ni
* to @new_init_size bytes. This involves zeroing any non-sparse space between
@@ -395,7 +393,6 @@ static inline void ntfs_fault_in_pages_readable_iovec(const struct iovec *iov,
* @nr_pages: number of page cache pages to obtain
* @pages: array of pages in which to return the obtained page cache pages
* @cached_page: allocated but as yet unused page
- * @lru_pvec: lru-buffering pagevec of caller
*
* Obtain @nr_pages locked page cache pages from the mapping @mapping and
* starting at index @index.
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] ntfs: kernel-doc warning fixes
2014-07-04 19:53 [PATCH 1/1] ntfs: kernel-doc warning fixes Fabian Frederick
@ 2014-07-04 20:21 ` Anton Altaparmakov
0 siblings, 0 replies; 2+ messages in thread
From: Anton Altaparmakov @ 2014-07-04 20:21 UTC (permalink / raw)
To: Fabian Frederick; +Cc: linux-kernel, Andrew Morton, linux-ntfs-dev
Hi,
Looks good, thanks. Feel free to add:
Acked-by: Anton Altaparmakov <anton@tuxera.com>
Andrew, could you please take it in your tree for merging?
Thanks a lot in advance!
Best regards,
Anton
On 4 Jul 2014, at 20:53, Fabian Frederick <fabf@skynet.be> wrote:
> cached_page and lru_pvec were removed from
> ntfs_attr_extend_initialized in commit 2ec93b0bf35f
> ("ntfs: clean up ntfs_attr_extend_initialized")
>
> lru_pvec has been removed from __ntfs_grab_cache_pages in commit 4c99000ac47c
> ("ntfs: use add_to_page_cache_lru()")
>
> Cc: Anton Altaparmakov <anton@tuxera.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: linux-ntfs-dev@lists.sourceforge.net
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
> ---
> fs/ntfs/file.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/fs/ntfs/file.c b/fs/ntfs/file.c
> index 5c9e2c8..f5ec1ce 100644
> --- a/fs/ntfs/file.c
> +++ b/fs/ntfs/file.c
> @@ -74,8 +74,6 @@ static int ntfs_file_open(struct inode *vi, struct file *filp)
> * ntfs_attr_extend_initialized - extend the initialized size of an attribute
> * @ni: ntfs inode of the attribute to extend
> * @new_init_size: requested new initialized size in bytes
> - * @cached_page: store any allocated but unused page here
> - * @lru_pvec: lru-buffering pagevec of the caller
> *
> * Extend the initialized size of an attribute described by the ntfs inode @ni
> * to @new_init_size bytes. This involves zeroing any non-sparse space between
> @@ -395,7 +393,6 @@ static inline void ntfs_fault_in_pages_readable_iovec(const struct iovec *iov,
> * @nr_pages: number of page cache pages to obtain
> * @pages: array of pages in which to return the obtained page cache pages
> * @cached_page: allocated but as yet unused page
> - * @lru_pvec: lru-buffering pagevec of caller
> *
> * Obtain @nr_pages locked page cache pages from the mapping @mapping and
> * starting at index @index.
> --
> 1.9.1
>
--
Anton Altaparmakov <aia21 at cam.ac.uk> (replace at with @)
University of Cambridge Information Services, Roger Needham Building
7 JJ Thomson Avenue, Cambridge, CB3 0RB, UK
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-07-04 20:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-07-04 19:53 [PATCH 1/1] ntfs: kernel-doc warning fixes Fabian Frederick
2014-07-04 20:21 ` Anton Altaparmakov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.