* [PATCH] python-scons_1.3.0: add missing dependencies
@ 2011-01-25 15:51 Víctor Manuel Jáquez Leal
2011-01-25 15:59 ` Koen Kooi
0 siblings, 1 reply; 4+ messages in thread
From: Víctor Manuel Jáquez Leal @ 2011-01-25 15:51 UTC (permalink / raw)
To: openembedded-devel; +Cc: Koen Kooi
In order to launch scons in a board it depends on a couple python packages
which were not managed by the recipe.
This patch adds them.
Signed-off-by: Víctor Manuel Jáquez Leal <vjaquez@igalia.com>
---
recipes/python/python-scons_1.3.0.bb | 8 ++++++++
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/recipes/python/python-scons_1.3.0.bb b/recipes/python/python-scons_1.3.0.bb
index 792e3a5..0dc3236 100644
--- a/recipes/python/python-scons_1.3.0.bb
+++ b/recipes/python/python-scons_1.3.0.bb
@@ -1,8 +1,16 @@
DESCRIPTION = "A Software Construction Tool"
SECTION = "devel/python"
PRIORITY = "optional"
+RDEPENDS_${PN} = "python-shell \
+ python-stringold \
+ python-lang \
+ python-io \
+ python-fcntl \
+ python-pickle \
+ python-crypt"
LICENSE = "GPL"
SRCNAME = "scons"
+PR = "r1"
SRC_URI = "${SOURCEFORGE_MIRROR}/scons/scons-${PV}.tar.gz;name=scons \
file://toolchain-from-env.SConscript \
--
1.7.2.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] python-scons_1.3.0: add missing dependencies
2011-01-25 15:51 [PATCH] python-scons_1.3.0: add missing dependencies Víctor Manuel Jáquez Leal
@ 2011-01-25 15:59 ` Koen Kooi
2011-01-25 16:18 ` Víctor M. Jáquez L.
0 siblings, 1 reply; 4+ messages in thread
From: Koen Kooi @ 2011-01-25 15:59 UTC (permalink / raw)
To: Víctor Manuel Jáquez Leal; +Cc: Koen Kooi, openembedded-devel
Some small nitpicks, see below
Op 25 jan 2011, om 16:51 heeft Víctor Manuel Jáquez Leal het volgende geschreven:
> In order to launch scons in a board it depends on a couple python packages
> which were not managed by the recipe.
>
> This patch adds them.
>
> Signed-off-by: Víctor Manuel Jáquez Leal <vjaquez@igalia.com>
> ---
> recipes/python/python-scons_1.3.0.bb | 8 ++++++++
> 1 files changed, 8 insertions(+), 0 deletions(-)
>
> diff --git a/recipes/python/python-scons_1.3.0.bb b/recipes/python/python-scons_1.3.0.bb
> index 792e3a5..0dc3236 100644
> --- a/recipes/python/python-scons_1.3.0.bb
> +++ b/recipes/python/python-scons_1.3.0.bb
> @@ -1,8 +1,16 @@
> DESCRIPTION = "A Software Construction Tool"
> SECTION = "devel/python"
> PRIORITY = "optional"
> +RDEPENDS_${PN} = "python-shell \
> + python-stringold \
> + python-lang \
> + python-io \
> + python-fcntl \
> + python-pickle \
> + python-crypt"
We generally put variables in the order OE uses them, so RDEPENDS should go next to do_package/FILES/etc. Historically it was on top, but that stopped making sense after switching to RDEPENDS_${PN}
> LICENSE = "GPL"
Could you fix that while you're at it? It would be nice to know if it's GPLv2 or GPLv2+.
Other than that, the patch looks OK to me[1].
regards,
Koen
[1] Sconstructs still make my eyes bleed, but that's not the point
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] python-scons_1.3.0: add missing dependencies
2011-01-25 15:59 ` Koen Kooi
@ 2011-01-25 16:18 ` Víctor M. Jáquez L.
2011-01-25 16:22 ` Koen Kooi
0 siblings, 1 reply; 4+ messages in thread
From: Víctor M. Jáquez L. @ 2011-01-25 16:18 UTC (permalink / raw)
To: Koen Kooi; +Cc: Koen Kooi, openembedded-devel
On Tue, Jan 25, 2011 at 04:59:25PM +0100, Koen Kooi wrote:
> Some small nitpicks, see below
>
> Op 25 jan 2011, om 16:51 heeft Víctor Manuel Jáquez Leal het volgende geschreven:
>
> > In order to launch scons in a board it depends on a couple python packages
> > which were not managed by the recipe.
> >
[snip]
>
> We generally put variables in the order OE uses them, so RDEPENDS should go
> next to do_package/FILES/etc. Historically it was on top, but that stopped
> making sense after switching to RDEPENDS_${PN}
Done.
>
> > LICENSE = "GPL"
>
> Could you fix that while you're at it? It would be nice to know if it's
> GPLv2 or GPLv2+.
Verified. It is MIT not GPL!
>
> Other than that, the patch looks OK to me[1].
>
> regards,
>
> Koen
>
> [1] Sconstructs still make my eyes bleed, but that's not the point
I do not like it either at all, but v8 uses it.
vmjl
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] python-scons_1.3.0: add missing dependencies
2011-01-25 16:18 ` Víctor M. Jáquez L.
@ 2011-01-25 16:22 ` Koen Kooi
0 siblings, 0 replies; 4+ messages in thread
From: Koen Kooi @ 2011-01-25 16:22 UTC (permalink / raw)
To: Víctor M. Jáquez L.; +Cc: openembedded-devel
Op 25 jan 2011, om 17:18 heeft Víctor M. Jáquez L. het volgende geschreven:
> On Tue, Jan 25, 2011 at 04:59:25PM +0100, Koen Kooi wrote:
>> Some small nitpicks, see below
>>
>> Op 25 jan 2011, om 16:51 heeft Víctor Manuel Jáquez Leal het volgende geschreven:
>>
>>> In order to launch scons in a board it depends on a couple python packages
>>> which were not managed by the recipe.
>>>
>
> [snip]
>
>>
>> We generally put variables in the order OE uses them, so RDEPENDS should go
>> next to do_package/FILES/etc. Historically it was on top, but that stopped
>> making sense after switching to RDEPENDS_${PN}
>
> Done.
>
>>
>>> LICENSE = "GPL"
>>
>> Could you fix that while you're at it? It would be nice to know if it's
>> GPLv2 or GPLv2+.
>
> Verified. It is MIT not GPL!
Good catch!
>
>>
>> Other than that, the patch looks OK to me[1].
>>
>> regards,
>>
>> Koen
>>
>> [1] Sconstructs still make my eyes bleed, but that's not the point
>
> I do not like it either at all, but v8 uses it.
>
> vmjl
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-01-25 16:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-01-25 15:51 [PATCH] python-scons_1.3.0: add missing dependencies Víctor Manuel Jáquez Leal
2011-01-25 15:59 ` Koen Kooi
2011-01-25 16:18 ` Víctor M. Jáquez L.
2011-01-25 16:22 ` Koen Kooi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.