* [PATCH 5/7] dwc2: remove redundant D0 power state set
@ 2013-05-30 10:24 Yijing Wang
2013-05-30 18:18 ` Paul Zimmerman
0 siblings, 1 reply; 3+ messages in thread
From: Yijing Wang @ 2013-05-30 10:24 UTC (permalink / raw)
To: Paul Zimmerman
Cc: linux-kernel, Greg Kroah-Hartman, linux-usb, devel, Hanjun Guo,
Jiang Liu, Yijing Wang
Pci_enable_device() will set device power state to D0,
so it's no need to do it again in dwc2_driver_probe().
Signed-off-by: Yijing Wang <wangyijing@huawei.com>
---
drivers/staging/dwc2/pci.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/dwc2/pci.c b/drivers/staging/dwc2/pci.c
index 69c65eb..6a196c2 100644
--- a/drivers/staging/dwc2/pci.c
+++ b/drivers/staging/dwc2/pci.c
@@ -131,8 +131,6 @@ static int dwc2_driver_probe(struct pci_dev *dev,
if (!hsotg)
return -ENOMEM;
- pci_set_power_state(dev, PCI_D0);
-
hsotg->dev = &dev->dev;
hsotg->regs = devm_request_and_ioremap(&dev->dev, &dev->resource[0]);
if (!hsotg->regs)
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH 5/7] dwc2: remove redundant D0 power state set
2013-05-30 10:24 [PATCH 5/7] dwc2: remove redundant D0 power state set Yijing Wang
@ 2013-05-30 18:18 ` Paul Zimmerman
0 siblings, 0 replies; 3+ messages in thread
From: Paul Zimmerman @ 2013-05-30 18:18 UTC (permalink / raw)
To: Yijing Wang
Cc: linux-kernel, Greg Kroah-Hartman, linux-usb, devel, Hanjun Guo,
Jiang Liu
> From: Yijing Wang [mailto:wangyijing@huawei.com]
> Sent: Thursday, May 30, 2013 3:24 AM
>
> Pci_enable_device() will set device power state to D0,
> so it's no need to do it again in dwc2_driver_probe().
>
> Signed-off-by: Yijing Wang <wangyijing@huawei.com>
> ---
> drivers/staging/dwc2/pci.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/dwc2/pci.c b/drivers/staging/dwc2/pci.c
> index 69c65eb..6a196c2 100644
> --- a/drivers/staging/dwc2/pci.c
> +++ b/drivers/staging/dwc2/pci.c
> @@ -131,8 +131,6 @@ static int dwc2_driver_probe(struct pci_dev *dev,
> if (!hsotg)
> return -ENOMEM;
>
> - pci_set_power_state(dev, PCI_D0);
> -
> hsotg->dev = &dev->dev;
> hsotg->regs = devm_request_and_ioremap(&dev->dev, &dev->resource[0]);
> if (!hsotg->regs)
> --
> 1.7.1
Acked-by: Paul Zimmerman <paulz@synopsys.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 5/7] dwc2: remove redundant D0 power state set
@ 2013-06-03 2:12 Yijing Wang
0 siblings, 0 replies; 3+ messages in thread
From: Yijing Wang @ 2013-06-03 2:12 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: linux-kernel, Hanjun Guo, Jiang Liu, Yijing Wang, Paul Zimmerman,
linux-usb, devel
Pci_enable_device() will set device power state to D0,
so it's no need to do it again in dwc2_driver_probe().
Acked-by: Paul Zimmerman <paulz@synopsys.com>
Signed-off-by: Yijing Wang <wangyijing@huawei.com>
Cc: Paul Zimmerman <paulz@synopsys.com>
Cc: linux-usb@vger.kernel.org
Cc: devel@driverdev.osuosl.org
---
drivers/staging/dwc2/pci.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/dwc2/pci.c b/drivers/staging/dwc2/pci.c
index 69c65eb..6a196c2 100644
--- a/drivers/staging/dwc2/pci.c
+++ b/drivers/staging/dwc2/pci.c
@@ -131,8 +131,6 @@ static int dwc2_driver_probe(struct pci_dev *dev,
if (!hsotg)
return -ENOMEM;
- pci_set_power_state(dev, PCI_D0);
-
hsotg->dev = &dev->dev;
hsotg->regs = devm_request_and_ioremap(&dev->dev, &dev->resource[0]);
if (!hsotg->regs)
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-06-03 2:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-05-30 10:24 [PATCH 5/7] dwc2: remove redundant D0 power state set Yijing Wang
2013-05-30 18:18 ` Paul Zimmerman
2013-06-03 2:12 Yijing Wang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.