Re: [PATCH v4 0/8] powerpc/perf: Add json file metric support for the hv_24x7 socket/chip level events

From: Arnaldo Melo <arnaldo.melo@gmail.com>
To: Jiri Olsa <jolsa@redhat.com>, Kajol Jain <kjain@linux.ibm.com>
Cc: mark.rutland@arm.com, maddy@linux.vnet.ibm.com,
	peterz@infradead.org, yao.jin@linux.intel.com, mingo@kernel.org,
	kan.liang@linux.intel.com, ak@linux.intel.com,
	alexander.shishkin@linux.intel.com, anju@linux.vnet.ibm.com,
	mamatha4@linux.vnet.ibm.com, sukadev@linux.vnet.ibm.com,
	ravi.bangoria@linux.ibm.com, acme@kernel.org, jmario@redhat.com,
	namhyung@kernel.org, tglx@linutronix.de, mpetlan@redhat.com,
	gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
	linux-perf-users@vger.kernel.org, jolsa@kernel.org,
	linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v4 0/8] powerpc/perf: Add json file metric support for the hv_24x7 socket/chip level events
Date: Mon, 09 Mar 2020 08:22:58 -0300	[thread overview]
Message-ID: <A2F32D56-CCD0-4D5E-ACAA-710AD91635AC@gmail.com> (raw)
In-Reply-To: <20200309093506.GB67774@krava>

[-- Attachment #1: Type: text/plain, Size: 2082 bytes --]

Sure, will do it today

On March 9, 2020 6:35:06 AM GMT-03:00, Jiri Olsa <jolsa@redhat.com> wrote:
>On Mon, Mar 09, 2020 at 11:55:44AM +0530, Kajol Jain wrote:
>> First patch of the patchset fix inconsistent results we are getting
>when
>> we run multiple 24x7 events.
>> 
>> Patchset adds json file metric support for the hv_24x7 socket/chip
>level
>> events. "hv_24x7" pmu interface events needs system dependent
>parameter
>> like socket/chip/core. For example, hv_24x7 chip level events needs
>> specific chip-id to which the data is requested should be added as
>part
>> of pmu events.
>> 
>> So to enable JSON file support to "hv_24x7" interface, patchset
>expose
>> total number of sockets and chips per-socket details in sysfs
>> files (sockets, chips) under "/sys/devices/hv_24x7/interface/".
>> 
>> To get sockets and number of chips per sockets, patchset adds a rtas
>call
>> with token "PROCESSOR_MODULE_INFO" to get these details. Patchset
>also
>> handles partition migration case to re-init these system depended
>> parameters by adding proper calls in post_mobility_fixup()
>(mobility.c).
>> 
>> Patch 6 & 8 of the patchset handles perf tool plumbing needed to
>replace
>> the "?" character in the metric expression to proper value and
>hv_24x7
>> json metric file for different Socket/chip resources.
>> 
>> Patch set also enable Hz/hz prinitg for --metric-only option to print
>> metric data for bus frequency.
>> 
>> Applied and tested all these patches cleanly on top of jiri's flex
>changes
>> with the changes done by Kan Liang for "Support metric group
>constraint"
>> patchset and made required changes.
>> 
>> Changelog:
>> v3 -> v4
>> - Made changes suggested by jiri.
>
>could you please mention them next time? ;-)
>
>> - Apply these patch on top of Kan liang changes.
>
>Arnaldo, could you please pull the expr flex changes and Kan's
>metric group constraint changes? it's both prereq of this patchset
>
>thanks,
>jirka

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.

[-- Attachment #2: Type: text/html, Size: 2560 bytes --]