All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Deucher, Alexander" <Alexander.Deucher@amd.com>
To: Christoph Jaeger <christophjaeger@linux.com>,
	"Koenig, Christian" <Christian.Koenig@amd.com>,
	"airlied@linux.ie" <airlied@linux.ie>
Cc: "dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] drm/radeon: fix VCE fence command
Date: Mon, 14 Apr 2014 22:13:08 +0000	[thread overview]
Message-ID: <A3397C8B8B789E45844E7EC5DEAD89D03ECB19EF@satlexdag05.amd.com> (raw)
In-Reply-To: <1397513422-1566-1-git-send-email-christophjaeger@linux.com>

> -----Original Message-----
> From: Christoph Jaeger [mailto:christophjaeger@linux.com]
> Sent: Monday, April 14, 2014 6:10 PM
> To: Deucher, Alexander; Koenig, Christian; airlied@linux.ie
> Cc: dri-devel@lists.freedesktop.org; linux-kernel@vger.kernel.org; Christoph
> Jaeger
> Subject: [PATCH] drm/radeon: fix VCE fence command
> 
> Due to a type mismatch that causes an implicit type conversion, the
> upper 32 bits of the GPU address have been zeroed out when adding to the
> command buffer.
> 
> Picked up by Coverity - CID 1198624.
> 
> Signed-off-by: Christoph Jaeger <christophjaeger@linux.com>

Good catch!

Reviewed-by: Alex Deucher <alexander.deucher@amd.com>

> ---
>  drivers/gpu/drm/radeon/radeon_vce.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/radeon/radeon_vce.c
> b/drivers/gpu/drm/radeon/radeon_vce.c
> index 76e9904..ced53dd 100644
> --- a/drivers/gpu/drm/radeon/radeon_vce.c
> +++ b/drivers/gpu/drm/radeon/radeon_vce.c
> @@ -613,7 +613,7 @@ void radeon_vce_fence_emit(struct radeon_device
> *rdev,
>  			   struct radeon_fence *fence)
>  {
>  	struct radeon_ring *ring = &rdev->ring[fence->ring];
> -	uint32_t addr = rdev->fence_drv[fence->ring].gpu_addr;
> +	uint64_t addr = rdev->fence_drv[fence->ring].gpu_addr;
> 
>  	radeon_ring_write(ring, VCE_CMD_FENCE);
>  	radeon_ring_write(ring, addr);
> --
> 1.9.0


WARNING: multiple messages have this Message-ID (diff)
From: "Deucher, Alexander" <Alexander.Deucher@amd.com>
To: Christoph Jaeger <christophjaeger@linux.com>,
	"Koenig, Christian" <Christian.Koenig@amd.com>,
	"airlied@linux.ie" <airlied@linux.ie>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>
Subject: RE: [PATCH] drm/radeon: fix VCE fence command
Date: Mon, 14 Apr 2014 22:13:08 +0000	[thread overview]
Message-ID: <A3397C8B8B789E45844E7EC5DEAD89D03ECB19EF@satlexdag05.amd.com> (raw)
In-Reply-To: <1397513422-1566-1-git-send-email-christophjaeger@linux.com>

> -----Original Message-----
> From: Christoph Jaeger [mailto:christophjaeger@linux.com]
> Sent: Monday, April 14, 2014 6:10 PM
> To: Deucher, Alexander; Koenig, Christian; airlied@linux.ie
> Cc: dri-devel@lists.freedesktop.org; linux-kernel@vger.kernel.org; Christoph
> Jaeger
> Subject: [PATCH] drm/radeon: fix VCE fence command
> 
> Due to a type mismatch that causes an implicit type conversion, the
> upper 32 bits of the GPU address have been zeroed out when adding to the
> command buffer.
> 
> Picked up by Coverity - CID 1198624.
> 
> Signed-off-by: Christoph Jaeger <christophjaeger@linux.com>

Good catch!

Reviewed-by: Alex Deucher <alexander.deucher@amd.com>

> ---
>  drivers/gpu/drm/radeon/radeon_vce.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/radeon/radeon_vce.c
> b/drivers/gpu/drm/radeon/radeon_vce.c
> index 76e9904..ced53dd 100644
> --- a/drivers/gpu/drm/radeon/radeon_vce.c
> +++ b/drivers/gpu/drm/radeon/radeon_vce.c
> @@ -613,7 +613,7 @@ void radeon_vce_fence_emit(struct radeon_device
> *rdev,
>  			   struct radeon_fence *fence)
>  {
>  	struct radeon_ring *ring = &rdev->ring[fence->ring];
> -	uint32_t addr = rdev->fence_drv[fence->ring].gpu_addr;
> +	uint64_t addr = rdev->fence_drv[fence->ring].gpu_addr;
> 
>  	radeon_ring_write(ring, VCE_CMD_FENCE);
>  	radeon_ring_write(ring, addr);
> --
> 1.9.0

  reply	other threads:[~2014-04-14 22:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-14 22:10 [PATCH] drm/radeon: fix VCE fence command Christoph Jaeger
2014-04-14 22:13 ` Deucher, Alexander [this message]
2014-04-14 22:13   ` Deucher, Alexander
2014-04-15  9:17   ` Christian König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=A3397C8B8B789E45844E7EC5DEAD89D03ECB19EF@satlexdag05.amd.com \
    --to=alexander.deucher@amd.com \
    --cc=Christian.Koenig@amd.com \
    --cc=airlied@linux.ie \
    --cc=christophjaeger@linux.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.