All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Ondrej Mosnacek <omosnace@redhat.com>
Cc: linux-crypto@vger.kernel.org,
	Herbert Xu <herbert@gondor.apana.org.au>,
	keyrings@vger.kernel.org, David Howells <dhowells@redhat.com>,
	Stephan Mueller <smueller@chronox.de>,
	Milan Broz <gmazyland@gmail.com>,
	Ondrej Kozina <okozina@redhat.com>,
	Daniel Zatovic <dzatovic@redhat.com>
Subject: Re: [PATCH] crypto: af_alg - implement keyring support
Date: Tue, 21 May 2019 12:47:23 +0200	[thread overview]
Message-ID: <A3BC3B07-6446-4631-862A-F661FB9D63B9@holtmann.org> (raw)
In-Reply-To: <20190521100034.9651-1-omosnace@redhat.com>

Hi Ondrej,

> This patch adds new socket options to AF_ALG that allow setting key from
> kernel keyring. For simplicity, each keyring key type (logon, user,
> trusted, encrypted) has its own socket option name and the value is just
> the key description string that identifies the key to be used. The key
> description doesn't need to be NULL-terminated, but bytes after the
> first zero byte are ignored.

why use the description instead the actual key id? I wonder if a single socket option and a struct providing the key type and key id might be more useful.

Regards

Marcel


WARNING: multiple messages have this Message-ID (diff)
From: Marcel Holtmann <marcel@holtmann.org>
To: Ondrej Mosnacek <omosnace@redhat.com>
Cc: linux-crypto@vger.kernel.org,
	Herbert Xu <herbert@gondor.apana.org.au>,
	keyrings@vger.kernel.org, David Howells <dhowells@redhat.com>,
	Stephan Mueller <smueller@chronox.de>,
	Milan Broz <gmazyland@gmail.com>,
	Ondrej Kozina <okozina@redhat.com>,
	Daniel Zatovic <dzatovic@redhat.com>
Subject: Re: [PATCH] crypto: af_alg - implement keyring support
Date: Tue, 21 May 2019 10:47:23 +0000	[thread overview]
Message-ID: <A3BC3B07-6446-4631-862A-F661FB9D63B9@holtmann.org> (raw)
In-Reply-To: <20190521100034.9651-1-omosnace@redhat.com>

Hi Ondrej,

> This patch adds new socket options to AF_ALG that allow setting key from
> kernel keyring. For simplicity, each keyring key type (logon, user,
> trusted, encrypted) has its own socket option name and the value is just
> the key description string that identifies the key to be used. The key
> description doesn't need to be NULL-terminated, but bytes after the
> first zero byte are ignored.

why use the description instead the actual key id? I wonder if a single socket option and a struct providing the key type and key id might be more useful.

Regards

Marcel

  reply	other threads:[~2019-05-21 10:47 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-21 10:00 [PATCH] crypto: af_alg - implement keyring support Ondrej Mosnacek
2019-05-21 10:00 ` Ondrej Mosnacek
2019-05-21 10:47 ` Marcel Holtmann [this message]
2019-05-21 10:47   ` Marcel Holtmann
2019-05-21 11:02   ` Ondrej Mosnacek
2019-05-21 11:02     ` Ondrej Mosnacek
2019-05-21 11:30     ` Ondrej Kozina
2019-05-21 11:30       ` Ondrej Kozina
2019-05-21 19:15 ` Stephan Müller
2019-05-21 19:15   ` Stephan Müller
2019-05-21 21:18 ` David Howells
2019-05-21 21:18   ` David Howells
2019-05-25  3:10 ` Eric Biggers
2019-05-25  3:10   ` Eric Biggers
2019-05-25  7:04   ` Milan Broz
2019-05-25  7:04     ` Milan Broz
2019-05-29 13:54   ` Ondrej Mosnacek
2019-05-29 13:54     ` Ondrej Mosnacek
2019-05-30  7:14 ` Herbert Xu
2019-05-30  7:14   ` Herbert Xu
2019-05-30 11:35   ` Ondrej Mosnacek
2019-05-30 11:35     ` Ondrej Mosnacek
2019-05-30 13:22     ` Herbert Xu
2019-05-30 13:22       ` Herbert Xu
2019-05-30  7:39 ` Milan Broz
2019-05-30  7:39   ` Milan Broz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=A3BC3B07-6446-4631-862A-F661FB9D63B9@holtmann.org \
    --to=marcel@holtmann.org \
    --cc=dhowells@redhat.com \
    --cc=dzatovic@redhat.com \
    --cc=gmazyland@gmail.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=keyrings@vger.kernel.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=okozina@redhat.com \
    --cc=omosnace@redhat.com \
    --cc=smueller@chronox.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.