[PATCH i-g-t] list-workarounds: Fix python 2 print statement

[PATCH i-g-t] list-workarounds: Fix python 2 print statement

[Damien Lespiau]

That script is a python 3 script, so we can't use the python 2 print
statement, it's a function now.

I missed it in the review because reviewing a diff without additional
context gives you a partial story.

Cc: Sameer Kibey <sameer.kibey@intel.com>
Cc: Dylan Baker <baker.dylan.c@gmail.com>
Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
---
 scripts/list-workarounds | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/list-workarounds b/scripts/list-workarounds
index 8b41ae5..70c026d 100755
--- a/scripts/list-workarounds
+++ b/scripts/list-workarounds
@@ -96,7 +96,7 @@ def print_workarounds(project_root, driver_dir, project):
 		sys.exit(1)
 
 	parse(work_arounds)
-	print "\nList of workarounds found in %s:" % project
+	print("\nList of workarounds found in %s:" % project)
 	for wa in sorted(workarounds.keys()):
 		if not options.platform:
 			print("%s: %s" % (wa, ', '.join(workarounds[wa])))
-- 
2.4.3

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH i-g-t] list-workarounds: Fix python 2 print statement

[Kibey, Sameer]

Oops, sorry for the error. Thanks for fixing it.
Sameer

> -----Original Message-----
> From: Lespiau, Damien
> Sent: Monday, February 08, 2016 4:08 AM
> To: intel-gfx@lists.freedesktop.org
> Cc: Kibey, Sameer; Dylan Baker
> Subject: [PATCH i-g-t] list-workarounds: Fix python 2 print statement
> 
> That script is a python 3 script, so we can't use the python 2 print statement,
> it's a function now.
> 
> I missed it in the review because reviewing a diff without additional context
> gives you a partial story.
> 
> Cc: Sameer Kibey <sameer.kibey@intel.com>
> Cc: Dylan Baker <baker.dylan.c@gmail.com>
> Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
> ---
>  scripts/list-workarounds | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/list-workarounds b/scripts/list-workarounds index
> 8b41ae5..70c026d 100755
> --- a/scripts/list-workarounds
> +++ b/scripts/list-workarounds
> @@ -96,7 +96,7 @@ def print_workarounds(project_root, driver_dir,
> project):
>  		sys.exit(1)
> 
>  	parse(work_arounds)
> -	print "\nList of workarounds found in %s:" % project
> +	print("\nList of workarounds found in %s:" % project)
>  	for wa in sorted(workarounds.keys()):
>  		if not options.platform:
>  			print("%s: %s" % (wa, ', '.join(workarounds[wa])))
> --
> 2.4.3

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH i-g-t] list-workarounds: Fix python 2 print statement

[Dylan Baker]

[-- Attachment #1.1: Type: text/plain, Size: 1230 bytes --]

Looks good to me.

Reviewed-by: Dylan Baker <dylanx.c.baker@intel.com>

Quoting Damien Lespiau (2016-02-08 04:08:29)
> That script is a python 3 script, so we can't use the python 2 print
> statement, it's a function now.
> 
> I missed it in the review because reviewing a diff without additional
> context gives you a partial story.
> 
> Cc: Sameer Kibey <sameer.kibey@intel.com>
> Cc: Dylan Baker <baker.dylan.c@gmail.com>
> Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
> ---
>  scripts/list-workarounds | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/list-workarounds b/scripts/list-workarounds
> index 8b41ae5..70c026d 100755
> --- a/scripts/list-workarounds
> +++ b/scripts/list-workarounds
> @@ -96,7 +96,7 @@ def print_workarounds(project_root, driver_dir, project):
>                 sys.exit(1)
>  
>         parse(work_arounds)
> -       print "\nList of workarounds found in %s:" % project
> +       print("\nList of workarounds found in %s:" % project)
>         for wa in sorted(workarounds.keys()):
>                 if not options.platform:
>                         print("%s: %s" % (wa, ', '.join(workarounds[wa])))
> -- 
> 2.4.3
> 

[-- Attachment #1.2: signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAABCAAGBQJWuNtwAAoJEAieFpYUBojvZXUH/RQBlI7qZSPeyS5YA3qq8fZ4
blxf1M8RjogxQ9kjUr2YILI16eGbz2/744MyXsHlNFNYS8LLudl9kUSC57KrPBGf
3plfpUmFGzjBCFn68R3B2vkl5LFnIxdYxUxRsSpIf+EhO/I8tKAHlENqKKkYWYMO
KLFNI0pdVoOcZf54kx+nFzouTXKLJibAVR0xVDupLP5VxhqcH2oUcEZmEBGzFLQW
F9h1uC1YCTodDlgaYgJCvV+l2UBx7/mfrH28MWAtbbV1DlLLMTkZJ7iaye/3ju0m
Bq2HhMNOOAIOISVMB1sF8wohIWMy0zDalL3od2uwzSt3TCYpRAGmmWttudHHNZA=
=qP2y
-----END PGP SIGNATURE-----

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx