* [PATCH v1] Bluetooth: Fix wrong opcode when LL privacy enabled
@ 2021-09-27 11:58 Howard Chung
2021-09-27 13:24 ` Marcel Holtmann
0 siblings, 1 reply; 2+ messages in thread
From: Howard Chung @ 2021-09-27 11:58 UTC (permalink / raw)
To: linux-bluetooth
Cc: Yun-Hao Chung, David S. Miller, Jakub Kicinski, Johan Hedberg,
Luiz Augusto von Dentz, Marcel Holtmann, linux-kernel, netdev
From: Yun-Hao Chung <howardchung@chromium.org>
The returned opcode of command status of remove_adv is
wrong when LL privacy is enabled.
Signed-off-by: Yun-Hao Chung <howardchung@chromium.org>
---
Test with following steps:
1. btmgmt --index 0
2. [btmgmt] power off; [btmgmt] exp-privacy on; [btmgmt] power on
3. [btmgmt] rm-adv 1
4. Check if the 'Not supported' message is present in terminal
net/bluetooth/mgmt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c
index cea01e275f1ea..87acf0d783a07 100644
--- a/net/bluetooth/mgmt.c
+++ b/net/bluetooth/mgmt.c
@@ -8222,7 +8222,7 @@ static int remove_advertising(struct sock *sk, struct hci_dev *hdev,
* advertising.
*/
if (hci_dev_test_flag(hdev, HCI_ENABLE_LL_PRIVACY))
- return mgmt_cmd_status(sk, hdev->id, MGMT_OP_SET_ADVERTISING,
+ return mgmt_cmd_status(sk, hdev->id, MGMT_OP_REMOVE_ADVERTISING,
MGMT_STATUS_NOT_SUPPORTED);
hci_dev_lock(hdev);
--
2.33.0.685.g46640cef36-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v1] Bluetooth: Fix wrong opcode when LL privacy enabled
2021-09-27 11:58 [PATCH v1] Bluetooth: Fix wrong opcode when LL privacy enabled Howard Chung
@ 2021-09-27 13:24 ` Marcel Holtmann
0 siblings, 0 replies; 2+ messages in thread
From: Marcel Holtmann @ 2021-09-27 13:24 UTC (permalink / raw)
To: Howard Chung
Cc: linux-bluetooth, Yun-Hao Chung, David S. Miller, Jakub Kicinski,
Johan Hedberg, Luiz Augusto von Dentz, open list, netdev
Hi Howard,
> The returned opcode of command status of remove_adv is
> wrong when LL privacy is enabled.
>
> Signed-off-by: Yun-Hao Chung <howardchung@chromium.org>
> ---
> Test with following steps:
> 1. btmgmt --index 0
> 2. [btmgmt] power off; [btmgmt] exp-privacy on; [btmgmt] power on
> 3. [btmgmt] rm-adv 1
> 4. Check if the 'Not supported' message is present in terminal
>
> net/bluetooth/mgmt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
patch has been applied to bluetooth-next tree.
Regards
Marcel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-09-27 13:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-27 11:58 [PATCH v1] Bluetooth: Fix wrong opcode when LL privacy enabled Howard Chung
2021-09-27 13:24 ` Marcel Holtmann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.