* [PATCH] utils.bbclass: Support applications with keys in check_app_exist function
@ 2017-10-05 7:46 Nikolay Merinov
2017-10-06 10:45 ` Burton, Ross
0 siblings, 1 reply; 3+ messages in thread
From: Nikolay Merinov @ 2017-10-05 7:46 UTC (permalink / raw)
To: openembedded-core
check_app_exist function must support cases when "app" variable defined
as "progname --keys". For example BUILD_CC="gcc -march=x86-64" must
pass sanity check.
Signed-off-by: Nikolay Merinov <n.merinov@inango-systems.com>
---
meta/classes/utils.bbclass | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/classes/utils.bbclass b/meta/classes/utils.bbclass
index 081e662da1..8e07eac07a 100644
--- a/meta/classes/utils.bbclass
+++ b/meta/classes/utils.bbclass
@@ -320,7 +320,7 @@ hardlinkdir () {
def check_app_exists(app, d):
- app = d.expand(app).strip()
+ app = d.expand(app).split()[0].strip()
path = d.getVar('PATH')
return bool(bb.utils.which(path, app))
--
2.14.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] utils.bbclass: Support applications with keys in check_app_exist function
2017-10-05 7:46 [PATCH] utils.bbclass: Support applications with keys in check_app_exist function Nikolay Merinov
@ 2017-10-06 10:45 ` Burton, Ross
2017-10-06 18:53 ` Nikolai Merinov
0 siblings, 1 reply; 3+ messages in thread
From: Burton, Ross @ 2017-10-06 10:45 UTC (permalink / raw)
To: Nikolay Merinov; +Cc: OE-core
[-- Attachment #1: Type: text/plain, Size: 325 bytes --]
On 5 October 2017 at 08:46, Nikolay Merinov <n.merinov@inango-systems.com>
wrote:
> check_app_exist function must support cases when "app" variable defined
> as "progname --keys". For example BUILD_CC="gcc -march=x86-64" must
> pass sanity check.
>
Whilst this is useful, -march should be in BUILD_CFLAGS.
Ross
[-- Attachment #2: Type: text/html, Size: 696 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] utils.bbclass: Support applications with keys in check_app_exist function
2017-10-06 10:45 ` Burton, Ross
@ 2017-10-06 18:53 ` Nikolai Merinov
0 siblings, 0 replies; 3+ messages in thread
From: Nikolai Merinov @ 2017-10-06 18:53 UTC (permalink / raw)
To: Burton, Ross; +Cc: OE-core
[-- Attachment #1: Type: text/plain, Size: 779 bytes --]
Currently BUILD_CC = "${CCACHE}${BUILD_PREFIX}gcc ${BUILD_CC_ARCH}"
BUILD_CC_ARCH looks like correct place for "-march" flag, but if we provide non-empty value for this variable sanity check can fail.
6 октября 2017 г. 15:45:16 GMT+05:00, "Burton, Ross" <ross.burton@intel.com> пишет:
>On 5 October 2017 at 08:46, Nikolay Merinov
><n.merinov@inango-systems.com>
>wrote:
>
>> check_app_exist function must support cases when "app" variable
>defined
>> as "progname --keys". For example BUILD_CC="gcc -march=x86-64" must
>> pass sanity check.
>>
>
>Whilst this is useful, -march should be in BUILD_CFLAGS.
>
>Ross
--
Nikolay Merinov
Team Leader, 3-rd Party Group
n.merinov@inango-systems.com
T +7 343 298 0147 C +7 912 229 2564
inango.com
[-- Attachment #2: Type: text/html, Size: 1467 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-10-06 18:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-05 7:46 [PATCH] utils.bbclass: Support applications with keys in check_app_exist function Nikolay Merinov
2017-10-06 10:45 ` Burton, Ross
2017-10-06 18:53 ` Nikolai Merinov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.