Re: [PATCH] drm/i915: fix the issue DP-1 not working in guest

Re: [PATCH] drm/i915: fix the issue DP-1 not working in guest

[Anuar, Nuhairi]

[-- Attachment #1.1: Type: text/plain, Size: 1613 bytes --]

For a virtualized boot, it is possible for port A to be tied to DP.

Min He any additional comment?

On Jun 14, 2017 9:38 PM, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
On Wed, Jun 14, 2017 at 01:47:30PM +0800, Mustamin B Mustaffa wrote:
> From: "Anuar, Nuhairi" <nuhairi.anuar@intel.com>
>
> In GVT guest, when port A is DP, i915 will force it as an EDP panel,
> which
> will cause DP-1 not working in GVT guest.
> This patch fixed this issue by check intel_vgpu_active() in
> intel_ddi_compute_config().
>
> Signed-off-by: Min He <min.he@intel.com>
> Signed-off-by: Nuhairi Anuar <nuhairi.anuar@intel.com>
> ---
>  drivers/gpu/drm/i915/intel_ddi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
> index 66b367d..1110cbc 100644
> --- a/drivers/gpu/drm/i915/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/intel_ddi.c
> @@ -2069,7 +2069,7 @@ static bool intel_ddi_compute_config(struct intel_encoder *encoder,
>
>        WARN(type == INTEL_OUTPUT_UNKNOWN, "compute_config() on unknown output!\n");
>
> -     if (port == PORT_A)
> +     if (port == PORT_A && !intel_vgpu_active(dev_priv))
>                pipe_config->cpu_transcoder = TRANSCODER_EDP;

And why exactly are you trying to register DP on port A?

>
>        if (type == INTEL_OUTPUT_HDMI)
> --
> 1.9.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

--
Ville Syrjälä
Intel OTC


[-- Attachment #1.2: Type: text/html, Size: 2795 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915: fix the issue DP-1 not working in guest

[Anuar, Nuhairi]

[-- Attachment #1.1: Type: text/plain, Size: 2448 bytes --]

To be clear, I believe right now, GVT-g architecture on upstream still only have one Virtualized DP monitor which will be on port B/D, but we have patches (not yet upstream) that have 3 virtualized DP monitors which will be attached to Port A/B/D. So we need to add this flexibility in the code so that it is not conflicted with eDP logic.



From: Anuar, Nuhairi
Sent: Wednesday, June 14, 2017 10:55 PM
To: Ville Syrjälä <ville.syrjala@linux.intel.com>; He, Min <min.he@intel.com>
Cc: intel-gfx@lists.freedesktop.org; Mustaffa, Mustamin B <mustamin.b.mustaffa@intel.com>
Subject: Re: [Intel-gfx] [PATCH] drm/i915: fix the issue DP-1 not working in guest

For a virtualized boot, it is possible for port A to be tied to DP.

Min He any additional comment?

On Jun 14, 2017 9:38 PM, Ville Syrjälä <ville.syrjala@linux.intel.com<mailto:ville.syrjala@linux.intel.com>> wrote:
On Wed, Jun 14, 2017 at 01:47:30PM +0800, Mustamin B Mustaffa wrote:
> From: "Anuar, Nuhairi" <nuhairi.anuar@intel.com<mailto:nuhairi.anuar@intel.com>>
>
> In GVT guest, when port A is DP, i915 will force it as an EDP panel,
> which
> will cause DP-1 not working in GVT guest.
> This patch fixed this issue by check intel_vgpu_active() in
> intel_ddi_compute_config().
>
> Signed-off-by: Min He <min.he@intel.com<mailto:min.he@intel.com>>
> Signed-off-by: Nuhairi Anuar <nuhairi.anuar@intel.com<mailto:nuhairi.anuar@intel.com>>
> ---
>  drivers/gpu/drm/i915/intel_ddi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
> index 66b367d..1110cbc 100644
> --- a/drivers/gpu/drm/i915/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/intel_ddi.c
> @@ -2069,7 +2069,7 @@ static bool intel_ddi_compute_config(struct intel_encoder *encoder,
>
>        WARN(type == INTEL_OUTPUT_UNKNOWN, "compute_config() on unknown output!\n");
>
> -     if (port == PORT_A)
> +     if (port == PORT_A && !intel_vgpu_active(dev_priv))
>                pipe_config->cpu_transcoder = TRANSCODER_EDP;

And why exactly are you trying to register DP on port A?

>
>        if (type == INTEL_OUTPUT_HDMI)
> --
> 1.9.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org<mailto:Intel-gfx@lists.freedesktop.org>
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

--
Ville Syrjälä
Intel OTC


[-- Attachment #1.2: Type: text/html, Size: 6397 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915: fix the issue DP-1 not working in guest

[Ville Syrjälä]

On Thu, Jun 15, 2017 at 03:53:18AM +0000, Anuar, Nuhairi wrote:
> To be clear, I believe right now, GVT-g architecture on upstream still only have one Virtualized DP monitor which will be on port B/D, but we have patches (not yet upstream) that have 3 virtualized DP monitors which will be attached to Port A/B/D. So we need to add this flexibility in the code so that it is not conflicted with eDP logic.

Please don't do that. Real hardware doesn't support non-eDP on port A,
so your virtualized thing shouldn't either. Why aren't you putting it on
port C instead?

> 
> 
> 
> From: Anuar, Nuhairi
> Sent: Wednesday, June 14, 2017 10:55 PM
> To: Ville Syrjälä <ville.syrjala@linux.intel.com>; He, Min <min.he@intel.com>
> Cc: intel-gfx@lists.freedesktop.org; Mustaffa, Mustamin B <mustamin.b.mustaffa@intel.com>
> Subject: Re: [Intel-gfx] [PATCH] drm/i915: fix the issue DP-1 not working in guest
> 
> For a virtualized boot, it is possible for port A to be tied to DP.
> 
> Min He any additional comment?
> 
> On Jun 14, 2017 9:38 PM, Ville Syrjälä <ville.syrjala@linux.intel.com<mailto:ville.syrjala@linux.intel.com>> wrote:
> On Wed, Jun 14, 2017 at 01:47:30PM +0800, Mustamin B Mustaffa wrote:
> > From: "Anuar, Nuhairi" <nuhairi.anuar@intel.com<mailto:nuhairi.anuar@intel.com>>
> >
> > In GVT guest, when port A is DP, i915 will force it as an EDP panel,
> > which
> > will cause DP-1 not working in GVT guest.
> > This patch fixed this issue by check intel_vgpu_active() in
> > intel_ddi_compute_config().
> >
> > Signed-off-by: Min He <min.he@intel.com<mailto:min.he@intel.com>>
> > Signed-off-by: Nuhairi Anuar <nuhairi.anuar@intel.com<mailto:nuhairi.anuar@intel.com>>
> > ---
> >  drivers/gpu/drm/i915/intel_ddi.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
> > index 66b367d..1110cbc 100644
> > --- a/drivers/gpu/drm/i915/intel_ddi.c
> > +++ b/drivers/gpu/drm/i915/intel_ddi.c
> > @@ -2069,7 +2069,7 @@ static bool intel_ddi_compute_config(struct intel_encoder *encoder,
> >
> >        WARN(type == INTEL_OUTPUT_UNKNOWN, "compute_config() on unknown output!\n");
> >
> > -     if (port == PORT_A)
> > +     if (port == PORT_A && !intel_vgpu_active(dev_priv))
> >                pipe_config->cpu_transcoder = TRANSCODER_EDP;
> 
> And why exactly are you trying to register DP on port A?
> 
> >
> >        if (type == INTEL_OUTPUT_HDMI)
> > --
> > 1.9.1
> >
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org<mailto:Intel-gfx@lists.freedesktop.org>
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> 
> --
> Ville Syrjälä
> Intel OTC
> 

-- 
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915: fix the issue DP-1 not working in guest

[Jani Nikula]

On Thu, 15 Jun 2017, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> On Thu, Jun 15, 2017 at 03:53:18AM +0000, Anuar, Nuhairi wrote:
>> To be clear, I believe right now, GVT-g architecture on upstream still only have one Virtualized DP monitor which will be on port B/D, but we have patches (not yet upstream) that have 3 virtualized DP monitors which will be attached to Port A/B/D. So we need to add this flexibility in the code so that it is not conflicted with eDP logic.
>
> Please don't do that. Real hardware doesn't support non-eDP on port A,
> so your virtualized thing shouldn't either. Why aren't you putting it on
> port C instead?

Agreed. Otherwise we may end up piling up more intel_vgpu_active()
checks all over the place.

BR,
Jani.


-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[PATCH] drm/i915: fix the issue DP-1 not working in guest

[Mustamin B Mustaffa]

From: "Anuar, Nuhairi" <nuhairi.anuar@intel.com>

In GVT guest, when port A is DP, i915 will force it as an EDP panel,
which
will cause DP-1 not working in GVT guest.
This patch fixed this issue by check intel_vgpu_active() in
intel_ddi_compute_config().

Signed-off-by: Min He <min.he@intel.com>
Signed-off-by: Nuhairi Anuar <nuhairi.anuar@intel.com>
---
 drivers/gpu/drm/i915/intel_ddi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
index 66b367d..1110cbc 100644
--- a/drivers/gpu/drm/i915/intel_ddi.c
+++ b/drivers/gpu/drm/i915/intel_ddi.c
@@ -2069,7 +2069,7 @@ static bool intel_ddi_compute_config(struct intel_encoder *encoder,
 
 	WARN(type == INTEL_OUTPUT_UNKNOWN, "compute_config() on unknown output!\n");
 
-	if (port == PORT_A)
+	if (port == PORT_A && !intel_vgpu_active(dev_priv))
 		pipe_config->cpu_transcoder = TRANSCODER_EDP;
 
 	if (type == INTEL_OUTPUT_HDMI)
-- 
1.9.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915: fix the issue DP-1 not working in guest

[Ville Syrjälä]

On Wed, Jun 14, 2017 at 01:47:30PM +0800, Mustamin B Mustaffa wrote:
> From: "Anuar, Nuhairi" <nuhairi.anuar@intel.com>
> 
> In GVT guest, when port A is DP, i915 will force it as an EDP panel,
> which
> will cause DP-1 not working in GVT guest.
> This patch fixed this issue by check intel_vgpu_active() in
> intel_ddi_compute_config().
> 
> Signed-off-by: Min He <min.he@intel.com>
> Signed-off-by: Nuhairi Anuar <nuhairi.anuar@intel.com>
> ---
>  drivers/gpu/drm/i915/intel_ddi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
> index 66b367d..1110cbc 100644
> --- a/drivers/gpu/drm/i915/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/intel_ddi.c
> @@ -2069,7 +2069,7 @@ static bool intel_ddi_compute_config(struct intel_encoder *encoder,
>  
>  	WARN(type == INTEL_OUTPUT_UNKNOWN, "compute_config() on unknown output!\n");
>  
> -	if (port == PORT_A)
> +	if (port == PORT_A && !intel_vgpu_active(dev_priv))
>  		pipe_config->cpu_transcoder = TRANSCODER_EDP;

And why exactly are you trying to register DP on port A?

>  
>  	if (type == INTEL_OUTPUT_HDMI)
> -- 
> 1.9.1
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[PATCH] drm/i915: fix the issue DP-1 not working in guest

[Mustamin B Mustaffa]

In GVT guest, when port A is DP, i915 will force it as an EDP panel,
which
will cause DP-1 not working in GVT guest.
This patch fixed this issue by check intel_vgpu_active() in
intel_ddi_compute_config().

Signed-off-by: Min He <min.he@intel.com>
Signed-off-by: Nuhairi Anuar <nuhairi.anuar@intel.com>
Signed-off-by: Mustamin B Mustaffa <mustamin.b.mustaffa@intel.com>
---
 drivers/gpu/drm/i915/intel_ddi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
index db92a26..9f5e85c 100644
--- a/drivers/gpu/drm/i915/intel_ddi.c
+++ b/drivers/gpu/drm/i915/intel_ddi.c
@@ -2720,7 +2720,7 @@ static bool intel_ddi_compute_config(struct intel_encoder *encoder,
 	enum port port = encoder->port;
 	int ret;
 
-	if (port == PORT_A)
+	if (port == PORT_A && !intel_vgpu_active(dev_priv))
 		pipe_config->cpu_transcoder = TRANSCODER_EDP;
 
 	if (intel_crtc_has_type(pipe_config, INTEL_OUTPUT_HDMI))
-- 
1.9.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915: fix the issue DP-1 not working in guest

[Jani Nikula]

On Tue, 20 Feb 2018, Mustamin B Mustaffa <mustamin.b.mustaffa@intel.com> wrote:
> In GVT guest, when port A is DP, i915 will force it as an EDP panel,
> which
> will cause DP-1 not working in GVT guest.
> This patch fixed this issue by check intel_vgpu_active() in
> intel_ddi_compute_config().

Just repeating Ville's question from last June that went unanswered [1],
"And why exactly are you trying to register DP on port A?"

BR,
Jani.

[1] http://mid.mail-archive.com/20170614133842.GM12629@intel.com

>
> Signed-off-by: Min He <min.he@intel.com>
> Signed-off-by: Nuhairi Anuar <nuhairi.anuar@intel.com>
> Signed-off-by: Mustamin B Mustaffa <mustamin.b.mustaffa@intel.com>
> ---
>  drivers/gpu/drm/i915/intel_ddi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
> index db92a26..9f5e85c 100644
> --- a/drivers/gpu/drm/i915/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/intel_ddi.c
> @@ -2720,7 +2720,7 @@ static bool intel_ddi_compute_config(struct intel_encoder *encoder,
>  	enum port port = encoder->port;
>  	int ret;
>  
> -	if (port == PORT_A)
> +	if (port == PORT_A && !intel_vgpu_active(dev_priv))
>  		pipe_config->cpu_transcoder = TRANSCODER_EDP;
>  
>  	if (intel_crtc_has_type(pipe_config, INTEL_OUTPUT_HDMI))

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915: fix the issue DP-1 not working in guest

[Mustaffa, Mustamin B]

Hi Jani, 

In GVT (virtualization) environment, it only can use DP.  Therefore, we want to enable Port A as DP so that display panel on Port A can be used by GVT. 

Best regard 

Mustamin


-----Original Message-----
From: Jani Nikula [mailto:jani.nikula@linux.intel.com] 
Sent: Tuesday, February 20, 2018 7:35 PM
To: Mustaffa, Mustamin B <mustamin.b.mustaffa@intel.com>; intel-gfx@lists.freedesktop.org
Cc: Mustaffa, Mustamin B <mustamin.b.mustaffa@intel.com>; Anuar, Nuhairi <nuhairi.anuar@intel.com>
Subject: Re: [Intel-gfx] [PATCH] drm/i915: fix the issue DP-1 not working in guest

On Tue, 20 Feb 2018, Mustamin B Mustaffa <mustamin.b.mustaffa@intel.com> wrote:
> In GVT guest, when port A is DP, i915 will force it as an EDP panel, 
> which will cause DP-1 not working in GVT guest.
> This patch fixed this issue by check intel_vgpu_active() in 
> intel_ddi_compute_config().

Just repeating Ville's question from last June that went unanswered [1], "And why exactly are you trying to register DP on port A?"

BR,
Jani.

[1] http://mid.mail-archive.com/20170614133842.GM12629@intel.com

>
> Signed-off-by: Min He <min.he@intel.com>
> Signed-off-by: Nuhairi Anuar <nuhairi.anuar@intel.com>
> Signed-off-by: Mustamin B Mustaffa <mustamin.b.mustaffa@intel.com>
> ---
>  drivers/gpu/drm/i915/intel_ddi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_ddi.c 
> b/drivers/gpu/drm/i915/intel_ddi.c
> index db92a26..9f5e85c 100644
> --- a/drivers/gpu/drm/i915/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/intel_ddi.c
> @@ -2720,7 +2720,7 @@ static bool intel_ddi_compute_config(struct intel_encoder *encoder,
>  	enum port port = encoder->port;
>  	int ret;
>  
> -	if (port == PORT_A)
> +	if (port == PORT_A && !intel_vgpu_active(dev_priv))
>  		pipe_config->cpu_transcoder = TRANSCODER_EDP;
>  
>  	if (intel_crtc_has_type(pipe_config, INTEL_OUTPUT_HDMI))

--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915: fix the issue DP-1 not working in guest

[Jani Nikula]

On Wed, 21 Feb 2018, "Mustaffa, Mustamin B" <mustamin.b.mustaffa@intel.com> wrote:
> Hi Jani, 
>
> In GVT (virtualization) environment, it only can use DP.  Therefore,
> we want to enable Port A as DP so that display panel on Port A can be
> used by GVT.

Why not just disable port A in the guest VBT?

Or are you saying that host eDP can't be used by guest unless we fake
the same port as DP? Or what are you trying to say?


BR,
Jani.


>
> Best regard 
>
> Mustamin
>
>
> -----Original Message-----
> From: Jani Nikula [mailto:jani.nikula@linux.intel.com] 
> Sent: Tuesday, February 20, 2018 7:35 PM
> To: Mustaffa, Mustamin B <mustamin.b.mustaffa@intel.com>; intel-gfx@lists.freedesktop.org
> Cc: Mustaffa, Mustamin B <mustamin.b.mustaffa@intel.com>; Anuar, Nuhairi <nuhairi.anuar@intel.com>
> Subject: Re: [Intel-gfx] [PATCH] drm/i915: fix the issue DP-1 not working in guest
>
> On Tue, 20 Feb 2018, Mustamin B Mustaffa <mustamin.b.mustaffa@intel.com> wrote:
>> In GVT guest, when port A is DP, i915 will force it as an EDP panel, 
>> which will cause DP-1 not working in GVT guest.
>> This patch fixed this issue by check intel_vgpu_active() in 
>> intel_ddi_compute_config().
>
> Just repeating Ville's question from last June that went unanswered [1], "And why exactly are you trying to register DP on port A?"
>
> BR,
> Jani.
>
> [1] http://mid.mail-archive.com/20170614133842.GM12629@intel.com
>
>>
>> Signed-off-by: Min He <min.he@intel.com>
>> Signed-off-by: Nuhairi Anuar <nuhairi.anuar@intel.com>
>> Signed-off-by: Mustamin B Mustaffa <mustamin.b.mustaffa@intel.com>
>> ---
>>  drivers/gpu/drm/i915/intel_ddi.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/intel_ddi.c 
>> b/drivers/gpu/drm/i915/intel_ddi.c
>> index db92a26..9f5e85c 100644
>> --- a/drivers/gpu/drm/i915/intel_ddi.c
>> +++ b/drivers/gpu/drm/i915/intel_ddi.c
>> @@ -2720,7 +2720,7 @@ static bool intel_ddi_compute_config(struct intel_encoder *encoder,
>>  	enum port port = encoder->port;
>>  	int ret;
>>  
>> -	if (port == PORT_A)
>> +	if (port == PORT_A && !intel_vgpu_active(dev_priv))
>>  		pipe_config->cpu_transcoder = TRANSCODER_EDP;
>>  
>>  	if (intel_crtc_has_type(pipe_config, INTEL_OUTPUT_HDMI))
>
> --
> Jani Nikula, Intel Open Source Technology Center

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915: fix the issue DP-1 not working in guest

[Mustaffa, Mustamin B]

Hi Jani, 

We cannot disable any port as we might use all the ports for display. 
And yes, we fake the DP to use EDP panel. 

Hi Nuhairi, please correct me if I'm wrong. 

Best regard 

Mustamin


-----Original Message-----
From: Jani Nikula [mailto:jani.nikula@linux.intel.com] 
Sent: Wednesday, February 21, 2018 4:03 PM
To: Mustaffa, Mustamin B <mustamin.b.mustaffa@intel.com>; intel-gfx@lists.freedesktop.org
Cc: Anuar, Nuhairi <nuhairi.anuar@intel.com>; Ville Syrjälä <ville.syrjala@linux.intel.com>
Subject: RE: [Intel-gfx] [PATCH] drm/i915: fix the issue DP-1 not working in guest

On Wed, 21 Feb 2018, "Mustaffa, Mustamin B" <mustamin.b.mustaffa@intel.com> wrote:
> Hi Jani,
>
> In GVT (virtualization) environment, it only can use DP.  Therefore, 
> we want to enable Port A as DP so that display panel on Port A can be 
> used by GVT.

Why not just disable port A in the guest VBT?

Or are you saying that host eDP can't be used by guest unless we fake the same port as DP? Or what are you trying to say?


BR,
Jani.


>
> Best regard
>
> Mustamin
>
>
> -----Original Message-----
> From: Jani Nikula [mailto:jani.nikula@linux.intel.com]
> Sent: Tuesday, February 20, 2018 7:35 PM
> To: Mustaffa, Mustamin B <mustamin.b.mustaffa@intel.com>; 
> intel-gfx@lists.freedesktop.org
> Cc: Mustaffa, Mustamin B <mustamin.b.mustaffa@intel.com>; Anuar, 
> Nuhairi <nuhairi.anuar@intel.com>
> Subject: Re: [Intel-gfx] [PATCH] drm/i915: fix the issue DP-1 not 
> working in guest
>
> On Tue, 20 Feb 2018, Mustamin B Mustaffa <mustamin.b.mustaffa@intel.com> wrote:
>> In GVT guest, when port A is DP, i915 will force it as an EDP panel, 
>> which will cause DP-1 not working in GVT guest.
>> This patch fixed this issue by check intel_vgpu_active() in 
>> intel_ddi_compute_config().
>
> Just repeating Ville's question from last June that went unanswered [1], "And why exactly are you trying to register DP on port A?"
>
> BR,
> Jani.
>
> [1] http://mid.mail-archive.com/20170614133842.GM12629@intel.com
>
>>
>> Signed-off-by: Min He <min.he@intel.com>
>> Signed-off-by: Nuhairi Anuar <nuhairi.anuar@intel.com>
>> Signed-off-by: Mustamin B Mustaffa <mustamin.b.mustaffa@intel.com>
>> ---
>>  drivers/gpu/drm/i915/intel_ddi.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/intel_ddi.c
>> b/drivers/gpu/drm/i915/intel_ddi.c
>> index db92a26..9f5e85c 100644
>> --- a/drivers/gpu/drm/i915/intel_ddi.c
>> +++ b/drivers/gpu/drm/i915/intel_ddi.c
>> @@ -2720,7 +2720,7 @@ static bool intel_ddi_compute_config(struct intel_encoder *encoder,
>>  	enum port port = encoder->port;
>>  	int ret;
>>  
>> -	if (port == PORT_A)
>> +	if (port == PORT_A && !intel_vgpu_active(dev_priv))
>>  		pipe_config->cpu_transcoder = TRANSCODER_EDP;
>>  
>>  	if (intel_crtc_has_type(pipe_config, INTEL_OUTPUT_HDMI))
>
> --
> Jani Nikula, Intel Open Source Technology Center

--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx