Thoughts on representing the LED groups in Redfish ?

Thoughts on representing the LED groups in Redfish ?

[Vishwanatha Subbanna]

[-- Attachment #1: Type: text/html, Size: 2374 bytes --]

Re: Thoughts on representing the LED groups in Redfish ?

[Vishwanatha Subbanna]

[-- Attachment #1: Type: text/html, Size: 1631 bytes --]

Re: Thoughts on representing the LED groups in Redfish ?

[Patrick Williams]

[-- Attachment #1: Type: text/plain, Size: 2031 bytes --]

On Thu, Feb 20, 2020 at 02:28:59PM +0530, Vishwanatha Subbanna wrote:
> Hello,
> 
> Wonder if the community has any thoughts ?
> 
> Thanks,
> !! Vishwa !!
> 
> 
>     On 14-Feb-2020, at 4:51 PM, Vishwanatha Subbanna
>     <vishwa@linux.vnet.ibm.com> wrote:
> 
>     Hello,
> 
>     Writing this to get your thoughts on representing LED logical groups in
>     Redfish.
> 
>     OpenBmc LED subsystem has 2 layers
> 
>     1/. Logical LED group manager
>     2/. Physical LED controller that sets ONE particular LED to On/Off/Blink
> 
>     Logical LED group manager:
> 
>     This is where we define a group with set of physical LEDs and their
>     respective actions for one use case.
> 
>     For example: https://github.com/openbmc/phosphor-led-manager/blob/master/
>     led.yaml
> 
>     When the user wants to turn on the Identify indicators, they don’t target
>     the physical LEDs individually. Instead, they just set the “Asserted”
>     property :  “xyz/openbmc_project/led/groups/enclosure_identify/attr/
>     Asserted"
> 
>     LED manager will then request physical led controllers of those LEDs to
>     take the right action
> 
>     Current bmcweb actually uses the groups than targeting the physical LEDs.
>     So it’s good. https://github.com/openbmc/bmcweb/blob/
>     1c8fba97b1feb4164e9b54cd66aad530bbfc1826/redfish-core/lib/led.hpp#L33
> 
>     However, I am not sure if there are ways to express the LED logical groups
>     in the redfish schema.
> 
>     Any ideas ?
> 
>     Thank you,
>     !! Vishwa !!

It seems like if BMCWeb is using the logical groups already, this is
good because this is likely what the administrator is most interested in
anyhow.  From what you've written here, I'm not sure what the new
feature is you'd be proposing.  How might logical vs physical LEDs be
presented in a management interface like Redfish and what advantage does
it provide to a user (over what we're doing today)?

-- 
Patrick Williams

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]