* [RFC][PATCH 0/2]efi_pstore: Avoid missing panic message in NVRAM
@ 2012-07-03 23:33 Seiji Aguchi
2012-07-05 13:20 ` Don Zickus
0 siblings, 1 reply; 2+ messages in thread
From: Seiji Aguchi @ 2012-07-03 23:33 UTC (permalink / raw)
To: linux-kernel, Luck, Tony (tony.luck@intel.com),
mikew, Matthew Garrett (mjg@redhat.com),
dzickus
Cc: dle-develop, Satoru Moriya
[Problem]
Current efi_pstore simply overwrites existing entries in NVRAM.
So, if 2nd panic happens before a user checks 1st panic message, 1st panic message will be lost.
[Solution]
To avoid missing 1st panic message, this patch introduce a rule checking if existing entries in NRAM are erasable to efi_pstore.
[Patch Descriptions]
[PATCH 1/2] Duplicate a shared code between write and erase callbacks
Currently, efi_pstore driver shares a code erasing existing entries in NVRAM with write and erase callbacks.
But there some cases we should avoid erasing existing entries in write callback. (Please see PATCH 2/2).
This patch duplicates the code so that write and erase callbacks work independently.
[PATCH 2/2] write callback: Check if existing entry is erasable
this patch introduce a rule checking if existing entries in NRAM are erasable to efi_pstore.
With this patch, if previous event is panic, efi_pstore never overwrite it.
drivers/firmware/efivars.c | 94 +++++++++++++++++++++++++++++++++++++++++++-
fs/pstore/platform.c | 4 +-
include/linux/pstore.h | 5 ++
3 files changed, 99 insertions(+), 4 deletions(-)
Seiji
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [RFC][PATCH 0/2]efi_pstore: Avoid missing panic message in NVRAM
2012-07-03 23:33 [RFC][PATCH 0/2]efi_pstore: Avoid missing panic message in NVRAM Seiji Aguchi
@ 2012-07-05 13:20 ` Don Zickus
0 siblings, 0 replies; 2+ messages in thread
From: Don Zickus @ 2012-07-05 13:20 UTC (permalink / raw)
To: Seiji Aguchi
Cc: linux-kernel, Luck, Tony (tony.luck@intel.com),
mikew, Matthew Garrett (mjg@redhat.com),
dle-develop, Satoru Moriya
On Tue, Jul 03, 2012 at 11:33:57PM +0000, Seiji Aguchi wrote:
> [Problem]
> Current efi_pstore simply overwrites existing entries in NVRAM.
> So, if 2nd panic happens before a user checks 1st panic message, 1st panic message will be lost.
I thought the rule was entries do not get overwritten until they are
deleted first. Perhaps that is just an APEI thing, but it seems like that
should be a good rule for EFI too.
Mainly because there is very little userspace apps that actually clear the
old error records. So this could become a common problem.
Unless we are implementing a flight recorder option which explicitly
states overwrite older entries?
Cheers,
Don
>
> [Solution]
> To avoid missing 1st panic message, this patch introduce a rule checking if existing entries in NRAM are erasable to efi_pstore.
>
> [Patch Descriptions]
>
> [PATCH 1/2] Duplicate a shared code between write and erase callbacks
>
> Currently, efi_pstore driver shares a code erasing existing entries in NVRAM with write and erase callbacks.
> But there some cases we should avoid erasing existing entries in write callback. (Please see PATCH 2/2).
> This patch duplicates the code so that write and erase callbacks work independently.
>
>
> [PATCH 2/2] write callback: Check if existing entry is erasable
>
> this patch introduce a rule checking if existing entries in NRAM are erasable to efi_pstore.
> With this patch, if previous event is panic, efi_pstore never overwrite it.
>
>
> drivers/firmware/efivars.c | 94 +++++++++++++++++++++++++++++++++++++++++++-
> fs/pstore/platform.c | 4 +-
> include/linux/pstore.h | 5 ++
> 3 files changed, 99 insertions(+), 4 deletions(-)
>
> Seiji
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-07-05 13:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-07-03 23:33 [RFC][PATCH 0/2]efi_pstore: Avoid missing panic message in NVRAM Seiji Aguchi
2012-07-05 13:20 ` Don Zickus
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.