All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/1] Improve bb-matrix graphs
@ 2013-09-10 12:20 Peter Kjellerstedt
  2013-09-10 12:20 ` [PATCH 1/1] bb-matrix-plot: Use interpolation for sparse data Peter Kjellerstedt
  0 siblings, 1 reply; 5+ messages in thread
From: Peter Kjellerstedt @ 2013-09-10 12:20 UTC (permalink / raw)
  To: openembedded-core

This improves the look of bb-matrix graphs with sparse data, i.e.,
where not all combinations of BB_NUMBER_THREADS and PARALLEL_MAKE have
been tested.

This adds an implicit dependency on gnuplot v4.4 or later, but since
this only is a script in the contrib section I hope that is
acceptable.

//Peter

The following changes since commit 0ca5d1fb38157564a2b9452ade32391d18a41b09:

  yocto-bsp: remove apm as a default MACHINE_FEATURE (2013-09-09 16:28:47 +0100)

are available in the git repository at:

  git://git.yoctoproject.org/poky-contrib pkj/bb-matrix-plot
  http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=pkj/bb-matrix-plot

Peter Kjellerstedt (1):
  bb-matrix-plot: Use interpolation for sparse data

 scripts/contrib/bb-perf/bb-matrix-plot.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
1.8.2.1



^ permalink raw reply	[flat|nested] 5+ messages in thread
* [PATCH 1/1] bb-matrix-plot: Use interpolation for sparse data
  2013-09-10 12:20 [PATCH 0/1] Improve bb-matrix graphs Peter Kjellerstedt
@ 2013-09-10 12:20 ` Peter Kjellerstedt
  2013-09-10 15:37   ` Darren Hart
  0 siblings, 1 reply; 5+ messages in thread
From: Peter Kjellerstedt @ 2013-09-10 12:20 UTC (permalink / raw)
  To: openembedded-core

If not every combination of BB_NUMBER_THREADS and PARALLEL_MAKE have
been tested by bb-matrix.sh, e.g., by using BB_RANGE="04 08 10 12 16"
and PM_RANGE="04 08 10 12 16", then the graph that gnuplot generates by
default looks very jagged due to the missing data points. By using
splines to interpolate the missing data the graph looks a lot better.

This should not change graphs where all data points are available in any
way, only improve sparse graphs.

Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
---
 scripts/contrib/bb-perf/bb-matrix-plot.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/contrib/bb-perf/bb-matrix-plot.sh b/scripts/contrib/bb-perf/bb-matrix-plot.sh
index 87e8cb1..136a255 100755
--- a/scripts/contrib/bb-perf/bb-matrix-plot.sh
+++ b/scripts/contrib/bb-perf/bb-matrix-plot.sh
@@ -115,7 +115,7 @@ set xlabel "$XLABEL"
 set ylabel "$YLABEL"
 set style line 100 lt 5 lw 1.5
 $PM3D_FRAGMENT
-set dgrid3d $PM_CNT,$BB_CNT
+set dgrid3d $PM_CNT,$BB_CNT splines
 set ticslevel 0.2
 
 set term png size $SIZE
-- 
1.8.2.1



^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] bb-matrix-plot: Use interpolation for sparse data
  2013-09-10 12:20 ` [PATCH 1/1] bb-matrix-plot: Use interpolation for sparse data Peter Kjellerstedt
@ 2013-09-10 15:37   ` Darren Hart
  2013-09-11 12:30     ` Peter Kjellerstedt
  0 siblings, 1 reply; 5+ messages in thread
From: Darren Hart @ 2013-09-10 15:37 UTC (permalink / raw)
  To: Peter Kjellerstedt; +Cc: openembedded-core

On Tue, 2013-09-10 at 14:20 +0200, Peter Kjellerstedt wrote:
> If not every combination of BB_NUMBER_THREADS and PARALLEL_MAKE have
> been tested by bb-matrix.sh, e.g., by using BB_RANGE="04 08 10 12 16"
> and PM_RANGE="04 08 10 12 16", then the graph that gnuplot generates by
> default looks very jagged due to the missing data points. By using
> splines to interpolate the missing data the graph looks a lot better.
> 
> This should not change graphs where all data points are available in any
> way, only improve sparse graphs.
> 
> Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
> ---
>  scripts/contrib/bb-perf/bb-matrix-plot.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/contrib/bb-perf/bb-matrix-plot.sh b/scripts/contrib/bb-perf/bb-matrix-plot.sh
> index 87e8cb1..136a255 100755
> --- a/scripts/contrib/bb-perf/bb-matrix-plot.sh
> +++ b/scripts/contrib/bb-perf/bb-matrix-plot.sh
> @@ -115,7 +115,7 @@ set xlabel "$XLABEL"
>  set ylabel "$YLABEL"
>  set style line 100 lt 5 lw 1.5
>  $PM3D_FRAGMENT
> -set dgrid3d $PM_CNT,$BB_CNT
> +set dgrid3d $PM_CNT,$BB_CNT splines


Saweet! I just couldn't figure that one out for some reason. Thank you,
thank you, thank you!

Please note the gnuplot 4.4 dependency in the patch commit message
though. Also, what happens if an older gnuplot is used? Does it fail or
revert to the old behavior? If it fails, can we check for 4.4 and use
splines if available?

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel




^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] bb-matrix-plot: Use interpolation for sparse data
  2013-09-10 15:37   ` Darren Hart
@ 2013-09-11 12:30     ` Peter Kjellerstedt
  2013-09-11 16:19       ` Darren Hart
  0 siblings, 1 reply; 5+ messages in thread
From: Peter Kjellerstedt @ 2013-09-11 12:30 UTC (permalink / raw)
  To: Darren Hart; +Cc: openembedded-core

> -----Original Message-----
> From: Darren Hart [mailto:dvhart@linux.intel.com]
> Sent: den 10 september 2013 17:38
> To: Peter Kjellerstedt
> Cc: openembedded-core@lists.openembedded.org
> Subject: Re: [OE-core] [PATCH 1/1] bb-matrix-plot: Use interpolation
> for sparse data
> 
> On Tue, 2013-09-10 at 14:20 +0200, Peter Kjellerstedt wrote:
> > If not every combination of BB_NUMBER_THREADS and PARALLEL_MAKE have
> > been tested by bb-matrix.sh, e.g., by using BB_RANGE="04 08 10 12 16"
> > and PM_RANGE="04 08 10 12 16", then the graph that gnuplot generates by
> > default looks very jagged due to the missing data points. By using
> > splines to interpolate the missing data the graph looks a lot better.
> >
> > This should not change graphs where all data points are available in any
> > way, only improve sparse graphs.
> >
> > Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
> > ---
> >  scripts/contrib/bb-perf/bb-matrix-plot.sh | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/scripts/contrib/bb-perf/bb-matrix-plot.sh b/scripts/contrib/bb-perf/bb-matrix-plot.sh
> > index 87e8cb1..136a255 100755
> > --- a/scripts/contrib/bb-perf/bb-matrix-plot.sh
> > +++ b/scripts/contrib/bb-perf/bb-matrix-plot.sh
> > @@ -115,7 +115,7 @@ set xlabel "$XLABEL"
> >  set ylabel "$YLABEL"
> >  set style line 100 lt 5 lw 1.5
> >  $PM3D_FRAGMENT
> > -set dgrid3d $PM_CNT,$BB_CNT
> > +set dgrid3d $PM_CNT,$BB_CNT splines
> 
> 
> Saweet! I just couldn't figure that one out for some reason. Thank you,
> thank you, thank you!
> 
> Please note the gnuplot 4.4 dependency in the patch commit message
> though. Also, what happens if an older gnuplot is used? Does it fail or
> revert to the old behavior? If it fails, can we check for 4.4 and use
> splines if available?

I actually tried it now using gnuplot 4.2.2, and the script 
already uses a couple of features that require gnuplot 4.4.
The script can be fixed to support gnuplot 4.2 (by adding a 
test for the gnuplot version and then modifying the input to 
gnuplot accordingly), but since nobody has complained so far, 
I would suggest just leaving it as is...

> --
> Darren Hart
> Intel Open Source Technology Center
> Yocto Project - Linux Kernel

//Peter


^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] bb-matrix-plot: Use interpolation for sparse data
  2013-09-11 12:30     ` Peter Kjellerstedt
@ 2013-09-11 16:19       ` Darren Hart
  0 siblings, 0 replies; 5+ messages in thread
From: Darren Hart @ 2013-09-11 16:19 UTC (permalink / raw)
  To: Peter Kjellerstedt; +Cc: openembedded-core

On Wed, 2013-09-11 at 14:30 +0200, Peter Kjellerstedt wrote:
> > -----Original Message-----
> > From: Darren Hart [mailto:dvhart@linux.intel.com]
> > Sent: den 10 september 2013 17:38
> > To: Peter Kjellerstedt
> > Cc: openembedded-core@lists.openembedded.org
> > Subject: Re: [OE-core] [PATCH 1/1] bb-matrix-plot: Use interpolation
> > for sparse data
> > 
> > On Tue, 2013-09-10 at 14:20 +0200, Peter Kjellerstedt wrote:
> > > If not every combination of BB_NUMBER_THREADS and PARALLEL_MAKE have
> > > been tested by bb-matrix.sh, e.g., by using BB_RANGE="04 08 10 12 16"
> > > and PM_RANGE="04 08 10 12 16", then the graph that gnuplot generates by
> > > default looks very jagged due to the missing data points. By using
> > > splines to interpolate the missing data the graph looks a lot better.
> > >
> > > This should not change graphs where all data points are available in any
> > > way, only improve sparse graphs.
> > >
> > > Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
> > > ---
> > >  scripts/contrib/bb-perf/bb-matrix-plot.sh | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/scripts/contrib/bb-perf/bb-matrix-plot.sh b/scripts/contrib/bb-perf/bb-matrix-plot.sh
> > > index 87e8cb1..136a255 100755
> > > --- a/scripts/contrib/bb-perf/bb-matrix-plot.sh
> > > +++ b/scripts/contrib/bb-perf/bb-matrix-plot.sh
> > > @@ -115,7 +115,7 @@ set xlabel "$XLABEL"
> > >  set ylabel "$YLABEL"
> > >  set style line 100 lt 5 lw 1.5
> > >  $PM3D_FRAGMENT
> > > -set dgrid3d $PM_CNT,$BB_CNT
> > > +set dgrid3d $PM_CNT,$BB_CNT splines
> > 
> > 
> > Saweet! I just couldn't figure that one out for some reason. Thank you,
> > thank you, thank you!
> > 
> > Please note the gnuplot 4.4 dependency in the patch commit message
> > though. Also, what happens if an older gnuplot is used? Does it fail or
> > revert to the old behavior? If it fails, can we check for 4.4 and use
> > splines if available?
> 
> I actually tried it now using gnuplot 4.2.2, and the script 
> already uses a couple of features that require gnuplot 4.4.
> The script can be fixed to support gnuplot 4.2 (by adding a 
> test for the gnuplot version and then modifying the input to 
> gnuplot accordingly), but since nobody has complained so far, 
> I would suggest just leaving it as is...

Agreed. Thank you Peter.

Acked-by: Darren Hart <dvhart@linux.intel.com>


-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel




^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-09-11 16:19 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-09-10 12:20 [PATCH 0/1] Improve bb-matrix graphs Peter Kjellerstedt
2013-09-10 12:20 ` [PATCH 1/1] bb-matrix-plot: Use interpolation for sparse data Peter Kjellerstedt
2013-09-10 15:37   ` Darren Hart
2013-09-11 12:30     ` Peter Kjellerstedt
2013-09-11 16:19       ` Darren Hart

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.