* [PATCH] V4L: adding digital video timings APIs
@ 2009-10-21 22:42 m-karicheri2
2009-10-21 23:04 ` Hans Verkuil
0 siblings, 1 reply; 13+ messages in thread
From: m-karicheri2 @ 2009-10-21 22:42 UTC (permalink / raw)
To: linux-media, hverkuil; +Cc: davinci-linux-open-source, Muralidharan Karicheri
From: Muralidharan Karicheri <m-karicheri2@ti.com>
This is the initial version of the digital video timings APIs implementation.
This adds the above APIs to the v4l2 core. This is based on version v1.2
of the RFC titled "V4L - Support for video timings at the input/output interface"
Following new ioctls are added:-
- VIDIOC_ENUM_DV_PRESETS
- VIDIOC_S_DV_PRESET
- VIDIOC_G_DV_PRESET
- VIDIOC_QUERY_DV_PRESET
- VIDIOC_S_DV_TIMINGS
- VIDIOC_G_DV_TIMINGS
Please refer to the RFC for the details. This code was tested using vpfe
capture driver on TI's DM365. Following is the test configuration used :-
Blue Ray HD DVD source -> TVP7002 -> DM365 (VPFE) ->DDR
A draft version of the TVP7002 driver (currently being reviewed in the mailing
list) was used that supports V4L2_DV_1080I60 & V4L2_DV_720P60 presets.
A loopback video capture application was used for testing these APIs. This calls
following IOCTLS :-
- verify the new v4l2_input capabilities flag added
- Enumerate available presets using VIDIOC_ENUM_DV_PRESETS
- Set one of the supported preset using VIDIOC_S_DV_PRESET
- Get current preset using VIDIOC_G_DV_PRESET
- Detect current preset using VIDIOC_QUERY_DV_PRESET
- Using stub functions in tvp7002, verify VIDIOC_S_DV_TIMINGS
and VIDIOC_G_DV_TIMINGS ioctls are received at the sub device.
TODOs :
- Test it on a 64bit platform - I need help here since I don't have the platform.
- Add documentation (Can someone tell me which file to modify in the kernel tree?).
Please review this and let me know your comments.
Mandatory reviewer - Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Muralidharan Karicheri <m-karicheri2@ti.com>
---
Applies to V4L-DVB linux-next branch
drivers/media/video/v4l2-compat-ioctl32.c | 7 ++
drivers/media/video/v4l2-ioctl.c | 122 ++++++++++++++++++++++++++
include/linux/videodev2.h | 136 ++++++++++++++++++++++++++++-
include/media/v4l2-ioctl.h | 15 +++
include/media/v4l2-subdev.h | 21 +++++
5 files changed, 299 insertions(+), 2 deletions(-)
diff --git a/drivers/media/video/v4l2-compat-ioctl32.c b/drivers/media/video/v4l2-compat-ioctl32.c
index 997975d..9277448 100644
--- a/drivers/media/video/v4l2-compat-ioctl32.c
+++ b/drivers/media/video/v4l2-compat-ioctl32.c
@@ -1077,6 +1077,13 @@ long v4l2_compat_ioctl32(struct file *file, unsigned int cmd, unsigned long arg)
case VIDIOC_DBG_G_REGISTER:
case VIDIOC_DBG_G_CHIP_IDENT:
case VIDIOC_S_HW_FREQ_SEEK:
+ case VIDIOC_ENUM_DV_PRESETS:
+ case VIDIOC_S_DV_PRESET:
+ case VIDIOC_G_DV_PRESET:
+ case VIDIOC_QUERY_DV_PRESET:
+ case VIDIOC_S_DV_TIMINGS:
+ case VIDIOC_G_DV_TIMINGS:
+
ret = do_video_ioctl(file, cmd, arg);
break;
diff --git a/drivers/media/video/v4l2-ioctl.c b/drivers/media/video/v4l2-ioctl.c
index 30cc334..10b5678 100644
--- a/drivers/media/video/v4l2-ioctl.c
+++ b/drivers/media/video/v4l2-ioctl.c
@@ -284,6 +284,12 @@ static const char *v4l2_ioctls[] = {
[_IOC_NR(VIDIOC_DBG_G_CHIP_IDENT)] = "VIDIOC_DBG_G_CHIP_IDENT",
[_IOC_NR(VIDIOC_S_HW_FREQ_SEEK)] = "VIDIOC_S_HW_FREQ_SEEK",
#endif
+ [_IOC_NR(VIDIOC_ENUM_DV_PRESETS)] = "VIDIOC_ENUM_DV_PRESETS",
+ [_IOC_NR(VIDIOC_S_DV_PRESET)] = "VIDIOC_S_DV_PRESET",
+ [_IOC_NR(VIDIOC_G_DV_PRESET)] = "VIDIOC_G_DV_PRESET",
+ [_IOC_NR(VIDIOC_QUERY_DV_PRESET)] = "VIDIOC_QUERY_DV_PRESET",
+ [_IOC_NR(VIDIOC_S_DV_TIMINGS)] = "VIDIOC_S_DV_TIMINGS",
+ [_IOC_NR(VIDIOC_G_DV_TIMINGS)] = "VIDIOC_G_DV_TIMINGS",
};
#define V4L2_IOCTLS ARRAY_SIZE(v4l2_ioctls)
@@ -1794,6 +1800,122 @@ static long __video_do_ioctl(struct file *file,
}
break;
}
+ case VIDIOC_ENUM_DV_PRESETS:
+ {
+ struct v4l2_dv_enum_preset *p = arg;
+
+ if (!ops->vidioc_enum_dv_presets)
+ break;
+
+ ret = ops->vidioc_enum_dv_presets(file, fh, p);
+ if (!ret)
+ dbgarg(cmd,
+ "index=%d, preset=%d, name=%s, width=%d,"
+ " height=%d ",
+ p->index, p->preset, p->name, p->width,
+ p->height);
+ break;
+ }
+ case VIDIOC_S_DV_PRESET:
+ {
+ struct v4l2_dv_preset *p = arg;
+
+ if (!ops->vidioc_s_dv_preset)
+ break;
+
+ dbgarg(cmd, "preset=%d\n", p->preset);
+ ret = ops->vidioc_s_dv_preset(file, fh, p);
+ break;
+ }
+ case VIDIOC_G_DV_PRESET:
+ {
+ struct v4l2_dv_preset *p = arg;
+
+ if (!ops->vidioc_g_dv_preset)
+ break;
+
+ ret = ops->vidioc_g_dv_preset(file, fh, p);
+ if (!ret)
+ dbgarg(cmd, "preset=%d\n", p->preset);
+ break;
+ }
+ case VIDIOC_QUERY_DV_PRESET:
+ {
+ struct v4l2_dv_preset *p = arg;
+
+ if (!ops->vidioc_query_dv_preset)
+ break;
+
+ ret = ops->vidioc_query_dv_preset(file, fh, p);
+ if (!ret)
+ dbgarg(cmd, "preset=%d\n", p->preset);
+ break;
+ }
+ case VIDIOC_S_DV_TIMINGS:
+ {
+ struct v4l2_dv_timings *p = arg;
+
+ if (!ops->vidioc_s_dv_timings)
+ break;
+
+ dbgarg(cmd, "type=%d", p->type);
+ switch (p->type) {
+ case V4L2_DV_BT_656_1120:
+ dbgarg2("interlaced=%d, pixelclock=%lld,"
+ " width=%d, height=%d, polarities=%x,"
+ " hfrontporch=%d, hsync=%d, hbackporch=%d,"
+ " vfrontporch=%d, vsync=%d, vbackporch=%d,"
+ " il_vfrontporch=%d, il_vsync=%d,"
+ " il_vbackporch=%d\n",
+ p->bt.interlaced, p->bt.pixelclock,
+ p->bt.width, p->bt.height, p->bt.polarities,
+ p->bt.hfrontporch, p->bt.hsync,
+ p->bt.hbackporch, p->bt.vfrontporch,
+ p->bt.vsync, p->bt.vbackporch,
+ p->bt.il_vfrontporch, p->bt.il_vsync,
+ p->bt.il_vbackporch);
+ ret = ops->vidioc_s_dv_timings(file, fh, p);
+ break;
+ default:
+ dbgarg2("- Unknown type!\n");
+ break;
+ }
+ break;
+ }
+ case VIDIOC_G_DV_TIMINGS:
+ {
+ struct v4l2_dv_timings *p = arg;
+
+ if (!ops->vidioc_g_dv_timings)
+ break;
+
+ dbgarg(cmd, "type=%d", p->type);
+ ret = ops->vidioc_g_dv_timings(file, fh, p);
+ if (!ret) {
+ switch (p->type) {
+ case V4L2_DV_BT_656_1120:
+ dbgarg2("interlaced=%d, pixelclock=%lld,"
+ " width=%d, height=%d, polarities=%x,"
+ " hfrontporch=%d, hsync=%d,"
+ " hbackporch=%d, vfrontporch=%d,"
+ " vsync=%d, vbackporch=%d,"
+ " il_vfrontporch=%d, il_vsync=%d,"
+ " il_vbackporch=%d\n",
+ p->bt.interlaced, p->bt.pixelclock,
+ p->bt.width, p->bt.height,
+ p->bt.polarities, p->bt.hfrontporch,
+ p->bt.hsync, p->bt.hbackporch,
+ p->bt.vfrontporch, p->bt.vsync,
+ p->bt.vbackporch, p->bt.il_vfrontporch,
+ p->bt.il_vsync, p->bt.il_vbackporch);
+ break;
+ default:
+ dbgarg2("- Unknown type!\n");
+ break;
+ }
+ }
+ break;
+ }
default:
{
diff --git a/include/linux/videodev2.h b/include/linux/videodev2.h
index 469dbd0..3436d4a 100644
--- a/include/linux/videodev2.h
+++ b/include/linux/videodev2.h
@@ -730,6 +730,119 @@ struct v4l2_standard {
};
/*
+ * V I D E O T I M I N G S D V P R E S E T
+ */
+struct v4l2_dv_preset {
+ __u32 preset;
+ __u32 reserved[4];
+};
+
+/*
+ * D V P R E S E T S E N U M E R A T I O N
+ */
+struct v4l2_dv_enum_preset {
+ __u32 index;
+ __u32 preset;
+ __u8 name[32]; /* Name of the preset timing */
+ __u32 width;
+ __u32 height;
+ __u32 reserved[4];
+};
+
+/*
+ * D V P R E S E T V A L U E S
+ */
+#define V4L2_DV_PRESET_BASE 0x00000000
+#define V4L2_DV_INVALID (V4L2_DV_PRESET_BASE + 0)
+/* BT.1362 */
+#define V4L2_DV_480P59_94 (V4L2_DV_PRESET_BASE + 1)
+/* BT.1362 */
+#define V4L2_DV_576P50 (V4L2_DV_PRESET_BASE + 2)
+/* SMPTE 296M */
+#define V4L2_DV_720P24 (V4L2_DV_PRESET_BASE + 3)
+/* SMPTE 296M */
+#define V4L2_DV_720P25 (V4L2_DV_PRESET_BASE + 4)
+/* SMPTE 296M */
+#define V4L2_DV_720P30 (V4L2_DV_PRESET_BASE + 5)
+/* SMPTE 296M */
+#define V4L2_DV_720P50 (V4L2_DV_PRESET_BASE + 6)
+/* SMPTE 274M */
+#define V4L2_DV_720P59_94 (V4L2_DV_PRESET_BASE + 7)
+/* SMPTE 274M/296M */
+#define V4L2_DV_720P60 (V4L2_DV_PRESET_BASE + 8)
+/* BT.1120/ SMPTE 274M */
+#define V4L2_DV_1080I29_97 (V4L2_DV_PRESET_BASE + 9)
+/* BT.1120/ SMPTE 274M */
+#define V4L2_DV_1080I30 (V4L2_DV_PRESET_BASE + 10)
+/* BT.1120 */
+#define V4L2_DV_1080I25 (V4L2_DV_PRESET_BASE + 11)
+/* SMPTE 296M */
+#define V4L2_DV_1080I50 (V4L2_DV_PRESET_BASE + 12)
+/* SMPTE 296M */
+#define V4L2_DV_1080I60 (V4L2_DV_PRESET_BASE + 13)
+/* SMPTE 296M */
+#define V4L2_DV_1080P24 (V4L2_DV_PRESET_BASE + 14)
+/* SMPTE 296M */
+#define V4L2_DV_1080P25 (V4L2_DV_PRESET_BASE + 15)
+/* SMPTE 296M */
+#define V4L2_DV_1080P30 (V4L2_DV_PRESET_BASE + 16)
+/* BT.1120 */
+#define V4L2_DV_1080P50 (V4L2_DV_PRESET_BASE + 17)
+/* BT.1120 */
+#define V4L2_DV_1080P60 (V4L2_DV_PRESET_BASE + 18)
+
+/*
+ * D V B T T I M I N G S
+ */
+
+/* BT.656/BT.1120 timing data */
+struct v4l2_bt_timings {
+ __u32 width; /* width in pixels */
+ __u32 height; /* height in lines */
+ __u32 interlaced; /* Interlaced or progressive */
+ __u32 polarities; /* Positive or negative polarity */
+ __u64 pixelclock; /* Pixel clock in HZ. Ex. 74.25MHz->74250000 */
+ __u32 hfrontporch; /* Horizpontal front porch in pixels */
+ __u32 hsync; /* Horizontal Sync length in pixels */
+ __u32 hbackporch; /* Horizontal back porch in pixels */
+ __u32 vfrontporch; /* Vertical front porch in pixels */
+ __u32 vsync; /* Vertical Sync length in lines */
+ __u32 vbackporch; /* Vertical back porch in lines */
+ __u32 il_vfrontporch; /* Vertical front porch for bottom field of
+ * interlaced field formats
+ */
+ __u32 il_vsync; /* Vertical sync length for bottom field of
+ * interlaced field formats
+ */
+ __u32 il_vbackporch; /* Vertical back porch for bottom field of
+ * interlaced field formats
+ */
+ __u32 reserved[16];
+};
+
+/* Interlaced or progressive format */
+#define V4L2_DV_PROGRESSIVE 0
+#define V4L2_DV_INTERLACED 1
+
+/* Polarities. If bit is not set, it is assumed to be negative polarity */
+#define V4L2_DV_VSYNC_POS_POL 0x00000001
+#define V4L2_DV_HSYNC_POS_POL 0x00000002
+
+/* BT.656/1120 timing type */
+enum v4l2_dv_timings_type {
+ V4L2_DV_BT_656_1120,
+};
+
+/* DV timings */
+struct v4l2_dv_timings {
+ enum v4l2_dv_timings_type type;
+ union {
+ struct v4l2_bt_timings bt;
+ __u32 reserved[32];
+ };
+};
+
+/*
* V I D E O I N P U T S
*/
struct v4l2_input {
@@ -740,7 +853,8 @@ struct v4l2_input {
__u32 tuner; /* Associated tuner */
v4l2_std_id std;
__u32 status;
- __u32 reserved[4];
+ __u32 capabilities;
+ __u32 reserved[3];
};
/* Values for the 'type' field */
@@ -771,6 +885,11 @@ struct v4l2_input {
#define V4L2_IN_ST_NO_ACCESS 0x02000000 /* Conditional access denied */
#define V4L2_IN_ST_VTR 0x04000000 /* VTR time constant */
+/* capabilities flags */
+#define V4L2_IN_CAP_PRESETS 0x00000001 /* Supports DV_PRESETS */
+#define V4L2_IN_CAP_CUSTOM_TIMINGS 0x00000002 /* Supports Custom timings */
+#define V4L2_IN_CAP_STD 0x00000004 /* Supports STD */
+
/*
* V I D E O O U T P U T S
*/
@@ -781,13 +900,19 @@ struct v4l2_output {
__u32 audioset; /* Associated audios (bitfield) */
__u32 modulator; /* Associated modulator */
v4l2_std_id std;
- __u32 reserved[4];
+ __u32 capabilities;
+ __u32 reserved[3];
};
/* Values for the 'type' field */
#define V4L2_OUTPUT_TYPE_MODULATOR 1
#define V4L2_OUTPUT_TYPE_ANALOG 2
#define V4L2_OUTPUT_TYPE_ANALOGVGAOVERLAY 3
+/* capabilities flags */
+#define V4L2_OUT_CAP_PRESETS 0x00000001 /* Supports DV_PRESETS */
+#define V4L2_OUT_CAP_CUSTOM_TIMINGS 0x00000002 /* Supports Custom timings */
+#define V4L2_OUT_CAP_STD 0x00000004 /* Supports STD */
+
/*
* C O N T R O L S
*/
@@ -1620,6 +1745,13 @@ struct v4l2_dbg_chip_ident {
#endif
#define VIDIOC_S_HW_FREQ_SEEK _IOW('V', 82, struct v4l2_hw_freq_seek)
+#define VIDIOC_ENUM_DV_PRESETS _IOWR('V', 83, struct v4l2_dv_enum_preset)
+#define VIDIOC_S_DV_PRESET _IOWR('V', 84, struct v4l2_dv_preset)
+#define VIDIOC_G_DV_PRESET _IOWR('V', 85, struct v4l2_dv_preset)
+#define VIDIOC_QUERY_DV_PRESET _IOR('V', 86, struct v4l2_dv_preset)
+#define VIDIOC_S_DV_TIMINGS _IOWR('V', 87, struct v4l2_dv_timings)
+#define VIDIOC_G_DV_TIMINGS _IOWR('V', 88, struct v4l2_dv_timings)
+
/* Reminder: when adding new ioctls please add support for them to
drivers/media/video/v4l2-compat-ioctl32.c as well! */
diff --git a/include/media/v4l2-ioctl.h b/include/media/v4l2-ioctl.h
index 7a4529d..e8ba0f2 100644
--- a/include/media/v4l2-ioctl.h
+++ b/include/media/v4l2-ioctl.h
@@ -239,6 +239,21 @@ struct v4l2_ioctl_ops {
int (*vidioc_enum_frameintervals) (struct file *file, void *fh,
struct v4l2_frmivalenum *fival);
+ /* DV Timings IOCTLs */
+ int (*vidioc_enum_dv_presets) (struct file *file, void *fh,
+ struct v4l2_dv_enum_preset *preset);
+
+ int (*vidioc_s_dv_preset) (struct file *file, void *fh,
+ struct v4l2_dv_preset *preset);
+ int (*vidioc_g_dv_preset) (struct file *file, void *fh,
+ struct v4l2_dv_preset *preset);
+ int (*vidioc_query_dv_preset) (struct file *file, void *fh,
+ struct v4l2_dv_preset *qpreset);
+ int (*vidioc_s_dv_timings) (struct file *file, void *fh,
+ struct v4l2_dv_timings *timings);
+ int (*vidioc_g_dv_timings) (struct file *file, void *fh,
+ struct v4l2_dv_timings *timings);
+
/* For other private ioctls */
long (*vidioc_default) (struct file *file, void *fh,
int cmd, void *arg);
diff --git a/include/media/v4l2-subdev.h b/include/media/v4l2-subdev.h
index d411345..cedcc72 100644
--- a/include/media/v4l2-subdev.h
+++ b/include/media/v4l2-subdev.h
@@ -206,6 +206,19 @@ struct v4l2_subdev_audio_ops {
s_routing: see s_routing in audio_ops, except this version is for video
devices.
+
+ s_dv_preset: set dv (Digital Video) preset in the sub device. Similar to
+ s_std()
+
+ query_dv_preset: query dv preset in the sub device. This is similar to
+ querystd()
+
+ s_dv_timings(): Set custom dv timings in the sub device. This is used
+ when sub device is capable of setting detailed timing information
+ in the hardware to generate/detect the video signal.
+
+ g_dv_timings(): Get custom dv timings in the sub device.
+
*/
struct v4l2_subdev_video_ops {
int (*s_routing)(struct v4l2_subdev *sd, u32 input, u32 output, u32 config);
@@ -229,6 +242,14 @@ struct v4l2_subdev_video_ops {
int (*s_parm)(struct v4l2_subdev *sd, struct v4l2_streamparm *param);
int (*enum_framesizes)(struct v4l2_subdev *sd, struct v4l2_frmsizeenum *fsize);
int (*enum_frameintervals)(struct v4l2_subdev *sd, struct v4l2_frmivalenum *fival);
+ int (*s_dv_preset)(struct v4l2_subdev *sd,
+ struct v4l2_dv_preset *preset);
+ int (*query_dv_preset)(struct v4l2_subdev *sd,
+ struct v4l2_dv_preset *preset);
+ int (*s_dv_timings)(struct v4l2_subdev *sd,
+ struct v4l2_dv_timings *timings);
+ int (*g_dv_timings)(struct v4l2_subdev *sd,
+ struct v4l2_dv_timings *timings);
};
struct v4l2_subdev_ops {
--
1.6.0.4
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH] V4L: adding digital video timings APIs
2009-10-21 22:42 [PATCH] V4L: adding digital video timings APIs m-karicheri2
@ 2009-10-21 23:04 ` Hans Verkuil
2009-10-23 20:44 ` Karicheri, Muralidharan
0 siblings, 1 reply; 13+ messages in thread
From: Hans Verkuil @ 2009-10-21 23:04 UTC (permalink / raw)
To: m-karicheri2
Cc: linux-media, davinci-linux-open-source, Muralidharan Karicheri
Hi Murali,
> From: Muralidharan Karicheri <m-karicheri2@ti.com>
>
> This is the initial version of the digital video timings APIs
> implementation.
>
> This adds the above APIs to the v4l2 core. This is based on version v1.2
> of the RFC titled "V4L - Support for video timings at the input/output
> interface"
> Following new ioctls are added:-
>
> - VIDIOC_ENUM_DV_PRESETS
> - VIDIOC_S_DV_PRESET
> - VIDIOC_G_DV_PRESET
> - VIDIOC_QUERY_DV_PRESET
> - VIDIOC_S_DV_TIMINGS
> - VIDIOC_G_DV_TIMINGS
>
> Please refer to the RFC for the details. This code was tested using vpfe
> capture driver on TI's DM365. Following is the test configuration used :-
>
> Blue Ray HD DVD source -> TVP7002 -> DM365 (VPFE) ->DDR
>
> A draft version of the TVP7002 driver (currently being reviewed in the
> mailing
> list) was used that supports V4L2_DV_1080I60 & V4L2_DV_720P60 presets.
>
> A loopback video capture application was used for testing these APIs. This
> calls
> following IOCTLS :-
>
> - verify the new v4l2_input capabilities flag added
> - Enumerate available presets using VIDIOC_ENUM_DV_PRESETS
> - Set one of the supported preset using VIDIOC_S_DV_PRESET
> - Get current preset using VIDIOC_G_DV_PRESET
> - Detect current preset using VIDIOC_QUERY_DV_PRESET
> - Using stub functions in tvp7002, verify VIDIOC_S_DV_TIMINGS
> and VIDIOC_G_DV_TIMINGS ioctls are received at the sub device.
>
> TODOs :
>
> - Test it on a 64bit platform - I need help here since I don't have the
> platform.
> - Add documentation (Can someone tell me which file to modify in the
> kernel tree?).
Use the spec in media-spec/v4l.
Please also add support to v4l2-ctl.cpp in v4l2-apps/util! That's handy
for testing.
Setting the input/output capabilities should be done in v4l2-ioctl.c
rather than in the drivers. All the info you need to set these bits is
available in the core after all.
I also noticed that not all new ioctls are part of video_ops. Aren't they
all required?
Regards,
Hans
PS: Thanks for all your work! It's great to see this moving forward nicely!
>
> Please review this and let me know your comments.
>
> Mandatory reviewer - Hans Verkuil <hverkuil@xs4all.nl>
>
> Signed-off-by: Muralidharan Karicheri <m-karicheri2@ti.com>
> ---
> Applies to V4L-DVB linux-next branch
>
> drivers/media/video/v4l2-compat-ioctl32.c | 7 ++
> drivers/media/video/v4l2-ioctl.c | 122
> ++++++++++++++++++++++++++
> include/linux/videodev2.h | 136
> ++++++++++++++++++++++++++++-
> include/media/v4l2-ioctl.h | 15 +++
> include/media/v4l2-subdev.h | 21 +++++
> 5 files changed, 299 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/video/v4l2-compat-ioctl32.c
> b/drivers/media/video/v4l2-compat-ioctl32.c
> index 997975d..9277448 100644
> --- a/drivers/media/video/v4l2-compat-ioctl32.c
> +++ b/drivers/media/video/v4l2-compat-ioctl32.c
> @@ -1077,6 +1077,13 @@ long v4l2_compat_ioctl32(struct file *file,
> unsigned int cmd, unsigned long arg)
> case VIDIOC_DBG_G_REGISTER:
> case VIDIOC_DBG_G_CHIP_IDENT:
> case VIDIOC_S_HW_FREQ_SEEK:
> + case VIDIOC_ENUM_DV_PRESETS:
> + case VIDIOC_S_DV_PRESET:
> + case VIDIOC_G_DV_PRESET:
> + case VIDIOC_QUERY_DV_PRESET:
> + case VIDIOC_S_DV_TIMINGS:
> + case VIDIOC_G_DV_TIMINGS:
> +
> ret = do_video_ioctl(file, cmd, arg);
> break;
>
> diff --git a/drivers/media/video/v4l2-ioctl.c
> b/drivers/media/video/v4l2-ioctl.c
> index 30cc334..10b5678 100644
> --- a/drivers/media/video/v4l2-ioctl.c
> +++ b/drivers/media/video/v4l2-ioctl.c
> @@ -284,6 +284,12 @@ static const char *v4l2_ioctls[] = {
> [_IOC_NR(VIDIOC_DBG_G_CHIP_IDENT)] = "VIDIOC_DBG_G_CHIP_IDENT",
> [_IOC_NR(VIDIOC_S_HW_FREQ_SEEK)] = "VIDIOC_S_HW_FREQ_SEEK",
> #endif
> + [_IOC_NR(VIDIOC_ENUM_DV_PRESETS)] = "VIDIOC_ENUM_DV_PRESETS",
> + [_IOC_NR(VIDIOC_S_DV_PRESET)] = "VIDIOC_S_DV_PRESET",
> + [_IOC_NR(VIDIOC_G_DV_PRESET)] = "VIDIOC_G_DV_PRESET",
> + [_IOC_NR(VIDIOC_QUERY_DV_PRESET)] = "VIDIOC_QUERY_DV_PRESET",
> + [_IOC_NR(VIDIOC_S_DV_TIMINGS)] = "VIDIOC_S_DV_TIMINGS",
> + [_IOC_NR(VIDIOC_G_DV_TIMINGS)] = "VIDIOC_G_DV_TIMINGS",
> };
> #define V4L2_IOCTLS ARRAY_SIZE(v4l2_ioctls)
>
> @@ -1794,6 +1800,122 @@ static long __video_do_ioctl(struct file *file,
> }
> break;
> }
> + case VIDIOC_ENUM_DV_PRESETS:
> + {
> + struct v4l2_dv_enum_preset *p = arg;
> +
> + if (!ops->vidioc_enum_dv_presets)
> + break;
> +
> + ret = ops->vidioc_enum_dv_presets(file, fh, p);
> + if (!ret)
> + dbgarg(cmd,
> + "index=%d, preset=%d, name=%s, width=%d,"
> + " height=%d ",
> + p->index, p->preset, p->name, p->width,
> + p->height);
> + break;
> + }
> + case VIDIOC_S_DV_PRESET:
> + {
> + struct v4l2_dv_preset *p = arg;
> +
> + if (!ops->vidioc_s_dv_preset)
> + break;
> +
> + dbgarg(cmd, "preset=%d\n", p->preset);
> + ret = ops->vidioc_s_dv_preset(file, fh, p);
> + break;
> + }
> + case VIDIOC_G_DV_PRESET:
> + {
> + struct v4l2_dv_preset *p = arg;
> +
> + if (!ops->vidioc_g_dv_preset)
> + break;
> +
> + ret = ops->vidioc_g_dv_preset(file, fh, p);
> + if (!ret)
> + dbgarg(cmd, "preset=%d\n", p->preset);
> + break;
> + }
> + case VIDIOC_QUERY_DV_PRESET:
> + {
> + struct v4l2_dv_preset *p = arg;
> +
> + if (!ops->vidioc_query_dv_preset)
> + break;
> +
> + ret = ops->vidioc_query_dv_preset(file, fh, p);
> + if (!ret)
> + dbgarg(cmd, "preset=%d\n", p->preset);
> + break;
> + }
> + case VIDIOC_S_DV_TIMINGS:
> + {
> + struct v4l2_dv_timings *p = arg;
> +
> + if (!ops->vidioc_s_dv_timings)
> + break;
> +
> + dbgarg(cmd, "type=%d", p->type);
> + switch (p->type) {
> + case V4L2_DV_BT_656_1120:
> + dbgarg2("interlaced=%d, pixelclock=%lld,"
> + " width=%d, height=%d, polarities=%x,"
> + " hfrontporch=%d, hsync=%d, hbackporch=%d,"
> + " vfrontporch=%d, vsync=%d, vbackporch=%d,"
> + " il_vfrontporch=%d, il_vsync=%d,"
> + " il_vbackporch=%d\n",
> + p->bt.interlaced, p->bt.pixelclock,
> + p->bt.width, p->bt.height, p->bt.polarities,
> + p->bt.hfrontporch, p->bt.hsync,
> + p->bt.hbackporch, p->bt.vfrontporch,
> + p->bt.vsync, p->bt.vbackporch,
> + p->bt.il_vfrontporch, p->bt.il_vsync,
> + p->bt.il_vbackporch);
> + ret = ops->vidioc_s_dv_timings(file, fh, p);
> + break;
> + default:
> + dbgarg2("- Unknown type!\n");
> + break;
> + }
> + break;
> + }
> + case VIDIOC_G_DV_TIMINGS:
> + {
> + struct v4l2_dv_timings *p = arg;
> +
> + if (!ops->vidioc_g_dv_timings)
> + break;
> +
> + dbgarg(cmd, "type=%d", p->type);
> + ret = ops->vidioc_g_dv_timings(file, fh, p);
> + if (!ret) {
> + switch (p->type) {
> + case V4L2_DV_BT_656_1120:
> + dbgarg2("interlaced=%d, pixelclock=%lld,"
> + " width=%d, height=%d, polarities=%x,"
> + " hfrontporch=%d, hsync=%d,"
> + " hbackporch=%d, vfrontporch=%d,"
> + " vsync=%d, vbackporch=%d,"
> + " il_vfrontporch=%d, il_vsync=%d,"
> + " il_vbackporch=%d\n",
> + p->bt.interlaced, p->bt.pixelclock,
> + p->bt.width, p->bt.height,
> + p->bt.polarities, p->bt.hfrontporch,
> + p->bt.hsync, p->bt.hbackporch,
> + p->bt.vfrontporch, p->bt.vsync,
> + p->bt.vbackporch, p->bt.il_vfrontporch,
> + p->bt.il_vsync, p->bt.il_vbackporch);
> + break;
> + default:
> + dbgarg2("- Unknown type!\n");
> + break;
> + }
> + }
> + break;
> + }
>
> default:
> {
> diff --git a/include/linux/videodev2.h b/include/linux/videodev2.h
> index 469dbd0..3436d4a 100644
> --- a/include/linux/videodev2.h
> +++ b/include/linux/videodev2.h
> @@ -730,6 +730,119 @@ struct v4l2_standard {
> };
>
> /*
> + * V I D E O T I M I N G S D V P R E S E T
> + */
> +struct v4l2_dv_preset {
> + __u32 preset;
> + __u32 reserved[4];
> +};
> +
> +/*
> + * D V P R E S E T S E N U M E R A T I O N
> + */
> +struct v4l2_dv_enum_preset {
> + __u32 index;
> + __u32 preset;
> + __u8 name[32]; /* Name of the preset timing */
> + __u32 width;
> + __u32 height;
> + __u32 reserved[4];
> +};
> +
> +/*
> + * D V P R E S E T V A L U E S
> + */
> +#define V4L2_DV_PRESET_BASE 0x00000000
> +#define V4L2_DV_INVALID (V4L2_DV_PRESET_BASE + 0)
> +/* BT.1362 */
> +#define V4L2_DV_480P59_94 (V4L2_DV_PRESET_BASE + 1)
> +/* BT.1362 */
> +#define V4L2_DV_576P50 (V4L2_DV_PRESET_BASE + 2)
> +/* SMPTE 296M */
> +#define V4L2_DV_720P24 (V4L2_DV_PRESET_BASE + 3)
> +/* SMPTE 296M */
> +#define V4L2_DV_720P25 (V4L2_DV_PRESET_BASE + 4)
> +/* SMPTE 296M */
> +#define V4L2_DV_720P30 (V4L2_DV_PRESET_BASE + 5)
> +/* SMPTE 296M */
> +#define V4L2_DV_720P50 (V4L2_DV_PRESET_BASE + 6)
> +/* SMPTE 274M */
> +#define V4L2_DV_720P59_94 (V4L2_DV_PRESET_BASE + 7)
> +/* SMPTE 274M/296M */
> +#define V4L2_DV_720P60 (V4L2_DV_PRESET_BASE + 8)
> +/* BT.1120/ SMPTE 274M */
> +#define V4L2_DV_1080I29_97 (V4L2_DV_PRESET_BASE + 9)
> +/* BT.1120/ SMPTE 274M */
> +#define V4L2_DV_1080I30 (V4L2_DV_PRESET_BASE + 10)
> +/* BT.1120 */
> +#define V4L2_DV_1080I25 (V4L2_DV_PRESET_BASE + 11)
> +/* SMPTE 296M */
> +#define V4L2_DV_1080I50 (V4L2_DV_PRESET_BASE + 12)
> +/* SMPTE 296M */
> +#define V4L2_DV_1080I60 (V4L2_DV_PRESET_BASE + 13)
> +/* SMPTE 296M */
> +#define V4L2_DV_1080P24 (V4L2_DV_PRESET_BASE + 14)
> +/* SMPTE 296M */
> +#define V4L2_DV_1080P25 (V4L2_DV_PRESET_BASE + 15)
> +/* SMPTE 296M */
> +#define V4L2_DV_1080P30 (V4L2_DV_PRESET_BASE + 16)
> +/* BT.1120 */
> +#define V4L2_DV_1080P50 (V4L2_DV_PRESET_BASE + 17)
> +/* BT.1120 */
> +#define V4L2_DV_1080P60 (V4L2_DV_PRESET_BASE + 18)
> +
> +/*
> + * D V B T T I M I N G S
> + */
> +
> +/* BT.656/BT.1120 timing data */
> +struct v4l2_bt_timings {
> + __u32 width; /* width in pixels */
> + __u32 height; /* height in lines */
> + __u32 interlaced; /* Interlaced or progressive */
> + __u32 polarities; /* Positive or negative polarity */
> + __u64 pixelclock; /* Pixel clock in HZ. Ex. 74.25MHz->74250000 */
> + __u32 hfrontporch; /* Horizpontal front porch in pixels */
> + __u32 hsync; /* Horizontal Sync length in pixels */
> + __u32 hbackporch; /* Horizontal back porch in pixels */
> + __u32 vfrontporch; /* Vertical front porch in pixels */
> + __u32 vsync; /* Vertical Sync length in lines */
> + __u32 vbackporch; /* Vertical back porch in lines */
> + __u32 il_vfrontporch; /* Vertical front porch for bottom field of
> + * interlaced field formats
> + */
> + __u32 il_vsync; /* Vertical sync length for bottom field of
> + * interlaced field formats
> + */
> + __u32 il_vbackporch; /* Vertical back porch for bottom field of
> + * interlaced field formats
> + */
> + __u32 reserved[16];
> +};
> +
> +/* Interlaced or progressive format */
> +#define V4L2_DV_PROGRESSIVE 0
> +#define V4L2_DV_INTERLACED 1
> +
> +/* Polarities. If bit is not set, it is assumed to be negative polarity
> */
> +#define V4L2_DV_VSYNC_POS_POL 0x00000001
> +#define V4L2_DV_HSYNC_POS_POL 0x00000002
> +
> +/* BT.656/1120 timing type */
> +enum v4l2_dv_timings_type {
> + V4L2_DV_BT_656_1120,
> +};
> +
> +/* DV timings */
> +struct v4l2_dv_timings {
> + enum v4l2_dv_timings_type type;
> + union {
> + struct v4l2_bt_timings bt;
> + __u32 reserved[32];
> + };
> +};
> +
> +/*
> * V I D E O I N P U T S
> */
> struct v4l2_input {
> @@ -740,7 +853,8 @@ struct v4l2_input {
> __u32 tuner; /* Associated tuner */
> v4l2_std_id std;
> __u32 status;
> - __u32 reserved[4];
> + __u32 capabilities;
> + __u32 reserved[3];
> };
>
> /* Values for the 'type' field */
> @@ -771,6 +885,11 @@ struct v4l2_input {
> #define V4L2_IN_ST_NO_ACCESS 0x02000000 /* Conditional access denied
> */
> #define V4L2_IN_ST_VTR 0x04000000 /* VTR time constant */
>
> +/* capabilities flags */
> +#define V4L2_IN_CAP_PRESETS 0x00000001 /* Supports DV_PRESETS */
> +#define V4L2_IN_CAP_CUSTOM_TIMINGS 0x00000002 /* Supports Custom timings
> */
> +#define V4L2_IN_CAP_STD 0x00000004 /* Supports STD */
> +
> /*
> * V I D E O O U T P U T S
> */
> @@ -781,13 +900,19 @@ struct v4l2_output {
> __u32 audioset; /* Associated audios (bitfield) */
> __u32 modulator; /* Associated modulator */
> v4l2_std_id std;
> - __u32 reserved[4];
> + __u32 capabilities;
> + __u32 reserved[3];
> };
> /* Values for the 'type' field */
> #define V4L2_OUTPUT_TYPE_MODULATOR 1
> #define V4L2_OUTPUT_TYPE_ANALOG 2
> #define V4L2_OUTPUT_TYPE_ANALOGVGAOVERLAY 3
>
> +/* capabilities flags */
> +#define V4L2_OUT_CAP_PRESETS 0x00000001 /* Supports DV_PRESETS */
> +#define V4L2_OUT_CAP_CUSTOM_TIMINGS 0x00000002 /* Supports Custom timings
> */
> +#define V4L2_OUT_CAP_STD 0x00000004 /* Supports STD */
> +
> /*
> * C O N T R O L S
> */
> @@ -1620,6 +1745,13 @@ struct v4l2_dbg_chip_ident {
> #endif
>
> #define VIDIOC_S_HW_FREQ_SEEK _IOW('V', 82, struct v4l2_hw_freq_seek)
> +#define VIDIOC_ENUM_DV_PRESETS _IOWR('V', 83, struct v4l2_dv_enum_preset)
> +#define VIDIOC_S_DV_PRESET _IOWR('V', 84, struct v4l2_dv_preset)
> +#define VIDIOC_G_DV_PRESET _IOWR('V', 85, struct v4l2_dv_preset)
> +#define VIDIOC_QUERY_DV_PRESET _IOR('V', 86, struct v4l2_dv_preset)
> +#define VIDIOC_S_DV_TIMINGS _IOWR('V', 87, struct v4l2_dv_timings)
> +#define VIDIOC_G_DV_TIMINGS _IOWR('V', 88, struct v4l2_dv_timings)
> +
> /* Reminder: when adding new ioctls please add support for them to
> drivers/media/video/v4l2-compat-ioctl32.c as well! */
>
> diff --git a/include/media/v4l2-ioctl.h b/include/media/v4l2-ioctl.h
> index 7a4529d..e8ba0f2 100644
> --- a/include/media/v4l2-ioctl.h
> +++ b/include/media/v4l2-ioctl.h
> @@ -239,6 +239,21 @@ struct v4l2_ioctl_ops {
> int (*vidioc_enum_frameintervals) (struct file *file, void *fh,
> struct v4l2_frmivalenum *fival);
>
> + /* DV Timings IOCTLs */
> + int (*vidioc_enum_dv_presets) (struct file *file, void *fh,
> + struct v4l2_dv_enum_preset *preset);
> +
> + int (*vidioc_s_dv_preset) (struct file *file, void *fh,
> + struct v4l2_dv_preset *preset);
> + int (*vidioc_g_dv_preset) (struct file *file, void *fh,
> + struct v4l2_dv_preset *preset);
> + int (*vidioc_query_dv_preset) (struct file *file, void *fh,
> + struct v4l2_dv_preset *qpreset);
> + int (*vidioc_s_dv_timings) (struct file *file, void *fh,
> + struct v4l2_dv_timings *timings);
> + int (*vidioc_g_dv_timings) (struct file *file, void *fh,
> + struct v4l2_dv_timings *timings);
> +
> /* For other private ioctls */
> long (*vidioc_default) (struct file *file, void *fh,
> int cmd, void *arg);
> diff --git a/include/media/v4l2-subdev.h b/include/media/v4l2-subdev.h
> index d411345..cedcc72 100644
> --- a/include/media/v4l2-subdev.h
> +++ b/include/media/v4l2-subdev.h
> @@ -206,6 +206,19 @@ struct v4l2_subdev_audio_ops {
>
> s_routing: see s_routing in audio_ops, except this version is for
> video
> devices.
> +
> + s_dv_preset: set dv (Digital Video) preset in the sub device. Similar
> to
> + s_std()
> +
> + query_dv_preset: query dv preset in the sub device. This is similar to
> + querystd()
> +
> + s_dv_timings(): Set custom dv timings in the sub device. This is used
> + when sub device is capable of setting detailed timing information
> + in the hardware to generate/detect the video signal.
> +
> + g_dv_timings(): Get custom dv timings in the sub device.
> +
> */
> struct v4l2_subdev_video_ops {
> int (*s_routing)(struct v4l2_subdev *sd, u32 input, u32 output, u32
> config);
> @@ -229,6 +242,14 @@ struct v4l2_subdev_video_ops {
> int (*s_parm)(struct v4l2_subdev *sd, struct v4l2_streamparm *param);
> int (*enum_framesizes)(struct v4l2_subdev *sd, struct v4l2_frmsizeenum
> *fsize);
> int (*enum_frameintervals)(struct v4l2_subdev *sd, struct
> v4l2_frmivalenum *fival);
> + int (*s_dv_preset)(struct v4l2_subdev *sd,
> + struct v4l2_dv_preset *preset);
> + int (*query_dv_preset)(struct v4l2_subdev *sd,
> + struct v4l2_dv_preset *preset);
> + int (*s_dv_timings)(struct v4l2_subdev *sd,
> + struct v4l2_dv_timings *timings);
> + int (*g_dv_timings)(struct v4l2_subdev *sd,
> + struct v4l2_dv_timings *timings);
> };
>
> struct v4l2_subdev_ops {
> --
> 1.6.0.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
Hans Verkuil - video4linux developer - sponsored by TANDBERG Telecom
^ permalink raw reply [flat|nested] 13+ messages in thread
* RE: [PATCH] V4L: adding digital video timings APIs
2009-10-21 23:04 ` Hans Verkuil
@ 2009-10-23 20:44 ` Karicheri, Muralidharan
2009-11-05 12:56 ` Hans Verkuil
0 siblings, 1 reply; 13+ messages in thread
From: Karicheri, Muralidharan @ 2009-10-23 20:44 UTC (permalink / raw)
To: Hans Verkuil; +Cc: linux-media, davinci-linux-open-source
Hans,
>> following IOCTLS :-
>>
>> - verify the new v4l2_input capabilities flag added
>> - Enumerate available presets using VIDIOC_ENUM_DV_PRESETS
>> - Set one of the supported preset using VIDIOC_S_DV_PRESET
>> - Get current preset using VIDIOC_G_DV_PRESET
>> - Detect current preset using VIDIOC_QUERY_DV_PRESET
>> - Using stub functions in tvp7002, verify VIDIOC_S_DV_TIMINGS
>> and VIDIOC_G_DV_TIMINGS ioctls are received at the sub device.
>>
>> TODOs :
>>
>> - Test it on a 64bit platform - I need help here since I don't have the
>> platform.
>> - Add documentation (Can someone tell me which file to modify in the
>> kernel tree?).
>
>Use the spec in media-spec/v4l.
[MK] Where can I access this? Is this part of kernel tree (I couldn't find
it under Documentation/video4linux/ under the kernel tree? Is it just updating a text file or I need to have some tool installed to access
this documentation and update it.
>
>Please also add support to v4l2-ctl.cpp in v4l2-apps/util! That's handy
>for testing.
[MK] Are you referring to the following repository for this?
http://linuxtv.org/hg/~dougsland/tool/file/5b884b36bbab
Is there a way I can do a git clone for this?
>
>Setting the input/output capabilities should be done in v4l2-ioctl.c
>rather than in the drivers. All the info you need to set these bits is
>available in the core after all.
>
[MK] Could you explain this to me? In my prototype, I had tvp5146 that
implements S_STD and tvp7002 that implements S_PRESET. Since bridge driver
has all the knowledge about the sub devices and their capabilities, it can
set the flag for each of the input that it supports (currently I am
setting this flag in the board setup file that describes all the inputs using v4l2_input structure). So it is a matter of setting relevant cap flag in this file for each of the input based on what the sub device supports. I am not sure how core can figure this out?
>I also noticed that not all new ioctls are part of video_ops. Aren't they
>all required?
>
[MK] All new ioctls are supported in video_ops. I am not sure what you are
referring to. For sub device ops, only few are required since bridge device
can handle the rest.
>Regards,
>
> Hans
>
>PS: Thanks for all your work! It's great to see this moving forward nicely!
>
>>
>> Please review this and let me know your comments.
>>
>> Mandatory reviewer - Hans Verkuil <hverkuil@xs4all.nl>
>>
>> Signed-off-by: Muralidharan Karicheri <m-karicheri2@ti.com>
>> ---
>> Applies to V4L-DVB linux-next branch
>>
>> drivers/media/video/v4l2-compat-ioctl32.c | 7 ++
>> drivers/media/video/v4l2-ioctl.c | 122
>> ++++++++++++++++++++++++++
>> include/linux/videodev2.h | 136
>> ++++++++++++++++++++++++++++-
>> include/media/v4l2-ioctl.h | 15 +++
>> include/media/v4l2-subdev.h | 21 +++++
>> 5 files changed, 299 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/media/video/v4l2-compat-ioctl32.c
>> b/drivers/media/video/v4l2-compat-ioctl32.c
>> index 997975d..9277448 100644
>> --- a/drivers/media/video/v4l2-compat-ioctl32.c
>> +++ b/drivers/media/video/v4l2-compat-ioctl32.c
>> @@ -1077,6 +1077,13 @@ long v4l2_compat_ioctl32(struct file *file,
>> unsigned int cmd, unsigned long arg)
>> case VIDIOC_DBG_G_REGISTER:
>> case VIDIOC_DBG_G_CHIP_IDENT:
>> case VIDIOC_S_HW_FREQ_SEEK:
>> + case VIDIOC_ENUM_DV_PRESETS:
>> + case VIDIOC_S_DV_PRESET:
>> + case VIDIOC_G_DV_PRESET:
>> + case VIDIOC_QUERY_DV_PRESET:
>> + case VIDIOC_S_DV_TIMINGS:
>> + case VIDIOC_G_DV_TIMINGS:
>> +
>> ret = do_video_ioctl(file, cmd, arg);
>> break;
>>
>> diff --git a/drivers/media/video/v4l2-ioctl.c
>> b/drivers/media/video/v4l2-ioctl.c
>> index 30cc334..10b5678 100644
>> --- a/drivers/media/video/v4l2-ioctl.c
>> +++ b/drivers/media/video/v4l2-ioctl.c
>> @@ -284,6 +284,12 @@ static const char *v4l2_ioctls[] = {
>> [_IOC_NR(VIDIOC_DBG_G_CHIP_IDENT)] = "VIDIOC_DBG_G_CHIP_IDENT",
>> [_IOC_NR(VIDIOC_S_HW_FREQ_SEEK)] = "VIDIOC_S_HW_FREQ_SEEK",
>> #endif
>> + [_IOC_NR(VIDIOC_ENUM_DV_PRESETS)] = "VIDIOC_ENUM_DV_PRESETS",
>> + [_IOC_NR(VIDIOC_S_DV_PRESET)] = "VIDIOC_S_DV_PRESET",
>> + [_IOC_NR(VIDIOC_G_DV_PRESET)] = "VIDIOC_G_DV_PRESET",
>> + [_IOC_NR(VIDIOC_QUERY_DV_PRESET)] = "VIDIOC_QUERY_DV_PRESET",
>> + [_IOC_NR(VIDIOC_S_DV_TIMINGS)] = "VIDIOC_S_DV_TIMINGS",
>> + [_IOC_NR(VIDIOC_G_DV_TIMINGS)] = "VIDIOC_G_DV_TIMINGS",
>> };
>> #define V4L2_IOCTLS ARRAY_SIZE(v4l2_ioctls)
>>
>> @@ -1794,6 +1800,122 @@ static long __video_do_ioctl(struct file *file,
>> }
>> break;
>> }
>> + case VIDIOC_ENUM_DV_PRESETS:
>> + {
>> + struct v4l2_dv_enum_preset *p = arg;
>> +
>> + if (!ops->vidioc_enum_dv_presets)
>> + break;
>> +
>> + ret = ops->vidioc_enum_dv_presets(file, fh, p);
>> + if (!ret)
>> + dbgarg(cmd,
>> + "index=%d, preset=%d, name=%s, width=%d,"
>> + " height=%d ",
>> + p->index, p->preset, p->name, p->width,
>> + p->height);
>> + break;
>> + }
>> + case VIDIOC_S_DV_PRESET:
>> + {
>> + struct v4l2_dv_preset *p = arg;
>> +
>> + if (!ops->vidioc_s_dv_preset)
>> + break;
>> +
>> + dbgarg(cmd, "preset=%d\n", p->preset);
>> + ret = ops->vidioc_s_dv_preset(file, fh, p);
>> + break;
>> + }
>> + case VIDIOC_G_DV_PRESET:
>> + {
>> + struct v4l2_dv_preset *p = arg;
>> +
>> + if (!ops->vidioc_g_dv_preset)
>> + break;
>> +
>> + ret = ops->vidioc_g_dv_preset(file, fh, p);
>> + if (!ret)
>> + dbgarg(cmd, "preset=%d\n", p->preset);
>> + break;
>> + }
>> + case VIDIOC_QUERY_DV_PRESET:
>> + {
>> + struct v4l2_dv_preset *p = arg;
>> +
>> + if (!ops->vidioc_query_dv_preset)
>> + break;
>> +
>> + ret = ops->vidioc_query_dv_preset(file, fh, p);
>> + if (!ret)
>> + dbgarg(cmd, "preset=%d\n", p->preset);
>> + break;
>> + }
>> + case VIDIOC_S_DV_TIMINGS:
>> + {
>> + struct v4l2_dv_timings *p = arg;
>> +
>> + if (!ops->vidioc_s_dv_timings)
>> + break;
>> +
>> + dbgarg(cmd, "type=%d", p->type);
>> + switch (p->type) {
>> + case V4L2_DV_BT_656_1120:
>> + dbgarg2("interlaced=%d, pixelclock=%lld,"
>> + " width=%d, height=%d, polarities=%x,"
>> + " hfrontporch=%d, hsync=%d, hbackporch=%d,"
>> + " vfrontporch=%d, vsync=%d, vbackporch=%d,"
>> + " il_vfrontporch=%d, il_vsync=%d,"
>> + " il_vbackporch=%d\n",
>> + p->bt.interlaced, p->bt.pixelclock,
>> + p->bt.width, p->bt.height, p->bt.polarities,
>> + p->bt.hfrontporch, p->bt.hsync,
>> + p->bt.hbackporch, p->bt.vfrontporch,
>> + p->bt.vsync, p->bt.vbackporch,
>> + p->bt.il_vfrontporch, p->bt.il_vsync,
>> + p->bt.il_vbackporch);
>> + ret = ops->vidioc_s_dv_timings(file, fh, p);
>> + break;
>> + default:
>> + dbgarg2("- Unknown type!\n");
>> + break;
>> + }
>> + break;
>> + }
>> + case VIDIOC_G_DV_TIMINGS:
>> + {
>> + struct v4l2_dv_timings *p = arg;
>> +
>> + if (!ops->vidioc_g_dv_timings)
>> + break;
>> +
>> + dbgarg(cmd, "type=%d", p->type);
>> + ret = ops->vidioc_g_dv_timings(file, fh, p);
>> + if (!ret) {
>> + switch (p->type) {
>> + case V4L2_DV_BT_656_1120:
>> + dbgarg2("interlaced=%d, pixelclock=%lld,"
>> + " width=%d, height=%d, polarities=%x,"
>> + " hfrontporch=%d, hsync=%d,"
>> + " hbackporch=%d, vfrontporch=%d,"
>> + " vsync=%d, vbackporch=%d,"
>> + " il_vfrontporch=%d, il_vsync=%d,"
>> + " il_vbackporch=%d\n",
>> + p->bt.interlaced, p->bt.pixelclock,
>> + p->bt.width, p->bt.height,
>> + p->bt.polarities, p->bt.hfrontporch,
>> + p->bt.hsync, p->bt.hbackporch,
>> + p->bt.vfrontporch, p->bt.vsync,
>> + p->bt.vbackporch, p->bt.il_vfrontporch,
>> + p->bt.il_vsync, p->bt.il_vbackporch);
>> + break;
>> + default:
>> + dbgarg2("- Unknown type!\n");
>> + break;
>> + }
>> + }
>> + break;
>> + }
>>
>> default:
>> {
>> diff --git a/include/linux/videodev2.h b/include/linux/videodev2.h
>> index 469dbd0..3436d4a 100644
>> --- a/include/linux/videodev2.h
>> +++ b/include/linux/videodev2.h
>> @@ -730,6 +730,119 @@ struct v4l2_standard {
>> };
>>
>> /*
>> + * V I D E O T I M I N G S D V P R E S E T
>> + */
>> +struct v4l2_dv_preset {
>> + __u32 preset;
>> + __u32 reserved[4];
>> +};
>> +
>> +/*
>> + * D V P R E S E T S E N U M E R A T I O N
>> + */
>> +struct v4l2_dv_enum_preset {
>> + __u32 index;
>> + __u32 preset;
>> + __u8 name[32]; /* Name of the preset timing */
>> + __u32 width;
>> + __u32 height;
>> + __u32 reserved[4];
>> +};
>> +
>> +/*
>> + * D V P R E S E T V A L U E S
>> + */
>> +#define V4L2_DV_PRESET_BASE 0x00000000
>> +#define V4L2_DV_INVALID (V4L2_DV_PRESET_BASE + 0)
>> +/* BT.1362 */
>> +#define V4L2_DV_480P59_94 (V4L2_DV_PRESET_BASE + 1)
>> +/* BT.1362 */
>> +#define V4L2_DV_576P50 (V4L2_DV_PRESET_BASE + 2)
>> +/* SMPTE 296M */
>> +#define V4L2_DV_720P24 (V4L2_DV_PRESET_BASE + 3)
>> +/* SMPTE 296M */
>> +#define V4L2_DV_720P25 (V4L2_DV_PRESET_BASE + 4)
>> +/* SMPTE 296M */
>> +#define V4L2_DV_720P30 (V4L2_DV_PRESET_BASE + 5)
>> +/* SMPTE 296M */
>> +#define V4L2_DV_720P50 (V4L2_DV_PRESET_BASE + 6)
>> +/* SMPTE 274M */
>> +#define V4L2_DV_720P59_94 (V4L2_DV_PRESET_BASE + 7)
>> +/* SMPTE 274M/296M */
>> +#define V4L2_DV_720P60 (V4L2_DV_PRESET_BASE + 8)
>> +/* BT.1120/ SMPTE 274M */
>> +#define V4L2_DV_1080I29_97 (V4L2_DV_PRESET_BASE + 9)
>> +/* BT.1120/ SMPTE 274M */
>> +#define V4L2_DV_1080I30 (V4L2_DV_PRESET_BASE + 10)
>> +/* BT.1120 */
>> +#define V4L2_DV_1080I25 (V4L2_DV_PRESET_BASE + 11)
>> +/* SMPTE 296M */
>> +#define V4L2_DV_1080I50 (V4L2_DV_PRESET_BASE + 12)
>> +/* SMPTE 296M */
>> +#define V4L2_DV_1080I60 (V4L2_DV_PRESET_BASE + 13)
>> +/* SMPTE 296M */
>> +#define V4L2_DV_1080P24 (V4L2_DV_PRESET_BASE + 14)
>> +/* SMPTE 296M */
>> +#define V4L2_DV_1080P25 (V4L2_DV_PRESET_BASE + 15)
>> +/* SMPTE 296M */
>> +#define V4L2_DV_1080P30 (V4L2_DV_PRESET_BASE + 16)
>> +/* BT.1120 */
>> +#define V4L2_DV_1080P50 (V4L2_DV_PRESET_BASE + 17)
>> +/* BT.1120 */
>> +#define V4L2_DV_1080P60 (V4L2_DV_PRESET_BASE + 18)
>> +
>> +/*
>> + * D V B T T I M I N G S
>> + */
>> +
>> +/* BT.656/BT.1120 timing data */
>> +struct v4l2_bt_timings {
>> + __u32 width; /* width in pixels */
>> + __u32 height; /* height in lines */
>> + __u32 interlaced; /* Interlaced or progressive */
>> + __u32 polarities; /* Positive or negative polarity */
>> + __u64 pixelclock; /* Pixel clock in HZ. Ex. 74.25MHz->74250000 */
>> + __u32 hfrontporch; /* Horizpontal front porch in pixels */
>> + __u32 hsync; /* Horizontal Sync length in pixels */
>> + __u32 hbackporch; /* Horizontal back porch in pixels */
>> + __u32 vfrontporch; /* Vertical front porch in pixels */
>> + __u32 vsync; /* Vertical Sync length in lines */
>> + __u32 vbackporch; /* Vertical back porch in lines */
>> + __u32 il_vfrontporch; /* Vertical front porch for bottom field of
>> + * interlaced field formats
>> + */
>> + __u32 il_vsync; /* Vertical sync length for bottom field of
>> + * interlaced field formats
>> + */
>> + __u32 il_vbackporch; /* Vertical back porch for bottom field of
>> + * interlaced field formats
>> + */
>> + __u32 reserved[16];
>> +};
>> +
>> +/* Interlaced or progressive format */
>> +#define V4L2_DV_PROGRESSIVE 0
>> +#define V4L2_DV_INTERLACED 1
>> +
>> +/* Polarities. If bit is not set, it is assumed to be negative polarity
>> */
>> +#define V4L2_DV_VSYNC_POS_POL 0x00000001
>> +#define V4L2_DV_HSYNC_POS_POL 0x00000002
>> +
>> +/* BT.656/1120 timing type */
>> +enum v4l2_dv_timings_type {
>> + V4L2_DV_BT_656_1120,
>> +};
>> +
>> +/* DV timings */
>> +struct v4l2_dv_timings {
>> + enum v4l2_dv_timings_type type;
>> + union {
>> + struct v4l2_bt_timings bt;
>> + __u32 reserved[32];
>> + };
>> +};
>> +
>> +/*
>> * V I D E O I N P U T S
>> */
>> struct v4l2_input {
>> @@ -740,7 +853,8 @@ struct v4l2_input {
>> __u32 tuner; /* Associated tuner */
>> v4l2_std_id std;
>> __u32 status;
>> - __u32 reserved[4];
>> + __u32 capabilities;
>> + __u32 reserved[3];
>> };
>>
>> /* Values for the 'type' field */
>> @@ -771,6 +885,11 @@ struct v4l2_input {
>> #define V4L2_IN_ST_NO_ACCESS 0x02000000 /* Conditional access denied
>> */
>> #define V4L2_IN_ST_VTR 0x04000000 /* VTR time constant */
>>
>> +/* capabilities flags */
>> +#define V4L2_IN_CAP_PRESETS 0x00000001 /* Supports DV_PRESETS
>*/
>> +#define V4L2_IN_CAP_CUSTOM_TIMINGS 0x00000002 /* Supports Custom
>timings
>> */
>> +#define V4L2_IN_CAP_STD 0x00000004 /* Supports STD */
>> +
>> /*
>> * V I D E O O U T P U T S
>> */
>> @@ -781,13 +900,19 @@ struct v4l2_output {
>> __u32 audioset; /* Associated audios (bitfield) */
>> __u32 modulator; /* Associated modulator */
>> v4l2_std_id std;
>> - __u32 reserved[4];
>> + __u32 capabilities;
>> + __u32 reserved[3];
>> };
>> /* Values for the 'type' field */
>> #define V4L2_OUTPUT_TYPE_MODULATOR 1
>> #define V4L2_OUTPUT_TYPE_ANALOG 2
>> #define V4L2_OUTPUT_TYPE_ANALOGVGAOVERLAY 3
>>
>> +/* capabilities flags */
>> +#define V4L2_OUT_CAP_PRESETS 0x00000001 /* Supports DV_PRESETS
>*/
>> +#define V4L2_OUT_CAP_CUSTOM_TIMINGS 0x00000002 /* Supports Custom
>timings
>> */
>> +#define V4L2_OUT_CAP_STD 0x00000004 /* Supports STD */
>> +
>> /*
>> * C O N T R O L S
>> */
>> @@ -1620,6 +1745,13 @@ struct v4l2_dbg_chip_ident {
>> #endif
>>
>> #define VIDIOC_S_HW_FREQ_SEEK _IOW('V', 82, struct
>v4l2_hw_freq_seek)
>> +#define VIDIOC_ENUM_DV_PRESETS _IOWR('V', 83, struct
>v4l2_dv_enum_preset)
>> +#define VIDIOC_S_DV_PRESET _IOWR('V', 84, struct v4l2_dv_preset)
>> +#define VIDIOC_G_DV_PRESET _IOWR('V', 85, struct v4l2_dv_preset)
>> +#define VIDIOC_QUERY_DV_PRESET _IOR('V', 86, struct v4l2_dv_preset)
>> +#define VIDIOC_S_DV_TIMINGS _IOWR('V', 87, struct v4l2_dv_timings)
>> +#define VIDIOC_G_DV_TIMINGS _IOWR('V', 88, struct v4l2_dv_timings)
>> +
>> /* Reminder: when adding new ioctls please add support for them to
>> drivers/media/video/v4l2-compat-ioctl32.c as well! */
>>
>> diff --git a/include/media/v4l2-ioctl.h b/include/media/v4l2-ioctl.h
>> index 7a4529d..e8ba0f2 100644
>> --- a/include/media/v4l2-ioctl.h
>> +++ b/include/media/v4l2-ioctl.h
>> @@ -239,6 +239,21 @@ struct v4l2_ioctl_ops {
>> int (*vidioc_enum_frameintervals) (struct file *file, void *fh,
>> struct v4l2_frmivalenum *fival);
>>
>> + /* DV Timings IOCTLs */
>> + int (*vidioc_enum_dv_presets) (struct file *file, void *fh,
>> + struct v4l2_dv_enum_preset *preset);
>> +
>> + int (*vidioc_s_dv_preset) (struct file *file, void *fh,
>> + struct v4l2_dv_preset *preset);
>> + int (*vidioc_g_dv_preset) (struct file *file, void *fh,
>> + struct v4l2_dv_preset *preset);
>> + int (*vidioc_query_dv_preset) (struct file *file, void *fh,
>> + struct v4l2_dv_preset *qpreset);
>> + int (*vidioc_s_dv_timings) (struct file *file, void *fh,
>> + struct v4l2_dv_timings *timings);
>> + int (*vidioc_g_dv_timings) (struct file *file, void *fh,
>> + struct v4l2_dv_timings *timings);
>> +
>> /* For other private ioctls */
>> long (*vidioc_default) (struct file *file, void *fh,
>> int cmd, void *arg);
>> diff --git a/include/media/v4l2-subdev.h b/include/media/v4l2-subdev.h
>> index d411345..cedcc72 100644
>> --- a/include/media/v4l2-subdev.h
>> +++ b/include/media/v4l2-subdev.h
>> @@ -206,6 +206,19 @@ struct v4l2_subdev_audio_ops {
>>
>> s_routing: see s_routing in audio_ops, except this version is for
>> video
>> devices.
>> +
>> + s_dv_preset: set dv (Digital Video) preset in the sub device. Similar
>> to
>> + s_std()
>> +
>> + query_dv_preset: query dv preset in the sub device. This is similar
>to
>> + querystd()
>> +
>> + s_dv_timings(): Set custom dv timings in the sub device. This is used
>> + when sub device is capable of setting detailed timing information
>> + in the hardware to generate/detect the video signal.
>> +
>> + g_dv_timings(): Get custom dv timings in the sub device.
>> +
>> */
>> struct v4l2_subdev_video_ops {
>> int (*s_routing)(struct v4l2_subdev *sd, u32 input, u32 output, u32
>> config);
>> @@ -229,6 +242,14 @@ struct v4l2_subdev_video_ops {
>> int (*s_parm)(struct v4l2_subdev *sd, struct v4l2_streamparm *param);
>> int (*enum_framesizes)(struct v4l2_subdev *sd, struct
>v4l2_frmsizeenum
>> *fsize);
>> int (*enum_frameintervals)(struct v4l2_subdev *sd, struct
>> v4l2_frmivalenum *fival);
>> + int (*s_dv_preset)(struct v4l2_subdev *sd,
>> + struct v4l2_dv_preset *preset);
>> + int (*query_dv_preset)(struct v4l2_subdev *sd,
>> + struct v4l2_dv_preset *preset);
>> + int (*s_dv_timings)(struct v4l2_subdev *sd,
>> + struct v4l2_dv_timings *timings);
>> + int (*g_dv_timings)(struct v4l2_subdev *sd,
>> + struct v4l2_dv_timings *timings);
>> };
>>
>> struct v4l2_subdev_ops {
>> --
>> 1.6.0.4
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-media" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
>
>
>--
>Hans Verkuil - video4linux developer - sponsored by TANDBERG Telecom
>
>--
>To unsubscribe from this list: send the line "unsubscribe linux-media" in
>the body of a message to majordomo@vger.kernel.org
>More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] V4L: adding digital video timings APIs
2009-10-23 20:44 ` Karicheri, Muralidharan
@ 2009-11-05 12:56 ` Hans Verkuil
2009-11-11 7:21 ` Hans Verkuil
2009-11-11 21:45 ` Karicheri, Muralidharan
0 siblings, 2 replies; 13+ messages in thread
From: Hans Verkuil @ 2009-11-05 12:56 UTC (permalink / raw)
To: Karicheri, Muralidharan; +Cc: linux-media, davinci-linux-open-source
On Friday 23 October 2009 22:44:34 Karicheri, Muralidharan wrote:
> Hans,
>
> >> following IOCTLS :-
> >>
> >> - verify the new v4l2_input capabilities flag added
> >> - Enumerate available presets using VIDIOC_ENUM_DV_PRESETS
> >> - Set one of the supported preset using VIDIOC_S_DV_PRESET
> >> - Get current preset using VIDIOC_G_DV_PRESET
> >> - Detect current preset using VIDIOC_QUERY_DV_PRESET
> >> - Using stub functions in tvp7002, verify VIDIOC_S_DV_TIMINGS
> >> and VIDIOC_G_DV_TIMINGS ioctls are received at the sub device.
> >>
> >> TODOs :
> >>
> >> - Test it on a 64bit platform - I need help here since I don't have the
> >> platform.
> >> - Add documentation (Can someone tell me which file to modify in the
> >> kernel tree?).
> >
> >Use the spec in media-spec/v4l.
>
> [MK] Where can I access this? Is this part of kernel tree (I couldn't find
> it under Documentation/video4linux/ under the kernel tree? Is it just updating a text file or I need to have some tool installed to access
> this documentation and update it.
This has been moved around quite a bit lately. It is now in
linux/Documentation/DocBook/v4l. You build it using 'make media-spec'.
> >Please also add support to v4l2-ctl.cpp in v4l2-apps/util! That's handy
> >for testing.
> [MK] Are you referring to the following repository for this?
>
> http://linuxtv.org/hg/~dougsland/tool/file/5b884b36bbab
>
> Is there a way I can do a git clone for this?
Both the doc and the v4l2-ctl.cpp utility are in the master hg repository
(linuxtv.org/hg/v4l-dvb). The utility can be found here: v4l2-apps/util.
Build it using 'make apps'. The patches of the timings API, docs and utils
should all be done against the master hg tree since that is that latest and
greatest tree.
>
> >
> >Setting the input/output capabilities should be done in v4l2-ioctl.c
> >rather than in the drivers. All the info you need to set these bits is
> >available in the core after all.
> >
>
> [MK] Could you explain this to me? In my prototype, I had tvp5146 that
> implements S_STD and tvp7002 that implements S_PRESET. Since bridge driver
> has all the knowledge about the sub devices and their capabilities, it can
> set the flag for each of the input that it supports (currently I am
> setting this flag in the board setup file that describes all the inputs using v4l2_input structure). So it is a matter of setting relevant cap flag in this file for each of the input based on what the sub device supports. I am not sure how core can figure this out?
The problem is that we don't want to go through all drivers in order to set
the input/output capability flags. However, v4l2_ioctl.c can easily check
whether the v4l2_ioctl_ops struct has set vidioc_s_std, vidioc_s_dv_preset
and/or vidioc_s_dv_timings and fill in the caps accordingly. If this is done
before the vidioc_enum_input/output is called, then the driver can override
what v4l2_ioctl.c did if that is needed.
>
> >I also noticed that not all new ioctls are part of video_ops. Aren't they
> >all required?
> >
> [MK] All new ioctls are supported in video_ops. I am not sure what you are
> referring to. For sub device ops, only few are required since bridge device
> can handle the rest.
OK.
Regards,
Hans
--
Hans Verkuil - video4linux developer - sponsored by TANDBERG Telecom
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] V4L: adding digital video timings APIs
2009-11-05 12:56 ` Hans Verkuil
@ 2009-11-11 7:21 ` Hans Verkuil
2009-11-11 21:47 ` Karicheri, Muralidharan
` (2 more replies)
2009-11-11 21:45 ` Karicheri, Muralidharan
1 sibling, 3 replies; 13+ messages in thread
From: Hans Verkuil @ 2009-11-11 7:21 UTC (permalink / raw)
To: Karicheri, Muralidharan; +Cc: linux-media, davinci-linux-open-source
On Thursday 05 November 2009 13:56:29 Hans Verkuil wrote:
> On Friday 23 October 2009 22:44:34 Karicheri, Muralidharan wrote:
> > Hans,
> >
> > >> following IOCTLS :-
> > >>
> > >> - verify the new v4l2_input capabilities flag added
> > >> - Enumerate available presets using VIDIOC_ENUM_DV_PRESETS
> > >> - Set one of the supported preset using VIDIOC_S_DV_PRESET
> > >> - Get current preset using VIDIOC_G_DV_PRESET
> > >> - Detect current preset using VIDIOC_QUERY_DV_PRESET
> > >> - Using stub functions in tvp7002, verify VIDIOC_S_DV_TIMINGS
> > >> and VIDIOC_G_DV_TIMINGS ioctls are received at the sub device.
> > >>
> > >> TODOs :
> > >>
> > >> - Test it on a 64bit platform - I need help here since I don't have the
> > >> platform.
> > >> - Add documentation (Can someone tell me which file to modify in the
> > >> kernel tree?).
> > >
> > >Use the spec in media-spec/v4l.
> >
> > [MK] Where can I access this? Is this part of kernel tree (I couldn't find
> > it under Documentation/video4linux/ under the kernel tree? Is it just updating a text file or I need to have some tool installed to access
> > this documentation and update it.
>
> This has been moved around quite a bit lately. It is now in
> linux/Documentation/DocBook/v4l. You build it using 'make media-spec'.
>
> > >Please also add support to v4l2-ctl.cpp in v4l2-apps/util! That's handy
> > >for testing.
> > [MK] Are you referring to the following repository for this?
> >
> > http://linuxtv.org/hg/~dougsland/tool/file/5b884b36bbab
> >
> > Is there a way I can do a git clone for this?
>
> Both the doc and the v4l2-ctl.cpp utility are in the master hg repository
> (linuxtv.org/hg/v4l-dvb). The utility can be found here: v4l2-apps/util.
> Build it using 'make apps'. The patches of the timings API, docs and utils
> should all be done against the master hg tree since that is that latest and
> greatest tree.
>
> >
> > >
> > >Setting the input/output capabilities should be done in v4l2-ioctl.c
> > >rather than in the drivers. All the info you need to set these bits is
> > >available in the core after all.
> > >
> >
> > [MK] Could you explain this to me? In my prototype, I had tvp5146 that
> > implements S_STD and tvp7002 that implements S_PRESET. Since bridge driver
> > has all the knowledge about the sub devices and their capabilities, it can
> > set the flag for each of the input that it supports (currently I am
> > setting this flag in the board setup file that describes all the inputs using v4l2_input structure). So it is a matter of setting relevant cap flag in this file for each of the input based on what the sub device supports. I am not sure how core can figure this out?
>
> The problem is that we don't want to go through all drivers in order to set
> the input/output capability flags. However, v4l2_ioctl.c can easily check
> whether the v4l2_ioctl_ops struct has set vidioc_s_std, vidioc_s_dv_preset
> and/or vidioc_s_dv_timings and fill in the caps accordingly. If this is done
> before the vidioc_enum_input/output is called, then the driver can override
> what v4l2_ioctl.c did if that is needed.
>
> >
> > >I also noticed that not all new ioctls are part of video_ops. Aren't they
> > >all required?
> > >
> > [MK] All new ioctls are supported in video_ops. I am not sure what you are
> > referring to. For sub device ops, only few are required since bridge device
> > can handle the rest.
>
> OK.
>
> Regards,
>
> Hans
>
Hi Murali,
What is the status of this? It would be great if we can get this in for 2.6.33.
Regards,
Hans
--
Hans Verkuil - video4linux developer - sponsored by TANDBERG Telecom
^ permalink raw reply [flat|nested] 13+ messages in thread
* RE: [PATCH] V4L: adding digital video timings APIs
2009-11-05 12:56 ` Hans Verkuil
2009-11-11 7:21 ` Hans Verkuil
@ 2009-11-11 21:45 ` Karicheri, Muralidharan
2009-11-12 6:18 ` Hans Verkuil
1 sibling, 1 reply; 13+ messages in thread
From: Karicheri, Muralidharan @ 2009-11-11 21:45 UTC (permalink / raw)
To: Hans Verkuil; +Cc: linux-media, davinci-linux-open-source
Hans,
>> [MK] Could you explain this to me? In my prototype, I had tvp5146 that
>> implements S_STD and tvp7002 that implements S_PRESET. Since bridge
>driver
>> has all the knowledge about the sub devices and their capabilities, it
>can
>> set the flag for each of the input that it supports (currently I am
>> setting this flag in the board setup file that describes all the inputs
>using v4l2_input structure). So it is a matter of setting relevant cap flag
>in this file for each of the input based on what the sub device supports. I
>am not sure how core can figure this out?
>
>The problem is that we don't want to go through all drivers in order to set
>the input/output capability flags. However, v4l2_ioctl.c can easily check
>whether the v4l2_ioctl_ops struct has set vidioc_s_std, vidioc_s_dv_preset
>and/or vidioc_s_dv_timings and fill in the caps accordingly. If this is
>done
>before the vidioc_enum_input/output is called, then the driver can override
>what v4l2_ioctl.c did if that is needed.
>
Why do we need to do that? Why not leave it to the bridge driver to set that
flag since it knows all encoder/decoder connected to it and whether current encoder/decoder has support for S_STD or S_PRESET looking at the sub dev ops.
If we set them at the core, as you explained, then bridge driver needs to
override it. That is not clean IMO.
Murali
>Regards,
>
> Hans
>
>--
>Hans Verkuil - video4linux developer - sponsored by TANDBERG Telecom
^ permalink raw reply [flat|nested] 13+ messages in thread
* RE: [PATCH] V4L: adding digital video timings APIs
2009-11-11 7:21 ` Hans Verkuil
@ 2009-11-11 21:47 ` Karicheri, Muralidharan
2009-11-13 18:19 ` Karicheri, Muralidharan
2009-11-16 18:35 ` Karicheri, Muralidharan
2 siblings, 0 replies; 13+ messages in thread
From: Karicheri, Muralidharan @ 2009-11-11 21:47 UTC (permalink / raw)
To: Hans Verkuil; +Cc: linux-media, davinci-linux-open-source
Hans,
Please see my response to your comment on setting the flag. I still think it is cleaner to do it in the bridge driver.
The patch is ready and I need to finish the documentation. I plan to do this in a weeks time and push the patch to the list.
Murali Karicheri
Software Design Engineer
Texas Instruments Inc.
Germantown, MD 20874
phone: 301-407-9583
email: m-karicheri2@ti.com
>-----Original Message-----
>From: Hans Verkuil [mailto:hverkuil@xs4all.nl]
>Sent: Wednesday, November 11, 2009 2:21 AM
>To: Karicheri, Muralidharan
>Cc: linux-media@vger.kernel.org; davinci-linux-open-
>source@linux.davincidsp.com
>Subject: Re: [PATCH] V4L: adding digital video timings APIs
>
>On Thursday 05 November 2009 13:56:29 Hans Verkuil wrote:
>> On Friday 23 October 2009 22:44:34 Karicheri, Muralidharan wrote:
>> > Hans,
>> >
>> > >> following IOCTLS :-
>> > >>
>> > >> - verify the new v4l2_input capabilities flag added
>> > >> - Enumerate available presets using VIDIOC_ENUM_DV_PRESETS
>> > >> - Set one of the supported preset using VIDIOC_S_DV_PRESET
>> > >> - Get current preset using VIDIOC_G_DV_PRESET
>> > >> - Detect current preset using VIDIOC_QUERY_DV_PRESET
>> > >> - Using stub functions in tvp7002, verify VIDIOC_S_DV_TIMINGS
>> > >> and VIDIOC_G_DV_TIMINGS ioctls are received at the sub device.
>> > >>
>> > >> TODOs :
>> > >>
>> > >> - Test it on a 64bit platform - I need help here since I don't have
>the
>> > >> platform.
>> > >> - Add documentation (Can someone tell me which file to modify in
>the
>> > >> kernel tree?).
>> > >
>> > >Use the spec in media-spec/v4l.
>> >
>> > [MK] Where can I access this? Is this part of kernel tree (I couldn't
>find
>> > it under Documentation/video4linux/ under the kernel tree? Is it just
>updating a text file or I need to have some tool installed to access
>> > this documentation and update it.
>>
>> This has been moved around quite a bit lately. It is now in
>> linux/Documentation/DocBook/v4l. You build it using 'make media-spec'.
>>
>> > >Please also add support to v4l2-ctl.cpp in v4l2-apps/util! That's
>handy
>> > >for testing.
>> > [MK] Are you referring to the following repository for this?
>> >
>> > http://linuxtv.org/hg/~dougsland/tool/file/5b884b36bbab
>> >
>> > Is there a way I can do a git clone for this?
>>
>> Both the doc and the v4l2-ctl.cpp utility are in the master hg repository
>> (linuxtv.org/hg/v4l-dvb). The utility can be found here: v4l2-apps/util.
>> Build it using 'make apps'. The patches of the timings API, docs and
>utils
>> should all be done against the master hg tree since that is that latest
>and
>> greatest tree.
>>
>> >
>> > >
>> > >Setting the input/output capabilities should be done in v4l2-ioctl.c
>> > >rather than in the drivers. All the info you need to set these bits is
>> > >available in the core after all.
>> > >
>> >
>> > [MK] Could you explain this to me? In my prototype, I had tvp5146 that
>> > implements S_STD and tvp7002 that implements S_PRESET. Since bridge
>driver
>> > has all the knowledge about the sub devices and their capabilities, it
>can
>> > set the flag for each of the input that it supports (currently I am
>> > setting this flag in the board setup file that describes all the inputs
>using v4l2_input structure). So it is a matter of setting relevant cap flag
>in this file for each of the input based on what the sub device supports. I
>am not sure how core can figure this out?
>>
>> The problem is that we don't want to go through all drivers in order to
>set
>> the input/output capability flags. However, v4l2_ioctl.c can easily check
>> whether the v4l2_ioctl_ops struct has set vidioc_s_std,
>vidioc_s_dv_preset
>> and/or vidioc_s_dv_timings and fill in the caps accordingly. If this is
>done
>> before the vidioc_enum_input/output is called, then the driver can
>override
>> what v4l2_ioctl.c did if that is needed.
>>
>> >
>> > >I also noticed that not all new ioctls are part of video_ops. Aren't
>they
>> > >all required?
>> > >
>> > [MK] All new ioctls are supported in video_ops. I am not sure what you
>are
>> > referring to. For sub device ops, only few are required since bridge
>device
>> > can handle the rest.
>>
>> OK.
>>
>> Regards,
>>
>> Hans
>>
>
>Hi Murali,
>
>What is the status of this? It would be great if we can get this in for
>2.6.33.
>
>Regards,
>
> Hans
>
>--
>Hans Verkuil - video4linux developer - sponsored by TANDBERG Telecom
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] V4L: adding digital video timings APIs
2009-11-11 21:45 ` Karicheri, Muralidharan
@ 2009-11-12 6:18 ` Hans Verkuil
2009-11-12 15:34 ` Karicheri, Muralidharan
0 siblings, 1 reply; 13+ messages in thread
From: Hans Verkuil @ 2009-11-12 6:18 UTC (permalink / raw)
To: Karicheri, Muralidharan; +Cc: linux-media, davinci-linux-open-source
On Wednesday 11 November 2009 22:45:15 Karicheri, Muralidharan wrote:
> Hans,
>
> >> [MK] Could you explain this to me? In my prototype, I had tvp5146 that
> >> implements S_STD and tvp7002 that implements S_PRESET. Since bridge
> >driver
> >> has all the knowledge about the sub devices and their capabilities, it
> >can
> >> set the flag for each of the input that it supports (currently I am
> >> setting this flag in the board setup file that describes all the inputs
> >using v4l2_input structure). So it is a matter of setting relevant cap flag
> >in this file for each of the input based on what the sub device supports. I
> >am not sure how core can figure this out?
> >
> >The problem is that we don't want to go through all drivers in order to set
> >the input/output capability flags. However, v4l2_ioctl.c can easily check
> >whether the v4l2_ioctl_ops struct has set vidioc_s_std, vidioc_s_dv_preset
> >and/or vidioc_s_dv_timings and fill in the caps accordingly. If this is
> >done
> >before the vidioc_enum_input/output is called, then the driver can override
> >what v4l2_ioctl.c did if that is needed.
> >
>
> Why do we need to do that? Why not leave it to the bridge driver to set that
> flag since it knows all encoder/decoder connected to it and whether current encoder/decoder has support for S_STD or S_PRESET looking at the sub dev ops.
> If we set them at the core, as you explained, then bridge driver needs to
> override it. That is not clean IMO.
Actually, the bridge driver only needs to override if it has multiple inputs
where the capability flags differ (i.e. some inputs only support S_STD and
others only support S_DV_PRESET).
In all other cases the core will fill it in correctly.
Doing it in the core ensures that the capability flags will be filled in so
drivers don't need to remember doing this. The alternative is that you have to
go through ALL existing drivers and add the new SUPPORTS_STD capability flag.
But even then I am pretty certain that people will forget to set this flag
for new upcoming drivers.
So I prefer to have this set in the core and only drivers that have mixed
inputs/outputs need to do a bit more work.
Regards,
Hans
>
> Murali
>
> >Regards,
> >
> > Hans
> >
> >--
> >Hans Verkuil - video4linux developer - sponsored by TANDBERG Telecom
>
>
>
--
Hans Verkuil - video4linux developer - sponsored by TANDBERG Telecom
^ permalink raw reply [flat|nested] 13+ messages in thread
* RE: [PATCH] V4L: adding digital video timings APIs
2009-11-12 6:18 ` Hans Verkuil
@ 2009-11-12 15:34 ` Karicheri, Muralidharan
0 siblings, 0 replies; 13+ messages in thread
From: Karicheri, Muralidharan @ 2009-11-12 15:34 UTC (permalink / raw)
To: Hans Verkuil; +Cc: linux-media, davinci-linux-open-source
>
>Actually, the bridge driver only needs to override if it has multiple
>inputs
>where the capability flags differ (i.e. some inputs only support S_STD and
>others only support S_DV_PRESET).
>
>In all other cases the core will fill it in correctly.
>
>Doing it in the core ensures that the capability flags will be filled in so
>drivers don't need to remember doing this. The alternative is that you have
>to
>go through ALL existing drivers and add the new SUPPORTS_STD capability
>flag.
>
That is a good point to have it in the core. I will update the patch
and send it.
>But even then I am pretty certain that people will forget to set this flag
>for new upcoming drivers.
>
>So I prefer to have this set in the core and only drivers that have mixed
>inputs/outputs need to do a bit more work.
>
>Regards,
>
> Hans
>
>>
>> Murali
>>
>> >Regards,
>> >
>> > Hans
>> >
>> >--
>> >Hans Verkuil - video4linux developer - sponsored by TANDBERG Telecom
>>
>>
>>
>
>
>
>--
>Hans Verkuil - video4linux developer - sponsored by TANDBERG Telecom
^ permalink raw reply [flat|nested] 13+ messages in thread
* RE: [PATCH] V4L: adding digital video timings APIs
2009-11-11 7:21 ` Hans Verkuil
2009-11-11 21:47 ` Karicheri, Muralidharan
@ 2009-11-13 18:19 ` Karicheri, Muralidharan
2009-11-16 18:35 ` Karicheri, Muralidharan
2 siblings, 0 replies; 13+ messages in thread
From: Karicheri, Muralidharan @ 2009-11-13 18:19 UTC (permalink / raw)
To: Hans Verkuil; +Cc: linux-media, davinci-linux-open-source
Hi,
I have downloaded the tree for Documentation and Applications and started first building documentation.
make media-spec
It seems to build. What output it creates? Do I edit one of the xml file
to add the documentation? After adding the documentation, I guess I need
to build again and verify the document is added in proper format. I am
assuming that the build will create a html file which I can view for
verification of content. Please reply so that I can save some time in this
process by not re-inventing the wheel.
Thanks.
Murali Karicheri
Software Design Engineer
Texas Instruments Inc.
Germantown, MD 20874
phone: 301-407-9583
email: m-karicheri2@ti.com
>-----Original Message-----
>From: Hans Verkuil [mailto:hverkuil@xs4all.nl]
>Sent: Wednesday, November 11, 2009 2:21 AM
>To: Karicheri, Muralidharan
>Cc: linux-media@vger.kernel.org; davinci-linux-open-
>source@linux.davincidsp.com
>Subject: Re: [PATCH] V4L: adding digital video timings APIs
>
>On Thursday 05 November 2009 13:56:29 Hans Verkuil wrote:
>> On Friday 23 October 2009 22:44:34 Karicheri, Muralidharan wrote:
>> > Hans,
>> >
>> > >> following IOCTLS :-
>> > >>
>> > >> - verify the new v4l2_input capabilities flag added
>> > >> - Enumerate available presets using VIDIOC_ENUM_DV_PRESETS
>> > >> - Set one of the supported preset using VIDIOC_S_DV_PRESET
>> > >> - Get current preset using VIDIOC_G_DV_PRESET
>> > >> - Detect current preset using VIDIOC_QUERY_DV_PRESET
>> > >> - Using stub functions in tvp7002, verify VIDIOC_S_DV_TIMINGS
>> > >> and VIDIOC_G_DV_TIMINGS ioctls are received at the sub device.
>> > >>
>> > >> TODOs :
>> > >>
>> > >> - Test it on a 64bit platform - I need help here since I don't have
>the
>> > >> platform.
>> > >> - Add documentation (Can someone tell me which file to modify in
>the
>> > >> kernel tree?).
>> > >
>> > >Use the spec in media-spec/v4l.
>> >
>> > [MK] Where can I access this? Is this part of kernel tree (I couldn't
>find
>> > it under Documentation/video4linux/ under the kernel tree? Is it just
>updating a text file or I need to have some tool installed to access
>> > this documentation and update it.
>>
>> This has been moved around quite a bit lately. It is now in
>> linux/Documentation/DocBook/v4l. You build it using 'make media-spec'.
>>
>> > >Please also add support to v4l2-ctl.cpp in v4l2-apps/util! That's
>handy
>> > >for testing.
>> > [MK] Are you referring to the following repository for this?
>> >
>> > http://linuxtv.org/hg/~dougsland/tool/file/5b884b36bbab
>> >
>> > Is there a way I can do a git clone for this?
>>
>> Both the doc and the v4l2-ctl.cpp utility are in the master hg repository
>> (linuxtv.org/hg/v4l-dvb). The utility can be found here: v4l2-apps/util.
>> Build it using 'make apps'. The patches of the timings API, docs and
>utils
>> should all be done against the master hg tree since that is that latest
>and
>> greatest tree.
>>
>> >
>> > >
>> > >Setting the input/output capabilities should be done in v4l2-ioctl.c
>> > >rather than in the drivers. All the info you need to set these bits is
>> > >available in the core after all.
>> > >
>> >
>> > [MK] Could you explain this to me? In my prototype, I had tvp5146 that
>> > implements S_STD and tvp7002 that implements S_PRESET. Since bridge
>driver
>> > has all the knowledge about the sub devices and their capabilities, it
>can
>> > set the flag for each of the input that it supports (currently I am
>> > setting this flag in the board setup file that describes all the inputs
>using v4l2_input structure). So it is a matter of setting relevant cap flag
>in this file for each of the input based on what the sub device supports. I
>am not sure how core can figure this out?
>>
>> The problem is that we don't want to go through all drivers in order to
>set
>> the input/output capability flags. However, v4l2_ioctl.c can easily check
>> whether the v4l2_ioctl_ops struct has set vidioc_s_std,
>vidioc_s_dv_preset
>> and/or vidioc_s_dv_timings and fill in the caps accordingly. If this is
>done
>> before the vidioc_enum_input/output is called, then the driver can
>override
>> what v4l2_ioctl.c did if that is needed.
>>
>> >
>> > >I also noticed that not all new ioctls are part of video_ops. Aren't
>they
>> > >all required?
>> > >
>> > [MK] All new ioctls are supported in video_ops. I am not sure what you
>are
>> > referring to. For sub device ops, only few are required since bridge
>device
>> > can handle the rest.
>>
>> OK.
>>
>> Regards,
>>
>> Hans
>>
>
>Hi Murali,
>
>What is the status of this? It would be great if we can get this in for
>2.6.33.
>
>Regards,
>
> Hans
>
>--
>Hans Verkuil - video4linux developer - sponsored by TANDBERG Telecom
^ permalink raw reply [flat|nested] 13+ messages in thread
* RE: [PATCH] V4L: adding digital video timings APIs
2009-11-11 7:21 ` Hans Verkuil
2009-11-11 21:47 ` Karicheri, Muralidharan
2009-11-13 18:19 ` Karicheri, Muralidharan
@ 2009-11-16 18:35 ` Karicheri, Muralidharan
2009-11-17 7:14 ` Hans Verkuil
2 siblings, 1 reply; 13+ messages in thread
From: Karicheri, Muralidharan @ 2009-11-16 18:35 UTC (permalink / raw)
To: Hans Verkuil; +Cc: linux-media, davinci-linux-open-source
Hans,
>Hi Murali,
>
>What is the status of this? It would be great if we can get this in for
>2.6.33.
>
I am working on the documentation today and then the application. I think a
new patch will be ready by tomorrow. I am not sure if there is a better way
to add documentation.. Currently I have just editing the xml file manually.
Regards,
Murali
>Regards,
>
> Hans
>
>--
>Hans Verkuil - video4linux developer - sponsored by TANDBERG Telecom
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] V4L: adding digital video timings APIs
2009-11-16 18:35 ` Karicheri, Muralidharan
@ 2009-11-17 7:14 ` Hans Verkuil
0 siblings, 0 replies; 13+ messages in thread
From: Hans Verkuil @ 2009-11-17 7:14 UTC (permalink / raw)
To: Karicheri, Muralidharan; +Cc: linux-media, davinci-linux-open-source
On Monday 16 November 2009 19:35:40 Karicheri, Muralidharan wrote:
>
> Hans,
>
> >Hi Murali,
> >
> >What is the status of this? It would be great if we can get this in for
> >2.6.33.
> >
>
> I am working on the documentation today and then the application. I think a
> new patch will be ready by tomorrow. I am not sure if there is a better way
> to add documentation.. Currently I have just editing the xml file manually.
That's what I do as well. I know that there are some xml editing programs
available, but I've no idea how well they work with this code.
Regards,
Hans
>
> Regards,
> Murali
> >Regards,
> >
> > Hans
> >
> >--
> >Hans Verkuil - video4linux developer - sponsored by TANDBERG Telecom
>
>
>
>
--
Hans Verkuil - video4linux developer - sponsored by TANDBERG Telecom
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH] V4L: adding digital video timings APIs
@ 2009-10-21 22:40 m-karicheri2
0 siblings, 0 replies; 13+ messages in thread
From: m-karicheri2 @ 2009-10-21 22:40 UTC (permalink / raw)
To: linux-media, hverkuil; +Cc: Muralidharan Karicheri
From: Muralidharan Karicheri <m-karicheri2@ti.com>
This is the initial version of the digital video timings APIs implementation.
This adds the above APIs to the v4l2 core. This is based on version v1.2
of the RFC titled "V4L - Support for video timings at the input/output interface"
Following new ioctls are added:-
- VIDIOC_ENUM_DV_PRESETS
- VIDIOC_S_DV_PRESET
- VIDIOC_G_DV_PRESET
- VIDIOC_QUERY_DV_PRESET
- VIDIOC_S_DV_TIMINGS
- VIDIOC_G_DV_TIMINGS
Please refer to the RFC for the details. This code was tested using vpfe
capture driver on TI's DM365. Following is the test configuration used :-
Blue Ray HD DVD source -> TVP7002 -> DM365 (VPFE) ->DDR
A draft version of the TVP7002 driver (currently being reviewed in the mailing
list) was used that supports V4L2_DV_1080I60 & V4L2_DV_720P60 presets.
A loopback video capture application was used for testing these APIs. This calls
following IOCTLS :-
- verify the new v4l2_input capabilities flag added
- Enumerate available presets using VIDIOC_ENUM_DV_PRESETS
- Set one of the supported preset using VIDIOC_S_DV_PRESET
- Get current preset using VIDIOC_G_DV_PRESET
- Detect current preset using VIDIOC_QUERY_DV_PRESET
- Using stub functions in tvp7002, verify VIDIOC_S_DV_TIMINGS
and VIDIOC_G_DV_TIMINGS ioctls are received at the sub device.
TODOs :
- Test it on a 64bit platform - I need help here since I don't have the platform.
- Add documentation (Can someone tell me which file to modify in the kernel tree?).
Please review this and let me know your comments.
Mandatory reviewer - Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Muralidharan Karicheri <m-karicheri2@ti.com>
---
Applies to V4L-DVB linux-next branch
drivers/media/video/v4l2-compat-ioctl32.c | 7 ++
drivers/media/video/v4l2-ioctl.c | 122 ++++++++++++++++++++++++++
include/linux/videodev2.h | 136 ++++++++++++++++++++++++++++-
include/media/v4l2-ioctl.h | 15 +++
include/media/v4l2-subdev.h | 21 +++++
5 files changed, 299 insertions(+), 2 deletions(-)
diff --git a/drivers/media/video/v4l2-compat-ioctl32.c b/drivers/media/video/v4l2-compat-ioctl32.c
index 997975d..9277448 100644
--- a/drivers/media/video/v4l2-compat-ioctl32.c
+++ b/drivers/media/video/v4l2-compat-ioctl32.c
@@ -1077,6 +1077,13 @@ long v4l2_compat_ioctl32(struct file *file, unsigned int cmd, unsigned long arg)
case VIDIOC_DBG_G_REGISTER:
case VIDIOC_DBG_G_CHIP_IDENT:
case VIDIOC_S_HW_FREQ_SEEK:
+ case VIDIOC_ENUM_DV_PRESETS:
+ case VIDIOC_S_DV_PRESET:
+ case VIDIOC_G_DV_PRESET:
+ case VIDIOC_QUERY_DV_PRESET:
+ case VIDIOC_S_DV_TIMINGS:
+ case VIDIOC_G_DV_TIMINGS:
+
ret = do_video_ioctl(file, cmd, arg);
break;
diff --git a/drivers/media/video/v4l2-ioctl.c b/drivers/media/video/v4l2-ioctl.c
index 30cc334..10b5678 100644
--- a/drivers/media/video/v4l2-ioctl.c
+++ b/drivers/media/video/v4l2-ioctl.c
@@ -284,6 +284,12 @@ static const char *v4l2_ioctls[] = {
[_IOC_NR(VIDIOC_DBG_G_CHIP_IDENT)] = "VIDIOC_DBG_G_CHIP_IDENT",
[_IOC_NR(VIDIOC_S_HW_FREQ_SEEK)] = "VIDIOC_S_HW_FREQ_SEEK",
#endif
+ [_IOC_NR(VIDIOC_ENUM_DV_PRESETS)] = "VIDIOC_ENUM_DV_PRESETS",
+ [_IOC_NR(VIDIOC_S_DV_PRESET)] = "VIDIOC_S_DV_PRESET",
+ [_IOC_NR(VIDIOC_G_DV_PRESET)] = "VIDIOC_G_DV_PRESET",
+ [_IOC_NR(VIDIOC_QUERY_DV_PRESET)] = "VIDIOC_QUERY_DV_PRESET",
+ [_IOC_NR(VIDIOC_S_DV_TIMINGS)] = "VIDIOC_S_DV_TIMINGS",
+ [_IOC_NR(VIDIOC_G_DV_TIMINGS)] = "VIDIOC_G_DV_TIMINGS",
};
#define V4L2_IOCTLS ARRAY_SIZE(v4l2_ioctls)
@@ -1794,6 +1800,122 @@ static long __video_do_ioctl(struct file *file,
}
break;
}
+ case VIDIOC_ENUM_DV_PRESETS:
+ {
+ struct v4l2_dv_enum_preset *p = arg;
+
+ if (!ops->vidioc_enum_dv_presets)
+ break;
+
+ ret = ops->vidioc_enum_dv_presets(file, fh, p);
+ if (!ret)
+ dbgarg(cmd,
+ "index=%d, preset=%d, name=%s, width=%d,"
+ " height=%d ",
+ p->index, p->preset, p->name, p->width,
+ p->height);
+ break;
+ }
+ case VIDIOC_S_DV_PRESET:
+ {
+ struct v4l2_dv_preset *p = arg;
+
+ if (!ops->vidioc_s_dv_preset)
+ break;
+
+ dbgarg(cmd, "preset=%d\n", p->preset);
+ ret = ops->vidioc_s_dv_preset(file, fh, p);
+ break;
+ }
+ case VIDIOC_G_DV_PRESET:
+ {
+ struct v4l2_dv_preset *p = arg;
+
+ if (!ops->vidioc_g_dv_preset)
+ break;
+
+ ret = ops->vidioc_g_dv_preset(file, fh, p);
+ if (!ret)
+ dbgarg(cmd, "preset=%d\n", p->preset);
+ break;
+ }
+ case VIDIOC_QUERY_DV_PRESET:
+ {
+ struct v4l2_dv_preset *p = arg;
+
+ if (!ops->vidioc_query_dv_preset)
+ break;
+
+ ret = ops->vidioc_query_dv_preset(file, fh, p);
+ if (!ret)
+ dbgarg(cmd, "preset=%d\n", p->preset);
+ break;
+ }
+ case VIDIOC_S_DV_TIMINGS:
+ {
+ struct v4l2_dv_timings *p = arg;
+
+ if (!ops->vidioc_s_dv_timings)
+ break;
+
+ dbgarg(cmd, "type=%d", p->type);
+ switch (p->type) {
+ case V4L2_DV_BT_656_1120:
+ dbgarg2("interlaced=%d, pixelclock=%lld,"
+ " width=%d, height=%d, polarities=%x,"
+ " hfrontporch=%d, hsync=%d, hbackporch=%d,"
+ " vfrontporch=%d, vsync=%d, vbackporch=%d,"
+ " il_vfrontporch=%d, il_vsync=%d,"
+ " il_vbackporch=%d\n",
+ p->bt.interlaced, p->bt.pixelclock,
+ p->bt.width, p->bt.height, p->bt.polarities,
+ p->bt.hfrontporch, p->bt.hsync,
+ p->bt.hbackporch, p->bt.vfrontporch,
+ p->bt.vsync, p->bt.vbackporch,
+ p->bt.il_vfrontporch, p->bt.il_vsync,
+ p->bt.il_vbackporch);
+ ret = ops->vidioc_s_dv_timings(file, fh, p);
+ break;
+ default:
+ dbgarg2("- Unknown type!\n");
+ break;
+ }
+ break;
+ }
+ case VIDIOC_G_DV_TIMINGS:
+ {
+ struct v4l2_dv_timings *p = arg;
+
+ if (!ops->vidioc_g_dv_timings)
+ break;
+
+ dbgarg(cmd, "type=%d", p->type);
+ ret = ops->vidioc_g_dv_timings(file, fh, p);
+ if (!ret) {
+ switch (p->type) {
+ case V4L2_DV_BT_656_1120:
+ dbgarg2("interlaced=%d, pixelclock=%lld,"
+ " width=%d, height=%d, polarities=%x,"
+ " hfrontporch=%d, hsync=%d,"
+ " hbackporch=%d, vfrontporch=%d,"
+ " vsync=%d, vbackporch=%d,"
+ " il_vfrontporch=%d, il_vsync=%d,"
+ " il_vbackporch=%d\n",
+ p->bt.interlaced, p->bt.pixelclock,
+ p->bt.width, p->bt.height,
+ p->bt.polarities, p->bt.hfrontporch,
+ p->bt.hsync, p->bt.hbackporch,
+ p->bt.vfrontporch, p->bt.vsync,
+ p->bt.vbackporch, p->bt.il_vfrontporch,
+ p->bt.il_vsync, p->bt.il_vbackporch);
+ break;
+ default:
+ dbgarg2("- Unknown type!\n");
+ break;
+ }
+ }
+ break;
+ }
default:
{
diff --git a/include/linux/videodev2.h b/include/linux/videodev2.h
index 469dbd0..3436d4a 100644
--- a/include/linux/videodev2.h
+++ b/include/linux/videodev2.h
@@ -730,6 +730,119 @@ struct v4l2_standard {
};
/*
+ * V I D E O T I M I N G S D V P R E S E T
+ */
+struct v4l2_dv_preset {
+ __u32 preset;
+ __u32 reserved[4];
+};
+
+/*
+ * D V P R E S E T S E N U M E R A T I O N
+ */
+struct v4l2_dv_enum_preset {
+ __u32 index;
+ __u32 preset;
+ __u8 name[32]; /* Name of the preset timing */
+ __u32 width;
+ __u32 height;
+ __u32 reserved[4];
+};
+
+/*
+ * D V P R E S E T V A L U E S
+ */
+#define V4L2_DV_PRESET_BASE 0x00000000
+#define V4L2_DV_INVALID (V4L2_DV_PRESET_BASE + 0)
+/* BT.1362 */
+#define V4L2_DV_480P59_94 (V4L2_DV_PRESET_BASE + 1)
+/* BT.1362 */
+#define V4L2_DV_576P50 (V4L2_DV_PRESET_BASE + 2)
+/* SMPTE 296M */
+#define V4L2_DV_720P24 (V4L2_DV_PRESET_BASE + 3)
+/* SMPTE 296M */
+#define V4L2_DV_720P25 (V4L2_DV_PRESET_BASE + 4)
+/* SMPTE 296M */
+#define V4L2_DV_720P30 (V4L2_DV_PRESET_BASE + 5)
+/* SMPTE 296M */
+#define V4L2_DV_720P50 (V4L2_DV_PRESET_BASE + 6)
+/* SMPTE 274M */
+#define V4L2_DV_720P59_94 (V4L2_DV_PRESET_BASE + 7)
+/* SMPTE 274M/296M */
+#define V4L2_DV_720P60 (V4L2_DV_PRESET_BASE + 8)
+/* BT.1120/ SMPTE 274M */
+#define V4L2_DV_1080I29_97 (V4L2_DV_PRESET_BASE + 9)
+/* BT.1120/ SMPTE 274M */
+#define V4L2_DV_1080I30 (V4L2_DV_PRESET_BASE + 10)
+/* BT.1120 */
+#define V4L2_DV_1080I25 (V4L2_DV_PRESET_BASE + 11)
+/* SMPTE 296M */
+#define V4L2_DV_1080I50 (V4L2_DV_PRESET_BASE + 12)
+/* SMPTE 296M */
+#define V4L2_DV_1080I60 (V4L2_DV_PRESET_BASE + 13)
+/* SMPTE 296M */
+#define V4L2_DV_1080P24 (V4L2_DV_PRESET_BASE + 14)
+/* SMPTE 296M */
+#define V4L2_DV_1080P25 (V4L2_DV_PRESET_BASE + 15)
+/* SMPTE 296M */
+#define V4L2_DV_1080P30 (V4L2_DV_PRESET_BASE + 16)
+/* BT.1120 */
+#define V4L2_DV_1080P50 (V4L2_DV_PRESET_BASE + 17)
+/* BT.1120 */
+#define V4L2_DV_1080P60 (V4L2_DV_PRESET_BASE + 18)
+
+/*
+ * D V B T T I M I N G S
+ */
+
+/* BT.656/BT.1120 timing data */
+struct v4l2_bt_timings {
+ __u32 width; /* width in pixels */
+ __u32 height; /* height in lines */
+ __u32 interlaced; /* Interlaced or progressive */
+ __u32 polarities; /* Positive or negative polarity */
+ __u64 pixelclock; /* Pixel clock in HZ. Ex. 74.25MHz->74250000 */
+ __u32 hfrontporch; /* Horizpontal front porch in pixels */
+ __u32 hsync; /* Horizontal Sync length in pixels */
+ __u32 hbackporch; /* Horizontal back porch in pixels */
+ __u32 vfrontporch; /* Vertical front porch in pixels */
+ __u32 vsync; /* Vertical Sync length in lines */
+ __u32 vbackporch; /* Vertical back porch in lines */
+ __u32 il_vfrontporch; /* Vertical front porch for bottom field of
+ * interlaced field formats
+ */
+ __u32 il_vsync; /* Vertical sync length for bottom field of
+ * interlaced field formats
+ */
+ __u32 il_vbackporch; /* Vertical back porch for bottom field of
+ * interlaced field formats
+ */
+ __u32 reserved[16];
+};
+
+/* Interlaced or progressive format */
+#define V4L2_DV_PROGRESSIVE 0
+#define V4L2_DV_INTERLACED 1
+
+/* Polarities. If bit is not set, it is assumed to be negative polarity */
+#define V4L2_DV_VSYNC_POS_POL 0x00000001
+#define V4L2_DV_HSYNC_POS_POL 0x00000002
+
+/* BT.656/1120 timing type */
+enum v4l2_dv_timings_type {
+ V4L2_DV_BT_656_1120,
+};
+
+/* DV timings */
+struct v4l2_dv_timings {
+ enum v4l2_dv_timings_type type;
+ union {
+ struct v4l2_bt_timings bt;
+ __u32 reserved[32];
+ };
+};
+
+/*
* V I D E O I N P U T S
*/
struct v4l2_input {
@@ -740,7 +853,8 @@ struct v4l2_input {
__u32 tuner; /* Associated tuner */
v4l2_std_id std;
__u32 status;
- __u32 reserved[4];
+ __u32 capabilities;
+ __u32 reserved[3];
};
/* Values for the 'type' field */
@@ -771,6 +885,11 @@ struct v4l2_input {
#define V4L2_IN_ST_NO_ACCESS 0x02000000 /* Conditional access denied */
#define V4L2_IN_ST_VTR 0x04000000 /* VTR time constant */
+/* capabilities flags */
+#define V4L2_IN_CAP_PRESETS 0x00000001 /* Supports DV_PRESETS */
+#define V4L2_IN_CAP_CUSTOM_TIMINGS 0x00000002 /* Supports Custom timings */
+#define V4L2_IN_CAP_STD 0x00000004 /* Supports STD */
+
/*
* V I D E O O U T P U T S
*/
@@ -781,13 +900,19 @@ struct v4l2_output {
__u32 audioset; /* Associated audios (bitfield) */
__u32 modulator; /* Associated modulator */
v4l2_std_id std;
- __u32 reserved[4];
+ __u32 capabilities;
+ __u32 reserved[3];
};
/* Values for the 'type' field */
#define V4L2_OUTPUT_TYPE_MODULATOR 1
#define V4L2_OUTPUT_TYPE_ANALOG 2
#define V4L2_OUTPUT_TYPE_ANALOGVGAOVERLAY 3
+/* capabilities flags */
+#define V4L2_OUT_CAP_PRESETS 0x00000001 /* Supports DV_PRESETS */
+#define V4L2_OUT_CAP_CUSTOM_TIMINGS 0x00000002 /* Supports Custom timings */
+#define V4L2_OUT_CAP_STD 0x00000004 /* Supports STD */
+
/*
* C O N T R O L S
*/
@@ -1620,6 +1745,13 @@ struct v4l2_dbg_chip_ident {
#endif
#define VIDIOC_S_HW_FREQ_SEEK _IOW('V', 82, struct v4l2_hw_freq_seek)
+#define VIDIOC_ENUM_DV_PRESETS _IOWR('V', 83, struct v4l2_dv_enum_preset)
+#define VIDIOC_S_DV_PRESET _IOWR('V', 84, struct v4l2_dv_preset)
+#define VIDIOC_G_DV_PRESET _IOWR('V', 85, struct v4l2_dv_preset)
+#define VIDIOC_QUERY_DV_PRESET _IOR('V', 86, struct v4l2_dv_preset)
+#define VIDIOC_S_DV_TIMINGS _IOWR('V', 87, struct v4l2_dv_timings)
+#define VIDIOC_G_DV_TIMINGS _IOWR('V', 88, struct v4l2_dv_timings)
+
/* Reminder: when adding new ioctls please add support for them to
drivers/media/video/v4l2-compat-ioctl32.c as well! */
diff --git a/include/media/v4l2-ioctl.h b/include/media/v4l2-ioctl.h
index 7a4529d..e8ba0f2 100644
--- a/include/media/v4l2-ioctl.h
+++ b/include/media/v4l2-ioctl.h
@@ -239,6 +239,21 @@ struct v4l2_ioctl_ops {
int (*vidioc_enum_frameintervals) (struct file *file, void *fh,
struct v4l2_frmivalenum *fival);
+ /* DV Timings IOCTLs */
+ int (*vidioc_enum_dv_presets) (struct file *file, void *fh,
+ struct v4l2_dv_enum_preset *preset);
+
+ int (*vidioc_s_dv_preset) (struct file *file, void *fh,
+ struct v4l2_dv_preset *preset);
+ int (*vidioc_g_dv_preset) (struct file *file, void *fh,
+ struct v4l2_dv_preset *preset);
+ int (*vidioc_query_dv_preset) (struct file *file, void *fh,
+ struct v4l2_dv_preset *qpreset);
+ int (*vidioc_s_dv_timings) (struct file *file, void *fh,
+ struct v4l2_dv_timings *timings);
+ int (*vidioc_g_dv_timings) (struct file *file, void *fh,
+ struct v4l2_dv_timings *timings);
+
/* For other private ioctls */
long (*vidioc_default) (struct file *file, void *fh,
int cmd, void *arg);
diff --git a/include/media/v4l2-subdev.h b/include/media/v4l2-subdev.h
index d411345..cedcc72 100644
--- a/include/media/v4l2-subdev.h
+++ b/include/media/v4l2-subdev.h
@@ -206,6 +206,19 @@ struct v4l2_subdev_audio_ops {
s_routing: see s_routing in audio_ops, except this version is for video
devices.
+
+ s_dv_preset: set dv (Digital Video) preset in the sub device. Similar to
+ s_std()
+
+ query_dv_preset: query dv preset in the sub device. This is similar to
+ querystd()
+
+ s_dv_timings(): Set custom dv timings in the sub device. This is used
+ when sub device is capable of setting detailed timing information
+ in the hardware to generate/detect the video signal.
+
+ g_dv_timings(): Get custom dv timings in the sub device.
+
*/
struct v4l2_subdev_video_ops {
int (*s_routing)(struct v4l2_subdev *sd, u32 input, u32 output, u32 config);
@@ -229,6 +242,14 @@ struct v4l2_subdev_video_ops {
int (*s_parm)(struct v4l2_subdev *sd, struct v4l2_streamparm *param);
int (*enum_framesizes)(struct v4l2_subdev *sd, struct v4l2_frmsizeenum *fsize);
int (*enum_frameintervals)(struct v4l2_subdev *sd, struct v4l2_frmivalenum *fival);
+ int (*s_dv_preset)(struct v4l2_subdev *sd,
+ struct v4l2_dv_preset *preset);
+ int (*query_dv_preset)(struct v4l2_subdev *sd,
+ struct v4l2_dv_preset *preset);
+ int (*s_dv_timings)(struct v4l2_subdev *sd,
+ struct v4l2_dv_timings *timings);
+ int (*g_dv_timings)(struct v4l2_subdev *sd,
+ struct v4l2_dv_timings *timings);
};
struct v4l2_subdev_ops {
--
1.6.0.4
^ permalink raw reply related [flat|nested] 13+ messages in thread
end of thread, other threads:[~2009-11-17 7:14 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-10-21 22:42 [PATCH] V4L: adding digital video timings APIs m-karicheri2
2009-10-21 23:04 ` Hans Verkuil
2009-10-23 20:44 ` Karicheri, Muralidharan
2009-11-05 12:56 ` Hans Verkuil
2009-11-11 7:21 ` Hans Verkuil
2009-11-11 21:47 ` Karicheri, Muralidharan
2009-11-13 18:19 ` Karicheri, Muralidharan
2009-11-16 18:35 ` Karicheri, Muralidharan
2009-11-17 7:14 ` Hans Verkuil
2009-11-11 21:45 ` Karicheri, Muralidharan
2009-11-12 6:18 ` Hans Verkuil
2009-11-12 15:34 ` Karicheri, Muralidharan
-- strict thread matches above, loose matches on Subject: below --
2009-10-21 22:40 m-karicheri2
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.