RE: [PATCH v6 3/5] mmc: davinci_mmc: add DT support

["Manjunathappa, Prakash" <prakash.pm-l0cyMroinI0@public.gmane.org>]

On Wed, Mar 27, 2013 at 16:13:51, Arnd Bergmann wrote:
> On Wednesday 27 March 2013, Manjunathappa, Prakash wrote:
> > On Wed, Mar 20, 2013 at 18:56:09, Arnd Bergmann wrote:
> > > On Wednesday 20 March 2013, Manjunathappa, Prakash wrote:
> > > > Adds device tree support for davinci_mmc. Also add binding documentation.
> > > > As of now in non-dma PIO mode and without GPIO card_detect/write_protect
> > > > option because of dependencies on EDMA and GPIO module DT support.
> > > 
> > > Shouldn't the binding at least specify the names for the DMA channels?
> > > It's fine if the driver works without those, but I think there is no
> > > strict dependency here: If dma_request_slave_channel does not find
> > > a channel, the driver can just continue in PIO mode, and as soon
> > > as the EDMA driver is merged, it will work with DMA.
> > 
> > In that case, don't I have to add support for it in driver also using
> > dma_request_slave_channel_compat? As we do not have edma support yet on
> > da850, I will not be able to test it.
> 
> The code is independent of the binding in this case. If you already know
> that the hardware supports DMA channels and you will add support in the
> code later, I would recommend writing up the binding the way it should
> be used.
> 

Ok I will add support for DMA bindings with a note saying "not tested dma capability via DT". 

Thanks,
Prakash