All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 19/28] leds-lp5521/5523: use lp55xx common deinit device function
@ 2012-10-05  8:22 Kim, Milo
  0 siblings, 0 replies; only message in thread
From: Kim, Milo @ 2012-10-05  8:22 UTC (permalink / raw)
  To: Bryan Wu; +Cc: Richard Purdie, linux-leds, linux-kernel

 Use lp55xx common function to release the device.
 Unnecessary old code lines are removed.

Signed-off-by: Milo(Woogyom) Kim <milo.kim@ti.com>
---
 drivers/leds/leds-lp5521.c |    6 +-----
 drivers/leds/leds-lp5523.c |    6 +-----
 2 files changed, 2 insertions(+), 10 deletions(-)

diff --git a/drivers/leds/leds-lp5521.c b/drivers/leds/leds-lp5521.c
index 8aa4a90..67d492c 100644
--- a/drivers/leds/leds-lp5521.c
+++ b/drivers/leds/leds-lp5521.c
@@ -528,7 +528,6 @@ err_init:
 
 static int __devexit lp5521_remove(struct i2c_client *client)
 {
-	struct lp5521_chip *old_chip = i2c_get_clientdata(client);
 	struct lp55xx_led *led = i2c_get_clientdata(client);
 	struct lp55xx_chip *chip = led->chip;
 
@@ -536,11 +535,8 @@ static int __devexit lp5521_remove(struct i2c_client *client)
 
 	lp55xx_unregister_sysfs(chip);
 	lp55xx_unregister_leds(led, chip);
+	lp55xx_deinit_device(chip);
 
-	if (old_chip->pdata->enable)
-		old_chip->pdata->enable(0);
-	if (old_chip->pdata->release_resources)
-		old_chip->pdata->release_resources();
 	return 0;
 }
 
diff --git a/drivers/leds/leds-lp5523.c b/drivers/leds/leds-lp5523.c
index b029a09..5c4f6df 100644
--- a/drivers/leds/leds-lp5523.c
+++ b/drivers/leds/leds-lp5523.c
@@ -583,7 +583,6 @@ err_init:
 
 static int lp5523_remove(struct i2c_client *client)
 {
-	struct lp5523_chip *old_chip = i2c_get_clientdata(client);
 	struct lp55xx_led *led = i2c_get_clientdata(client);
 	struct lp55xx_chip *chip = led->chip;
 
@@ -591,11 +590,8 @@ static int lp5523_remove(struct i2c_client *client)
 
 	lp55xx_unregister_sysfs(chip);
 	lp55xx_unregister_leds(led, chip);
+	lp55xx_deinit_device(chip);
 
-	if (old_chip->pdata->enable)
-		old_chip->pdata->enable(0);
-	if (old_chip->pdata->release_resources)
-		old_chip->pdata->release_resources();
 	return 0;
 }
 
-- 
1.7.9.5


Best Regards,
Milo



^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2012-10-05  8:22 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-10-05  8:22 [PATCH 19/28] leds-lp5521/5523: use lp55xx common deinit device function Kim, Milo

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.