* Re: [patch] 2.5.25 I2C driver id and Config updates boundar
@ 2002-07-11 11:23 Petr Vandrovec
0 siblings, 0 replies; only message in thread
From: Petr Vandrovec @ 2002-07-11 11:23 UTC (permalink / raw)
To: Albert Cranford; +Cc: linux-kernel
On 11 Jul 02 at 1:26, Albert Cranford wrote:
> Hello Linus,
> Could you please apply these 3 patches toward 2.5.26.
> They include Config.in updates, additions in i2c-id.h
> for "Video for Linux" and a compatibility fix for
> i2c-algo-bit.c
Hi,
is timeout field in i2c_algo_bit_data supposed to be in jiffies
(like it is currently used) or in 10ms units? If it is supposed
to be in jiffies (other algos do not care about timeout field),
there is dozen of places (all callers of i2c_bit_add_bus) which
get it wrong.
Next suspicious thing is that 'timeout' field from i2c_adapter
structure is not used at all - only i2c_control is willing to
set it, but nobody reads this field. Should not i2c_bit_add_bus
copy its timeout into this field, and then use adap->timeout instead
of bitadap->timeout in its sclhi() procedure?
Thanks,
Petr Vandrovec
vandrove@vc.cvut.cz
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2002-07-11 11:21 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-07-11 11:23 [patch] 2.5.25 I2C driver id and Config updates boundar Petr Vandrovec
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.