* [PATCH] reboot-mode: put the build artifacts in ${B}
@ 2023-03-31 12:31 Bartosz Golaszewski
2023-03-31 13:10 ` [oe] " Ross Burton
0 siblings, 1 reply; 4+ messages in thread
From: Bartosz Golaszewski @ 2023-03-31 12:31 UTC (permalink / raw)
To: Khem Raj, openembedded-devel; +Cc: Bartosz Golaszewski
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
We should output the compiled executables into ${B} and install them
from it as well. Currently we put the build objects in the source
directory. While at it: don't assume we're already in the source
directory and instead prepend the source file with ${S}.
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
meta-oe/recipes-support/reboot-mode/reboot-mode_git.bb | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/meta-oe/recipes-support/reboot-mode/reboot-mode_git.bb b/meta-oe/recipes-support/reboot-mode/reboot-mode_git.bb
index 20e77c63d..4c3436823 100644
--- a/meta-oe/recipes-support/reboot-mode/reboot-mode_git.bb
+++ b/meta-oe/recipes-support/reboot-mode/reboot-mode_git.bb
@@ -10,9 +10,9 @@ SRCREV = "84831b20512abd9033414ca5f5a023f333525335"
S = "${WORKDIR}/git"
do_compile() {
- ${CC} ${CFLAGS} ${LDFLAGS} reboot-mode.c -o reboot-mode
+ ${CC} ${CFLAGS} ${LDFLAGS} ${S}/reboot-mode.c -o ${B}/reboot-mode
}
do_install() {
- install -D -m 0755 ${S}/reboot-mode ${D}${bindir}/reboot-mode
+ install -D -m 0755 ${B}/reboot-mode ${D}${bindir}/reboot-mode
}
--
2.37.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [oe] [PATCH] reboot-mode: put the build artifacts in ${B}
2023-03-31 12:31 [PATCH] reboot-mode: put the build artifacts in ${B} Bartosz Golaszewski
@ 2023-03-31 13:10 ` Ross Burton
2023-03-31 14:10 ` Bartosz Golaszewski
0 siblings, 1 reply; 4+ messages in thread
From: Ross Burton @ 2023-03-31 13:10 UTC (permalink / raw)
To: Bartosz Golaszewski; +Cc: Khem Raj, openembeded-devel, Bartosz Golaszewski
On 31 Mar 2023, at 13:31, Bartosz Golaszewski via lists.openembedded.org <brgl=bgdev.pl@lists.openembedded.org> wrote:
>
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> We should output the compiled executables into ${B} and install them
> from it as well. Currently we put the build objects in the source
> directory. While at it: don't assume we're already in the source
> directory and instead prepend the source file with ${S}.
By default B=${S}, so this hasn’t changed anything.
Ross
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [oe] [PATCH] reboot-mode: put the build artifacts in ${B}
2023-03-31 13:10 ` [oe] " Ross Burton
@ 2023-03-31 14:10 ` Bartosz Golaszewski
2023-03-31 14:13 ` Ross Burton
0 siblings, 1 reply; 4+ messages in thread
From: Bartosz Golaszewski @ 2023-03-31 14:10 UTC (permalink / raw)
To: Ross Burton; +Cc: Khem Raj, openembeded-devel, Bartosz Golaszewski
On Fri, Mar 31, 2023 at 3:11 PM Ross Burton <Ross.Burton@arm.com> wrote:
>
> On 31 Mar 2023, at 13:31, Bartosz Golaszewski via lists.openembedded.org <brgl=bgdev.pl@lists.openembedded.org> wrote:
> >
> > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> >
> > We should output the compiled executables into ${B} and install them
> > from it as well. Currently we put the build objects in the source
> > directory. While at it: don't assume we're already in the source
> > directory and instead prepend the source file with ${S}.
>
> By default B=${S}, so this hasn’t changed anything.
>
> Ross
I'd say it's still more semantically correct, no?
Bart
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [oe] [PATCH] reboot-mode: put the build artifacts in ${B}
2023-03-31 14:10 ` Bartosz Golaszewski
@ 2023-03-31 14:13 ` Ross Burton
0 siblings, 0 replies; 4+ messages in thread
From: Ross Burton @ 2023-03-31 14:13 UTC (permalink / raw)
To: Bartosz Golaszewski; +Cc: Khem Raj, openembeded-devel, Bartosz Golaszewski
On 31 Mar 2023, at 15:10, Bartosz Golaszewski <brgl@bgdev.pl> wrote:
>
> On Fri, Mar 31, 2023 at 3:11 PM Ross Burton <Ross.Burton@arm.com> wrote:
>>
>> On 31 Mar 2023, at 13:31, Bartosz Golaszewski via lists.openembedded.org <brgl=bgdev.pl@lists.openembedded.org> wrote:
>>>
>>> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>>>
>>> We should output the compiled executables into ${B} and install them
>>> from it as well. Currently we put the build objects in the source
>>> directory. While at it: don't assume we're already in the source
>>> directory and instead prepend the source file with ${S}.
>>
>> By default B=${S}, so this hasn’t changed anything.
>>
>> Ross
>
> I'd say it's still more semantically correct, no?
Personally, I prefer to use S/B only in the case where they’re actually different directories and the latter has been wiped clean on every build.
Ross
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-03-31 14:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-31 12:31 [PATCH] reboot-mode: put the build artifacts in ${B} Bartosz Golaszewski
2023-03-31 13:10 ` [oe] " Ross Burton
2023-03-31 14:10 ` Bartosz Golaszewski
2023-03-31 14:13 ` Ross Burton
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.