All of lore.kernel.org
 help / color / mirror / Atom feed
From: Felipe Contreras <felipe.contreras@gmail.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: linux-usb <linux-usb@vger.kernel.org>,
	linux-main <linux-kernel@vger.kernel.org>,
	linux-omap <linux-omap@vger.kernel.org>,
	Felipe Balbi <balbi@ti.com>, Greg KH <greg@kroah.com>,
	Samuel Ortiz <sameo@linux.intel.com>,
	Liam Girdwood <lrg@slimlogic.co.uk>,
	Mark Brown <broonie@opensource.wolfsonmicro.com>,
	David Brownell <dbrownell@users.sourceforge.net>,
	Greg Kroah-Hartman <gregkh@suse.de>, Hao Wu <hao.wu@intel.com>,
	Alan Cox <alan@linux.intel.com>,
	Mike Rapoport <mike@compulab.co.il>
Subject: Re: [PATCH v3 2/2] drivers: cleanup Kconfig stuff
Date: Tue, 2 Nov 2010 16:23:22 +0200	[thread overview]
Message-ID: <AANLkTi=4hi-zNSFPvHnTEPeweTuqUwni+Aij_E6Zj8i5@mail.gmail.com> (raw)
In-Reply-To: <20101102141456.GV31158@pengutronix.de>

2010/11/2 Uwe Kleine-König <u.kleine-koenig@pengutronix.de>:
> On Tue, Nov 02, 2010 at 02:14:13AM +0200, Felipe Contreras wrote:
>> Add missing dependencies, and remove redundant ones, and select sensible
>> defaults.
>>
>> This is more user-friendly, and logical.
>>
>>  - TWL4030_CORE people should be able to compile without ARM
>>  - REGULATOR_TWL4030 if TWL4030_CORE and REGULATOR, it's pretty clear we
>>    want this
>>  - USB_GADGET_SELECTED is already inside USB_GADGET
>>  - USB_GADGET_OMAP only works on ARCH_OMAP1, and USB_OTG_UTILS is
>>    already selected by NOP_USB_XCEIV
>>  - USB_GADGET_R8A66597 is meant for ARCH_SHMOBILE
>>  - USB_MUSB_HDRC needs either NOP_USB_XCEIV, or TWL4030_USB
>>  - USB_MUSB_AM35X, NOP_USB_XCEIV is already selected because MACH_OMAP3EVM
>>
>> Finally, move:
>> config USB_MUSB_HDRC
>>       select NOP_USB_XCEIV if (ARCH_DAVINCI || MACH_OMAP3EVM || BLACKFIN)
>>       select TWL4030_USB if MACH_OMAP_3430SDP
>>
>> To:
>> config TWL4030_USB
>>       default y if ARCH_OMAP3
>>
>> config NOP_USB_XCEIV
>>       default y if ARCH_DAVINCI || MACH_OMAP3EVM || BLACKFIN
>>
>> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
> All changes look fine to me, but I think you will need to split up this
> patch for the different subsystem maintainers.

Ok, will do.

-- 
Felipe Contreras

WARNING: multiple messages have this Message-ID (diff)
From: Felipe Contreras <felipe.contreras-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: "Uwe Kleine-König"
	<u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Cc: linux-usb <linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	linux-main <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	linux-omap <linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>,
	Greg KH <greg-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>,
	Samuel Ortiz <sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
	Liam Girdwood <lrg-kDsPt+C1G03kYMGBc/C6ZA@public.gmane.org>,
	Mark Brown
	<broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>,
	David Brownell
	<dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>,
	Greg Kroah-Hartman <gregkh-l3A5Bk7waGM@public.gmane.org>,
	Hao Wu <hao.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	Alan Cox <alan-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
	Mike Rapoport <mike-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
Subject: Re: [PATCH v3 2/2] drivers: cleanup Kconfig stuff
Date: Tue, 2 Nov 2010 16:23:22 +0200	[thread overview]
Message-ID: <AANLkTi=4hi-zNSFPvHnTEPeweTuqUwni+Aij_E6Zj8i5@mail.gmail.com> (raw)
In-Reply-To: <20101102141456.GV31158-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>

2010/11/2 Uwe Kleine-König <u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>:
> On Tue, Nov 02, 2010 at 02:14:13AM +0200, Felipe Contreras wrote:
>> Add missing dependencies, and remove redundant ones, and select sensible
>> defaults.
>>
>> This is more user-friendly, and logical.
>>
>>  - TWL4030_CORE people should be able to compile without ARM
>>  - REGULATOR_TWL4030 if TWL4030_CORE and REGULATOR, it's pretty clear we
>>    want this
>>  - USB_GADGET_SELECTED is already inside USB_GADGET
>>  - USB_GADGET_OMAP only works on ARCH_OMAP1, and USB_OTG_UTILS is
>>    already selected by NOP_USB_XCEIV
>>  - USB_GADGET_R8A66597 is meant for ARCH_SHMOBILE
>>  - USB_MUSB_HDRC needs either NOP_USB_XCEIV, or TWL4030_USB
>>  - USB_MUSB_AM35X, NOP_USB_XCEIV is already selected because MACH_OMAP3EVM
>>
>> Finally, move:
>> config USB_MUSB_HDRC
>>       select NOP_USB_XCEIV if (ARCH_DAVINCI || MACH_OMAP3EVM || BLACKFIN)
>>       select TWL4030_USB if MACH_OMAP_3430SDP
>>
>> To:
>> config TWL4030_USB
>>       default y if ARCH_OMAP3
>>
>> config NOP_USB_XCEIV
>>       default y if ARCH_DAVINCI || MACH_OMAP3EVM || BLACKFIN
>>
>> Signed-off-by: Felipe Contreras <felipe.contreras-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> All changes look fine to me, but I think you will need to split up this
> patch for the different subsystem maintainers.

Ok, will do.

-- 
Felipe Contreras
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2010-11-02 14:23 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-02  0:14 [PATCH v3 0/2] usb: generic Kconfig fixes Felipe Contreras
2010-11-02  0:14 ` Felipe Contreras
2010-11-02  0:14 ` [PATCH v3 1/2] usb: trivial Kconfig cleanups Felipe Contreras
2010-11-02  0:14   ` Felipe Contreras
2010-11-02  0:14 ` [PATCH v3 2/2] drivers: cleanup Kconfig stuff Felipe Contreras
2010-11-02  0:14   ` Felipe Contreras
2010-11-02 13:11   ` Mark Brown
2010-11-02 13:11     ` Mark Brown
2010-11-02 14:02     ` Felipe Contreras
2010-11-02 14:02       ` Felipe Contreras
2010-11-02 14:12       ` Uwe Kleine-König
2010-11-02 14:12         ` Uwe Kleine-König
2010-11-02 14:18         ` Felipe Contreras
2010-11-02 14:18           ` Felipe Contreras
2010-11-02 14:39           ` Mark Brown
2010-11-02 14:39             ` Mark Brown
2010-11-02 19:46             ` Felipe Contreras
2010-11-02 20:34               ` Mark Brown
2010-11-02 14:35       ` Mark Brown
2010-11-02 19:43         ` Felipe Contreras
2010-11-02 19:43           ` Felipe Contreras
2010-11-02 20:26           ` Mark Brown
2010-11-02 14:14   ` Uwe Kleine-König
2010-11-02 14:14     ` Uwe Kleine-König
2010-11-02 14:23     ` Felipe Contreras [this message]
2010-11-02 14:23       ` Felipe Contreras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='AANLkTi=4hi-zNSFPvHnTEPeweTuqUwni+Aij_E6Zj8i5@mail.gmail.com' \
    --to=felipe.contreras@gmail.com \
    --cc=alan@linux.intel.com \
    --cc=balbi@ti.com \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=dbrownell@users.sourceforge.net \
    --cc=greg@kroah.com \
    --cc=gregkh@suse.de \
    --cc=hao.wu@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=lrg@slimlogic.co.uk \
    --cc=mike@compulab.co.il \
    --cc=sameo@linux.intel.com \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.