All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Gardiner <bengardiner@nanometrics.ca>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] da850evm: basic MII EMAC support
Date: Mon, 13 Sep 2010 08:55:47 -0400	[thread overview]
Message-ID: <AANLkTi=8SjPakU9tRa6+9kuRrXMgHt2VVN+cVtE7dcJB@mail.gmail.com> (raw)
In-Reply-To: <201009110001.40659.vapier@gentoo.org>

Hi Mike,

On Sat, Sep 11, 2010 at 12:01 AM, Mike Frysinger <vapier@gentoo.org> wrote:
> On Friday, September 10, 2010 16:10:16 Ben Gardiner wrote:
>> The current da850evm support in u-boot/master [1] omits any use of
>> the davinci EMAC. This patch adds basic support for the EMAC using
>> the MII PHY found on the baseboard of the EVM. The MAC address is
>> read from the environment variable 'ethadd'. Note that this is
>> different from the da850evm support in the u-boot omapl1 tree
>> where the MAC address is read from SPI flash [2].
>>
>> CC: Sandeep Paulraj <s-paulraj@ti.com>
>> CC: Sudhakar Rajashekhara <sudhakar.raj@ti.com>
>
> where is your sign-off-by ? ?patches cant be merged without it.

Right. My mistake, sorry.

>> [1] http://git.denx.de/?p=u-boot.git
>> [2] http://arago-project.org/git/projects/?p=u-boot-omapl1.git
>
> these URLs are useless. ?just drop them.

Thanks for the feedback on these -- I have been wondering whether URL
footnotes were desirable in commit messages. I put them there since I
can remember that it is sometimes difficult to find the trees that are
being referred to when you are a newcomer.  Would SHA1's and/or git
URLs be more acceptable? Or is the point that nothing before the '---'
should have links?

Best Regards,
Ben Gardiner

---
Nanometrics Inc.
http://www.nanometrics.ca

  reply	other threads:[~2010-09-13 12:55 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-10 20:10 [U-Boot] [PATCH] da850evm: basic MII EMAC support Ben Gardiner
2010-09-11  4:01 ` Mike Frysinger
2010-09-13 12:55   ` Ben Gardiner [this message]
2010-09-14 13:00     ` Mike Frysinger
2010-09-14 13:07       ` Ben Gardiner
2010-09-13  3:45 ` Ben Warren
2010-09-13 13:07   ` Ben Gardiner
2010-09-13 13:16     ` Ben Warren
2010-09-13 21:04       ` [U-Boot] [PATCH v2 0/2] da850evm " Ben Gardiner
2010-09-13 21:04         ` [U-Boot] [PATCH v2 1/2] davinci_emac: davinci_eth_set_mac_addr to ->write_hwaddr Ben Gardiner
2010-09-14  8:37           ` Nick Thompson
2010-09-13 21:04         ` [U-Boot] [PATCH v2 2/2] da850evm: basic MII EMAC support Ben Gardiner
2010-09-22 17:16         ` [U-Boot] [PATCH v3 0/2][NEXT] da850evm " Ben Gardiner
2010-09-22 17:16           ` [U-Boot] [PATCH v3 1/2][NEXT] davinci_emac: davinci_eth_set_mac_addr to ->write_hwaddr Ben Gardiner
2010-09-22 17:16           ` [U-Boot] [PATCH v3 2/2][NEXT] da850evm: basic MII EMAC support Ben Gardiner
2010-09-22 18:21             ` Mike Frysinger
2010-09-22 18:38               ` Ben Gardiner
2010-09-22 18:44           ` [U-Boot] [PATCH v4 0/2][NEXT] da850evm " Ben Gardiner
2010-09-22 18:44             ` [U-Boot] [PATCH v4 1/2][NEXT] davinci_emac: davinci_eth_set_mac_addr to ->write_hwaddr Ben Gardiner
2010-09-23  9:03               ` Nick Thompson
2010-09-23 13:24                 ` Ben Gardiner
2010-09-22 18:44             ` [U-Boot] [PATCH v4 2/2][NEXT] da850evm: basic MII EMAC support Ben Gardiner
2010-09-23 13:33             ` [U-Boot] [PATCH v5 0/2][NEXT] da850evm " Ben Gardiner
2010-09-23 13:33               ` [U-Boot] [PATCH v5 1/2][NEXT] davinci_emac: davinci_eth_set_mac_addr to ->write_hwaddr Ben Gardiner
2010-09-23 13:49                 ` Nick Thompson
2010-09-23 13:53                   ` Ben Gardiner
2010-09-23 13:39               ` [U-Boot] [PATCH v5 2/2][NEXT] da850evm: basic MII EMAC support Ben Gardiner
2010-09-23 13:58               ` [U-Boot] [PATCH v6 0/2][NEXT] da850evm " Ben Gardiner
2010-09-23 13:58                 ` [U-Boot] [PATCH v6 1/2][NEXT] davinci_emac: davinci_eth_set_mac_addr to ->write_hwaddr Ben Gardiner
2010-10-12  6:11                   ` Ben Warren
2010-09-23 13:59                 ` [U-Boot] [PATCH v6 2/2][NEXT] da850evm: basic MII EMAC support Ben Gardiner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='AANLkTi=8SjPakU9tRa6+9kuRrXMgHt2VVN+cVtE7dcJB@mail.gmail.com' \
    --to=bengardiner@nanometrics.ca \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.