All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Warren <biggerbadderben@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] da850evm: basic MII EMAC support
Date: Mon, 13 Sep 2010 06:16:00 -0700	[thread overview]
Message-ID: <AANLkTimFGbXfzds+NQNvaBT0HuCaJCbCHm6G1+hN6HKu@mail.gmail.com> (raw)
In-Reply-To: <AANLkTinhAvE=0+Je422ghR3nhxrs7SGaU3Cv5zHRGw3p@mail.gmail.com>

Hi Ben,

On Monday, September 13, 2010, Ben Gardiner <bengardiner@nanometrics.ca> wrote:
> Hi Ben,
>
> On Sun, Sep 12, 2010 at 11:45 PM, Ben Warren <biggerbadderben@gmail.com> wrote:
>> Please consider doing this differently. ?If you change the driver to make
>> 'davinci_eth_set_mac_addr()' meet the signature of
>> 'eth_device->write_hwaddr()', all the environment handling is done
>> automagically. ?Let me know if you're confused and I'll provide more
>> guidance.
>
> Thanks for pointing me in the right direction here. I think I get it
> now; please correct me if I am wrong: board_eth_init should assign the
> eth_device->write_hwaddr() function pointer then eth_initialize() will
> handle calling board_eth_init and will set the MAC address from the
> ethaddr env var if the MAC address in the eth_device struct is
> all-zeroes.
>
Almost.  The driver should set the function pointer, just as it does
'send()', 'init()', 'halt()', etc.  This is a recent feature and the
davinci driver hasn't been updated yet
> Best Regards,
> Ben Gardiner
>
> ---
> Nanometrics Inc.
> http://www.nanometrics.ca

Regards,
Ben

  reply	other threads:[~2010-09-13 13:16 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-10 20:10 [U-Boot] [PATCH] da850evm: basic MII EMAC support Ben Gardiner
2010-09-11  4:01 ` Mike Frysinger
2010-09-13 12:55   ` Ben Gardiner
2010-09-14 13:00     ` Mike Frysinger
2010-09-14 13:07       ` Ben Gardiner
2010-09-13  3:45 ` Ben Warren
2010-09-13 13:07   ` Ben Gardiner
2010-09-13 13:16     ` Ben Warren [this message]
2010-09-13 21:04       ` [U-Boot] [PATCH v2 0/2] da850evm " Ben Gardiner
2010-09-13 21:04         ` [U-Boot] [PATCH v2 1/2] davinci_emac: davinci_eth_set_mac_addr to ->write_hwaddr Ben Gardiner
2010-09-14  8:37           ` Nick Thompson
2010-09-13 21:04         ` [U-Boot] [PATCH v2 2/2] da850evm: basic MII EMAC support Ben Gardiner
2010-09-22 17:16         ` [U-Boot] [PATCH v3 0/2][NEXT] da850evm " Ben Gardiner
2010-09-22 17:16           ` [U-Boot] [PATCH v3 1/2][NEXT] davinci_emac: davinci_eth_set_mac_addr to ->write_hwaddr Ben Gardiner
2010-09-22 17:16           ` [U-Boot] [PATCH v3 2/2][NEXT] da850evm: basic MII EMAC support Ben Gardiner
2010-09-22 18:21             ` Mike Frysinger
2010-09-22 18:38               ` Ben Gardiner
2010-09-22 18:44           ` [U-Boot] [PATCH v4 0/2][NEXT] da850evm " Ben Gardiner
2010-09-22 18:44             ` [U-Boot] [PATCH v4 1/2][NEXT] davinci_emac: davinci_eth_set_mac_addr to ->write_hwaddr Ben Gardiner
2010-09-23  9:03               ` Nick Thompson
2010-09-23 13:24                 ` Ben Gardiner
2010-09-22 18:44             ` [U-Boot] [PATCH v4 2/2][NEXT] da850evm: basic MII EMAC support Ben Gardiner
2010-09-23 13:33             ` [U-Boot] [PATCH v5 0/2][NEXT] da850evm " Ben Gardiner
2010-09-23 13:33               ` [U-Boot] [PATCH v5 1/2][NEXT] davinci_emac: davinci_eth_set_mac_addr to ->write_hwaddr Ben Gardiner
2010-09-23 13:49                 ` Nick Thompson
2010-09-23 13:53                   ` Ben Gardiner
2010-09-23 13:39               ` [U-Boot] [PATCH v5 2/2][NEXT] da850evm: basic MII EMAC support Ben Gardiner
2010-09-23 13:58               ` [U-Boot] [PATCH v6 0/2][NEXT] da850evm " Ben Gardiner
2010-09-23 13:58                 ` [U-Boot] [PATCH v6 1/2][NEXT] davinci_emac: davinci_eth_set_mac_addr to ->write_hwaddr Ben Gardiner
2010-10-12  6:11                   ` Ben Warren
2010-09-23 13:59                 ` [U-Boot] [PATCH v6 2/2][NEXT] da850evm: basic MII EMAC support Ben Gardiner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AANLkTimFGbXfzds+NQNvaBT0HuCaJCbCHm6G1+hN6HKu@mail.gmail.com \
    --to=biggerbadderben@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.