[PATCH] mv_xor: fix race in tasklet function

[PATCH] mv_xor: fix race in tasklet function

[Saeed Bishara]

use mv_xor_slot_cleanup() instead of __mv_xor_slot_cleanup() as the former function
aquires the spin lock that needed to protect the drivers data.

Signed-off-by: Saeed Bishara <saeed@marvell.com>
---
 drivers/dma/mv_xor.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/dma/mv_xor.c b/drivers/dma/mv_xor.c
index 411d5bf..a25f5f6 100644
--- a/drivers/dma/mv_xor.c
+++ b/drivers/dma/mv_xor.c
@@ -449,7 +449,7 @@ mv_xor_slot_cleanup(struct mv_xor_chan *mv_chan)
 static void mv_xor_tasklet(unsigned long data)
 {
 	struct mv_xor_chan *chan = (struct mv_xor_chan *) data;
-	__mv_xor_slot_cleanup(chan);
+	mv_xor_slot_cleanup(chan);
 }
 
 static struct mv_xor_desc_slot *
-- 
1.6.0.4

Re: [PATCH] mv_xor: fix race in tasklet function

[saeed bishara]

Dan, can you please merge this patch?

On Tue, Dec 21, 2010 at 4:53 PM, Saeed Bishara <saeed@marvell.com> wrote:
> use mv_xor_slot_cleanup() instead of __mv_xor_slot_cleanup() as the former function
> aquires the spin lock that needed to protect the drivers data.
>
> Signed-off-by: Saeed Bishara <saeed@marvell.com>
> ---
>  drivers/dma/mv_xor.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/dma/mv_xor.c b/drivers/dma/mv_xor.c
> index 411d5bf..a25f5f6 100644
> --- a/drivers/dma/mv_xor.c
> +++ b/drivers/dma/mv_xor.c
> @@ -449,7 +449,7 @@ mv_xor_slot_cleanup(struct mv_xor_chan *mv_chan)
>  static void mv_xor_tasklet(unsigned long data)
>  {
>        struct mv_xor_chan *chan = (struct mv_xor_chan *) data;
> -       __mv_xor_slot_cleanup(chan);
> +       mv_xor_slot_cleanup(chan);
>  }
>
>  static struct mv_xor_desc_slot *
> --
> 1.6.0.4
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html