[PATCH 0/2] 3 build failures in imx-for-2.6.39

[PATCH 0/2] 3 build failures in imx-for-2.6.39

[Uwe Kleine-König]

Hello,

currently there are 3 build failures in Sascha's imx-for-2.6.39 branch.
Two of them are fixed in this series, I didn't find motivation to fix
the third (in mx51_defconfig):

	arch/arm/mach-mx5/built-in.o: In function `efika_board_common_init':
	board-mx51_efikamx.c:(.init.text+0x1384): undefined reference to `otg_ulpi_create'
	board-mx51_efikamx.c:(.init.text+0x1430): undefined reference to `mxc_ulpi_access_ops'

I guess there are some #ifdefs missing somewhere.

I talked shortly to Sascha about it and we both think that these #ifdefs
are ugly and a better fix is needed here. (E.g. providing dummys for
the used functions. But I didn't look into that yet.)

For the two patches in this series I'd suggest to squash them in the
offending commits, but that's up to Sascha to decide.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-K?nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

[PATCH 1/2] ARM: mx3/cpuimx35: fix build failure

[Uwe Kleine-König]

It seems vim's autocompletion played tricks on me without me noticing.
This was intruduced in
	97976e2 (ARM: mx3: use .init_early to initialize cpu type, reset address and iomuxer)

Signed-off-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
---
 arch/arm/mach-mx3/mach-cpuimx35.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-mx3/mach-cpuimx35.c b/arch/arm/mach-mx3/mach-cpuimx35.c
index a42f1a9..ec63d99 100644
--- a/arch/arm/mach-mx3/mach-cpuimx35.c
+++ b/arch/arm/mach-mx3/mach-cpuimx35.c
@@ -196,7 +196,7 @@ MACHINE_START(EUKREA_CPUIMX35, "Eukrea CPUIMX35")
 	/* Maintainer: Eukrea Electromatique */
 	.boot_params = MX3x_PHYS_OFFSET + 0x100,
 	.map_io = mx35_map_io,
-	.init_ext3_fs = imx35_init_early,
+	.init_early = imx35_init_early,
 	.init_irq = mx35_init_irq,
 	.timer = &eukrea_cpuimx35_timer,
 	.init_machine = eukrea_cpuimx35_init,
-- 
1.7.2.3

[PATCH 2/2] ARM: mx3/pcm043: fix build failure

[Uwe Kleine-König]

Commit

	530aca5 (arm: mach-mx3: pcm043: add write-protect and card-detect for SD1)

assigned a non-existing member .cd_gpio in a struct esdhc_platform_data.
Though I expect this to change soon I remove it for now to unbreak the
autobuilders.

Cc: Wolfram Sang <w.sang@pengutronix.de>
Signed-off-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
---
 arch/arm/mach-mx3/mach-pcm043.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/arch/arm/mach-mx3/mach-pcm043.c b/arch/arm/mach-mx3/mach-pcm043.c
index 3a7b3c3..b5ee66e 100644
--- a/arch/arm/mach-mx3/mach-pcm043.c
+++ b/arch/arm/mach-mx3/mach-pcm043.c
@@ -227,7 +227,6 @@ static iomux_v3_cfg_t pcm043_pads[] = {
 #define AC97_GPIO_RESET	IMX_GPIO_NR(2, 0)
 
 #define SD1_GPIO_WP	IMX_GPIO_NR(2, 23)
-#define SD1_GPIO_CD	IMX_GPIO_NR(2, 24)
 
 static void pcm043_ac97_warm_reset(struct snd_ac97 *ac97)
 {
@@ -313,7 +312,6 @@ pcm037_nand_board_info __initconst = {
 
 static struct esdhc_platform_data sd1_pdata = {
 	.wp_gpio = SD1_GPIO_WP,
-	.cd_gpio = SD1_GPIO_CD,
 };
 
 #if defined(CONFIG_USB_ULPI)
-- 
1.7.2.3

[PATCH 1/2] ARM: mx3/cpuimx35: fix build failure

[Russell King - ARM Linux]

On Tue, Mar 01, 2011 at 09:30:58PM +0100, Uwe Kleine-K?nig wrote:
> It seems vim's autocompletion played tricks on me without me noticing.

Every time I hear the word 'autocompletion' it's always associated with
the wrong thing happening.  I really don't know why people even bother
with 'autocompletion' because it seems to go wrong very often.  Whether
it be with code, or with nicknames on IRC...

The only autocompletion that I've seen which works right and avoids these
kinds of issues is in things like bash, where it won't autocomplete unless
there is exactly one completion available.

[PATCH 1/2] ARM: mx3/cpuimx35: fix build failure

[Uwe Kleine-König]

Hi Russell,

On Tue, Mar 01, 2011 at 08:37:34PM +0000, Russell King - ARM Linux wrote:
> On Tue, Mar 01, 2011 at 09:30:58PM +0100, Uwe Kleine-K?nig wrote:
> > It seems vim's autocompletion played tricks on me without me noticing.
> 
> Every time I hear the word 'autocompletion' it's always associated with
> the wrong thing happening.  I really don't know why people even bother
> with 'autocompletion' because it seems to go wrong very often.  Whether
> it be with code, or with nicknames on IRC...
> 
> The only autocompletion that I've seen which works right and avoids these
> kinds of issues is in things like bash, where it won't autocomplete unless
> there is exactly one completion available.
Yeah, for vim autocompletion is "pop up a menu of possibilities and
already select the first one".
Still I consider the real problem to be "without me noticing".

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-K?nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

[PATCH 2/2] ARM: mx3/pcm043: fix build failure

[Fabio Estevam]

Hallo Uwe,

2011/3/1 Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>:
> Commit
>
> ? ? ? ?530aca5 (arm: mach-mx3: pcm043: add write-protect and card-detect for SD1)
>
> assigned a non-existing member .cd_gpio in a struct esdhc_platform_data.
> Though I expect this to change soon I remove it for now to unbreak the
> autobuilders.

Same error happens on mx25_3ds. Would you like me to send a patch for
fixing it for mx25_3ds too?

Regards,

Fabio Estevam