[PATCH] Drop trailing newline from DBG() calls

[PATCH] Drop trailing newline from DBG() calls

[Anderson Lizardo]

---
 audio/telephony-ofono.c |    2 +-
 plugins/service.c       |    4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/audio/telephony-ofono.c b/audio/telephony-ofono.c
index 0a7f0bd..b9fb0f1 100644
--- a/audio/telephony-ofono.c
+++ b/audio/telephony-ofono.c
@@ -1116,7 +1116,7 @@ static void get_modems_reply(DBusPendingCall *call, void *user_data)
 	DBusMessage *reply;
 	DBusMessageIter iter, entry;
 
-	DBG("list_modem_reply is called\n");
+	DBG("list_modem_reply is called");
 	reply = dbus_pending_call_steal_reply(call);
 
 	dbus_error_init(&err);
diff --git a/plugins/service.c b/plugins/service.c
index f44aa92..4e4db81 100644
--- a/plugins/service.c
+++ b/plugins/service.c
@@ -172,13 +172,13 @@ static void element_end(GMarkupParseContext *context,
 			int ret = sdp_attr_add(ctx_data->record, ctx_data->attr_id,
 							ctx_data->stack_head->data);
 			if (ret == -1)
-				DBG("Trouble adding attribute\n");
+				DBG("Trouble adding attribute");
 
 			ctx_data->stack_head->data = NULL;
 			sdp_xml_data_free(ctx_data->stack_head);
 			ctx_data->stack_head = NULL;
 		} else {
-			DBG("No data for attribute 0x%04x\n", ctx_data->attr_id);
+			DBG("No data for attribute 0x%04x", ctx_data->attr_id);
 		}
 		return;
 	}
-- 
1.7.0.4

[PATCH] Fix DBG() calls with bogus messages

[Anderson Lizardo]

Remove unnecessary trailing newlines (already added by DBG()) and
rewrite debug messages to become more useful.
---
 audio/telephony-ofono.c |    2 +-
 plugins/service.c       |    5 +++--
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/audio/telephony-ofono.c b/audio/telephony-ofono.c
index 0a7f0bd..ef4ede7 100644
--- a/audio/telephony-ofono.c
+++ b/audio/telephony-ofono.c
@@ -1116,7 +1116,7 @@ static void get_modems_reply(DBusPendingCall *call, void *user_data)
 	DBusMessage *reply;
 	DBusMessageIter iter, entry;
 
-	DBG("list_modem_reply is called\n");
+	DBG("");
 	reply = dbus_pending_call_steal_reply(call);
 
 	dbus_error_init(&err);
diff --git a/plugins/service.c b/plugins/service.c
index f44aa92..d73cdea 100644
--- a/plugins/service.c
+++ b/plugins/service.c
@@ -172,13 +172,14 @@ static void element_end(GMarkupParseContext *context,
 			int ret = sdp_attr_add(ctx_data->record, ctx_data->attr_id,
 							ctx_data->stack_head->data);
 			if (ret == -1)
-				DBG("Trouble adding attribute\n");
+				DBG("Could not add attribute 0x%04x",
+							ctx_data->attr_id);
 
 			ctx_data->stack_head->data = NULL;
 			sdp_xml_data_free(ctx_data->stack_head);
 			ctx_data->stack_head = NULL;
 		} else {
-			DBG("No data for attribute 0x%04x\n", ctx_data->attr_id);
+			DBG("No data for attribute 0x%04x", ctx_data->attr_id);
 		}
 		return;
 	}
-- 
1.7.0.4

Re: [PATCH] Drop trailing newline from DBG() calls

[Anderson Lizardo]

Hi Johan,

On Wed, Feb 23, 2011 at 10:28 AM, Anderson Lizardo
<anderson.lizardo@openbossa.org> wrote:
> ---
>  audio/telephony-ofono.c |    2 +-
>  plugins/service.c       |    4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)

Please ignore this patch, it was superseded by the one titled "Fix
DBG() calls with bogus messages".

Regards,
-- 
Anderson Lizardo
Instituto Nokia de Tecnologia - INdT
Manaus - Brazil

Re: [PATCH] Fix DBG() calls with bogus messages

[Johan Hedberg]

Hi Lizardo,

On Wed, Feb 23, 2011, Anderson Lizardo wrote:
> Remove unnecessary trailing newlines (already added by DBG()) and
> rewrite debug messages to become more useful.
> ---
>  audio/telephony-ofono.c |    2 +-
>  plugins/service.c       |    5 +++--
>  2 files changed, 4 insertions(+), 3 deletions(-)

Pushed upstream. Thanks.

Johan