[PATCH 1/2] regulator: twl: add clk32kg to twl-regulator

[PATCH 1/2] regulator: twl: add clk32kg to twl-regulator

[Balaji T K]

In OMAP4 Blaze and Panda, 32KHz clock to WLAN is supplied from Phoenix TWL6030.
The 32KHz clock state (ON/OFF) is configured in CLK32KG_CFG_[GRP, TRANS, STATE]
register. This follows the same register programming model as other regulators
in TWL6030. So add CLK32KG as pseudo regulator.

Signed-off-by: Balaji T K <balajitk@ti.com>
---
 drivers/mfd/twl-core.c            |    4 ++++
 drivers/regulator/twl-regulator.c |    3 ++-
 include/linux/i2c/twl.h           |    2 ++
 3 files changed, 8 insertions(+), 1 deletions(-)

diff --git a/drivers/mfd/twl-core.c b/drivers/mfd/twl-core.c
index a35fa7d..7d909cc 100644
--- a/drivers/mfd/twl-core.c
+++ b/drivers/mfd/twl-core.c
@@ -864,6 +864,10 @@ add_children(struct twl4030_platform_data *pdata, unsigned long features)
 		child = add_regulator(TWL6030_REG_VAUX3_6030, pdata->vaux3);
 		if (IS_ERR(child))
 			return PTR_ERR(child);
+
+		child = add_regulator(TWL6030_REG_CLK32KG, pdata->clk32kg);
+		if (IS_ERR(child))
+			return PTR_ERR(child);
 	}
 
 	if (twl_has_bci() && pdata->bci &&
diff --git a/drivers/regulator/twl-regulator.c b/drivers/regulator/twl-regulator.c
index bd332cf..425f1fa 100644
--- a/drivers/regulator/twl-regulator.c
+++ b/drivers/regulator/twl-regulator.c
@@ -577,7 +577,8 @@ static struct twlreg_info twl_regs[] = {
 	TWL6030_FIXED_LDO(VANA, 0x50, 2100, 15, 0, 0x21),
 	TWL6030_FIXED_LDO(VCXIO, 0x60, 1800, 16, 0, 0x21),
 	TWL6030_FIXED_LDO(VDAC, 0x64, 1800, 17, 0, 0x21),
-	TWL6030_FIXED_LDO(VUSB, 0x70, 3300, 18, 0, 0x21)
+	TWL6030_FIXED_LDO(VUSB, 0x70, 3300, 18, 0, 0x21),
+	TWL6030_FIXED_LDO(CLK32KG, 0x8C, 1000, 48, 0, 0x21),
 };
 
 static int __devinit twlreg_probe(struct platform_device *pdev)
diff --git a/include/linux/i2c/twl.h b/include/linux/i2c/twl.h
index 61b9609..7086e1e 100644
--- a/include/linux/i2c/twl.h
+++ b/include/linux/i2c/twl.h
@@ -698,6 +698,7 @@ struct twl4030_platform_data {
 	struct regulator_init_data              *vana;
 	struct regulator_init_data              *vcxio;
 	struct regulator_init_data              *vusb;
+	struct regulator_init_data		*clk32kg;
 };
 
 /*----------------------------------------------------------------------*/
@@ -777,5 +778,6 @@ static inline int twl4030charger_usb_en(int enable) { return 0; }
 
 /* INTERNAL LDOs */
 #define TWL6030_REG_VRTC	47
+#define TWL6030_REG_CLK32KG	48
 
 #endif /* End of __TWL4030_H */
-- 
1.7.0.4

Re: [PATCH 1/2] regulator: twl: add clk32kg to twl-regulator

[Mark Brown]

On Wed, Feb 09, 2011 at 09:07:25PM +0530, Balaji T K wrote:

> -	TWL6030_FIXED_LDO(VUSB, 0x70, 3300, 18, 0, 0x21)
> +	TWL6030_FIXED_LDO(VUSB, 0x70, 3300, 18, 0, 0x21),
> +	TWL6030_FIXED_LDO(CLK32KG, 0x8C, 1000, 48, 0, 0x21),

It'd seem better to implement a version of this that just doesn't have
the voltage readback operation rather than putting in a dummy voltage.
Otherwise this looks good.

Re: [PATCH 1/2] regulator: twl: add clk32kg to twl-regulator

[Krishnamoorthy, Balaji T]

On Wed, Feb 9, 2011 at 9:14 PM, Mark Brown
<broonie@opensource.wolfsonmicro.com> wrote:
> On Wed, Feb 09, 2011 at 09:07:25PM +0530, Balaji T K wrote:
>
>> -     TWL6030_FIXED_LDO(VUSB, 0x70, 3300, 18, 0, 0x21)
>> +     TWL6030_FIXED_LDO(VUSB, 0x70, 3300, 18, 0, 0x21),
>> +     TWL6030_FIXED_LDO(CLK32KG, 0x8C, 1000, 48, 0, 0x21),
>
> It'd seem better to implement a version of this that just doesn't have
> the voltage readback operation rather than putting in a dummy voltage.
> Otherwise this looks good.
>

yes, will do that.
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html