* [PATCH] i2c-mv64xxx: use subsys_initcall for early initialization
@ 2010-09-12 9:35 Mike Rapoport
[not found] ` <1284284129-28105-1-git-send-email-mike-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
0 siblings, 1 reply; 7+ messages in thread
From: Mike Rapoport @ 2010-09-12 9:35 UTC (permalink / raw)
To: ben-linux-elnMNo+KYs3YtjvyW6yDsg
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA, Mike Rapoport
Signed-off-by: Mike Rapoport <mike-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
---
drivers/i2c/busses/i2c-mv64xxx.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/i2c/busses/i2c-mv64xxx.c b/drivers/i2c/busses/i2c-mv64xxx.c
index 1624206..6f3d084 100644
--- a/drivers/i2c/busses/i2c-mv64xxx.c
+++ b/drivers/i2c/busses/i2c-mv64xxx.c
@@ -592,7 +592,7 @@ mv64xxx_i2c_exit(void)
platform_driver_unregister(&mv64xxx_i2c_driver);
}
-module_init(mv64xxx_i2c_init);
+subsys_initcall(mv64xxx_i2c_init);
module_exit(mv64xxx_i2c_exit);
MODULE_AUTHOR("Mark A. Greer <mgreer-Igf4POYTYCDQT0dZR+AlfA@public.gmane.org>");
--
1.6.6.2
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] i2c-mv64xxx: use subsys_initcall for early initialization
[not found] ` <1284284129-28105-1-git-send-email-mike-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
@ 2010-09-14 23:25 ` Ben Dooks
[not found] ` <20100914232547.GD7494-SMNkleLxa3Z6Wcw2j4pizdi2O/JbrIOy@public.gmane.org>
0 siblings, 1 reply; 7+ messages in thread
From: Ben Dooks @ 2010-09-14 23:25 UTC (permalink / raw)
To: Mike Rapoport
Cc: ben-linux-elnMNo+KYs3YtjvyW6yDsg, linux-i2c-u79uwXL29TY76Z2rM5mHXA
On Sun, Sep 12, 2010 at 11:35:29AM +0200, Mike Rapoport wrote:
> Signed-off-by: Mike Rapoport <mike-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
> ---
> drivers/i2c/busses/i2c-mv64xxx.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
We really should have an i2c_initcall, but it may be difficult to move
everyone over to it. What would be lovely is some form of dependency
based initialisation, but that's probably a way off...
I'll consider this for the next merge window.
> diff --git a/drivers/i2c/busses/i2c-mv64xxx.c b/drivers/i2c/busses/i2c-mv64xxx.c
> index 1624206..6f3d084 100644
> --- a/drivers/i2c/busses/i2c-mv64xxx.c
> +++ b/drivers/i2c/busses/i2c-mv64xxx.c
> @@ -592,7 +592,7 @@ mv64xxx_i2c_exit(void)
> platform_driver_unregister(&mv64xxx_i2c_driver);
> }
>
> -module_init(mv64xxx_i2c_init);
> +subsys_initcall(mv64xxx_i2c_init);
> module_exit(mv64xxx_i2c_exit);
>
> MODULE_AUTHOR("Mark A. Greer <mgreer-Igf4POYTYCDQT0dZR+AlfA@public.gmane.org>");
--
Ben
Q: What's a light-year?
A: One-third less calories than a regular year.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] i2c-mv64xxx: use subsys_initcall for early initialization
[not found] ` <20100914232547.GD7494-SMNkleLxa3Z6Wcw2j4pizdi2O/JbrIOy@public.gmane.org>
@ 2010-09-15 13:43 ` Mike Rapoport
[not found] ` <4C90CD6C.60100-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
2010-09-23 7:11 ` Linus Walleij
1 sibling, 1 reply; 7+ messages in thread
From: Mike Rapoport @ 2010-09-15 13:43 UTC (permalink / raw)
To: Ben Dooks
Cc: ben-linux-elnMNo+KYs3YtjvyW6yDsg, linux-i2c-u79uwXL29TY76Z2rM5mHXA
Ben Dooks wrote:
> On Sun, Sep 12, 2010 at 11:35:29AM +0200, Mike Rapoport wrote:
>> Signed-off-by: Mike Rapoport <mike-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
>> ---
>> drivers/i2c/busses/i2c-mv64xxx.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> We really should have an i2c_initcall, but it may be difficult to move
> everyone over to it. What would be lovely is some form of dependency
> based initialisation, but that's probably a way off...
Yeah, that would be nice...
> I'll consider this for the next merge window.
Thanks
>> diff --git a/drivers/i2c/busses/i2c-mv64xxx.c b/drivers/i2c/busses/i2c-mv64xxx.c
>> index 1624206..6f3d084 100644
>> --- a/drivers/i2c/busses/i2c-mv64xxx.c
>> +++ b/drivers/i2c/busses/i2c-mv64xxx.c
>> @@ -592,7 +592,7 @@ mv64xxx_i2c_exit(void)
>> platform_driver_unregister(&mv64xxx_i2c_driver);
>> }
>>
>> -module_init(mv64xxx_i2c_init);
>> +subsys_initcall(mv64xxx_i2c_init);
>> module_exit(mv64xxx_i2c_exit);
>>
>> MODULE_AUTHOR("Mark A. Greer <mgreer-Igf4POYTYCDQT0dZR+AlfA@public.gmane.org>");
>
--
Sincerely yours,
Mike.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] i2c-mv64xxx: use subsys_initcall for early initialization
[not found] ` <4C90CD6C.60100-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
@ 2010-09-15 13:49 ` Mark Brown
0 siblings, 0 replies; 7+ messages in thread
From: Mark Brown @ 2010-09-15 13:49 UTC (permalink / raw)
To: Mike Rapoport
Cc: Ben Dooks, ben-linux-elnMNo+KYs3YtjvyW6yDsg,
linux-i2c-u79uwXL29TY76Z2rM5mHXA
On Wed, Sep 15, 2010 at 03:43:08PM +0200, Mike Rapoport wrote:
> Ben Dooks wrote:
>>> drivers/i2c/busses/i2c-mv64xxx.c | 2 +-
>>> 1 files changed, 1 insertions(+), 1 deletions(-)
>> We really should have an i2c_initcall, but it may be difficult to move
>> everyone over to it. What would be lovely is some form of dependency
>> based initialisation, but that's probably a way off...
> Yeah, that would be nice...
Grant Likely was muttering about contributing something here.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] i2c-mv64xxx: use subsys_initcall for early initialization
[not found] ` <20100914232547.GD7494-SMNkleLxa3Z6Wcw2j4pizdi2O/JbrIOy@public.gmane.org>
2010-09-15 13:43 ` Mike Rapoport
@ 2010-09-23 7:11 ` Linus Walleij
[not found] ` <AANLkTi=gtXJ8zQt2kTSCCy7=Zc4R-8BDp=Z8w7u8_ua+-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
1 sibling, 1 reply; 7+ messages in thread
From: Linus Walleij @ 2010-09-23 7:11 UTC (permalink / raw)
To: Ben Dooks
Cc: Mike Rapoport, ben-linux-elnMNo+KYs3YtjvyW6yDsg,
linux-i2c-u79uwXL29TY76Z2rM5mHXA
2010/9/15 Ben Dooks <ben-i2c-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>:
> On Sun, Sep 12, 2010 at 11:35:29AM +0200, Mike Rapoport wrote:
>> Signed-off-by: Mike Rapoport <mike-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
>> ---
>> drivers/i2c/busses/i2c-mv64xxx.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> We really should have an i2c_initcall, but it may be difficult to move
> everyone over to it. What would be lovely is some form of dependency
> based initialisation, but that's probably a way off...
SPI, SDIO and other external busses (Dallas 1-wire? w1) may all have
the same "needs to be up early because we need that before that"
type of problem.
Makes me think of crazy things like putting a lightweight version of
Lennars Pötterings "systemd" scheme into the kernel for resolving
these initcalls.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] i2c-mv64xxx: use subsys_initcall for early initialization
[not found] ` <AANLkTi=gtXJ8zQt2kTSCCy7=Zc4R-8BDp=Z8w7u8_ua+-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
@ 2010-09-23 12:29 ` Mark Brown
2010-09-28 23:11 ` Ben Dooks
1 sibling, 0 replies; 7+ messages in thread
From: Mark Brown @ 2010-09-23 12:29 UTC (permalink / raw)
To: Linus Walleij
Cc: Ben Dooks, Mike Rapoport, ben-linux-elnMNo+KYs3YtjvyW6yDsg,
linux-i2c-u79uwXL29TY76Z2rM5mHXA
On Thu, Sep 23, 2010 at 09:11:00AM +0200, Linus Walleij wrote:
> Makes me think of crazy things like putting a lightweight version of
> Lennars P?tterings "systemd" scheme into the kernel for resolving
> these initcalls.
We pretty much need that; it's not just the initcalls - we also need the
probes to go through in the right order, we're just using the initcall
fiddling to bodge that for now with particularly critical system
components.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] i2c-mv64xxx: use subsys_initcall for early initialization
[not found] ` <AANLkTi=gtXJ8zQt2kTSCCy7=Zc4R-8BDp=Z8w7u8_ua+-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-09-23 12:29 ` Mark Brown
@ 2010-09-28 23:11 ` Ben Dooks
1 sibling, 0 replies; 7+ messages in thread
From: Ben Dooks @ 2010-09-28 23:11 UTC (permalink / raw)
To: Linus Walleij
Cc: Ben Dooks, Mike Rapoport, ben-linux-elnMNo+KYs3YtjvyW6yDsg,
linux-i2c-u79uwXL29TY76Z2rM5mHXA
On Thu, Sep 23, 2010 at 09:11:00AM +0200, Linus Walleij wrote:
> 2010/9/15 Ben Dooks <ben-i2c-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>:
> > On Sun, Sep 12, 2010 at 11:35:29AM +0200, Mike Rapoport wrote:
> >> Signed-off-by: Mike Rapoport <mike-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
> >> ---
> >> drivers/i2c/busses/i2c-mv64xxx.c | 2 +-
> >> 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > We really should have an i2c_initcall, but it may be difficult to move
> > everyone over to it. What would be lovely is some form of dependency
> > based initialisation, but that's probably a way off...
>
> SPI, SDIO and other external busses (Dallas 1-wire? w1) may all have
> the same "needs to be up early because we need that before that"
> type of problem.
>
> Makes me think of crazy things like putting a lightweight version of
> Lennars Pötterings "systemd" scheme into the kernel for resolving
> these initcalls.
Either that, or build stuff as modules and use an initrd...
Not sure what the best solution is...
--
Ben
Q: What's a light-year?
A: One-third less calories than a regular year.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2010-09-28 23:11 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-09-12 9:35 [PATCH] i2c-mv64xxx: use subsys_initcall for early initialization Mike Rapoport
[not found] ` <1284284129-28105-1-git-send-email-mike-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
2010-09-14 23:25 ` Ben Dooks
[not found] ` <20100914232547.GD7494-SMNkleLxa3Z6Wcw2j4pizdi2O/JbrIOy@public.gmane.org>
2010-09-15 13:43 ` Mike Rapoport
[not found] ` <4C90CD6C.60100-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
2010-09-15 13:49 ` Mark Brown
2010-09-23 7:11 ` Linus Walleij
[not found] ` <AANLkTi=gtXJ8zQt2kTSCCy7=Zc4R-8BDp=Z8w7u8_ua+-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-09-23 12:29 ` Mark Brown
2010-09-28 23:11 ` Ben Dooks
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.