* [U-Boot] [PATCH] usb: musb: set target address for non-multipoint devices
@ 2010-08-09 18:35 Mike Frysinger
2010-08-09 19:14 ` Sergei Shtylyov
2010-08-09 22:41 ` [U-Boot] [PATCH v2] " Mike Frysinger
0 siblings, 2 replies; 6+ messages in thread
From: Mike Frysinger @ 2010-08-09 18:35 UTC (permalink / raw)
To: u-boot
From: Bryan Wu <bryan.wu@analog.com>
Signed-off-by: Bryan Wu <bryan.wu@analog.com>
Signed-off-by: Cliff Cai <cliff.cai@analog.com>
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
drivers/usb/musb/musb_hcd.c | 7 +++++++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/drivers/usb/musb/musb_hcd.c b/drivers/usb/musb/musb_hcd.c
index dd2aa7f..abb84b2 100644
--- a/drivers/usb/musb/musb_hcd.c
+++ b/drivers/usb/musb/musb_hcd.c
@@ -917,6 +917,13 @@ int submit_control_msg(struct usb_device *dev, unsigned long pipe, void *buffer,
dev->status = 0;
dev->act_len = len;
+
+#ifdef MUSB_NO_MULTIPOINT
+ /* Set device address to USB_FADDR register */
+ if (setup->request == USB_REQ_SET_ADDRESS)
+ writew(dev->devnum, &musbr->faddr);
+#endif
+
return len;
}
--
1.7.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] usb: musb: set target address for non-multipoint devices
2010-08-09 18:35 [U-Boot] [PATCH] usb: musb: set target address for non-multipoint devices Mike Frysinger
@ 2010-08-09 19:14 ` Sergei Shtylyov
2010-08-09 19:20 ` Mike Frysinger
2010-08-09 22:41 ` [U-Boot] [PATCH v2] " Mike Frysinger
1 sibling, 1 reply; 6+ messages in thread
From: Sergei Shtylyov @ 2010-08-09 19:14 UTC (permalink / raw)
To: u-boot
Mike Frysinger wrote:
> From: Bryan Wu <bryan.wu@analog.com>
> Signed-off-by: Bryan Wu <bryan.wu@analog.com>
> Signed-off-by: Cliff Cai <cliff.cai@analog.com>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> ---
> drivers/usb/musb/musb_hcd.c | 7 +++++++
> 1 files changed, 7 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/usb/musb/musb_hcd.c b/drivers/usb/musb/musb_hcd.c
> index dd2aa7f..abb84b2 100644
> --- a/drivers/usb/musb/musb_hcd.c
> +++ b/drivers/usb/musb/musb_hcd.c
> @@ -917,6 +917,13 @@ int submit_control_msg(struct usb_device *dev, unsigned long pipe, void *buffer,
>
> dev->status = 0;
> dev->act_len = len;
> +
> +#ifdef MUSB_NO_MULTIPOINT
> + /* Set device address to USB_FADDR register */
> + if (setup->request == USB_REQ_SET_ADDRESS)
> + writew(dev->devnum, &musbr->faddr);
FAddr is a 8-bit regisrer, isn't it?
WBR, Sergei
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] usb: musb: set target address for non-multipoint devices
2010-08-09 19:14 ` Sergei Shtylyov
@ 2010-08-09 19:20 ` Mike Frysinger
2010-08-09 22:26 ` Mike Frysinger
0 siblings, 1 reply; 6+ messages in thread
From: Mike Frysinger @ 2010-08-09 19:20 UTC (permalink / raw)
To: u-boot
On Mon, Aug 9, 2010 at 3:14 PM, Sergei Shtylyov wrote:
> Mike Frysinger wrote:
>> --- a/drivers/usb/musb/musb_hcd.c
>> +++ b/drivers/usb/musb/musb_hcd.c
>> @@ -917,6 +917,13 @@ int submit_control_msg(struct usb_device *dev,
>> unsigned long pipe, void *buffer,
>> ? ? ? ?dev->status = 0;
>> ? ? ? ?dev->act_len = len;
>> +
>> +#ifdef MUSB_NO_MULTIPOINT
>> + ? ? ? /* Set device address to USB_FADDR register */
>> + ? ? ? if (setup->request == USB_REQ_SET_ADDRESS)
>> + ? ? ? ? ? ? ? writew(dev->devnum, &musbr->faddr);
>
> ? FAddr is a 8-bit regisrer, isn't it?
on Blackfin systems, it is 16bit ... i'll have to double check to see
what the hardware does with an 8bit access. i see there are other
places in the code where 8bit is already being done, so those might
need to be addressed as well ...
-mike
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] usb: musb: set target address for non-multipoint devices
2010-08-09 19:20 ` Mike Frysinger
@ 2010-08-09 22:26 ` Mike Frysinger
0 siblings, 0 replies; 6+ messages in thread
From: Mike Frysinger @ 2010-08-09 22:26 UTC (permalink / raw)
To: u-boot
On Mon, Aug 9, 2010 at 3:20 PM, Mike Frysinger wrote:
> On Mon, Aug 9, 2010 at 3:14 PM, Sergei Shtylyov wrote:
>> Mike Frysinger wrote:
>>> --- a/drivers/usb/musb/musb_hcd.c
>>> +++ b/drivers/usb/musb/musb_hcd.c
>>> @@ -917,6 +917,13 @@ int submit_control_msg(struct usb_device *dev,
>>> unsigned long pipe, void *buffer,
>>> ? ? ? ?dev->status = 0;
>>> ? ? ? ?dev->act_len = len;
>>> +
>>> +#ifdef MUSB_NO_MULTIPOINT
>>> + ? ? ? /* Set device address to USB_FADDR register */
>>> + ? ? ? if (setup->request == USB_REQ_SET_ADDRESS)
>>> + ? ? ? ? ? ? ? writew(dev->devnum, &musbr->faddr);
>>
>> ? FAddr is a 8-bit regisrer, isn't it?
>
> on Blackfin systems, it is 16bit ... i'll have to double check to see
> what the hardware does with an 8bit access. ?i see there are other
> places in the code where 8bit is already being done, so those might
> need to be addressed as well ...
yeah, Blackfin hardware likes to reject 8bit accesses to this mmr.
although, i just remembered that in the musb code only, we
specifically rewrite all readb/writeb to readw/writew for Blackfin
systems. so i'll change this patch to writeb as you suggested.
-mike
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH v2] usb: musb: set target address for non-multipoint devices
2010-08-09 18:35 [U-Boot] [PATCH] usb: musb: set target address for non-multipoint devices Mike Frysinger
2010-08-09 19:14 ` Sergei Shtylyov
@ 2010-08-09 22:41 ` Mike Frysinger
2010-08-12 18:00 ` Remy Bohmer
1 sibling, 1 reply; 6+ messages in thread
From: Mike Frysinger @ 2010-08-09 22:41 UTC (permalink / raw)
To: u-boot
From: Bryan Wu <bryan.wu@analog.com>
Signed-off-by: Bryan Wu <bryan.wu@analog.com>
Signed-off-by: Cliff Cai <cliff.cai@analog.com>
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
v2
- use writeb instead of writew as pointed out by Sergei Shtylyov
drivers/usb/musb/musb_hcd.c | 7 +++++++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/drivers/usb/musb/musb_hcd.c b/drivers/usb/musb/musb_hcd.c
index dd2aa7f..8a761df 100644
--- a/drivers/usb/musb/musb_hcd.c
+++ b/drivers/usb/musb/musb_hcd.c
@@ -917,6 +917,13 @@ int submit_control_msg(struct usb_device *dev, unsigned long pipe, void *buffer,
dev->status = 0;
dev->act_len = len;
+
+#ifdef MUSB_NO_MULTIPOINT
+ /* Set device address to USB_FADDR register */
+ if (setup->request == USB_REQ_SET_ADDRESS)
+ writeb(dev->devnum, &musbr->faddr);
+#endif
+
return len;
}
--
1.7.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH v2] usb: musb: set target address for non-multipoint devices
2010-08-09 22:41 ` [U-Boot] [PATCH v2] " Mike Frysinger
@ 2010-08-12 18:00 ` Remy Bohmer
0 siblings, 0 replies; 6+ messages in thread
From: Remy Bohmer @ 2010-08-12 18:00 UTC (permalink / raw)
To: u-boot
Hi,
2010/8/10 Mike Frysinger <vapier@gentoo.org>:
> From: Bryan Wu <bryan.wu@analog.com>
>
> Signed-off-by: Bryan Wu <bryan.wu@analog.com>
> Signed-off-by: Cliff Cai <cliff.cai@analog.com>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> ---
> v2
> ? ? ? ?- use writeb instead of writew as pointed out by Sergei Shtylyov
>
Applied to u-boot-usb.
Thanks.
Remy
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-08-12 18:00 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-08-09 18:35 [U-Boot] [PATCH] usb: musb: set target address for non-multipoint devices Mike Frysinger
2010-08-09 19:14 ` Sergei Shtylyov
2010-08-09 19:20 ` Mike Frysinger
2010-08-09 22:26 ` Mike Frysinger
2010-08-09 22:41 ` [U-Boot] [PATCH v2] " Mike Frysinger
2010-08-12 18:00 ` Remy Bohmer
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.