From: Linus Torvalds <torvalds@linux-foundation.org>
To: Mike Snitzer <snitzer@gmail.com>
Cc: Ian Campbell <ijc@hellion.org.uk>,
linux-kernel@vger.kernel.org, stable@kernel.org,
stable-review@kernel.org, akpm@linux-foundation.org,
alan@lxorguk.ukuu.org.uk, Greg KH <gregkh@suse.de>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [RFC] mlock/stack guard interaction fixup
Date: Fri, 20 Aug 2010 17:54:07 -0700 [thread overview]
Message-ID: <AANLkTik0v=FonpBzpRCxCrogL2KoPRQDT0X4BSbHx2cF@mail.gmail.com> (raw)
In-Reply-To: <AANLkTi=iTY1LBE6F6u+e4mF61N6b_Sqdy2MBi6LJMQai@mail.gmail.com>
On Fri, Aug 20, 2010 at 5:20 PM, Mike Snitzer <snitzer@gmail.com> wrote:
>
> In 0002-mm-make-the-mlock-stack-guard-page-checks-stricter.patch you
> switch __mlock_vma_pages_range from 'start += PAGE_SIZE' to 'addr +=
> PAGE_SIZE'.
>
> So would that be a bugfix for commit d7824370? Seems likely given
> start isn't used after that point.
Yup, that's a bug-fix. Although the real bug was having two variables
(addr and start) both be the same thing. Probably for some random
historical reason. And I didn't fix that.
Linus
next prev parent reply other threads:[~2010-08-21 0:54 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-20 23:59 [RFC] mlock/stack guard interaction fixup Linus Torvalds
2010-08-21 0:20 ` Mike Snitzer
2010-08-21 0:54 ` Linus Torvalds [this message]
2010-08-21 11:56 ` Ian Campbell
2010-08-21 15:48 ` Linus Torvalds
2010-08-21 16:08 ` Sam Ravnborg
2010-08-23 16:34 ` Tony Luck
2010-08-22 6:57 ` Ian Campbell
2010-08-22 7:33 ` Ian Campbell
2010-08-22 9:55 ` Ian Campbell
2010-08-22 16:43 ` Linus Torvalds
2010-08-22 17:25 ` Greg KH
2010-08-22 18:21 ` Linus Torvalds
2010-08-22 19:04 ` Greg KH
2010-08-23 9:22 ` Peter Zijlstra
2010-08-23 15:42 ` ijackson
2010-08-23 16:25 ` Peter Zijlstra
2010-08-23 17:18 ` Ian Jackson
2010-08-23 17:34 ` Linus Torvalds
2010-08-23 17:53 ` Peter Zijlstra
2010-08-23 17:59 ` Peter Zijlstra
2010-08-23 18:43 ` Darren Hart
2010-08-23 18:50 ` Jeremy Fitzhardinge
2010-08-23 19:07 ` Peter Zijlstra
2010-08-23 19:23 ` Jeremy Fitzhardinge
2010-08-23 19:26 ` Peter Zijlstra
2010-08-23 19:54 ` Jeremy Fitzhardinge
2010-08-24 7:08 ` Peter Zijlstra
2010-08-24 7:20 ` Peter Zijlstra
2010-08-23 19:03 ` Ian Campbell
2010-08-23 17:40 ` Peter Zijlstra
2010-08-23 18:53 ` Jeremy Fitzhardinge
2010-08-25 8:28 ` [Stable-review] " Stefan Bader
2010-08-23 9:00 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTik0v=FonpBzpRCxCrogL2KoPRQDT0X4BSbHx2cF@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=gregkh@suse.de \
--cc=ijc@hellion.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=snitzer@gmail.com \
--cc=stable-review@kernel.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.