[Qemu-devel] [PATCH v3 00/15] GCC warning flags

[Qemu-devel] [PATCH v3 00/15] GCC warning flags

[Blue Swirl]

I updated the descriptions and cleaned up 6/16.

Blue Swirl (15):
  Check for errors during BIOS or kernel load
  linux-user: fix socklen_t comparisons
  linux-user: fix types in a comparison
  linux-user: improve flatload error checking
  Introduce range.h
  Use range_covers_byte
  pxa2xx: remove useless checks
  blkdebug: fix enum comparison
  PPC: Suppress gcc warnings with -Wtype-limits
  MIPS: fix yield handling
  pxa2xx: fix SSSR TFN logic
  Use gcc warning flag -Wtype-limits
  Use a few more gcc warning flags
  Use gcc warning flag -Wempty-body
  Use gcc warning flag -Wnested-externs

 block/blkdebug.c        |    4 +--
 configure               |    5 +++-
 feature_to_c.sh         |    1 -
 gdbstub.c               |    1 -
 gdbstub.h               |    3 ++
 hw/acpi_piix4.c         |    1 +
 hw/mips_fulong2e.c      |    2 +-
 hw/msix.c               |    1 +
 hw/omap1.c              |   14 +++++++-----
 hw/omap_i2c.c           |    5 ++-
 hw/omap_mmc.c           |    5 ++-
 hw/pci.c                |    1 +
 hw/pci.h                |   29 ---------------------------
 hw/piix_pci.c           |    1 +
 hw/ppc405_boards.c      |   23 ++++++++++++---------
 hw/ppc_newworld.c       |    3 +-
 hw/ppc_prep.c           |    3 +-
 hw/pxa2xx.c             |   15 +++++++------
 hw/sm501.c              |    5 ++-
 hw/soc_dma.c            |    5 ++-
 hw/vhost.c              |    3 +-
 linux-user/flatload.c   |    3 +-
 linux-user/mmap.c       |    2 +-
 linux-user/syscall.c    |   20 ++++++++++++------
 range.h                 |   29 +++++++++++++++++++++++++++
 target-cris/mmu.c       |    2 +-
 target-mips/op_helper.c |    4 ++-
 target-ppc/op_helper.c  |   50 +++++++++++++++++++++++-----------------------
 28 files changed, 133 insertions(+), 107 deletions(-)
 create mode 100644 range.h

Re: [Qemu-devel] [PATCH v3 00/15] GCC warning flags

[Andreas Färber]

Hi Blue,

Some of the warnings currently enabled are applicable only to C and  
Objective-C code, but gcc warns for C++:

cc1plus: warning: command line option "-Wold-style-definition" is  
valid for C/ObjC but not for C++
cc1plus: warning: command line option "-Wold-style-declaration" is  
valid for C/ObjC but not for C++
cc1plus: warning: command line option "-Wnested-externs" is valid for  
C/ObjC but not for C++
cc1plus: warning: command line option "-Wstrict-prototypes" is valid  
for C/ObjC but not for C++
cc1plus: warning: command line option "-Wmissing-prototypes" is valid  
for C/ObjC but not for C++

Any idea how to handle this configure/rules.mak-wise? Split  
QEMU_CFLAGS into QEMU_CPPFLAGS and QEMU_CFLAGS/QEMU_CXXFLAGS?

Regards,
Andreas

Re: [Qemu-devel] [PATCH v3 00/15] GCC warning flags

[Blue Swirl]

On Sun, Sep 19, 2010 at 9:52 AM, Andreas Färber <andreas.faerber@web.de> wrote:
> Hi Blue,
>
> Some of the warnings currently enabled are applicable only to C and
> Objective-C code, but gcc warns for C++:
>
> cc1plus: warning: command line option "-Wold-style-definition" is valid for
> C/ObjC but not for C++
> cc1plus: warning: command line option "-Wold-style-declaration" is valid for
> C/ObjC but not for C++
> cc1plus: warning: command line option "-Wnested-externs" is valid for C/ObjC
> but not for C++
> cc1plus: warning: command line option "-Wstrict-prototypes" is valid for
> C/ObjC but not for C++
> cc1plus: warning: command line option "-Wmissing-prototypes" is valid for
> C/ObjC but not for C++
>
> Any idea how to handle this configure/rules.mak-wise? Split QEMU_CFLAGS into
> QEMU_CPPFLAGS and QEMU_CFLAGS/QEMU_CXXFLAGS?

That could work, but why would we care about C++ at all? For example,
we use 'new' as variable name.

Re: [Qemu-devel] [PATCH v3 00/15] GCC warning flags

[Stefan Weil]

Am 10.09.2010 22:58, schrieb Blue Swirl:
> I updated the descriptions and cleaned up 6/16.
>
> Blue Swirl (15):
> Check for errors during BIOS or kernel load
> linux-user: fix socklen_t comparisons
> linux-user: fix types in a comparison
> linux-user: improve flatload error checking
> Introduce range.h
> Use range_covers_byte
> pxa2xx: remove useless checks
> blkdebug: fix enum comparison
> PPC: Suppress gcc warnings with -Wtype-limits
> MIPS: fix yield handling
> pxa2xx: fix SSSR TFN logic
> Use gcc warning flag -Wtype-limits
> Use a few more gcc warning flags
> Use gcc warning flag -Wempty-body
> Use gcc warning flag -Wnested-externs
[snip]

-Wmissing-format-attribute is also a very useful warning flag.
I have patches which add the missing format attributes, so
this flag could be applied.

Some of these patches were already send to qemu-devel:
http://patchwork.ozlabs.org/patch/64643/
http://patchwork.ozlabs.org/patch/64644/
http://patchwork.ozlabs.org/patch/64487/
http://patchwork.ozlabs.org/patch/64488/

Although HACKING says that "patches to add the attribute would
be very much appreciated", these patches were still not applied
to QEMU master (not even reviewed).

Sending a complete set patch of patches is some work for me
(not because it is difficult, but because a lot of files
are concerned). Is there a maintainer willing to support
integration of my patches so that it does not take months
for review and commit?

Regards
Stefan

Re: [Qemu-devel] [PATCH v3 00/15] GCC warning flags

[Blue Swirl]

On Mon, Sep 20, 2010 at 11:28 AM, Stefan Weil <weil@mail.berlios.de> wrote:
> Am 10.09.2010 22:58, schrieb Blue Swirl:
>>
>> I updated the descriptions and cleaned up 6/16.
>>
>> Blue Swirl (15):
>> Check for errors during BIOS or kernel load
>> linux-user: fix socklen_t comparisons
>> linux-user: fix types in a comparison
>> linux-user: improve flatload error checking
>> Introduce range.h
>> Use range_covers_byte
>> pxa2xx: remove useless checks
>> blkdebug: fix enum comparison
>> PPC: Suppress gcc warnings with -Wtype-limits
>> MIPS: fix yield handling
>> pxa2xx: fix SSSR TFN logic
>> Use gcc warning flag -Wtype-limits
>> Use a few more gcc warning flags
>> Use gcc warning flag -Wempty-body
>> Use gcc warning flag -Wnested-externs
>
> [snip]
>
> -Wmissing-format-attribute is also a very useful warning flag.
> I have patches which add the missing format attributes, so
> this flag could be applied.
>
> Some of these patches were already send to qemu-devel:
> http://patchwork.ozlabs.org/patch/64643/
> http://patchwork.ozlabs.org/patch/64644/
> http://patchwork.ozlabs.org/patch/64487/
> http://patchwork.ozlabs.org/patch/64488/
>
> Although HACKING says that "patches to add the attribute would
> be very much appreciated", these patches were still not applied
> to QEMU master (not even reviewed).
>
> Sending a complete set patch of patches is some work for me
> (not because it is difficult, but because a lot of files
> are concerned). Is there a maintainer willing to support
> integration of my patches so that it does not take months
> for review and commit?

I'll review the patches and commit if there are no objections.