[PATCH] doc: Assisted Satellite Navigation API and Agent API

[PATCH] doc: Assisted Satellite Navigation API and Agent API

[Sjur =?unknown-8bit?q?Br=C3=A6ndeland?=]

[-- Attachment #1: Type: text/plain, Size: 3644 bytes --]

From: Simon Lethbridge <simon.lethbridge@stericsson.com>

This patch introduces support for Global Satellite Navigation System (GNSS),
using the AT commands AT+CPOS and +CPOSR as specified 3GPP 27.007.
---
Hi Denis,

2010/11/30 Denis Kenzior <denkenz@gmail.com>:
>> +AssistedSatelliteNavigation hierarchy
>What do you think of naming this AssistedNavigation?  I think the
>current name might be a bit too long.
See mail previous mail on this topic, I think we'd like to keep
it as is for now.

>> +Methods              void SendPositioningControl(string xml_element)
>What do you think of SendPositioningElement?
Fixed,

>> +Methods      void PositioningRequest(string xml_element)
>I think that 'Request' will be sufficient.  Positioning is already part
>of the agent name.
Fixed,

>> +             void AssistanceDataReset()
>I suggest ResetAssistanceData here.
Fixed,

>The only other change I'd make is to mark the entire interface
>'experimental', but I can take care of that as well.
Fixed,

>Otherwise the proposal looks good to me.
Sorry for taking so long before responding on this.
Let us know if you have any issues with this patch.

Regards,
Sjur and Simon.

 doc/assisted-sattelite-navigation.txt |   56 +++++++++++++++++++++++++++++++++
 1 files changed, 56 insertions(+), 0 deletions(-)
 create mode 100644 doc/assisted-sattelite-navigation.txt

diff --git a/doc/assisted-sattelite-navigation.txt b/doc/assisted-sattelite-navigation.txt
new file mode 100644
index 0000000..abacf54
--- /dev/null
+++ b/doc/assisted-sattelite-navigation.txt
@@ -0,0 +1,56 @@
+Assisted Satellite Navigation hierarchy [experimental]
+==========================================================
+
+Service		org.ofono
+Interface	org.ofono.AssistedSatelliteNavigation
+Object path	[variable prefix]/{modem0,modem1,...}
+
+Methods		void SendPositioningElement(string xml_element)
+
+			Send an XML element conforming to the XML DTD for <pos>
+			as defined in 3GPP 27.007 Table 8.55-2. This xml is
+			used for transferring data associated with positioning
+			requests received via control plane from the network.
+			This includes assistance data requests and the results
+			of positioning procedures. This method maps directly to
+			the 3GPP 27.007 AT+CPOS command.
+
+		void RegisterPositioningRequestAgent(object path)
+
+			Registers an agent which will be called whenever a
+			CPOSR AT response is received. The Agent must respond
+			to requests using SendPositioningControl.
+
+		void UnregisterPositioningRequestAgent(object path)
+
+			Un-registers the agent.
+
+PositioningRequestAgent hierarchy
+==================================
+
+Service		unique name
+Interface	org.ofono.PositioningRequestAgent
+Object path	freely definable
+
+Methods	void Request(string xml_element)
+
+			Receive an XML element conforming to the XML DTD for
+			<pos> in 3GPP 27.007. This xml is used for transferring
+			data associated with positioning requests received, via
+			control plane, from the network. This includes
+			measurement requests and assistance data. This method
+			maps directly to the 3GPP defined +CPOSR unsolicited
+			result code.
+
+		void ResetAssistanceData()
+
+			A request has been received from the network that all
+			assistance data should be reset.  This is used for 3gpp
+			performance tests.
+
+		void Release()
+
+			Agent is being released, possibly because of oFono
+			terminating, AssistedSatelliteNavigation interface
+			is being torn down or modem off.
+			No UnregisterAgent call is needed.
-- 
1.7.0.4

Re: [PATCH] doc: Assisted Satellite Navigation API and Agent API

[=?unknown-8bit?q?R=C3=A9mi?= Denis-Courmont]

[-- Attachment #1: Type: text/plain, Size: 403 bytes --]

On Friday 28 January 2011 13:32:50 ext Sjur Brændeland, you wrote:
> +		void RegisterPositioningRequestAgent(object path)
> +
> +			Registers an agent which will be called whenever a
> +			CPOSR AT response is received. The Agent must respond
> +			to requests using SendPositioningControl.

Spelling is inconsistent ;)

-- 
Rémi Denis-Courmont
Nokia Devices R&D, Maemo Software, Helsinki

[PATCHv2] doc: Assisted Satellite Navigation API and Agent API

[Sjur =?unknown-8bit?q?Br=C3=A6ndeland?=]

[-- Attachment #1: Type: text/plain, Size: 3860 bytes --]

From: Simon Lethbridge <simon.lethbridge@stericsson.com>

This patch introduces support for Global Satellite Navigation System (GNSS),
using the AT commands AT+CPOS and +CPOSR as specified 3GPP 27.007.
---

Changes from v1 (28 Jan):
s/SendPositioningControl/SendPositioningElement/

Thanks Rémi, for spotting this one,


Changes from RFCv2 (Nov 22):
>Hi Denis,
>
>2010/11/30 Denis Kenzior <denkenz@gmail.com>:
>>> +AssistedSatelliteNavigation hierarchy
>>What do you think of naming this AssistedNavigation?  I think the
>>current name might be a bit too long.
>
>See mail previous mail on this topic, I think we'd like to keep
>it as is for now.
>
>>> +Methods              void SendPositioningControl(string xml_element)
>>What do you think of SendPositioningElement?
>
>Fixed,
>
>>> +Methods      void PositioningRequest(string xml_element)
>>I think that 'Request' will be sufficient.  Positioning is already part
>>of the agent name.
>
>Fixed,
>
>>> +             void AssistanceDataReset()
>>I suggest ResetAssistanceData here.
>Fixed,
>
>>The only other change I'd make is to mark the entire interface
>>'experimental', but I can take care of that as well.
>
>Fixed,
>
>>Otherwise the proposal looks good to me.
>
>Sorry for taking so long before responding on this.
>Let us know if you have any issues with this patch.

Regards,
Sjur and Simon.

 doc/assisted-sattelite-navigation.txt |   56 +++++++++++++++++++++++++++++++++
 1 files changed, 56 insertions(+), 0 deletions(-)
 create mode 100644 doc/assisted-sattelite-navigation.txt

diff --git a/doc/assisted-sattelite-navigation.txt b/doc/assisted-sattelite-navigation.txt
new file mode 100644
index 0000000..c5a8c10
--- /dev/null
+++ b/doc/assisted-sattelite-navigation.txt
@@ -0,0 +1,56 @@
+Assisted Satellite Navigation hierarchy [experimental]
+==========================================================
+
+Service		org.ofono
+Interface	org.ofono.AssistedSatelliteNavigation
+Object path	[variable prefix]/{modem0,modem1,...}
+
+Methods		void SendPositioningElement(string xml_element)
+
+			Send an XML element conforming to the XML DTD for <pos>
+			as defined in 3GPP 27.007 Table 8.55-2. This xml is
+			used for transferring data associated with positioning
+			requests received via control plane from the network.
+			This includes assistance data requests and the results
+			of positioning procedures. This method maps directly to
+			the 3GPP 27.007 AT+CPOS command.
+
+		void RegisterPositioningRequestAgent(object path)
+
+			Registers an agent which will be called whenever a
+			CPOSR AT response is received. The Agent must respond
+			to requests using SendPositioningElement.
+
+		void UnregisterPositioningRequestAgent(object path)
+
+			Un-registers the agent.
+
+PositioningRequestAgent hierarchy
+==================================
+
+Service		unique name
+Interface	org.ofono.PositioningRequestAgent
+Object path	freely definable
+
+Methods		void Request(string xml_element)
+
+			Receive an XML element conforming to the XML DTD for
+			<pos> in 3GPP 27.007. This xml is used for transferring
+			data associated with positioning requests received, via
+			control plane, from the network. This includes
+			measurement requests and assistance data. This method
+			maps directly to the 3GPP defined +CPOSR unsolicited
+			result code.
+
+		void ResetAssistanceData()
+
+			A request has been received from the network that all
+			assistance data should be reset.  This is used for 3gpp
+			performance tests.
+
+		void Release()
+
+			Agent is being released, possibly because of oFono
+			terminating, AssistedSatelliteNavigation interface
+			is being torn down or modem off.
+			No UnregisterPositioningRequestAgent call is needed.
-- 
1.7.0.4

Re: [PATCHv2] doc: Assisted Satellite Navigation API and Agent API

[Aki Niemi]

[-- Attachment #1: Type: text/plain, Size: 2006 bytes --]

Hi Sjur and Simon,

2011/1/30 Sjur Brændeland <sjurbren@gmail.com>:
> +PositioningRequestAgent hierarchy
> +==================================
> +
> +Service                unique name
> +Interface      org.ofono.PositioningRequestAgent
> +Object path    freely definable
> +
> +Methods                void Request(string xml_element)
> +
> +                       Receive an XML element conforming to the XML DTD for
> +                       <pos> in 3GPP 27.007. This xml is used for transferring
> +                       data associated with positioning requests received, via
> +                       control plane, from the network. This includes
> +                       measurement requests and assistance data. This method
> +                       maps directly to the 3GPP defined +CPOSR unsolicited
> +                       result code.
> +
> +               void ResetAssistanceData()
> +
> +                       A request has been received from the network that all
> +                       assistance data should be reset.  This is used for 3gpp
> +                       performance tests.
> +
> +               void Release()
> +
> +                       Agent is being released, possibly because of oFono
> +                       terminating, AssistedSatelliteNavigation interface
> +                       is being torn down or modem off.
> +                       No UnregisterPositioningRequestAgent call is needed.

In addition to these, I think there has been discussion of at least
having the fine time injection API, and in addition our positioning
guys would like to have a way of getting reference clock uncertainty
information from the modem. Of course, these can be added in separate
patches.

Overall, looks good to me.

Cheers,
Aki

Re: [PATCHv2] doc: Assisted Satellite Navigation API and Agent API

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 349 bytes --]

Hi Sjur / Simon,

On 01/29/2011 05:44 PM, Sjur Brændeland wrote:
> From: Simon Lethbridge <simon.lethbridge@stericsson.com>
> 
> This patch introduces support for Global Satellite Navigation System (GNSS),
> using the AT commands AT+CPOS and +CPOSR as specified 3GPP 27.007.
> ---
> 

Patch has been applied, thanks.

Regards,
-Denis

RE: [PATCHv2] doc: Assisted Satellite Navigation API and Agent API

[Joly, Frederic]

[-- Attachment #1: Type: text/plain, Size: 1433 bytes --]

Hi Sjur,

-----Original Message-----
From: ofono-bounces(a)ofono.org [mailto:ofono-bounces(a)ofono.org] On Behalf Of Sjur Brændeland
Sent: Sunday, January 30, 2011 12:45 AM
To: remi.denis-courmont(a)nokia.com; Denis Kenzior; ofono(a)ofono.org
Cc: Simon Lethbridge
Subject: [PATCHv2] doc: Assisted Satellite Navigation API and Agent API

+		void ResetAssistanceData()
+
+			A request has been received from the network that all
+			assistance data should be reset.  This is used for 3gpp
+			performance tests.
+

Sorry to come back so late of this. By assistance data reset, you meant a reset of all positioning stored information? Like used in 3GPP conformance testing (44.014 § 8.15 for instance)?
The knowledge of positioning information is somehow "Assistance" information, but this is not the wording I'm used to.

Thanks,

Fred

 
---------------------------------------------------------------------
Intel Corporation SAS (French simplified joint stock company)
Registered headquarters: "Les Montalets"- 2, rue de Paris, 
92196 Meudon Cedex, France
Registration Number:  302 456 199 R.C.S. NANTERRE
Capital: 4,572,000 Euros

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.

[PATCHv2] doc: Assisted Satellite Navigation API and Agent API

[Simon LETHBRIDGE]

[-- Attachment #1: Type: text/plain, Size: 741 bytes --]

Hi Fred,

> +		void ResetAssistanceData()
> +
> +			A request has been received from the network that all
> +			assistance data should be reset.  This is used for 3gpp
> +			performance tests.
>
> Sorry to come back so late of this. By assistance data reset, you meant a reset of all positioning stored information? Like used in 3GPP conformance testing (44.014 ? 8.15 for instance)?
> The knowledge of positioning information is somehow "Assistance" information, but this is not the wording I'm used to.
>
Yes.  Since this is a 3GPP performance test most of the stored information will have been received from the network as assistance data. 

The recs that I have in mind are 34.123 and 51.10 Section 70

Regards,

Simon