* [U-Boot] [PATCH] fsl: update CRC after system EEPROM identifier
@ 2011-02-09 19:40 Timur Tabi
2011-02-09 21:08 ` Timur Tabi
0 siblings, 1 reply; 3+ messages in thread
From: Timur Tabi @ 2011-02-09 19:40 UTC (permalink / raw)
To: u-boot
The "mac id" command is used to initialize the EEPROM data to a specific
format, but it was not updating the CRC. This didn't cause any real
problems, because writing the data to the EEPROM will always update the
CRC anyway, but it did result in a bogus CRC warning.
Signed-off-by: Timur Tabi <timur@freescale.com>
---
board/freescale/common/sys_eeprom.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/board/freescale/common/sys_eeprom.c b/board/freescale/common/sys_eeprom.c
index 11dfd84..3ecfb06 100644
--- a/board/freescale/common/sys_eeprom.c
+++ b/board/freescale/common/sys_eeprom.c
@@ -361,6 +361,7 @@ int do_mac(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
#else
memcpy(e.id, "CCID", sizeof(e.id));
#endif
+ update_crc();
return 0;
}
--
1.7.3.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] fsl: update CRC after system EEPROM identifier
2011-02-09 19:40 [U-Boot] [PATCH] fsl: update CRC after system EEPROM identifier Timur Tabi
@ 2011-02-09 21:08 ` Timur Tabi
2011-02-10 5:30 ` Kumar Gala
0 siblings, 1 reply; 3+ messages in thread
From: Timur Tabi @ 2011-02-09 21:08 UTC (permalink / raw)
To: u-boot
On Wed, Feb 9, 2011 at 1:40 PM, Timur Tabi <timur@freescale.com> wrote:
> The "mac id" command is used to initialize the EEPROM data to a specific
> format, but it was not updating the CRC. ?This didn't cause any real
> problems, because writing the data to the EEPROM will always update the
> CRC anyway, but it did result in a bogus CRC warning.
>
> Signed-off-by: Timur Tabi <timur@freescale.com>
> ---
That should say, "after setting EEPROM identifier"
--
Timur Tabi
Linux kernel developer at Freescale
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] fsl: update CRC after system EEPROM identifier
2011-02-09 21:08 ` Timur Tabi
@ 2011-02-10 5:30 ` Kumar Gala
0 siblings, 0 replies; 3+ messages in thread
From: Kumar Gala @ 2011-02-10 5:30 UTC (permalink / raw)
To: u-boot
On Feb 9, 2011, at 3:08 PM, Timur Tabi wrote:
> On Wed, Feb 9, 2011 at 1:40 PM, Timur Tabi <timur@freescale.com> wrote:
>> The "mac id" command is used to initialize the EEPROM data to a specific
>> format, but it was not updating the CRC. This didn't cause any real
>> problems, because writing the data to the EEPROM will always update the
>> CRC anyway, but it did result in a bogus CRC warning.
>>
>> Signed-off-by: Timur Tabi <timur@freescale.com>
>> ---
>
> That should say, "after setting EEPROM identifier"
Fixed, committed to 85xx
- k
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-02-10 5:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-02-09 19:40 [U-Boot] [PATCH] fsl: update CRC after system EEPROM identifier Timur Tabi
2011-02-09 21:08 ` Timur Tabi
2011-02-10 5:30 ` Kumar Gala
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.