All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Airlie <airlied@gmail.com>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: no LVDS on Intel SandyBridge SDVs
Date: Tue, 21 Dec 2010 12:43:38 +1000	[thread overview]
Message-ID: <AANLkTikdmUM6W=YHueW05VC_jcfrJeuSYW6-b-_avGeD@mail.gmail.com> (raw)
In-Reply-To: <20101220120540.5f990080@jbarnes-desktop>

On Tue, Dec 21, 2010 at 6:05 AM, Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> Add a DMI match entry for the SDV to indicate it has no LVDS present.

Sounds wrong, generally the SDVs can get an LVDS panel plugged into
them, so they have an LVDS connector.

I'd worry that this would break something upstream that isn't an SDV.

Dave.

>
> Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
>
> diff --git a/drivers/gpu/drm/i915/intel_lvds.c b/drivers/gpu/drm/i915/intel_lvds.c
> index aa23070..2f383f0 100644
> --- a/drivers/gpu/drm/i915/intel_lvds.c
> +++ b/drivers/gpu/drm/i915/intel_lvds.c
> @@ -719,6 +719,14 @@ static const struct dmi_system_id intel_no_lvds[] = {
>                        DMI_MATCH(DMI_PRODUCT_NAME, "U800"),
>                },
>        },
> +       {
> +               .callback = intel_no_lvds_dmi_callback,
> +               .ident = "Intel SandyBridge",
> +               .matches = {
> +                       DMI_MATCH(DMI_SYS_VENDOR, "Intel Corporation"),
> +                       DMI_MATCH(DMI_PRODUCT_NAME, "SandyBridge Platform"),
> +               },
> +       },
>
>        { }     /* terminating entry */
>  };
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
>

  parent reply	other threads:[~2010-12-21  2:43 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-20 20:05 [PATCH] drm/i915: no LVDS on Intel SandyBridge SDVs Jesse Barnes
2010-12-20 20:46 ` Chris Wilson
2010-12-21  2:43 ` Dave Airlie [this message]
2010-12-21  2:53   ` Jesse Barnes
2010-12-21 11:36     ` Chris Wilson
2010-12-21 18:14       ` Keith Packard
2010-12-21 19:55         ` Chris Wilson
2010-12-21 20:12           ` Keith Packard
2010-12-22 14:47             ` Chris Wilson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='AANLkTikdmUM6W=YHueW05VC_jcfrJeuSYW6-b-_avGeD@mail.gmail.com' \
    --to=airlied@gmail.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jbarnes@virtuousgeek.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.