[patch 7/7] selinux: fix error codes in symtab_init()

[patch 7/7] selinux: fix error codes in symtab_init()

[Dan Carpenter]

hashtab_create() only returns NULL on allocation failures to -ENOMEM is
appropriate here.

Signed-off-by: Dan Carpenter <error27@gmail.com>

diff --git a/security/selinux/ss/symtab.c b/security/selinux/ss/symtab.c
index bcf9f62..160326e 100644
--- a/security/selinux/ss/symtab.c
+++ b/security/selinux/ss/symtab.c
@@ -36,7 +36,7 @@ int symtab_init(struct symtab *s, unsigned int size)
 {
 	s->table = hashtab_create(symhash, symcmp, size);
 	if (!s->table)
-		return -1;
+		return -ENOMEM;
 	s->nprim = 0;
 	return 0;
 }

Re: [patch 7/7] selinux: fix error codes in symtab_init()

[Eric Paris]

On Mon, Jun 7, 2010 at 5:11 PM, Dan Carpenter <error27@gmail.com> wrote:
> hashtab_create() only returns NULL on allocation failures to -ENOMEM is
> appropriate here.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>

Acked-by: Eric Paris <eparis@redhat.com>

>
> diff --git a/security/selinux/ss/symtab.c b/security/selinux/ss/symtab.c
> index bcf9f62..160326e 100644
> --- a/security/selinux/ss/symtab.c
> +++ b/security/selinux/ss/symtab.c
> @@ -36,7 +36,7 @@ int symtab_init(struct symtab *s, unsigned int size)
>  {
>        s->table = hashtab_create(symhash, symcmp, size);
>        if (!s->table)
> -               return -1;
> +               return -ENOMEM;
>        s->nprim = 0;
>        return 0;
>  }
>
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html