[LTP] [patch]rt_sigprocmask01 issue

[LTP] [patch]rt_sigprocmask01 issue

[lina.zhao]

[-- Attachment #1: Type: text/plain, Size: 842 bytes --]

Hi,

In rt_sigprocmask01.c:

TEST(syscall(__NR_rt_sigpending, &oset,
                   SIGSETSIZE));
               if (TEST_RETURN == -1) {
                   tst_brkm(TFAIL|TTERRNO, cleanup,
                       "rt_sigpending call failed");
               }
               TEST(sigismember(&oset, TEST_SIG));
               if (TEST_RETURN == 0) {
                   tst_brkm(TFAIL|TTERRNO,
                       cleanup,
                       "sigismember call failed");
               }
               /* call rt_sigprocmask() to unblock
                * signal#TEST_SIG */
               TEST(syscall(__NR_rt_sigprocmask,
                   SIG_UNBLOCK, &set, &oset, 8));

on most of the arch,the SIGSETSIZE is 8, but it is 16 for mips, so in 
sigprocmask,
the last parameter should be SIGSETSIZE too, not 8.

Regards,

Lina Zhao

[-- Attachment #2: rt_sigprocmask01-argument-change.patch --]
[-- Type: text/x-diff, Size: 1100 bytes --]

From 69be40baa594c10e5de553a2a60ba4875680c68c Mon Sep 17 00:00:00 2001
From: Lina Zhao <lina.zhao@windriver.com>
Date: Thu, 12 Aug 2010 15:45:10 +0800
Subject: [PATCH] On most of the arch,the SIGSETSIZE is 8,
 but it is 16 for mips, so in sigprocmask, the last parameter
 should be SIGSETSIZE too, not 8.

Signed-off-by: Lina Zhao <lina.zhao@windriver.com>
---
 .../syscalls/rt_sigprocmask/rt_sigprocmask01.c     |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/testcases/kernel/syscalls/rt_sigprocmask/rt_sigprocmask01.c b/testcases/kernel/syscalls/rt_sigprocmask/rt_sigprocmask01.c
index cc32ea8..e100561 100644
--- a/testcases/kernel/syscalls/rt_sigprocmask/rt_sigprocmask01.c
+++ b/testcases/kernel/syscalls/rt_sigprocmask/rt_sigprocmask01.c
@@ -210,7 +210,7 @@ int main(int ac, char **av) {
 				/* call rt_sigprocmask() to unblock
 				 * signal#TEST_SIG */
 				TEST(syscall(__NR_rt_sigprocmask,
-					SIG_UNBLOCK, &set, &oset, 8));
+					SIG_UNBLOCK, &set, &oset, SIGSETSIZE));
 				if (TEST_RETURN == -1) {
 					tst_brkm(TFAIL|TTERRNO,
 						cleanup,
-- 
1.6.3.1


[-- Attachment #3: Type: text/plain, Size: 224 bytes --]

------------------------------------------------------------------------------
This SF.net email is sponsored by 

Make an app they can't live without
Enter the BlackBerry Developer Challenge
http://p.sf.net/sfu/RIM-dev2dev 

[-- Attachment #4: Type: text/plain, Size: 155 bytes --]

_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [patch]rt_sigprocmask01 issue

[Garrett Cooper]

On Thu, Aug 12, 2010 at 1:16 AM, lina.zhao <lina.zhao@windriver.com> wrote:
> Hi,
>
> In rt_sigprocmask01.c:
>
> TEST(syscall(__NR_rt_sigpending, &oset,
>                  SIGSETSIZE));
>              if (TEST_RETURN == -1) {
>                  tst_brkm(TFAIL|TTERRNO, cleanup,
>                      "rt_sigpending call failed");
>              }
>              TEST(sigismember(&oset, TEST_SIG));
>              if (TEST_RETURN == 0) {
>                  tst_brkm(TFAIL|TTERRNO,
>                      cleanup,
>                      "sigismember call failed");
>              }
>              /* call rt_sigprocmask() to unblock
>               * signal#TEST_SIG */
>              TEST(syscall(__NR_rt_sigprocmask,
>                  SIG_UNBLOCK, &set, &oset, 8));
>
> on most of the arch,the SIGSETSIZE is 8, but it is 16 for mips, so in
> sigprocmask,
> the last parameter should be SIGSETSIZE too, not 8.

Committed. Please provide a signed-off-by line next time.
Thanks,
-Garrett

------------------------------------------------------------------------------
This SF.net email is sponsored by 

Make an app they can't live without
Enter the BlackBerry Developer Challenge
http://p.sf.net/sfu/RIM-dev2dev 
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list