All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] poll: fix a typo in comment
@ 2010-12-09  4:20 Namhyung Kim
  2010-12-09  6:31 ` KOSAKI Motohiro
  0 siblings, 1 reply; 6+ messages in thread
From: Namhyung Kim @ 2010-12-09  4:20 UTC (permalink / raw)
  To: Jiri Kosina; +Cc: linux-kernel

Signed-off-by: Namhyung Kim <namhyung@gmail.com>
---
 include/linux/poll.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/include/linux/poll.h b/include/linux/poll.h
index 56e76af78102..afd3375e58ee 100644
--- a/include/linux/poll.h
+++ b/include/linux/poll.h
@@ -57,7 +57,7 @@ struct poll_table_entry {
 };
 
 /*
- * Structures and helpers for sys_poll/sys_poll
+ * Structures and helpers for sys_select/sys_poll
  */
 struct poll_wqueues {
 	poll_table pt;
-- 
1.7.3.3.400.g93cef


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] poll: fix a typo in comment
  2010-12-09  4:20 [PATCH] poll: fix a typo in comment Namhyung Kim
@ 2010-12-09  6:31 ` KOSAKI Motohiro
  2010-12-09  6:48   ` Namhyung Kim
  0 siblings, 1 reply; 6+ messages in thread
From: KOSAKI Motohiro @ 2010-12-09  6:31 UTC (permalink / raw)
  To: Namhyung Kim; +Cc: kosaki.motohiro, Jiri Kosina, linux-kernel

> Signed-off-by: Namhyung Kim <namhyung@gmail.com>
> ---
>  include/linux/poll.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/include/linux/poll.h b/include/linux/poll.h
> index 56e76af78102..afd3375e58ee 100644
> --- a/include/linux/poll.h
> +++ b/include/linux/poll.h
> @@ -57,7 +57,7 @@ struct poll_table_entry {
>  };
>  
>  /*
> - * Structures and helpers for sys_poll/sys_poll
> + * Structures and helpers for sys_select/sys_poll
>   */

Now we don't have sys_poll() and sys_poll() function. At least they
are hidden by SYSCALL_DEFINEx() macro.

so probably, "for select/poll syscall" is better explanation?



>  struct poll_wqueues {
>  	poll_table pt;
> -- 
> 1.7.3.3.400.g93cef
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/




^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] poll: fix a typo in comment
  2010-12-09  6:31 ` KOSAKI Motohiro
@ 2010-12-09  6:48   ` Namhyung Kim
  2010-12-09 16:57     ` [PATCH UPDATED] " Namhyung Kim
  0 siblings, 1 reply; 6+ messages in thread
From: Namhyung Kim @ 2010-12-09  6:48 UTC (permalink / raw)
  To: KOSAKI Motohiro; +Cc: Jiri Kosina, linux-kernel

On Thu, Dec 9, 2010 at 15:31, KOSAKI Motohiro
<kosaki.motohiro@jp.fujitsu.com> wrote:
>> Signed-off-by: Namhyung Kim <namhyung@gmail.com>
>> ---
>>  include/linux/poll.h |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/include/linux/poll.h b/include/linux/poll.h
>> index 56e76af78102..afd3375e58ee 100644
>> --- a/include/linux/poll.h
>> +++ b/include/linux/poll.h
>> @@ -57,7 +57,7 @@ struct poll_table_entry {
>>  };
>>
>>  /*
>> - * Structures and helpers for sys_poll/sys_poll
>> + * Structures and helpers for sys_select/sys_poll
>>   */
>
> Now we don't have sys_poll() and sys_poll() function. At least they
> are hidden by SYSCALL_DEFINEx() macro.
>
> so probably, "for select/poll syscall" is better explanation?
>

Good point. Will resend.
Thanks.


-- 
Regards,
Namhyung Kim

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH UPDATED] poll: fix a typo in comment
  2010-12-09  6:48   ` Namhyung Kim
@ 2010-12-09 16:57     ` Namhyung Kim
  2010-12-10  5:41       ` KOSAKI Motohiro
  0 siblings, 1 reply; 6+ messages in thread
From: Namhyung Kim @ 2010-12-09 16:57 UTC (permalink / raw)
  To: Jiri Kosina; +Cc: KOSAKI Motohiro, linux-kernel

Convert duplicated sys_poll to select. As Kosaki suggests, sys_poll() and
sys_select() are now hidden by SYSCALL_DEFINEx() macros so it would be
better to use plain select/poll syscall name.

Signed-off-by: Namhyung Kim <namhyung@gmail.com>
---
 include/linux/poll.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/include/linux/poll.h b/include/linux/poll.h
index 56e76af78102..afd3375e58ee 100644
--- a/include/linux/poll.h
+++ b/include/linux/poll.h
@@ -57,7 +57,7 @@ struct poll_table_entry {
 };
 
 /*
- * Structures and helpers for sys_poll/sys_poll
+ * Structures and helpers for select/poll syscall
  */
 struct poll_wqueues {
 	poll_table pt;
-- 
1.7.3.3.400.g93cef


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH UPDATED] poll: fix a typo in comment
  2010-12-09 16:57     ` [PATCH UPDATED] " Namhyung Kim
@ 2010-12-10  5:41       ` KOSAKI Motohiro
  2010-12-10 14:06         ` Jiri Kosina
  0 siblings, 1 reply; 6+ messages in thread
From: KOSAKI Motohiro @ 2010-12-10  5:41 UTC (permalink / raw)
  To: Namhyung Kim; +Cc: kosaki.motohiro, Jiri Kosina, linux-kernel

> Convert duplicated sys_poll to select. As Kosaki suggests, sys_poll() and
> sys_select() are now hidden by SYSCALL_DEFINEx() macros so it would be
> better to use plain select/poll syscall name.
> 
> Signed-off-by: Namhyung Kim <namhyung@gmail.com>

Thank you.
	Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>

> ---
>  include/linux/poll.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/include/linux/poll.h b/include/linux/poll.h
> index 56e76af78102..afd3375e58ee 100644
> --- a/include/linux/poll.h
> +++ b/include/linux/poll.h
> @@ -57,7 +57,7 @@ struct poll_table_entry {
>  };
>  
>  /*
> - * Structures and helpers for sys_poll/sys_poll
> + * Structures and helpers for select/poll syscall
>   */
>  struct poll_wqueues {
>  	poll_table pt;
> -- 
> 1.7.3.3.400.g93cef
> 




^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH UPDATED] poll: fix a typo in comment
  2010-12-10  5:41       ` KOSAKI Motohiro
@ 2010-12-10 14:06         ` Jiri Kosina
  0 siblings, 0 replies; 6+ messages in thread
From: Jiri Kosina @ 2010-12-10 14:06 UTC (permalink / raw)
  To: KOSAKI Motohiro; +Cc: Namhyung Kim, linux-kernel

On Fri, 10 Dec 2010, KOSAKI Motohiro wrote:

> > Convert duplicated sys_poll to select. As Kosaki suggests, sys_poll() and
> > sys_select() are now hidden by SYSCALL_DEFINEx() macros so it would be
> > better to use plain select/poll syscall name.
> > 
> > Signed-off-by: Namhyung Kim <namhyung@gmail.com>
> 
> Thank you.
> 	Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>

Applied.

-- 
Jiri Kosina
SUSE Labs, Novell Inc.

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-12-10 14:07 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-12-09  4:20 [PATCH] poll: fix a typo in comment Namhyung Kim
2010-12-09  6:31 ` KOSAKI Motohiro
2010-12-09  6:48   ` Namhyung Kim
2010-12-09 16:57     ` [PATCH UPDATED] " Namhyung Kim
2010-12-10  5:41       ` KOSAKI Motohiro
2010-12-10 14:06         ` Jiri Kosina

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.