Re: [PATCH] Acer 7730G support update.

Re: [PATCH] Acer 7730G support update.

[Takashi Iwai]

At Mon, 8 Nov 2010 00:01:45 +0300,
Denis Kup wrote:
> 
> [1  <multipart/alternative (7bit)>]
> [1.1  <text/plain; ISO-8859-1 (7bit)>]
> Hello!
> 
> I want to commit patch that fix no-sound on acer 7730G laptop. All work
> history you can see here
> https://bugtrack.alsa-project.org/alsa-bug/view.php?id=5123 .
> This patch for the latest snapshot, where this changes have been made:
> http://www.kerneltrap.com/mailarchive/git-commits-head/2010/5/20/35023 .
> 
> Acer 7730G support patch.
> 
> Changes:
> 1) Fixes automatic EAPD configuration on Acer 7730G laptop.
> 
> Denis Kuplyakov <dener.kup@gmail.com>
> 8.11.10 00:00:50

[Sorry for the late reply - the mail was stuck in my output queue
 without triggering for weeks!]

Thanks for the patch.
Unfortunately, your patch isn't applicable as is to the latest code.
The patch gives fuzz and errors.

Could you rebase your patch to the latest 2.6.37-rc kernel code?

Also, don't forget to give your sign-off.  It's simply a line like
Signed-off-by: Foo Bar <foo@bar.com>


thanks,

Takashi

Re: [PATCH] Acer 7730G support update.

[Denis Kup]

2010/11/22 Takashi Iwai <tiwai@suse.de>:
> At Mon, 8 Nov 2010 00:01:45 +0300,
> Denis Kup wrote:
>>
>> [1  <multipart/alternative (7bit)>]
>> [1.1  <text/plain; ISO-8859-1 (7bit)>]
>> Hello!
>>
>> I want to commit patch that fix no-sound on acer 7730G laptop. All work
>> history you can see here
>> https://bugtrack.alsa-project.org/alsa-bug/view.php?id=5123 .
>> This patch for the latest snapshot, where this changes have been made:
>> http://www.kerneltrap.com/mailarchive/git-commits-head/2010/5/20/35023 .
>>
>> Acer 7730G support patch.
>>
>> Changes:
>> 1) Fixes automatic EAPD configuration on Acer 7730G laptop.
>>
>> Denis Kuplyakov <dener.kup@gmail.com>
>> 8.11.10 00:00:50
>
> [Sorry for the late reply - the mail was stuck in my output queue
>  without triggering for weeks!]
>
> Thanks for the patch.
> Unfortunately, your patch isn't applicable as is to the latest code.
> The patch gives fuzz and errors.
>
> Could you rebase your patch to the latest 2.6.37-rc kernel code?
>
> Also, don't forget to give your sign-off.  It's simply a line like
> Signed-off-by: Foo Bar <foo@bar.com>
>
>
> thanks,
>
> Takashi
>

Can you send me a link to the latest version, that should I patch.

Re: [PATCH] Acer 7730G support update.

[Takashi Iwai]

At Mon, 22 Nov 2010 13:51:45 +0300,
Denis Kup wrote:
> 
> 2010/11/22 Takashi Iwai <tiwai@suse.de>:
> > At Mon, 8 Nov 2010 00:01:45 +0300,
> > Denis Kup wrote:
> >>
> >> [1  <multipart/alternative (7bit)>]
> >> [1.1  <text/plain; ISO-8859-1 (7bit)>]
> >> Hello!
> >>
> >> I want to commit patch that fix no-sound on acer 7730G laptop. All work
> >> history you can see here
> >> https://bugtrack.alsa-project.org/alsa-bug/view.php?id=5123 .
> >> This patch for the latest snapshot, where this changes have been made:
> >> http://www.kerneltrap.com/mailarchive/git-commits-head/2010/5/20/35023 .
> >>
> >> Acer 7730G support patch.
> >>
> >> Changes:
> >> 1) Fixes automatic EAPD configuration on Acer 7730G laptop.
> >>
> >> Denis Kuplyakov <dener.kup@gmail.com>
> >> 8.11.10 00:00:50
> >
> > [Sorry for the late reply - the mail was stuck in my output queue
> >  without triggering for weeks!]
> >
> > Thanks for the patch.
> > Unfortunately, your patch isn't applicable as is to the latest code.
> > The patch gives fuzz and errors.
> >
> > Could you rebase your patch to the latest 2.6.37-rc kernel code?
> >
> > Also, don't forget to give your sign-off.  It's simply a line like
> > Signed-off-by: Foo Bar <foo@bar.com>
> >
> >
> > thanks,
> >
> > Takashi
> >
> 
> Can you send me a link to the latest version, that should I patch.

It's Linus tree, e.g. 2.6.37-rc3 should suffice.


Takashi
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Re: [PATCH] Acer 7730G support update.

[Denis Kup]

Do you mean that?
http://www.kernel.org/pub/linux/kernel/v2.6/testing/linux-2.6.37-rc3.tar.bz2

2010/11/22 Takashi Iwai <tiwai@suse.de>:
> At Mon, 22 Nov 2010 13:51:45 +0300,
> Denis Kup wrote:
>>
>> 2010/11/22 Takashi Iwai <tiwai@suse.de>:
>> > At Mon, 8 Nov 2010 00:01:45 +0300,
>> > Denis Kup wrote:
>> >>
>> >> [1  <multipart/alternative (7bit)>]
>> >> [1.1  <text/plain; ISO-8859-1 (7bit)>]
>> >> Hello!
>> >>
>> >> I want to commit patch that fix no-sound on acer 7730G laptop. All work
>> >> history you can see here
>> >> https://bugtrack.alsa-project.org/alsa-bug/view.php?id=5123 .
>> >> This patch for the latest snapshot, where this changes have been made:
>> >> http://www.kerneltrap.com/mailarchive/git-commits-head/2010/5/20/35023 .
>> >>
>> >> Acer 7730G support patch.
>> >>
>> >> Changes:
>> >> 1) Fixes automatic EAPD configuration on Acer 7730G laptop.
>> >>
>> >> Denis Kuplyakov <dener.kup@gmail.com>
>> >> 8.11.10 00:00:50
>> >
>> > [Sorry for the late reply - the mail was stuck in my output queue
>> >  without triggering for weeks!]
>> >
>> > Thanks for the patch.
>> > Unfortunately, your patch isn't applicable as is to the latest code.
>> > The patch gives fuzz and errors.
>> >
>> > Could you rebase your patch to the latest 2.6.37-rc kernel code?
>> >
>> > Also, don't forget to give your sign-off.  It's simply a line like
>> > Signed-off-by: Foo Bar <foo@bar.com>
>> >
>> >
>> > thanks,
>> >
>> > Takashi
>> >
>>
>> Can you send me a link to the latest version, that should I patch.
>
> It's Linus tree, e.g. 2.6.37-rc3 should suffice.
>
>
> Takashi
>

Re: [PATCH] Acer 7730G support update.

[Takashi Iwai]

At Mon, 22 Nov 2010 15:24:16 +0300,
Denis Kup wrote:
> 
> Do you mean that?
> http://www.kernel.org/pub/linux/kernel/v2.6/testing/linux-2.6.37-rc3.tar.bz2

Yes.


Takashi

> 2010/11/22 Takashi Iwai <tiwai@suse.de>:
> > At Mon, 22 Nov 2010 13:51:45 +0300,
> > Denis Kup wrote:
> >>
> >> 2010/11/22 Takashi Iwai <tiwai@suse.de>:
> >> > At Mon, 8 Nov 2010 00:01:45 +0300,
> >> > Denis Kup wrote:
> >> >>
> >> >> [1  <multipart/alternative (7bit)>]
> >> >> [1.1  <text/plain; ISO-8859-1 (7bit)>]
> >> >> Hello!
> >> >>
> >> >> I want to commit patch that fix no-sound on acer 7730G laptop. All work
> >> >> history you can see here
> >> >> https://bugtrack.alsa-project.org/alsa-bug/view.php?id=5123 .
> >> >> This patch for the latest snapshot, where this changes have been made:
> >> >> http://www.kerneltrap.com/mailarchive/git-commits-head/2010/5/20/35023 .
> >> >>
> >> >> Acer 7730G support patch.
> >> >>
> >> >> Changes:
> >> >> 1) Fixes automatic EAPD configuration on Acer 7730G laptop.
> >> >>
> >> >> Denis Kuplyakov <dener.kup@gmail.com>
> >> >> 8.11.10 00:00:50
> >> >
> >> > [Sorry for the late reply - the mail was stuck in my output queue
> >> >  without triggering for weeks!]
> >> >
> >> > Thanks for the patch.
> >> > Unfortunately, your patch isn't applicable as is to the latest code.
> >> > The patch gives fuzz and errors.
> >> >
> >> > Could you rebase your patch to the latest 2.6.37-rc kernel code?
> >> >
> >> > Also, don't forget to give your sign-off.  It's simply a line like
> >> > Signed-off-by: Foo Bar <foo@bar.com>
> >> >
> >> >
> >> > thanks,
> >> >
> >> > Takashi
> >> >
> >>
> >> Can you send me a link to the latest version, that should I patch.
> >
> > It's Linus tree, e.g. 2.6.37-rc3 should suffice.
> >
> >
> > Takashi
> >
> 
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Re: [PATCH] Acer 7730G support update.

[Denis Kup]

Yes it is 70 MB in archived state and 266.6 when decompressed. After
decompressing i have such folders in linux-2.6.37-rc3:

drivers
Documentation
crypto
block
arch

I have used find tool to locate sound folder and I have found it only
in documentation.

2010/11/22 Takashi Iwai <tiwai@suse.de>:
> At Mon, 22 Nov 2010 17:46:31 +0300,
> Denis Kup wrote:
>>
>> There is no such directory in archive.
>
> You must be kidding.  Double-check you downloaded the whole file.
> It's 70M big in the compressed form.
>
>
> Takashi
>
>
>> 2010/11/22 Takashi Iwai <tiwai@suse.de>:
>> > At Mon, 22 Nov 2010 15:40:31 +0300,
>> > Denis Kup wrote:
>> >>
>> >> I can't find patch_realtek.c in this archive. Where should it be situated?
>> >
>> > It's in sound/pci/hda/patch_realtek.c.
>> >
>> >
>> > Takashi
>> >
>> >
>> >> 2010/11/22 Takashi Iwai <tiwai@suse.de>:
>> >> > At Mon, 22 Nov 2010 15:24:16 +0300,
>> >> > Denis Kup wrote:
>> >> >>
>> >> >> Do you mean that?
>> >> >> http://www.kernel.org/pub/linux/kernel/v2.6/testing/linux-2.6.37-rc3.tar.bz2
>> >> >
>> >> > Yes.
>> >> >
>> >> >
>> >> > Takashi
>> >> >
>> >> >> 2010/11/22 Takashi Iwai <tiwai@suse.de>:
>> >> >> > At Mon, 22 Nov 2010 13:51:45 +0300,
>> >> >> > Denis Kup wrote:
>> >> >> >>
>> >> >> >> 2010/11/22 Takashi Iwai <tiwai@suse.de>:
>> >> >> >> > At Mon, 8 Nov 2010 00:01:45 +0300,
>> >> >> >> > Denis Kup wrote:
>> >> >> >> >>
>> >> >> >> >> [1  <multipart/alternative (7bit)>]
>> >> >> >> >> [1.1  <text/plain; ISO-8859-1 (7bit)>]
>> >> >> >> >> Hello!
>> >> >> >> >>
>> >> >> >> >> I want to commit patch that fix no-sound on acer 7730G laptop. All work
>> >> >> >> >> history you can see here
>> >> >> >> >> https://bugtrack.alsa-project.org/alsa-bug/view.php?id=5123 .
>> >> >> >> >> This patch for the latest snapshot, where this changes have been made:
>> >> >> >> >> http://www.kerneltrap.com/mailarchive/git-commits-head/2010/5/20/35023 .
>> >> >> >> >>
>> >> >> >> >> Acer 7730G support patch.
>> >> >> >> >>
>> >> >> >> >> Changes:
>> >> >> >> >> 1) Fixes automatic EAPD configuration on Acer 7730G laptop.
>> >> >> >> >>
>> >> >> >> >> Denis Kuplyakov <dener.kup@gmail.com>
>> >> >> >> >> 8.11.10 00:00:50
>> >> >> >> >
>> >> >> >> > [Sorry for the late reply - the mail was stuck in my output queue
>> >> >> >> >  without triggering for weeks!]
>> >> >> >> >
>> >> >> >> > Thanks for the patch.
>> >> >> >> > Unfortunately, your patch isn't applicable as is to the latest code.
>> >> >> >> > The patch gives fuzz and errors.
>> >> >> >> >
>> >> >> >> > Could you rebase your patch to the latest 2.6.37-rc kernel code?
>> >> >> >> >
>> >> >> >> > Also, don't forget to give your sign-off.  It's simply a line like
>> >> >> >> > Signed-off-by: Foo Bar <foo@bar.com>
>> >> >> >> >
>> >> >> >> >
>> >> >> >> > thanks,
>> >> >> >> >
>> >> >> >> > Takashi
>> >> >> >> >
>> >> >> >>
>> >> >> >> Can you send me a link to the latest version, that should I patch.
>> >> >> >
>> >> >> > It's Linus tree, e.g. 2.6.37-rc3 should suffice.
>> >> >> >
>> >> >> >
>> >> >> > Takashi
>> >> >> >
>> >> >>
>> >> >
>> >>
>> >
>>
>

Re: [PATCH] Acer 7730G support update.

[Takashi Iwai]

At Mon, 22 Nov 2010 17:53:22 +0300,
Denis Kup wrote:
> 
> Yes it is 70 MB in archived state and 266.6 when decompressed. After
> decompressing i have such folders in linux-2.6.37-rc3:
> 
> drivers
> Documentation
> crypto
> block
> arch

There must be more directories like include, lib, sound, etc.
I checked the tarball here and it contains correctly.

Either your filesystem is filled up to full or the downloaded archive
is broken, I guess.


Takashi


> I have used find tool to locate sound folder and I have found it only
> in documentation.
> 
> 2010/11/22 Takashi Iwai <tiwai@suse.de>:
> > At Mon, 22 Nov 2010 17:46:31 +0300,
> > Denis Kup wrote:
> >>
> >> There is no such directory in archive.
> >
> > You must be kidding.  Double-check you downloaded the whole file.
> > It's 70M big in the compressed form.
> >
> >
> > Takashi
> >
> >
> >> 2010/11/22 Takashi Iwai <tiwai@suse.de>:
> >> > At Mon, 22 Nov 2010 15:40:31 +0300,
> >> > Denis Kup wrote:
> >> >>
> >> >> I can't find patch_realtek.c in this archive. Where should it be situated?
> >> >
> >> > It's in sound/pci/hda/patch_realtek.c.
> >> >
> >> >
> >> > Takashi
> >> >
> >> >
> >> >> 2010/11/22 Takashi Iwai <tiwai@suse.de>:
> >> >> > At Mon, 22 Nov 2010 15:24:16 +0300,
> >> >> > Denis Kup wrote:
> >> >> >>
> >> >> >> Do you mean that?
> >> >> >> http://www.kernel.org/pub/linux/kernel/v2.6/testing/linux-2.6.37-rc3.tar.bz2
> >> >> >
> >> >> > Yes.
> >> >> >
> >> >> >
> >> >> > Takashi
> >> >> >
> >> >> >> 2010/11/22 Takashi Iwai <tiwai@suse.de>:
> >> >> >> > At Mon, 22 Nov 2010 13:51:45 +0300,
> >> >> >> > Denis Kup wrote:
> >> >> >> >>
> >> >> >> >> 2010/11/22 Takashi Iwai <tiwai@suse.de>:
> >> >> >> >> > At Mon, 8 Nov 2010 00:01:45 +0300,
> >> >> >> >> > Denis Kup wrote:
> >> >> >> >> >>
> >> >> >> >> >> [1  <multipart/alternative (7bit)>]
> >> >> >> >> >> [1.1  <text/plain; ISO-8859-1 (7bit)>]
> >> >> >> >> >> Hello!
> >> >> >> >> >>
> >> >> >> >> >> I want to commit patch that fix no-sound on acer 7730G laptop. All work
> >> >> >> >> >> history you can see here
> >> >> >> >> >> https://bugtrack.alsa-project.org/alsa-bug/view.php?id=5123 .
> >> >> >> >> >> This patch for the latest snapshot, where this changes have been made:
> >> >> >> >> >> http://www.kerneltrap.com/mailarchive/git-commits-head/2010/5/20/35023 .
> >> >> >> >> >>
> >> >> >> >> >> Acer 7730G support patch.
> >> >> >> >> >>
> >> >> >> >> >> Changes:
> >> >> >> >> >> 1) Fixes automatic EAPD configuration on Acer 7730G laptop.
> >> >> >> >> >>
> >> >> >> >> >> Denis Kuplyakov <dener.kup@gmail.com>
> >> >> >> >> >> 8.11.10 00:00:50
> >> >> >> >> >
> >> >> >> >> > [Sorry for the late reply - the mail was stuck in my output queue
> >> >> >> >> >  without triggering for weeks!]
> >> >> >> >> >
> >> >> >> >> > Thanks for the patch.
> >> >> >> >> > Unfortunately, your patch isn't applicable as is to the latest code.
> >> >> >> >> > The patch gives fuzz and errors.
> >> >> >> >> >
> >> >> >> >> > Could you rebase your patch to the latest 2.6.37-rc kernel code?
> >> >> >> >> >
> >> >> >> >> > Also, don't forget to give your sign-off.  It's simply a line like
> >> >> >> >> > Signed-off-by: Foo Bar <foo@bar.com>
> >> >> >> >> >
> >> >> >> >> >
> >> >> >> >> > thanks,
> >> >> >> >> >
> >> >> >> >> > Takashi
> >> >> >> >> >
> >> >> >> >>
> >> >> >> >> Can you send me a link to the latest version, that should I patch.
> >> >> >> >
> >> >> >> > It's Linus tree, e.g. 2.6.37-rc3 should suffice.
> >> >> >> >
> >> >> >> >
> >> >> >> > Takashi
> >> >> >> >
> >> >> >>
> >> >> >
> >> >>
> >> >
> >>
> >
> 
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Re: [PATCH] Acer 7730G support update.

[Denis Kup]

[-- Attachment #1: Type: text/plain, Size: 3984 bytes --]

I have downloaded file normally. I found that all tabs was converted
to spaces in patch file. So I am sending new version.

2010/11/22 Takashi Iwai <tiwai@suse.de>:
> At Mon, 22 Nov 2010 17:53:22 +0300,
> Denis Kup wrote:
>>
>> Yes it is 70 MB in archived state and 266.6 when decompressed. After
>> decompressing i have such folders in linux-2.6.37-rc3:
>>
>> drivers
>> Documentation
>> crypto
>> block
>> arch
>
> There must be more directories like include, lib, sound, etc.
> I checked the tarball here and it contains correctly.
>
> Either your filesystem is filled up to full or the downloaded archive
> is broken, I guess.
>
>
> Takashi
>
>
>> I have used find tool to locate sound folder and I have found it only
>> in documentation.
>>
>> 2010/11/22 Takashi Iwai <tiwai@suse.de>:
>> > At Mon, 22 Nov 2010 17:46:31 +0300,
>> > Denis Kup wrote:
>> >>
>> >> There is no such directory in archive.
>> >
>> > You must be kidding.  Double-check you downloaded the whole file.
>> > It's 70M big in the compressed form.
>> >
>> >
>> > Takashi
>> >
>> >
>> >> 2010/11/22 Takashi Iwai <tiwai@suse.de>:
>> >> > At Mon, 22 Nov 2010 15:40:31 +0300,
>> >> > Denis Kup wrote:
>> >> >>
>> >> >> I can't find patch_realtek.c in this archive. Where should it be situated?
>> >> >
>> >> > It's in sound/pci/hda/patch_realtek.c.
>> >> >
>> >> >
>> >> > Takashi
>> >> >
>> >> >
>> >> >> 2010/11/22 Takashi Iwai <tiwai@suse.de>:
>> >> >> > At Mon, 22 Nov 2010 15:24:16 +0300,
>> >> >> > Denis Kup wrote:
>> >> >> >>
>> >> >> >> Do you mean that?
>> >> >> >> http://www.kernel.org/pub/linux/kernel/v2.6/testing/linux-2.6.37-rc3.tar.bz2
>> >> >> >
>> >> >> > Yes.
>> >> >> >
>> >> >> >
>> >> >> > Takashi
>> >> >> >
>> >> >> >> 2010/11/22 Takashi Iwai <tiwai@suse.de>:
>> >> >> >> > At Mon, 22 Nov 2010 13:51:45 +0300,
>> >> >> >> > Denis Kup wrote:
>> >> >> >> >>
>> >> >> >> >> 2010/11/22 Takashi Iwai <tiwai@suse.de>:
>> >> >> >> >> > At Mon, 8 Nov 2010 00:01:45 +0300,
>> >> >> >> >> > Denis Kup wrote:
>> >> >> >> >> >>
>> >> >> >> >> >> [1  <multipart/alternative (7bit)>]
>> >> >> >> >> >> [1.1  <text/plain; ISO-8859-1 (7bit)>]
>> >> >> >> >> >> Hello!
>> >> >> >> >> >>
>> >> >> >> >> >> I want to commit patch that fix no-sound on acer 7730G laptop. All work
>> >> >> >> >> >> history you can see here
>> >> >> >> >> >> https://bugtrack.alsa-project.org/alsa-bug/view.php?id=5123 .
>> >> >> >> >> >> This patch for the latest snapshot, where this changes have been made:
>> >> >> >> >> >> http://www.kerneltrap.com/mailarchive/git-commits-head/2010/5/20/35023 .
>> >> >> >> >> >>
>> >> >> >> >> >> Acer 7730G support patch.
>> >> >> >> >> >>
>> >> >> >> >> >> Changes:
>> >> >> >> >> >> 1) Fixes automatic EAPD configuration on Acer 7730G laptop.
>> >> >> >> >> >>
>> >> >> >> >> >> Denis Kuplyakov <dener.kup@gmail.com>
>> >> >> >> >> >> 8.11.10 00:00:50
>> >> >> >> >> >
>> >> >> >> >> > [Sorry for the late reply - the mail was stuck in my output queue
>> >> >> >> >> >  without triggering for weeks!]
>> >> >> >> >> >
>> >> >> >> >> > Thanks for the patch.
>> >> >> >> >> > Unfortunately, your patch isn't applicable as is to the latest code.
>> >> >> >> >> > The patch gives fuzz and errors.
>> >> >> >> >> >
>> >> >> >> >> > Could you rebase your patch to the latest 2.6.37-rc kernel code?
>> >> >> >> >> >
>> >> >> >> >> > Also, don't forget to give your sign-off.  It's simply a line like
>> >> >> >> >> > Signed-off-by: Foo Bar <foo@bar.com>
>> >> >> >> >> >
>> >> >> >> >> >
>> >> >> >> >> > thanks,
>> >> >> >> >> >
>> >> >> >> >> > Takashi
>> >> >> >> >> >
>> >> >> >> >>
>> >> >> >> >> Can you send me a link to the latest version, that should I patch.
>> >> >> >> >
>> >> >> >> > It's Linus tree, e.g. 2.6.37-rc3 should suffice.
>> >> >> >> >
>> >> >> >> >
>> >> >> >> > Takashi
>> >> >> >> >
>> >> >> >>
>> >> >> >
>> >> >>
>> >> >
>> >>
>> >
>>
>

[-- Attachment #2: patch --]
[-- Type: application/octet-stream, Size: 2647 bytes --]

--- ./a/patch_realtek.c	2010-11-22 02:18:56.000000000 +0300
+++ ./b/patch_realtek.c	2010-11-07 01:36:19.000000000 +0300
@@ -2014,6 +2014,36 @@ static struct hda_verb alc888_acer_aspir
 };
 
 /*
+ *ALC888 Acer Aspire 7730G model
+ */
+
+static struct hda_verb alc888_acer_aspire_7730G_verbs[] = {
+/* Bias voltage on for external mic port */
+	{0x18, AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_IN | PIN_VREF80},
+/* Front Mic: set to PIN_IN (empty by default) */
+	{0x12, AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_IN},
+/* Unselect Front Mic by default in input mixer 3 */
+	{0x22, AC_VERB_SET_AMP_GAIN_MUTE, AMP_IN_MUTE(0xb)},
+/* Enable unsolicited event for HP jack */
+	{0x15, AC_VERB_SET_UNSOLICITED_ENABLE, ALC880_HP_EVENT | AC_USRSP_EN},
+/* Enable speaker output */
+	{0x14, AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_OUT},
+	{0x14, AC_VERB_SET_AMP_GAIN_MUTE, AMP_OUT_UNMUTE},
+	{0x14, AC_VERB_SET_EAPD_BTLENABLE, 2},
+/* Enable headphone output */
+	{0x15, AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_OUT | PIN_HP},
+	{0x15, AC_VERB_SET_AMP_GAIN_MUTE, AMP_OUT_UNMUTE},
+	{0x15, AC_VERB_SET_CONNECT_SEL, 0x00},
+	{0x15, AC_VERB_SET_EAPD_BTLENABLE, 2},
+/*Enable internal subwoofer */
+	{0x17, AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_OUT},
+	{0x17, AC_VERB_SET_AMP_GAIN_MUTE, AMP_OUT_UNMUTE},
+	{0x17, AC_VERB_SET_CONNECT_SEL, 0x02},
+	{0x17, AC_VERB_SET_EAPD_BTLENABLE, 2},
+	{ }
+};
+
+/*
  * ALC889 Acer Aspire 8930G model
  */
 
@@ -2200,6 +2230,16 @@ static void alc888_acer_aspire_6530g_set
 	spec->autocfg.speaker_pins[2] = 0x17;
 }
 
+static void alc888_acer_aspire_7730g_setup(struct hda_codec *codec)
+{
+	struct alc_spec *spec = codec->spec;
+
+	spec->autocfg.hp_pins[0] = 0x15;
+	spec->autocfg.speaker_pins[0] = 0x14;
+	spec->autocfg.speaker_pins[1] = 0x16;
+	spec->autocfg.speaker_pins[2] = 0x17;
+}
+
 static void alc889_acer_aspire_8930g_setup(struct hda_codec *codec)
 {
 	struct alc_spec *spec = codec->spec;
@@ -9524,13 +9564,6 @@ static struct hda_verb alc883_acer_eapd_
 	{ }
 };
 
-static struct hda_verb alc888_acer_aspire_7730G_verbs[] = {
-	{0x15, AC_VERB_SET_CONNECT_SEL, 0x00},
-	{0x17, AC_VERB_SET_CONNECT_SEL, 0x02},
-	{0x15, AC_VERB_SET_UNSOLICITED_ENABLE, ALC880_HP_EVENT | AC_USRSP_EN},
-	{ } /* end */
-};
-
 static void alc888_6st_dell_setup(struct hda_codec *codec)
 {
 	struct alc_spec *spec = codec->spec;
@@ -10328,7 +10361,7 @@ static struct alc_config_preset alc882_p
 		.const_channel_count = 6,
 		.input_mux = &alc883_capture_source,
 		.unsol_event = alc_automute_amp_unsol_event,
-		.setup = alc888_acer_aspire_6530g_setup,
+		.setup = alc888_acer_aspire_7730g_setup,
 		.init_hook = alc_automute_amp,
 	},
 	[ALC883_MEDION] = {

[-- Attachment #3: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Re: [PATCH] Acer 7730G support update.

[Takashi Iwai]

At Mon, 22 Nov 2010 19:09:32 +0300,
Denis Kup wrote:
> 
> I have downloaded file normally. I found that all tabs was converted
> to spaces in patch file. So I am sending new version.

Thanks.  Could you give a proper changelog and your sign-off?
Otherwise it can't be applied to the upstream.

The change itself looks fine to me.


Takashi

Re: [PATCH] Acer 7730G support update.

[Denis Kup]

[-- Attachment #1: Type: text/plain, Size: 605 bytes --]

That is it:

Acer 7730G support patch.

Changes:
1) Fixes automatic EAPD configuration on Acer 7730G laptop.

Signed-off-by: Denis Kuplyakov <dener.kup@gmail.com>
23.11.10 08:29

2010/11/23 Takashi Iwai <tiwai@suse.de>:
> At Mon, 22 Nov 2010 19:09:32 +0300,
> Denis Kup wrote:
>>
>> I have downloaded file normally. I found that all tabs was converted
>> to spaces in patch file. So I am sending new version.
>
> Thanks.  Could you give a proper changelog and your sign-off?
> Otherwise it can't be applied to the upstream.
>
> The change itself looks fine to me.
>
>
> Takashi
>

[-- Attachment #2: patch --]
[-- Type: application/octet-stream, Size: 2647 bytes --]

--- ./a/patch_realtek.c	2010-11-22 02:18:56.000000000 +0300
+++ ./b/patch_realtek.c	2010-11-07 01:36:19.000000000 +0300
@@ -2014,6 +2014,36 @@ static struct hda_verb alc888_acer_aspir
 };
 
 /*
+ *ALC888 Acer Aspire 7730G model
+ */
+
+static struct hda_verb alc888_acer_aspire_7730G_verbs[] = {
+/* Bias voltage on for external mic port */
+	{0x18, AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_IN | PIN_VREF80},
+/* Front Mic: set to PIN_IN (empty by default) */
+	{0x12, AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_IN},
+/* Unselect Front Mic by default in input mixer 3 */
+	{0x22, AC_VERB_SET_AMP_GAIN_MUTE, AMP_IN_MUTE(0xb)},
+/* Enable unsolicited event for HP jack */
+	{0x15, AC_VERB_SET_UNSOLICITED_ENABLE, ALC880_HP_EVENT | AC_USRSP_EN},
+/* Enable speaker output */
+	{0x14, AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_OUT},
+	{0x14, AC_VERB_SET_AMP_GAIN_MUTE, AMP_OUT_UNMUTE},
+	{0x14, AC_VERB_SET_EAPD_BTLENABLE, 2},
+/* Enable headphone output */
+	{0x15, AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_OUT | PIN_HP},
+	{0x15, AC_VERB_SET_AMP_GAIN_MUTE, AMP_OUT_UNMUTE},
+	{0x15, AC_VERB_SET_CONNECT_SEL, 0x00},
+	{0x15, AC_VERB_SET_EAPD_BTLENABLE, 2},
+/*Enable internal subwoofer */
+	{0x17, AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_OUT},
+	{0x17, AC_VERB_SET_AMP_GAIN_MUTE, AMP_OUT_UNMUTE},
+	{0x17, AC_VERB_SET_CONNECT_SEL, 0x02},
+	{0x17, AC_VERB_SET_EAPD_BTLENABLE, 2},
+	{ }
+};
+
+/*
  * ALC889 Acer Aspire 8930G model
  */
 
@@ -2200,6 +2230,16 @@ static void alc888_acer_aspire_6530g_set
 	spec->autocfg.speaker_pins[2] = 0x17;
 }
 
+static void alc888_acer_aspire_7730g_setup(struct hda_codec *codec)
+{
+	struct alc_spec *spec = codec->spec;
+
+	spec->autocfg.hp_pins[0] = 0x15;
+	spec->autocfg.speaker_pins[0] = 0x14;
+	spec->autocfg.speaker_pins[1] = 0x16;
+	spec->autocfg.speaker_pins[2] = 0x17;
+}
+
 static void alc889_acer_aspire_8930g_setup(struct hda_codec *codec)
 {
 	struct alc_spec *spec = codec->spec;
@@ -9524,13 +9564,6 @@ static struct hda_verb alc883_acer_eapd_
 	{ }
 };
 
-static struct hda_verb alc888_acer_aspire_7730G_verbs[] = {
-	{0x15, AC_VERB_SET_CONNECT_SEL, 0x00},
-	{0x17, AC_VERB_SET_CONNECT_SEL, 0x02},
-	{0x15, AC_VERB_SET_UNSOLICITED_ENABLE, ALC880_HP_EVENT | AC_USRSP_EN},
-	{ } /* end */
-};
-
 static void alc888_6st_dell_setup(struct hda_codec *codec)
 {
 	struct alc_spec *spec = codec->spec;
@@ -10328,7 +10361,7 @@ static struct alc_config_preset alc882_p
 		.const_channel_count = 6,
 		.input_mux = &alc883_capture_source,
 		.unsol_event = alc_automute_amp_unsol_event,
-		.setup = alc888_acer_aspire_6530g_setup,
+		.setup = alc888_acer_aspire_7730g_setup,
 		.init_hook = alc_automute_amp,
 	},
 	[ALC883_MEDION] = {

[-- Attachment #3: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Re: [PATCH] Acer 7730G support update.

[Takashi Iwai]

At Tue, 23 Nov 2010 11:29:44 +0300,
Denis Kup wrote:
> 
> [1  <text/plain; ISO-8859-1 (quoted-printable)>]
> That is it:
> 
> Acer 7730G support patch.
> 
> Changes:
> 1) Fixes automatic EAPD configuration on Acer 7730G laptop.
> 
> Signed-off-by: Denis Kuplyakov <dener.kup@gmail.com>
> 23.11.10 08:29

Thanks, applied now to sound git tree.


Takashi

[PATCH] Acer 7730G support update.

[Denis Kup]

[-- Attachment #1: Type: text/plain, Size: 464 bytes --]

Hello!

I want to commit patch that fix no-sound on acer 7730G laptop. All
work history you can see here
https://bugtrack.alsa-project.org/alsa-bug/view.php?id=5123 .
This patch for the latest snapshot, where this changes have been made:
http://www.kerneltrap.com/mailarchive/git-commits-head/2010/5/20/35023
.

Acer 7730G support patch.

Changes:
1) Fixes automatic EAPD configuration on Acer 7730G laptop.

Denis Kuplyakov <dener.kup@gmail.com>
8.11.10 00:00:50

[-- Attachment #2: patch --]
[-- Type: application/octet-stream, Size: 3112 bytes --]

dener@DenerNotebook:~> diff -up ./a/alsa-driver/alsa-kernel/pci/hda/patch_realtek.c ./b/alsa-driver/alsa-kernel/pci/hda/patch_realtek.c 
--- ./a/alsa-driver/alsa-kernel/pci/hda/patch_realtek.c 2010-11-04 02:05:17.000000000 +0300
+++ ./b/alsa-driver/alsa-kernel/pci/hda/patch_realtek.c 2010-11-07 01:36:19.885316058 +0300
@@ -2014,6 +2014,36 @@ static struct hda_verb alc888_acer_aspir
 };
 
 /*
+ *ALC888 Acer Aspire 7730G model
+ */
+
+static struct hda_verb alc888_acer_aspire_7730G_verbs[] = {
+/* Bias voltage on for external mic port */
+       {0x18, AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_IN | PIN_VREF80},
+/* Front Mic: set to PIN_IN (empty by default) */
+       {0x12, AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_IN},
+/* Unselect Front Mic by default in input mixer 3 */
+       {0x22, AC_VERB_SET_AMP_GAIN_MUTE, AMP_IN_MUTE(0xb)},
+/* Enable unsolicited event for HP jack */
+       {0x15, AC_VERB_SET_UNSOLICITED_ENABLE, ALC880_HP_EVENT | AC_USRSP_EN},
+/* Enable speaker output */
+       {0x14, AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_OUT},
+       {0x14, AC_VERB_SET_AMP_GAIN_MUTE, AMP_OUT_UNMUTE},
+       {0x14, AC_VERB_SET_EAPD_BTLENABLE, 2},
+/* Enable headphone output */
+       {0x15, AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_OUT | PIN_HP},
+       {0x15, AC_VERB_SET_AMP_GAIN_MUTE, AMP_OUT_UNMUTE},
+       {0x15, AC_VERB_SET_CONNECT_SEL, 0x00},
+       {0x15, AC_VERB_SET_EAPD_BTLENABLE, 2},
+/*Enable internal subwoofer */
+       {0x17, AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_OUT},
+       {0x17, AC_VERB_SET_AMP_GAIN_MUTE, AMP_OUT_UNMUTE},
+       {0x17, AC_VERB_SET_CONNECT_SEL, 0x02},
+       {0x17, AC_VERB_SET_EAPD_BTLENABLE, 2},
+       { }
+};
+
+/*
  * ALC889 Acer Aspire 8930G model
  */
 
@@ -2200,6 +2230,16 @@ static void alc888_acer_aspire_6530g_set
        spec->autocfg.speaker_pins[2] = 0x17;
 }
 
+static void alc888_acer_aspire_7730g_setup(struct hda_codec *codec)
+{
+       struct alc_spec *spec = codec->spec;
+
+       spec->autocfg.hp_pins[0] = 0x15;
+       spec->autocfg.speaker_pins[0] = 0x14;
+       spec->autocfg.speaker_pins[1] = 0x16;
+       spec->autocfg.speaker_pins[2] = 0x17;
+}
+
 static void alc889_acer_aspire_8930g_setup(struct hda_codec *codec)
 {
        struct alc_spec *spec = codec->spec;
@@ -9524,13 +9564,6 @@ static struct hda_verb alc883_acer_eapd_
        { }
 };
 
-static struct hda_verb alc888_acer_aspire_7730G_verbs[] = {
-       {0x15, AC_VERB_SET_CONNECT_SEL, 0x00},
-       {0x17, AC_VERB_SET_CONNECT_SEL, 0x02},
-       {0x15, AC_VERB_SET_UNSOLICITED_ENABLE, ALC880_HP_EVENT | AC_USRSP_EN},
-       { } /* end */
-};
-
 static void alc888_6st_dell_setup(struct hda_codec *codec)
 {
        struct alc_spec *spec = codec->spec;
@@ -10328,7 +10361,7 @@ static struct alc_config_preset alc882_p
                .const_channel_count = 6,
                .input_mux = &alc883_capture_source,
                .unsol_event = alc_automute_amp_unsol_event,
-               .setup = alc888_acer_aspire_6530g_setup,
+               .setup = alc888_acer_aspire_7730g_setup,
                .init_hook = alc_automute_amp,
        },
        [ALC883_MEDION] = {

[-- Attachment #3: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel