Re: [PATCH v2 1/3]AsoC/nuc900: patch for SUBSTREAM_TYPE', 'PCM_TX' and 'PCM_RX' removal

Re: [PATCH v2 1/3]AsoC/nuc900: patch for SUBSTREAM_TYPE', 'PCM_TX' and 'PCM_RX' removal

[Wan ZongShun]

I am sorry for wrong subject.
It should be [PATCH v2 1/4].



> This patch is to remove the 'SUBSTREAM_TYPE','PCM_TX' and 'PCM_RX' definition.
>
> There is no need to redefine SNDRV_PCM_STREAM_PLAYBACK as PCM_TX,
> the SUBSTREAM_TYPE(substream) can be deleted too, the playback or record can be
> judged by 'if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK)' directly rather
> than 'if (PCM_TX == stype)', which makes the codes easy to read.
>
> Signed-off-by: Wan ZongShun<mcuos.com@gmail.com>
>
> ---
>  sound/soc/nuc900/nuc900-ac97.c  |    6 +++---
>  sound/soc/nuc900/nuc900-auido.h |    4 ----
>  sound/soc/nuc900/nuc900-pcm.c   |   18 ++++++++++--------
>  3 files changed, 13 insertions(+), 15 deletions(-)
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Re: [PATCH v2 1/3]AsoC/nuc900: patch for SUBSTREAM_TYPE', 'PCM_TX' and 'PCM_RX' removal

[Liam Girdwood]

On Wed, 2010-06-02 at 13:54 +0800, Wan ZongShun wrote:
> This patch is to remove the 'SUBSTREAM_TYPE','PCM_TX' and 'PCM_RX' definition.
> 
> There is no need to redefine SNDRV_PCM_STREAM_PLAYBACK as PCM_TX,
> the SUBSTREAM_TYPE(substream) can be deleted too, the playback or record can be
> judged by 'if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK)' directly rather
> than 'if (PCM_TX == stype)', which makes the codes easy to read.
> 
> Signed-off-by: Wan ZongShun<mcuos.com@gmail.com>

All 

Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
-- 
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk

Re: [PATCH v2 1/3]AsoC/nuc900: patch for SUBSTREAM_TYPE', 'PCM_TX' and 'PCM_RX' removal

[Mark Brown]

On Wed, Jun 02, 2010 at 10:43:07AM +0100, Liam Girdwood wrote:
> On Wed, 2010-06-02 at 13:54 +0800, Wan ZongShun wrote:
> > This patch is to remove the 'SUBSTREAM_TYPE','PCM_TX' and 'PCM_RX' definition.
> > 
> > There is no need to redefine SNDRV_PCM_STREAM_PLAYBACK as PCM_TX,
> > the SUBSTREAM_TYPE(substream) can be deleted too, the playback or record can be
> > judged by 'if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK)' directly rather
> > than 'if (PCM_TX == stype)', which makes the codes easy to read.
> > 
> > Signed-off-by: Wan ZongShun<mcuos.com@gmail.com>

Note here that you're still missing a space betwen your name and e-mail
address.

> All 

> Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>

I've applied all the patches, since I had to fix up the changelogs
anyway I updated the ms to us in the changelog for patch 2.  Thanks.

Re: [PATCH v2 1/3]AsoC/nuc900: patch for SUBSTREAM_TYPE', 'PCM_TX' and 'PCM_RX' removal

[Wan ZongShun]

2010/6/2 Mark Brown <broonie@opensource.wolfsonmicro.com>:
> On Wed, Jun 02, 2010 at 10:43:07AM +0100, Liam Girdwood wrote:
>> On Wed, 2010-06-02 at 13:54 +0800, Wan ZongShun wrote:
>> > This patch is to remove the 'SUBSTREAM_TYPE','PCM_TX' and 'PCM_RX' definition.
>> >
>> > There is no need to redefine SNDRV_PCM_STREAM_PLAYBACK as PCM_TX,
>> > the SUBSTREAM_TYPE(substream) can be deleted too, the playback or record can be
>> > judged by 'if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK)' directly rather
>> > than 'if (PCM_TX == stype)', which makes the codes easy to read.
>> >
>> > Signed-off-by: Wan ZongShun<mcuos.com@gmail.com>
>
> Note here that you're still missing a space betwen your name and e-mail
> address.
>
Okay, thank you.
but I use 'scripts/checkpatch.pl' to check my patch, it seems no
warning or error.:)

>> All
>
>> Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
>
> I've applied all the patches, since I had to fix up the changelogs
> anyway I updated the ms to us in the changelog for patch 2.  Thanks.
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>



-- 
*linux-arm-kernel mailing list
mail addr:linux-arm-kernel@lists.infradead.org
you can subscribe by:
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

* linux-arm-NUC900 mailing list
mail addr:NUC900@googlegroups.com
main web: https://groups.google.com/group/NUC900
you can subscribe it by sending me mail:
mcuos.com@gmail.com
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Re: [PATCH v2 1/3]AsoC/nuc900: patch for SUBSTREAM_TYPE', 'PCM_TX' and 'PCM_RX' removal

[Wan ZongShun]

Hi Mark,

2010/6/2 Mark Brown <broonie@opensource.wolfsonmicro.com>:
> On Wed, Jun 02, 2010 at 10:43:07AM +0100, Liam Girdwood wrote:
>> On Wed, 2010-06-02 at 13:54 +0800, Wan ZongShun wrote:
>> > This patch is to remove the 'SUBSTREAM_TYPE','PCM_TX' and 'PCM_RX' definition.
>> >
>> > There is no need to redefine SNDRV_PCM_STREAM_PLAYBACK as PCM_TX,
>> > the SUBSTREAM_TYPE(substream) can be deleted too, the playback or record can be
>> > judged by 'if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK)' directly rather
>> > than 'if (PCM_TX == stype)', which makes the codes easy to read.
>> >
>> > Signed-off-by: Wan ZongShun<mcuos.com@gmail.com>
>
> Note here that you're still missing a space betwen your name and e-mail
> address.
>

Do I need re-sent this patch with the missing space fix?

>> All
>
>> Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
>
> I've applied all the patches, since I had to fix up the changelogs
> anyway I updated the ms to us in the changelog for patch 2.  Thanks.
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>



-- 
*linux-arm-kernel mailing list
mail addr:linux-arm-kernel@lists.infradead.org
you can subscribe by:
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

* linux-arm-NUC900 mailing list
mail addr:NUC900@googlegroups.com
main web: https://groups.google.com/group/NUC900
you can subscribe it by sending me mail:
mcuos.com@gmail.com
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Re: [PATCH v2 1/3]AsoC/nuc900: patch for SUBSTREAM_TYPE', 'PCM_TX' and 'PCM_RX' removal

[Mark Brown]

On Sat, Jun 05, 2010 at 03:08:42PM +0800, Wan ZongShun wrote:

> Do I need re-sent this patch with the missing space fix?

No.  Like I said:

> > I've applied all the patches, since I had to fix up the changelogs
> > anyway I updated the ms to us in the changelog for patch 2.  Thanks.