[PATCH] sched: Remove redundant #ifdef.

[PATCH] sched: Remove redundant #ifdef.

[Rakib Mullick]

 Remove redundant #ifdef to wrap struct cpupri. root_domain structure
is declared under #ifdef CONFIG_SMP, no need to use #ifdef again
inside the structure.


Signed-off-by: Rakib Mullick <rakib.mullick@gmail.com>
---

--- linus-36/kernel/sched.c	2010-10-21 02:30:22.000000000 +0600
+++ rakib-36/kernel/sched.c	2010-10-31 11:16:22.000000000 +0600
@@ -426,9 +426,7 @@ struct root_domain {
 	 */
 	cpumask_var_t rto_mask;
 	atomic_t rto_count;
-#ifdef CONFIG_SMP
 	struct cpupri cpupri;
-#endif
 };

 /*

Re: [PATCH] sched: Remove redundant #ifdef.

[Ingo Molnar]

* Rakib Mullick <rakib.mullick@gmail.com> wrote:

>  Remove redundant #ifdef to wrap struct cpupri. root_domain structure
> is declared under #ifdef CONFIG_SMP, no need to use #ifdef again
> inside the structure.
> 
> 
> Signed-off-by: Rakib Mullick <rakib.mullick@gmail.com>
> ---
> 
> --- linus-36/kernel/sched.c	2010-10-21 02:30:22.000000000 +0600
> +++ rakib-36/kernel/sched.c	2010-10-31 11:16:22.000000000 +0600
> @@ -426,9 +426,7 @@ struct root_domain {
>  	 */
>  	cpumask_var_t rto_mask;
>  	atomic_t rto_count;
> -#ifdef CONFIG_SMP
>  	struct cpupri cpupri;
> -#endif
>  };

The same patch was already sent by Christian Dietrich a few weeks ago, and it's 
upstream already:

 ed2d372c0738: sched: Remove unnecessary #ifdef CONFIG_SMP

Thanks,

	Ingo

Re: [PATCH] sched: Remove redundant #ifdef.

[Rakib Mullick]

On Sun, Oct 31, 2010 at 2:44 PM, Ingo Molnar <mingo@elte.hu> wrote:
>
> * Rakib Mullick <rakib.mullick@gmail.com> wrote:
>
>>  Remove redundant #ifdef to wrap struct cpupri. root_domain structure
>> is declared under #ifdef CONFIG_SMP, no need to use #ifdef again
>> inside the structure.
>>
>>
>> Signed-off-by: Rakib Mullick <rakib.mullick@gmail.com>
>> ---
>>
>> --- linus-36/kernel/sched.c   2010-10-21 02:30:22.000000000 +0600
>> +++ rakib-36/kernel/sched.c   2010-10-31 11:16:22.000000000 +0600
>> @@ -426,9 +426,7 @@ struct root_domain {
>>        */
>>       cpumask_var_t rto_mask;
>>       atomic_t rto_count;
>> -#ifdef CONFIG_SMP
>>       struct cpupri cpupri;
>> -#endif
>>  };
>
> The same patch was already sent by Christian Dietrich a few weeks ago, and it's
> upstream already:
>
>  ed2d372c0738: sched: Remove unnecessary #ifdef CONFIG_SMP
>

Ah... sorry for the noise :(. Should have checked it first. It seems
to me that I checked it..... but, certainly I missed it..


Thanks,

Rakib
> Thanks,
>
>        Ingo
>

[PATCH] sched: Remove redundant #ifdef

[kernel]

From: Nikolay Borisov <n.borisov@siteground.com>

2 Adjacent members in task_struct were guarded
by the same define, so no need to have the define twice

Signed-off-by: Nikolay Borisov <n.borisov@siteground.com>
---
 include/linux/sched.h |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/include/linux/sched.h b/include/linux/sched.h
index 26a2e61..272d14e 100644
--- a/include/linux/sched.h
+++ b/include/linux/sched.h
@@ -1334,8 +1334,6 @@ struct task_struct {
 	int rcu_read_lock_nesting;
 	union rcu_special rcu_read_unlock_special;
 	struct list_head rcu_node_entry;
-#endif /* #ifdef CONFIG_PREEMPT_RCU */
-#ifdef CONFIG_PREEMPT_RCU
 	struct rcu_node *rcu_blocked_node;
 #endif /* #ifdef CONFIG_PREEMPT_RCU */
 #ifdef CONFIG_TASKS_RCU
-- 
1.7.1