All of lore.kernel.org
 help / color / mirror / Atom feed
* filter-branch --env-filter GIT_AUTHOR_DATE
@ 2011-01-18 16:43 Tuncer Ayaz
  2011-01-19  7:01 ` Johannes Sixt
  0 siblings, 1 reply; 6+ messages in thread
From: Tuncer Ayaz @ 2011-01-18 16:43 UTC (permalink / raw)
  To: git

To fix invalid timezone info in a repo I ran
git filter-branch --env-filter '
  GIT_AUTHOR_DATE=`echo ${GIT_AUTHOR_DATE}|sed s/+0000/-0800/`' HEAD

This fixed the invalid entries but the new timezone is -0700
instead of -0800. Is this expected?

git version 1.7.4.rc2

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: filter-branch --env-filter GIT_AUTHOR_DATE
  2011-01-18 16:43 filter-branch --env-filter GIT_AUTHOR_DATE Tuncer Ayaz
@ 2011-01-19  7:01 ` Johannes Sixt
  2011-01-19 10:08   ` Tuncer Ayaz
  0 siblings, 1 reply; 6+ messages in thread
From: Johannes Sixt @ 2011-01-19  7:01 UTC (permalink / raw)
  To: Tuncer Ayaz; +Cc: git

Am 1/18/2011 17:43, schrieb Tuncer Ayaz:
> To fix invalid timezone info in a repo I ran
> git filter-branch --env-filter '
>   GIT_AUTHOR_DATE=`echo ${GIT_AUTHOR_DATE}|sed s/+0000/-0800/`' HEAD
> 
> This fixed the invalid entries but the new timezone is -0700
> instead of -0800. Is this expected?

Parse error. You fixed it, but it is not fixed? So what?

What do you mean by "the new timezone is"? Do you mean "...is reported
as"? If so, reported by which tools?

> git version 1.7.4.rc2

I tried your command, but the timezone was changed in the expected way.

-- Hannes

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: filter-branch --env-filter GIT_AUTHOR_DATE
  2011-01-19  7:01 ` Johannes Sixt
@ 2011-01-19 10:08   ` Tuncer Ayaz
  2011-01-19 10:12     ` Tuncer Ayaz
  2011-01-19 10:32     ` Johannes Sixt
  0 siblings, 2 replies; 6+ messages in thread
From: Tuncer Ayaz @ 2011-01-19 10:08 UTC (permalink / raw)
  To: Johannes Sixt; +Cc: git

On Wed, Jan 19, 2011 at 8:01 AM, Johannes Sixt wrote:
> Am 1/18/2011 17:43, schrieb Tuncer Ayaz:
>> To fix invalid timezone info in a repo I ran
>> git filter-branch --env-filter '
>>   GIT_AUTHOR_DATE=`echo ${GIT_AUTHOR_DATE}|sed s/+0000/-0800/`' HEAD
>>
>> This fixed the invalid entries but the new timezone is -0700
>> instead of -0800. Is this expected?
>
> Parse error. You fixed it, but it is not fixed? So what?

Fixed because it is not +0000 anymore. Surprised because the new
timezone is -0700 and not -0800.

> What do you mean by "the new timezone is"? Do you mean "...is reported
> as"? If so, reported by which tools?

git log
git cat-file $REV

>> git version 1.7.4.rc2
>
> I tried your command, but the timezone was changed in the expected way.

How did you check?

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: filter-branch --env-filter GIT_AUTHOR_DATE
  2011-01-19 10:08   ` Tuncer Ayaz
@ 2011-01-19 10:12     ` Tuncer Ayaz
  2011-01-19 10:32     ` Johannes Sixt
  1 sibling, 0 replies; 6+ messages in thread
From: Tuncer Ayaz @ 2011-01-19 10:12 UTC (permalink / raw)
  To: Johannes Sixt; +Cc: git

On Wed, Jan 19, 2011 at 11:08 AM, Tuncer Ayaz wrote:
> git cat-file $REV

To be correct:
git cat-file -p $REV

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: filter-branch --env-filter GIT_AUTHOR_DATE
  2011-01-19 10:08   ` Tuncer Ayaz
  2011-01-19 10:12     ` Tuncer Ayaz
@ 2011-01-19 10:32     ` Johannes Sixt
  2011-01-19 14:30       ` Tuncer Ayaz
  1 sibling, 1 reply; 6+ messages in thread
From: Johannes Sixt @ 2011-01-19 10:32 UTC (permalink / raw)
  To: Tuncer Ayaz; +Cc: git

Am 1/19/2011 11:08, schrieb Tuncer Ayaz:
> On Wed, Jan 19, 2011 at 8:01 AM, Johannes Sixt wrote:
>> Am 1/18/2011 17:43, schrieb Tuncer Ayaz:
>>> To fix invalid timezone info in a repo I ran
>>> git filter-branch --env-filter '
>>>   GIT_AUTHOR_DATE=`echo ${GIT_AUTHOR_DATE}|sed s/+0000/-0800/`' HEAD
>>>
>>> This fixed the invalid entries but the new timezone is -0700
>>> instead of -0800. Is this expected?
>>
>> Parse error. You fixed it, but it is not fixed? So what?
> 
> Fixed because it is not +0000 anymore. Surprised because the new
> timezone is -0700 and not -0800.
> 
>> What do you mean by "the new timezone is"? Do you mean "...is reported
>> as"? If so, reported by which tools?
> 
> git log
> git cat-file $REV

$ git filter-branch -f --env-filter 'echo; echo "$GIT_AUTHOR_DATE"; GIT_AUTHOR_DATE=`echo ${GIT_AUTHOR_DATE}|sed s/+0100/-0800/`; echo "$GIT_AUTHOR_DATE"' -- -1
Rewrite 6fb5ec91707a4433628eae5d9d68153ca8b819fe (1/1)
1292311163 +0100
1292311163 -0800

Ref 'refs/heads/master' was rewritten
$ git cat-file commit HEAD
tree 43554f2216bbcfc96385db0641ae212409f26f21
parent 942f54790453970cfffbfedf29e47ac27b9ba995
author Johannes Sixt <j.sixt@viscovery.net> 1292311163 -0800
committer Johannes Sixt <j.sixt@viscovery.net> 1292311163 +0100

master

*Shrug*

-- Hannes

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: filter-branch --env-filter GIT_AUTHOR_DATE
  2011-01-19 10:32     ` Johannes Sixt
@ 2011-01-19 14:30       ` Tuncer Ayaz
  0 siblings, 0 replies; 6+ messages in thread
From: Tuncer Ayaz @ 2011-01-19 14:30 UTC (permalink / raw)
  To: Johannes Sixt; +Cc: git

On Wed, Jan 19, 2011 at 11:32 AM, Johannes Sixt wrote:
> Am 1/19/2011 11:08, schrieb Tuncer Ayaz:
>> On Wed, Jan 19, 2011 at 8:01 AM, Johannes Sixt wrote:
>>> Am 1/18/2011 17:43, schrieb Tuncer Ayaz:
>>>> To fix invalid timezone info in a repo I ran
>>>> git filter-branch --env-filter '
>>>>   GIT_AUTHOR_DATE=`echo ${GIT_AUTHOR_DATE}|sed s/+0000/-0800/`' HEAD
>>>>
>>>> This fixed the invalid entries but the new timezone is -0700
>>>> instead of -0800. Is this expected?
>>>
>>> Parse error. You fixed it, but it is not fixed? So what?
>>
>> Fixed because it is not +0000 anymore. Surprised because the new
>> timezone is -0700 and not -0800.
>>
>>> What do you mean by "the new timezone is"? Do you mean "...is reported
>>> as"? If so, reported by which tools?
>>
>> git log
>> git cat-file $REV
>
> $ git filter-branch -f --env-filter 'echo; echo "$GIT_AUTHOR_DATE";
> GIT_AUTHOR_DATE=`echo ${GIT_AUTHOR_DATE}|sed s/+0100/-0800/`;
> echo "$GIT_AUTHOR_DATE"' -- -1
> Rewrite 6fb5ec91707a4433628eae5d9d68153ca8b819fe (1/1)
> 1292311163 +0100
> 1292311163 -0800
>
> Ref 'refs/heads/master' was rewritten
> $ git cat-file commit HEAD
> tree 43554f2216bbcfc96385db0641ae212409f26f21
> parent 942f54790453970cfffbfedf29e47ac27b9ba995
> author Johannes Sixt <j.sixt@viscovery.net> 1292311163 -0800
> committer Johannes Sixt <j.sixt@viscovery.net> 1292311163 +0100
>
> master
>
> *Shrug*

Cannot reproduce anymore. Works as expected.

Successfully rewrote all GIT_AUTHOR_DATE timezone entries:
  -0700 -> -0800
  -0800 -> +0000
  +0000 -> -0800

git version 1.7.4.rc2.3.g60a2e

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2011-01-19 14:31 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-01-18 16:43 filter-branch --env-filter GIT_AUTHOR_DATE Tuncer Ayaz
2011-01-19  7:01 ` Johannes Sixt
2011-01-19 10:08   ` Tuncer Ayaz
2011-01-19 10:12     ` Tuncer Ayaz
2011-01-19 10:32     ` Johannes Sixt
2011-01-19 14:30       ` Tuncer Ayaz

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.