[LTP] [PATCH] Fix build of cpuset_syscall_test

[LTP] [PATCH] Fix build of cpuset_syscall_test

[Han Pingtian]

cpuset_syscall_test now depends on numa lib:

make[1]: Entering directory `/root/ltp/testcases/kernel/controllers/cpuset/cpuset_syscall_test'
gcc -g -O2 -g -O2 -fno-strict-aliasing -pipe -Wall  -I/root/ltp/testcases/kernel/include -I../../../../../include -I../../../../../include   -L/root/ltp/testcases/kernel/controllers/cpuset/cpuset_syscall_test/../cpuset_lib -L/root/ltp/testcases/kernel/controllers/cpuset/cpuset_syscall_test/../../libcontrollers -L../../../../../lib  cpuset_syscall_test.c   -lltp -lcpu_set -lcontrollers -lltp -o cpuset_syscall_test
/root/ltp/testcases/kernel/controllers/cpuset/cpuset_syscall_test/../cpuset_lib/libcpu_set.a(libcpuset.o): In function `cpuset_addr2node':
/root/ltp/testcases/kernel/controllers/cpuset/cpuset_lib/libcpuset.c:3455: undefined reference to `get_mempolicy'
/root/ltp/testcases/kernel/controllers/cpuset/cpuset_syscall_test/../cpuset_lib/libcpu_set.a(libcpuset.o): In function `cpuset_membind':
/root/ltp/testcases/kernel/controllers/cpuset/cpuset_lib/libcpuset.c:3439: undefined reference to `set_mempolicy'
/root/ltp/testcases/kernel/controllers/cpuset/cpuset_syscall_test/../cpuset_lib/libcpu_set.a(libcpuset.o): In function `cpuset_unpin':
/root/ltp/testcases/kernel/controllers/cpuset/cpuset_lib/libcpuset.c:3752: undefined reference to `set_mempolicy'
collect2: ld returned 1 exit status
make[1]: *** [cpuset_syscall_test] Error 1
make[1]: Leaving directory `/root/ltp/testcases/kernel/controllers/cpuset/cpuset_syscall_test'
make: *** [all] Error 2

This patch fixes this problem

Signed-off-by: Han Pingtian <phan@redhat.com>
---
 .../cpuset/cpuset_syscall_test/Makefile            |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/testcases/kernel/controllers/cpuset/cpuset_syscall_test/Makefile b/testcases/kernel/controllers/cpuset/cpuset_syscall_test/Makefile
index edc6265..17331fb 100644
--- a/testcases/kernel/controllers/cpuset/cpuset_syscall_test/Makefile
+++ b/testcases/kernel/controllers/cpuset/cpuset_syscall_test/Makefile
@@ -25,3 +25,5 @@ top_srcdir              ?= ../../../../..
 include $(top_srcdir)/include/mk/testcases.mk
 include $(abs_srcdir)/../Makefile.inc
 include $(top_srcdir)/include/mk/generic_leaf_target.mk
+
+LDLIBS                  += $(NUMA_LIBS)
-- 
1.7.1

------------------------------------------------------------------------------
The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE:
Pinpoint memory and threading errors before they happen.
Find and fix more than 250 security defects in the development cycle.
Locate bottlenecks in serial and parallel code that limit performance.
http://p.sf.net/sfu/intel-dev2devfeb
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH] Fix build of cpuset_syscall_test

[Garrett Cooper]

On Thu, Feb 10, 2011 at 12:52 AM, Han Pingtian <phan@redhat.com> wrote:
> cpuset_syscall_test now depends on numa lib:
>
> make[1]: Entering directory `/root/ltp/testcases/kernel/controllers/cpuset/cpuset_syscall_test'
> gcc -g -O2 -g -O2 -fno-strict-aliasing -pipe -Wall  -I/root/ltp/testcases/kernel/include -I../../../../../include -I../../../../../include   -L/root/ltp/testcases/kernel/controllers/cpuset/cpuset_syscall_test/../cpuset_lib -L/root/ltp/testcases/kernel/controllers/cpuset/cpuset_syscall_test/../../libcontrollers -L../../../../../lib  cpuset_syscall_test.c   -lltp -lcpu_set -lcontrollers -lltp -o cpuset_syscall_test
> /root/ltp/testcases/kernel/controllers/cpuset/cpuset_syscall_test/../cpuset_lib/libcpu_set.a(libcpuset.o): In function `cpuset_addr2node':
> /root/ltp/testcases/kernel/controllers/cpuset/cpuset_lib/libcpuset.c:3455: undefined reference to `get_mempolicy'
> /root/ltp/testcases/kernel/controllers/cpuset/cpuset_syscall_test/../cpuset_lib/libcpu_set.a(libcpuset.o): In function `cpuset_membind':
> /root/ltp/testcases/kernel/controllers/cpuset/cpuset_lib/libcpuset.c:3439: undefined reference to `set_mempolicy'
> /root/ltp/testcases/kernel/controllers/cpuset/cpuset_syscall_test/../cpuset_lib/libcpu_set.a(libcpuset.o): In function `cpuset_unpin':
> /root/ltp/testcases/kernel/controllers/cpuset/cpuset_lib/libcpuset.c:3752: undefined reference to `set_mempolicy'
> collect2: ld returned 1 exit status
> make[1]: *** [cpuset_syscall_test] Error 1
> make[1]: Leaving directory `/root/ltp/testcases/kernel/controllers/cpuset/cpuset_syscall_test'
> make: *** [all] Error 2
>
> This patch fixes this problem
>
> Signed-off-by: Han Pingtian <phan@redhat.com>
> ---
>  .../cpuset/cpuset_syscall_test/Makefile            |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/testcases/kernel/controllers/cpuset/cpuset_syscall_test/Makefile b/testcases/kernel/controllers/cpuset/cpuset_syscall_test/Makefile
> index edc6265..17331fb 100644
> --- a/testcases/kernel/controllers/cpuset/cpuset_syscall_test/Makefile
> +++ b/testcases/kernel/controllers/cpuset/cpuset_syscall_test/Makefile
> @@ -25,3 +25,5 @@ top_srcdir              ?= ../../../../..
>  include $(top_srcdir)/include/mk/testcases.mk
>  include $(abs_srcdir)/../Makefile.inc
>  include $(top_srcdir)/include/mk/generic_leaf_target.mk
> +
> +LDLIBS                  += $(NUMA_LIBS)
> --

For consistency this should be placed before generic_leaf_target.mk
Thanks,
-Garrett

------------------------------------------------------------------------------
The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE:
Pinpoint memory and threading errors before they happen.
Find and fix more than 250 security defects in the development cycle.
Locate bottlenecks in serial and parallel code that limit performance.
http://p.sf.net/sfu/intel-dev2devfeb
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH] Fix build of cpuset_syscall_test

[Han Pingtian]

[-- Attachment #1: Type: text/plain, Size: 1100 bytes --]

Sorry for the delay. Attachment is the updated patch.

Thanks.
> > Signed-off-by: Han Pingtian <phan@redhat.com>
> > ---
> >  .../cpuset/cpuset_syscall_test/Makefile            |    2 ++
> >  1 files changed, 2 insertions(+), 0 deletions(-)
> >
> > diff --git a/testcases/kernel/controllers/cpuset/cpuset_syscall_test/Makefile b/testcases/kernel/controllers/cpuset/cpuset_syscall_test/Makefile
> > index edc6265..17331fb 100644
> > --- a/testcases/kernel/controllers/cpuset/cpuset_syscall_test/Makefile
> > +++ b/testcases/kernel/controllers/cpuset/cpuset_syscall_test/Makefile
> > @@ -25,3 +25,5 @@ top_srcdir              ?= ../../../../..
> >  include $(top_srcdir)/include/mk/testcases.mk
> >  include $(abs_srcdir)/../Makefile.inc
> >  include $(top_srcdir)/include/mk/generic_leaf_target.mk
> > +
> > +LDLIBS                  += $(NUMA_LIBS)
> > --
> 
> For consistency this should be placed before generic_leaf_target.mk
> Thanks,
> -Garrett
> 
-- 
Han Pingtian
Quality Engineer
hpt @ #kernel-qe
Red Hat, Inc
Freedom ... courage ... Commitment ... ACCOUNTABILITY

[-- Attachment #2: 0001-Fix-build-of-cpuset_syscall_test.patch --]
[-- Type: text/plain, Size: 2484 bytes --]

From d5b38cc7013a7a5e9bfec198efaa1b7a026dc2c9 Mon Sep 17 00:00:00 2001
From: Han Pingtian <phan@redhat.com>
Date: Thu, 10 Feb 2011 16:44:37 +0800
Subject: [PATCH] Fix build of cpuset_syscall_test

cpuset_syscall_test now depends on numa lib:

make[1]: Entering directory `/root/ltp/testcases/kernel/controllers/cpuset/cpuset_syscall_test'
gcc -g -O2 -g -O2 -fno-strict-aliasing -pipe -Wall  -I/root/ltp/testcases/kernel/include -I../../../../../include -I../../../../../include   -L/root/ltp/testcases/kernel/controllers/cpuset/cpuset_syscall_test/../cpuset_lib -L/root/ltp/testcases/kernel/controllers/cpuset/cpuset_syscall_test/../../libcontrollers -L../../../../../lib  cpuset_syscall_test.c   -lltp -lcpu_set -lcontrollers -lltp -o cpuset_syscall_test
/root/ltp/testcases/kernel/controllers/cpuset/cpuset_syscall_test/../cpuset_lib/libcpu_set.a(libcpuset.o): In function `cpuset_addr2node':
/root/ltp/testcases/kernel/controllers/cpuset/cpuset_lib/libcpuset.c:3455: undefined reference to `get_mempolicy'
/root/ltp/testcases/kernel/controllers/cpuset/cpuset_syscall_test/../cpuset_lib/libcpu_set.a(libcpuset.o): In function `cpuset_membind':
/root/ltp/testcases/kernel/controllers/cpuset/cpuset_lib/libcpuset.c:3439: undefined reference to `set_mempolicy'
/root/ltp/testcases/kernel/controllers/cpuset/cpuset_syscall_test/../cpuset_lib/libcpu_set.a(libcpuset.o): In function `cpuset_unpin':
/root/ltp/testcases/kernel/controllers/cpuset/cpuset_lib/libcpuset.c:3752: undefined reference to `set_mempolicy'
collect2: ld returned 1 exit status
make[1]: *** [cpuset_syscall_test] Error 1
make[1]: Leaving directory `/root/ltp/testcases/kernel/controllers/cpuset/cpuset_syscall_test'
make: *** [all] Error 2

This patch fixes this problem

Signed-off-by: Han Pingtian <phan@redhat.com>
---
 .../cpuset/cpuset_syscall_test/Makefile            |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/testcases/kernel/controllers/cpuset/cpuset_syscall_test/Makefile b/testcases/kernel/controllers/cpuset/cpuset_syscall_test/Makefile
index edc6265..6565631 100644
--- a/testcases/kernel/controllers/cpuset/cpuset_syscall_test/Makefile
+++ b/testcases/kernel/controllers/cpuset/cpuset_syscall_test/Makefile
@@ -24,4 +24,8 @@ top_srcdir              ?= ../../../../..
 
 include $(top_srcdir)/include/mk/testcases.mk
 include $(abs_srcdir)/../Makefile.inc
+
+LDLIBS                  += $(NUMA_LIBS)
+
 include $(top_srcdir)/include/mk/generic_leaf_target.mk
+
-- 
1.7.1


[-- Attachment #3: Type: text/plain, Size: 387 bytes --]

------------------------------------------------------------------------------
The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE:
Pinpoint memory and threading errors before they happen.
Find and fix more than 250 security defects in the development cycle.
Locate bottlenecks in serial and parallel code that limit performance.
http://p.sf.net/sfu/intel-dev2devfeb

[-- Attachment #4: Type: text/plain, Size: 155 bytes --]

_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH] Fix build of cpuset_syscall_test

[Cyril Hrubis]

Hi!
Commited, thanks.

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
Xperia(TM) PLAY
It's a major breakthrough. An authentic gaming
smartphone on the nation's most reliable network.
And it wants your games.
http://p.sf.net/sfu/verizon-sfdev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list