From: Minchan Kim <minchan.kim@gmail.com> To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> Cc: Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>, "linux-mm@kvack.org" <linux-mm@kvack.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "hannes@cmpxchg.org" <hannes@cmpxchg.org>, "balbir@linux.vnet.ibm.com" <balbir@linux.vnet.ibm.com> Subject: Re: [BUGFIX][PATCH 1/4] memcg: fix limit estimation at reclaim for hugepage Date: Fri, 28 Jan 2011 17:37:29 +0900 [thread overview] Message-ID: <AANLkTimmOhbWKMek+9UgTZOU7-17A3H3pMZF-pGQ5v7P@mail.gmail.com> (raw) In-Reply-To: <20110128172438.6c49d4ea.kamezawa.hiroyu@jp.fujitsu.com> On Fri, Jan 28, 2011 at 5:24 PM, KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> wrote: > On Fri, 28 Jan 2011 17:04:16 +0900 > Minchan Kim <minchan.kim@gmail.com> wrote: > >> Hi Kame, >> >> On Fri, Jan 28, 2011 at 1:58 PM, KAMEZAWA Hiroyuki >> <kamezawa.hiroyu@jp.fujitsu.com> wrote: >> > How about this ? >> > == >> > From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> >> > >> > Current memory cgroup's code tends to assume page_size == PAGE_SIZE >> > and arrangement for THP is not enough yet. >> > >> > This is one of fixes for supporing THP. This adds >> > mem_cgroup_check_margin() and checks whether there are required amount of >> > free resource after memory reclaim. By this, THP page allocation >> > can know whether it really succeeded or not and avoid infinite-loop >> > and hangup. >> > >> > Total fixes for do_charge()/reclaim memory will follow this patch. >> >> If this patch is only related to THP, I think patch order isn't good. >> Before applying [2/4], huge page allocation will retry without >> reclaiming and loop forever by below part. >> >> @@ -1854,9 +1858,6 @@ static int __mem_cgroup_do_charge(struct >> } else >> mem_over_limit = mem_cgroup_from_res_counter(fail_res, res); >> >> - if (csize > PAGE_SIZE) /* change csize and retry */ >> - return CHARGE_RETRY; >> - >> if (!(gfp_mask & __GFP_WAIT)) >> return CHARGE_WOULDBLOCK; >> >> Am I missing something? >> > > You're right. But > - This patch oder doesn't affect bi-sect of the bug. because > 2 bugs seems to be the same. > - This patch implements a leaf function for the real fix. > > Then, I think patch order is not problem here. > > Thank you for pointing out. Okay. I understand Hannes and your opinion. In my opinion, my suggestion can enhance the patch readability in this series as just only my viewpoint. :) Anyway, I don't mind it. Reviewed-by: Minchan Kim <minchan.kim@gmail.com> Thanks!! > > Thanks, > -Kame > > > > > -- Kind regards, Minchan Kim
WARNING: multiple messages have this Message-ID (diff)
From: Minchan Kim <minchan.kim@gmail.com> To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> Cc: Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>, "linux-mm@kvack.org" <linux-mm@kvack.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "hannes@cmpxchg.org" <hannes@cmpxchg.org>, "balbir@linux.vnet.ibm.com" <balbir@linux.vnet.ibm.com> Subject: Re: [BUGFIX][PATCH 1/4] memcg: fix limit estimation at reclaim for hugepage Date: Fri, 28 Jan 2011 17:37:29 +0900 [thread overview] Message-ID: <AANLkTimmOhbWKMek+9UgTZOU7-17A3H3pMZF-pGQ5v7P@mail.gmail.com> (raw) In-Reply-To: <20110128172438.6c49d4ea.kamezawa.hiroyu@jp.fujitsu.com> On Fri, Jan 28, 2011 at 5:24 PM, KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> wrote: > On Fri, 28 Jan 2011 17:04:16 +0900 > Minchan Kim <minchan.kim@gmail.com> wrote: > >> Hi Kame, >> >> On Fri, Jan 28, 2011 at 1:58 PM, KAMEZAWA Hiroyuki >> <kamezawa.hiroyu@jp.fujitsu.com> wrote: >> > How about this ? >> > == >> > From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> >> > >> > Current memory cgroup's code tends to assume page_size == PAGE_SIZE >> > and arrangement for THP is not enough yet. >> > >> > This is one of fixes for supporing THP. This adds >> > mem_cgroup_check_margin() and checks whether there are required amount of >> > free resource after memory reclaim. By this, THP page allocation >> > can know whether it really succeeded or not and avoid infinite-loop >> > and hangup. >> > >> > Total fixes for do_charge()/reclaim memory will follow this patch. >> >> If this patch is only related to THP, I think patch order isn't good. >> Before applying [2/4], huge page allocation will retry without >> reclaiming and loop forever by below part. >> >> @@ -1854,9 +1858,6 @@ static int __mem_cgroup_do_charge(struct >> } else >> mem_over_limit = mem_cgroup_from_res_counter(fail_res, res); >> >> - if (csize > PAGE_SIZE) /* change csize and retry */ >> - return CHARGE_RETRY; >> - >> if (!(gfp_mask & __GFP_WAIT)) >> return CHARGE_WOULDBLOCK; >> >> Am I missing something? >> > > You're right. But > - This patch oder doesn't affect bi-sect of the bug. because > 2 bugs seems to be the same. > - This patch implements a leaf function for the real fix. > > Then, I think patch order is not problem here. > > Thank you for pointing out. Okay. I understand Hannes and your opinion. In my opinion, my suggestion can enhance the patch readability in this series as just only my viewpoint. :) Anyway, I don't mind it. Reviewed-by: Minchan Kim <minchan.kim@gmail.com> Thanks!! > > Thanks, > -Kame > > > > > -- Kind regards, Minchan Kim -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/ Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-01-28 8:37 UTC|newest] Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-01-28 3:22 [BUGFIX][PATCH 0/4] Fixes for memcg with THP KAMEZAWA Hiroyuki 2011-01-28 3:22 ` KAMEZAWA Hiroyuki 2011-01-28 3:24 ` [BUGFIX][PATCH 1/4] memcg: fix limit estimation at reclaim for hugepage KAMEZAWA Hiroyuki 2011-01-28 3:24 ` KAMEZAWA Hiroyuki 2011-01-28 4:40 ` Daisuke Nishimura 2011-01-28 4:40 ` Daisuke Nishimura 2011-01-28 4:49 ` KAMEZAWA Hiroyuki 2011-01-28 4:49 ` KAMEZAWA Hiroyuki 2011-01-28 4:58 ` KAMEZAWA Hiroyuki 2011-01-28 4:58 ` KAMEZAWA Hiroyuki 2011-01-28 5:36 ` Daisuke Nishimura 2011-01-28 5:36 ` Daisuke Nishimura 2011-01-28 8:04 ` Minchan Kim 2011-01-28 8:04 ` Minchan Kim 2011-01-28 8:17 ` Johannes Weiner 2011-01-28 8:17 ` Johannes Weiner 2011-01-28 8:25 ` Minchan Kim 2011-01-28 8:25 ` Minchan Kim 2011-01-28 8:36 ` KAMEZAWA Hiroyuki 2011-01-28 8:36 ` KAMEZAWA Hiroyuki 2011-01-30 2:26 ` Minchan Kim 2011-01-30 2:26 ` Minchan Kim 2011-01-28 8:41 ` Johannes Weiner 2011-01-28 8:41 ` Johannes Weiner 2011-01-28 8:24 ` KAMEZAWA Hiroyuki 2011-01-28 8:24 ` KAMEZAWA Hiroyuki 2011-01-28 8:37 ` Minchan Kim [this message] 2011-01-28 8:37 ` Minchan Kim 2011-01-28 7:52 ` Johannes Weiner 2011-01-28 7:52 ` Johannes Weiner 2011-01-28 8:06 ` KAMEZAWA Hiroyuki 2011-01-28 8:06 ` KAMEZAWA Hiroyuki 2011-01-28 3:26 ` [BUGFIX][PATCH 2/4] memcg: fix charge path for THP and allow early retirement KAMEZAWA Hiroyuki 2011-01-28 3:26 ` KAMEZAWA Hiroyuki 2011-01-28 5:37 ` Daisuke Nishimura 2011-01-28 5:37 ` Daisuke Nishimura 2011-01-28 7:57 ` Johannes Weiner 2011-01-28 7:57 ` Johannes Weiner 2011-01-28 8:14 ` KAMEZAWA Hiroyuki 2011-01-28 8:14 ` KAMEZAWA Hiroyuki 2011-01-28 9:02 ` Johannes Weiner 2011-01-28 9:02 ` Johannes Weiner 2011-01-28 9:16 ` KAMEZAWA Hiroyuki 2011-01-28 9:16 ` KAMEZAWA Hiroyuki 2011-01-28 3:27 ` [BUGFIX][PATCH 3/4] mecg: fix oom flag at THP charge KAMEZAWA Hiroyuki 2011-01-28 3:27 ` KAMEZAWA Hiroyuki 2011-01-28 5:39 ` Daisuke Nishimura 2011-01-28 5:39 ` Daisuke Nishimura 2011-01-28 5:50 ` KAMEZAWA Hiroyuki 2011-01-28 5:50 ` KAMEZAWA Hiroyuki 2011-01-28 8:02 ` Johannes Weiner 2011-01-28 8:02 ` Johannes Weiner 2011-01-28 8:21 ` KAMEZAWA Hiroyuki 2011-01-28 8:21 ` KAMEZAWA Hiroyuki 2011-01-31 7:41 ` Balbir Singh 2011-01-31 7:41 ` Balbir Singh 2011-01-28 3:28 ` [BUGFIX][PATCH 4/4] memcg: fix khugepaged should skip busy memcg KAMEZAWA Hiroyuki 2011-01-28 3:28 ` KAMEZAWA Hiroyuki 2011-01-28 8:20 ` Daisuke Nishimura 2011-01-28 8:20 ` Daisuke Nishimura 2011-01-28 8:30 ` KAMEZAWA Hiroyuki 2011-01-28 8:30 ` KAMEZAWA Hiroyuki 2011-01-29 12:47 ` [BUGFIX][PATCH 0/4] Fixes for memcg with THP Balbir Singh 2011-01-29 12:47 ` Balbir Singh 2011-01-30 23:55 ` KAMEZAWA Hiroyuki 2011-01-30 23:55 ` KAMEZAWA Hiroyuki
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=AANLkTimmOhbWKMek+9UgTZOU7-17A3H3pMZF-pGQ5v7P@mail.gmail.com \ --to=minchan.kim@gmail.com \ --cc=balbir@linux.vnet.ibm.com \ --cc=hannes@cmpxchg.org \ --cc=kamezawa.hiroyu@jp.fujitsu.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=nishimura@mxp.nes.nec.co.jp \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.