All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matt Turner <mattst88@gmail.com>
To: Tejun Heo <tj@kernel.org>
Cc: Richard Henderson <rth@twiddle.net>,
	Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
	linux-alpha@vger.kernel.org,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	Rusty Russell <rusty@rustcorp.com.au>,
	Christoph Lameter <cl@linux-foundation.org>,
	Ingo Molnar <mingo@elte.hu>,
	linux-next@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] alpha: fix build breakage in asm/cacheflush.h
Date: Sun, 19 Sep 2010 00:52:19 -0400	[thread overview]
Message-ID: <AANLkTimsf03FvWeTV0mC=dX7vsH=6yihiXa5MH_raAw+@mail.gmail.com> (raw)
In-Reply-To: <4C8F39A6.10504@kernel.org>

On Tue, Sep 14, 2010 at 5:00 AM, Tejun Heo <tj@kernel.org> wrote:
> Alpha SMP flush_icache_user_range() is implemented as an inline
> function inside include/asm/cacheflush.h.  It dereferences @current
> but doesn't include linux/sched.h and thus causes build failure if
> linux/sched.h wasn't included previously.  Fix it by including the
> needed header file explicitly.
>
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
>  arch/alpha/include/asm/cacheflush.h |    2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/arch/alpha/include/asm/cacheflush.h b/arch/alpha/include/asm/cacheflush.h
> index 01d71e1..012f124 100644
> --- a/arch/alpha/include/asm/cacheflush.h
> +++ b/arch/alpha/include/asm/cacheflush.h
> @@ -43,6 +43,8 @@ extern void smp_imb(void);
>  /* ??? Ought to use this in arch/alpha/kernel/signal.c too.  */
>
>  #ifndef CONFIG_SMP
> +#include <linux/sched.h>
> +
>  extern void __load_new_mm_context(struct mm_struct *);
>  static inline void
>  flush_icache_user_range(struct vm_area_struct *vma, struct page *page,

Thanks! Applied this to my tree and sent it to Linus.

WARNING: multiple messages have this Message-ID (diff)
From: Matt Turner <mattst88@gmail.com>
To: Tejun Heo <tj@kernel.org>
Cc: Richard Henderson <rth@twiddle.net>,
	Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
	linux-alpha@vger.kernel.org,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	Rusty Russell <rusty@rustcorp.com.au>,
	Christoph Lameter <cl@linux-foundation.org>,
	Ingo Molnar <mingo@elte.hu>,
	linux-next@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] alpha: fix build breakage in asm/cacheflush.h
Date: Sun, 19 Sep 2010 00:52:19 -0400	[thread overview]
Message-ID: <AANLkTimsf03FvWeTV0mC=dX7vsH=6yihiXa5MH_raAw+@mail.gmail.com> (raw)
In-Reply-To: <4C8F39A6.10504@kernel.org>

On Tue, Sep 14, 2010 at 5:00 AM, Tejun Heo <tj@kernel.org> wrote:
> Alpha SMP flush_icache_user_range() is implemented as an inline
> function inside include/asm/cacheflush.h.  It dereferences @current
> but doesn't include linux/sched.h and thus causes build failure if
> linux/sched.h wasn't included previously.  Fix it by including the
> needed header file explicitly.
>
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
>  arch/alpha/include/asm/cacheflush.h |    2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/arch/alpha/include/asm/cacheflush.h b/arch/alpha/include/asm/cacheflush.h
> index 01d71e1..012f124 100644
> --- a/arch/alpha/include/asm/cacheflush.h
> +++ b/arch/alpha/include/asm/cacheflush.h
> @@ -43,6 +43,8 @@ extern void smp_imb(void);
>  /* ??? Ought to use this in arch/alpha/kernel/signal.c too.  */
>
>  #ifndef CONFIG_SMP
> +#include <linux/sched.h>
> +
>  extern void __load_new_mm_context(struct mm_struct *);
>  static inline void
>  flush_icache_user_range(struct vm_area_struct *vma, struct page *page,

Thanks! Applied this to my tree and sent it to Linus.
--
To unsubscribe from this list: send the line "unsubscribe linux-alpha" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2010-09-19  4:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-13 14:21 linux-next: build failure after merge of the final tree (maybe percpu tree related) Stephen Rothwell
2010-09-14  9:00 ` [PATCH] alpha: fix build breakage in asm/cacheflush.h Tejun Heo
2010-09-19  4:52   ` Matt Turner [this message]
2010-09-19  4:52     ` Matt Turner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='AANLkTimsf03FvWeTV0mC=dX7vsH=6yihiXa5MH_raAw+@mail.gmail.com' \
    --to=mattst88@gmail.com \
    --cc=cl@linux-foundation.org \
    --cc=ink@jurassic.park.msu.ru \
    --cc=linux-alpha@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=rth@twiddle.net \
    --cc=rusty@rustcorp.com.au \
    --cc=sfr@canb.auug.org.au \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.