All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] staging: spectra needs <linux/slab.h>
@ 2010-08-10 19:19 Geert Uytterhoeven
  2010-08-14 21:55 ` Geert Uytterhoeven
  0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2010-08-10 19:19 UTC (permalink / raw)
  To: Greg Kroah-Hartman; +Cc: Linux Kernel Development

On one of my m68k test builds I get:

drivers/staging/spectra/ffsport.c: In function ‘ioctl_read_page_data’:
drivers/staging/spectra/ffsport.c:196: error: implicit declaration of function ‘kmalloc’
drivers/staging/spectra/ffsport.c:196: warning: assignment makes pointer from integer without a cast
drivers/staging/spectra/ffsport.c:212: error: implicit declaration of function ‘kfree’
drivers/staging/spectra/ffsport.c: In function ‘ioctl_write_page_data’:
drivers/staging/spectra/ffsport.c:229: warning: assignment makes pointer from integer without a cast
drivers/staging/spectra/ffsport.c: In function ‘SBD_setup_device’:
drivers/staging/spectra/ffsport.c:633: warning: assignment makes pointer from integer without a cast

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
 drivers/staging/spectra/ffsport.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/staging/spectra/ffsport.c b/drivers/staging/spectra/ffsport.c
index d0c5c97..a8ff80c 100644
--- a/drivers/staging/spectra/ffsport.c
+++ b/drivers/staging/spectra/ffsport.c
@@ -27,6 +27,7 @@
 #include <linux/kthread.h>
 #include <linux/log2.h>
 #include <linux/init.h>
+#include <linux/slab.h>
 
 /**** Helper functions used for Div, Remainder operation on u64 ****/
 
-- 
1.7.0.4

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] staging: spectra needs <linux/slab.h>
  2010-08-10 19:19 [PATCH] staging: spectra needs <linux/slab.h> Geert Uytterhoeven
@ 2010-08-14 21:55 ` Geert Uytterhoeven
  0 siblings, 0 replies; 2+ messages in thread
From: Geert Uytterhoeven @ 2010-08-14 21:55 UTC (permalink / raw)
  To: Greg Kroah-Hartman; +Cc: Linux Kernel Development, Randy Dunlap

2010/8/10 Geert Uytterhoeven <geert@linux-m68k.org>:
> On one of my m68k test builds I get:
>
> drivers/staging/spectra/ffsport.c: In function ‘ioctl_read_page_data’:
> drivers/staging/spectra/ffsport.c:196: error: implicit declaration of function ‘kmalloc’
> drivers/staging/spectra/ffsport.c:196: warning: assignment makes pointer from integer without a cast
> drivers/staging/spectra/ffsport.c:212: error: implicit declaration of function ‘kfree’
> drivers/staging/spectra/ffsport.c: In function ‘ioctl_write_page_data’:
> drivers/staging/spectra/ffsport.c:229: warning: assignment makes pointer from integer without a cast
> drivers/staging/spectra/ffsport.c: In function ‘SBD_setup_device’:
> drivers/staging/spectra/ffsport.c:633: warning: assignment makes pointer from integer without a cast

Still more errors:

        drivers/staging/spectra/ffsport.c: error: too many arguments to function
 ‘blk_queue_ordered’:  => 655
        drivers/staging/spectra/ffsport.c: error: unknown field ‘locked_ioctl’ s
pecified in initializer:  => 605
        drivers/staging/spectra/ffsport.c: error: ‘REQ_LB_OP_FLUSH’ undeclared (
first use in this function):  => 280, 301
        drivers/staging/spectra/ffsport.c: error: ‘REQ_TYPE_LINUX_BLOCK’ undecla
red (first use in this function):  => 278, 300

Some of these have been reported by Randy in linux-next on ... July 8.
The locked_ioctl one is a `new' one, though...

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-08-14 21:56 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-08-10 19:19 [PATCH] staging: spectra needs <linux/slab.h> Geert Uytterhoeven
2010-08-14 21:55 ` Geert Uytterhoeven

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.