Re: [PATCH 05/25][v2] u-boot: disable -Os option not supported by gcc

From: Adrian Alonso <aalonso@secretlab.ca>
To: Darren Hart <dvhart@linux.intel.com>
Cc: Josh Lock <joshua.lock@intel.com>, poky@yoctoproject.org
Subject: Re: [PATCH 05/25][v2] u-boot: disable -Os option not supported by gcc
Date: Wed, 26 Jan 2011 11:41:17 -0600	[thread overview]
Message-ID: <AANLkTin0Ejp=g3Le1xaCL5OTk8sHRJU3L+fDPCmBqeUA@mail.gmail.com> (raw)
In-Reply-To: <4D3F42AB.9000002@linux.intel.com>

[-- Attachment #1: Type: text/plain, Size: 2320 bytes --]

Got me,

Yep the OPTFLAGS was not been set in u-boot.
I end up overriding EXTRA_OEMAKE to set OPTFLAGS=-O2
Powerpc targets only builds with this option and is related to gcc bugs
described in previous treads.

In queue should patch v3

Regards

On Tue, Jan 25, 2011 at 3:37 PM, Darren Hart <dvhart@linux.intel.com> wrote:

> On 01/25/2011 01:09 PM, Adrian Alonso wrote:
>
>> * Disable -Os optspace option not supported by gcc
>> * v2 use OPTFLAGS variable, remove meke file patch
>> * Bump PR
>>
>> Signed-off-by: Adrian Alonso<aalonso@secretlab.ca>
>> ---
>>  recipes-bsp/uboot/u-boot-xilinx_git.bb |    6 ++++--
>>  1 files changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/recipes-bsp/uboot/u-boot-xilinx_git.bb b/recipes-bsp/uboot/
>> u-boot-xilinx_git.bb
>> index 50d99e3..499ce0b 100644
>> --- a/recipes-bsp/uboot/u-boot-xilinx_git.bb
>> +++ b/recipes-bsp/uboot/u-boot-xilinx_git.bb
>> @@ -1,9 +1,11 @@
>>  require ../meta/recipes-bsp/uboot/u-boot.inc
>> -PR = "r2"
>> +PR = "r3"
>>
>> +OPTFLAGS=""
>>
>
> Have you tested this build? Looking at the Makefile, it doesn't do a
> conditional assignment, so I would expect OPTFLAGS set here to be ignored.
> This is why I added it to EXTRA_OEMAKE, which overrides anything in the
> Makefil, regardless of how it is assigned. At least, that was my
> understanding of the mechanism.
>
> EXTRA_OEMAKE = "CROSS_COMPILE=${TARGET_PREFIX} OPTFLAGS=''"
>
>
> Josh, I think you may had something to do with my education in this area -
> can you comment? Am I all wet here?
>
> --
> Darren
>
>
>   BRANCH="master"
>>  TAG="e094f2479ea339d7f48b6826f06f0be4984d9a98"
>> -SRC_URI = "git://
>> git.xilinx.com/u-boot-xlnx.git;branch=${BRANCH};protocol=git<http://git.xilinx.com/u-boot-xlnx.git;branch=$%7BBRANCH%7D;protocol=git>
>> "
>> +SRC_URI = "git://
>> git.xilinx.com/u-boot-xlnx.git;branch=${BRANCH};protocol=git<http://git.xilinx.com/u-boot-xlnx.git;branch=$%7BBRANCH%7D;protocol=git>\
>> +          "
>>  SRCREV = "${TAG}"
>>
>>  inherit xilinx-boot
>>
>
>
> --
> Darren Hart
> Intel Open Source Technology Center
> Yocto Project - Linux Kernel
> _______________________________________________
> poky mailing list
> poky@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/poky
>

[-- Attachment #2: Type: text/html, Size: 3737 bytes --]